test(fix): Add sentry.source custom in the navigation span.data - #4294

Closed
antonis wants to merge 2 commits into
deps/scripts/update-javascript.shfrom
antonis/js-8.39.0-test-fix
Closed

test(fix): Add sentry.source custom in the navigation span.data#4294
antonis wants to merge 2 commits into
deps/scripts/update-javascript.shfrom
antonis/js-8.39.0-test-fix

Conversation

@antonis

@antonisantonis commented Nov 20, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

⚠️Based on: #4293

📜 Description

Adds sentry.source: custom in the span.data to fix failing tests in the JavaScript SDK to v8.39.0 upgrade #4293
The change seems to be related with getsentry/sentry-javascript#14251

💡 Motivation and Context

Fix failing tests in the JavaScript SDK to v8.39.0 upgrade #4293 (comment)

- React Navigation - TTID › ttid enabled › should add processing navigation span
- React Navigation - TTID › ttid enabled › should add processing navigation span for application start up

💚 How did you test it?

CI

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@antonisantonis mentioned this pull request Nov 20, 2024
Merged
@antonisantonis changed the title test(fix) Add custom sentry.source in the span datatest(fix): Add sentry.source custom in the navigation span.dataNov 20, 2024
@antonis
antonis marked this pull request as ready for review November 20, 2024 09:01
@github-actions

github-actionsBot commented Nov 20, 2024

Copy link
Copy Markdown
Contributor

Android (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time410.52 ms469.98 ms59.46 ms
Size7.15 MiB8.36 MiB1.21 MiB

Baseline results on branch: deps/scripts/update-javascript.sh

Startup times

RevisionPlainWith SentryDiff
1e9894e+dirty385.63 ms420.18 ms34.55 ms
4a9de34+dirty385.19 ms429.35 ms44.16 ms
cdeca8b+dirty418.09 ms468.62 ms50.53 ms
f193e90+dirty370.91 ms498.10 ms127.19 ms
e4c23be+dirty379.09 ms412.68 ms33.59 ms
bca5c58+dirty369.19 ms401.90 ms32.71 ms
7871424+dirty417.35 ms468.16 ms50.81 ms
c0332a6+dirty389.21 ms449.39 ms60.17 ms

App size

RevisionPlainWith SentryDiff
1e9894e+dirty7.15 MiB8.35 MiB1.20 MiB
4a9de34+dirty7.15 MiB8.35 MiB1.20 MiB
cdeca8b+dirty7.15 MiB8.35 MiB1.20 MiB
f193e90+dirty7.15 MiB8.35 MiB1.20 MiB
e4c23be+dirty7.15 MiB8.35 MiB1.20 MiB
bca5c58+dirty7.15 MiB8.35 MiB1.20 MiB
7871424+dirty7.15 MiB8.35 MiB1.20 MiB
c0332a6+dirty7.15 MiB8.35 MiB1.20 MiB

@github-actions

github-actionsBot commented Nov 20, 2024

Copy link
Copy Markdown
Contributor

iOS (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time1241.37 ms1241.47 ms0.10 ms
Size2.92 MiB3.66 MiB758.74 KiB

Baseline results on branch: deps/scripts/update-javascript.sh

Startup times

RevisionPlainWith SentryDiff
cdeca8b+dirty1235.78 ms1225.23 ms-10.55 ms
c0332a6+dirty1227.13 ms1230.90 ms3.77 ms
7871424+dirty1245.73 ms1235.39 ms-10.35 ms
bca5c58+dirty1224.23 ms1224.90 ms0.66 ms
f193e90+dirty1228.43 ms1229.02 ms0.59 ms
1e9894e+dirty1233.37 ms1226.96 ms-6.41 ms
e4c23be+dirty1232.21 ms1230.16 ms-2.05 ms
4a9de34+dirty1234.35 ms1230.35 ms-3.99 ms

App size

RevisionPlainWith SentryDiff
cdeca8b+dirty2.92 MiB3.64 MiB744.52 KiB
c0332a6+dirty2.92 MiB3.64 MiB742.47 KiB
7871424+dirty2.92 MiB3.66 MiB757.21 KiB
bca5c58+dirty2.92 MiB3.66 MiB757.55 KiB
f193e90+dirty2.92 MiB3.64 MiB742.92 KiB
1e9894e+dirty2.92 MiB3.66 MiB757.26 KiB
e4c23be+dirty2.92 MiB3.64 MiB742.98 KiB
4a9de34+dirty2.92 MiB3.66 MiB757.67 KiB

@github-actions

github-actionsBot commented Nov 20, 2024

Copy link
Copy Markdown
Contributor

iOS (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time1225.23 ms1225.66 ms0.43 ms
Size2.36 MiB3.10 MiB753.50 KiB

Baseline results on branch: deps/scripts/update-javascript.sh

Startup times

RevisionPlainWith SentryDiff
cdeca8b+dirty1212.42 ms1223.69 ms11.27 ms
c0332a6+dirty1223.13 ms1232.31 ms9.18 ms
7871424+dirty1212.69 ms1224.40 ms11.72 ms
bca5c58+dirty1208.27 ms1212.41 ms4.14 ms
f193e90+dirty1224.20 ms1229.10 ms4.90 ms
1e9894e+dirty1213.33 ms1225.16 ms11.83 ms
e4c23be+dirty1225.25 ms1223.76 ms-1.49 ms
4a9de34+dirty1215.58 ms1218.76 ms3.17 ms

App size

RevisionPlainWith SentryDiff
cdeca8b+dirty2.36 MiB3.09 MiB743.02 KiB
c0332a6+dirty2.36 MiB3.08 MiB736.57 KiB
7871424+dirty2.36 MiB3.10 MiB752.86 KiB
bca5c58+dirty2.36 MiB3.10 MiB752.95 KiB
f193e90+dirty2.36 MiB3.08 MiB737.28 KiB
1e9894e+dirty2.36 MiB3.10 MiB752.76 KiB
e4c23be+dirty2.36 MiB3.08 MiB737.17 KiB
4a9de34+dirty2.36 MiB3.10 MiB753.19 KiB

@bruno-garcia
bruno-garciaforce-pushed the deps/scripts/update-javascript.sh branch 5 times, most recently from 7a5b973 to 652045eCompareNovember 21, 2024 09:33
@github-actions

github-actionsBot commented Nov 21, 2024

Copy link
Copy Markdown
Contributor

Android (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time518.60 ms512.04 ms-6.56 ms
Size17.74 MiB20.08 MiB2.35 MiB

Baseline results on branch: deps/scripts/update-javascript.sh

Startup times

RevisionPlainWith SentryDiff
7871424462.63 ms445.80 ms-16.83 ms
1e9894e431.94 ms445.06 ms13.12 ms
c0332a6461.40 ms456.00 ms-5.40 ms
cdeca8b438.11 ms436.48 ms-1.63 ms
e4c23be452.76 ms438.16 ms-14.60 ms
d3ef7b9486.60 ms474.76 ms-11.84 ms
bca5c58498.31 ms498.32 ms0.01 ms
4a9de34423.00 ms429.66 ms6.66 ms
f193e90432.83 ms433.10 ms0.27 ms

App size

RevisionPlainWith SentryDiff
787142417.74 MiB20.08 MiB2.34 MiB
1e9894e17.74 MiB20.08 MiB2.34 MiB
c0332a617.74 MiB20.08 MiB2.34 MiB
cdeca8b17.74 MiB20.07 MiB2.34 MiB
e4c23be17.74 MiB20.08 MiB2.34 MiB
d3ef7b917.74 MiB20.08 MiB2.35 MiB
bca5c5817.74 MiB20.08 MiB2.34 MiB
4a9de3417.74 MiB20.08 MiB2.34 MiB
f193e9017.74 MiB20.08 MiB2.34 MiB

@antonis

antonis commented Nov 22, 2024

Copy link
Copy Markdown
ContributorAuthor

Merged the fix on #4293 with 61665c7

@antonisantonis closed this Nov 22, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@krystofwoldrichkrystofwoldrichAwaiting requested review from krystofwoldrich
@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimerman

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@web-flow
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
test(fix): Add sentry.source custom in the navigation span.data - #4294
Closed
antonis wants to merge 2 commits into
deps/scripts/update-javascript.shfrom 
antonis/js-8.39.0-test-fix
Closed
test(fix): Add sentry.source custom in the navigation span.data#4294
antonis wants to merge 2 commits into
deps/scripts/update-javascript.shfrom 
antonis/js-8.39.0-test-fix
Conversation
@antonis
@antonisantonis
commented
Nov 20, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
⚠️Based on: #4293
📜 Description
Adds sentry.source: custom in the span.data to fix failing tests in the JavaScript SDK to v8.39.0 upgrade #4293

The change seems to be related with getsentry/sentry-javascript#14251
💡 Motivation and Context
Fix failing tests in the JavaScript SDK to v8.39.0 upgrade #4293 (comment)
- React Navigation - TTID › ttid enabled › should add processing navigation span
- React Navigation - TTID › ttid enabled › should add processing navigation span for application start up

💚 How did you test it?
CI
📝 Checklist
  •  I reviewed submitted code
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  All tests passing
  •  No breaking changes
🔮 Next steps
#skip-changelog
@antonisantonis
mentioned this pull request
Nov 20, 2024
 Merged

@antonisantonis
changed the title
test(fix) Add custom sentry.source in the span datatest(fix): Add sentry.source custom in the navigation span.dataNov 20, 2024
@antonis
antonis
marked this pull request as ready for review
November 20, 2024 09:01
@github-actions
github-actionsBot
commented
Nov 20, 2024

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time410.52 ms469.98 ms59.46 ms
Size7.15 MiB8.36 MiB1.21 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
1e9894e+dirty385.63 ms420.18 ms34.55 ms
4a9de34+dirty385.19 ms429.35 ms44.16 ms
cdeca8b+dirty418.09 ms468.62 ms50.53 ms
f193e90+dirty370.91 ms498.10 ms127.19 ms
e4c23be+dirty379.09 ms412.68 ms33.59 ms
bca5c58+dirty369.19 ms401.90 ms32.71 ms
7871424+dirty417.35 ms468.16 ms50.81 ms
c0332a6+dirty389.21 ms449.39 ms60.17 ms
App size
RevisionPlainWith SentryDiff
1e9894e+dirty7.15 MiB8.35 MiB1.20 MiB
4a9de34+dirty7.15 MiB8.35 MiB1.20 MiB
cdeca8b+dirty7.15 MiB8.35 MiB1.20 MiB
f193e90+dirty7.15 MiB8.35 MiB1.20 MiB
e4c23be+dirty7.15 MiB8.35 MiB1.20 MiB
bca5c58+dirty7.15 MiB8.35 MiB1.20 MiB
7871424+dirty7.15 MiB8.35 MiB1.20 MiB
c0332a6+dirty7.15 MiB8.35 MiB1.20 MiB
@github-actions
github-actionsBot
commented
Nov 20, 2024

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1241.37 ms1241.47 ms0.10 ms
Size2.92 MiB3.66 MiB758.74 KiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
cdeca8b+dirty1235.78 ms1225.23 ms-10.55 ms
c0332a6+dirty1227.13 ms1230.90 ms3.77 ms
7871424+dirty1245.73 ms1235.39 ms-10.35 ms
bca5c58+dirty1224.23 ms1224.90 ms0.66 ms
f193e90+dirty1228.43 ms1229.02 ms0.59 ms
1e9894e+dirty1233.37 ms1226.96 ms-6.41 ms
e4c23be+dirty1232.21 ms1230.16 ms-2.05 ms
4a9de34+dirty1234.35 ms1230.35 ms-3.99 ms
App size
RevisionPlainWith SentryDiff
cdeca8b+dirty2.92 MiB3.64 MiB744.52 KiB
c0332a6+dirty2.92 MiB3.64 MiB742.47 KiB
7871424+dirty2.92 MiB3.66 MiB757.21 KiB
bca5c58+dirty2.92 MiB3.66 MiB757.55 KiB
f193e90+dirty2.92 MiB3.64 MiB742.92 KiB
1e9894e+dirty2.92 MiB3.66 MiB757.26 KiB
e4c23be+dirty2.92 MiB3.64 MiB742.98 KiB
4a9de34+dirty2.92 MiB3.66 MiB757.67 KiB
@github-actions
github-actionsBot
commented
Nov 20, 2024

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1225.23 ms1225.66 ms0.43 ms
Size2.36 MiB3.10 MiB753.50 KiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
cdeca8b+dirty1212.42 ms1223.69 ms11.27 ms
c0332a6+dirty1223.13 ms1232.31 ms9.18 ms
7871424+dirty1212.69 ms1224.40 ms11.72 ms
bca5c58+dirty1208.27 ms1212.41 ms4.14 ms
f193e90+dirty1224.20 ms1229.10 ms4.90 ms
1e9894e+dirty1213.33 ms1225.16 ms11.83 ms
e4c23be+dirty1225.25 ms1223.76 ms-1.49 ms
4a9de34+dirty1215.58 ms1218.76 ms3.17 ms
App size
RevisionPlainWith SentryDiff
cdeca8b+dirty2.36 MiB3.09 MiB743.02 KiB
c0332a6+dirty2.36 MiB3.08 MiB736.57 KiB
7871424+dirty2.36 MiB3.10 MiB752.86 KiB
bca5c58+dirty2.36 MiB3.10 MiB752.95 KiB
f193e90+dirty2.36 MiB3.08 MiB737.28 KiB
1e9894e+dirty2.36 MiB3.10 MiB752.76 KiB
e4c23be+dirty2.36 MiB3.08 MiB737.17 KiB
4a9de34+dirty2.36 MiB3.10 MiB753.19 KiB
@bruno-garcia
bruno-garciaforce-pushed
the
deps/scripts/update-javascript.sh
branch
5 times, most recently
from
7a5b973 to
652045eCompareNovember 21, 2024 09:33
@github-actions
github-actionsBot
commented
Nov 21, 2024

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time518.60 ms512.04 ms-6.56 ms
Size17.74 MiB20.08 MiB2.35 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
7871424462.63 ms445.80 ms-16.83 ms
1e9894e431.94 ms445.06 ms13.12 ms
c0332a6461.40 ms456.00 ms-5.40 ms
cdeca8b438.11 ms436.48 ms-1.63 ms
e4c23be452.76 ms438.16 ms-14.60 ms
d3ef7b9486.60 ms474.76 ms-11.84 ms
bca5c58498.31 ms498.32 ms0.01 ms
4a9de34423.00 ms429.66 ms6.66 ms
f193e90432.83 ms433.10 ms0.27 ms
App size
RevisionPlainWith SentryDiff
787142417.74 MiB20.08 MiB2.34 MiB
1e9894e17.74 MiB20.08 MiB2.34 MiB
c0332a617.74 MiB20.08 MiB2.34 MiB
cdeca8b17.74 MiB20.07 MiB2.34 MiB
e4c23be17.74 MiB20.08 MiB2.34 MiB
d3ef7b917.74 MiB20.08 MiB2.35 MiB
bca5c5817.74 MiB20.08 MiB2.34 MiB
4a9de3417.74 MiB20.08 MiB2.34 MiB
f193e9017.74 MiB20.08 MiB2.34 MiB
@antonis
antonis
commented
Nov 22, 2024

Copy link


Copy Markdown

ContributorAuthor
Merged the fix on #4293 with 61665c7
@antonisantonis
closed this
Nov 22, 2024
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@krystofwoldrichkrystofwoldrichAwaiting requested review from krystofwoldrich
@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimerman

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@web-flow

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test(fix): Add sentry.source custom in the navigation span.data - #4294
Closed
antonis wants to merge 2 commits into
deps/scripts/update-javascript.shfrom 
antonis/js-8.39.0-test-fix
Closed
test(fix): Add sentry.source custom in the navigation span.data#4294
antonis wants to merge 2 commits into
deps/scripts/update-javascript.shfrom 
antonis/js-8.39.0-test-fix
Conversation
@antonis
@antonisantonis
commented
Nov 20, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
⚠️Based on: #4293
📜 Description
Adds sentry.source: custom in the span.data to fix failing tests in the JavaScript SDK to v8.39.0 upgrade #4293

The change seems to be related with getsentry/sentry-javascript#14251
💡 Motivation and Context
Fix failing tests in the JavaScript SDK to v8.39.0 upgrade #4293 (comment)
- React Navigation - TTID › ttid enabled › should add processing navigation span
- React Navigation - TTID › ttid enabled › should add processing navigation span for application start up

💚 How did you test it?
CI
📝 Checklist
  •  I reviewed submitted code
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  All tests passing
  •  No breaking changes
🔮 Next steps
#skip-changelog
@antonisantonis
mentioned this pull request
Nov 20, 2024
 Merged

@antonisantonis
changed the title
test(fix) Add custom sentry.source in the span datatest(fix): Add sentry.source custom in the navigation span.dataNov 20, 2024
@antonis
antonis
marked this pull request as ready for review
November 20, 2024 09:01
@github-actions
github-actionsBot
commented
Nov 20, 2024

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time410.52 ms469.98 ms59.46 ms
Size7.15 MiB8.36 MiB1.21 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
1e9894e+dirty385.63 ms420.18 ms34.55 ms
4a9de34+dirty385.19 ms429.35 ms44.16 ms
cdeca8b+dirty418.09 ms468.62 ms50.53 ms
f193e90+dirty370.91 ms498.10 ms127.19 ms
e4c23be+dirty379.09 ms412.68 ms33.59 ms
bca5c58+dirty369.19 ms401.90 ms32.71 ms
7871424+dirty417.35 ms468.16 ms50.81 ms
c0332a6+dirty389.21 ms449.39 ms60.17 ms
App size
RevisionPlainWith SentryDiff
1e9894e+dirty7.15 MiB8.35 MiB1.20 MiB
4a9de34+dirty7.15 MiB8.35 MiB1.20 MiB
cdeca8b+dirty7.15 MiB8.35 MiB1.20 MiB
f193e90+dirty7.15 MiB8.35 MiB1.20 MiB
e4c23be+dirty7.15 MiB8.35 MiB1.20 MiB
bca5c58+dirty7.15 MiB8.35 MiB1.20 MiB
7871424+dirty7.15 MiB8.35 MiB1.20 MiB
c0332a6+dirty7.15 MiB8.35 MiB1.20 MiB
@github-actions
github-actionsBot
commented
Nov 20, 2024

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1241.37 ms1241.47 ms0.10 ms
Size2.92 MiB3.66 MiB758.74 KiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
cdeca8b+dirty1235.78 ms1225.23 ms-10.55 ms
c0332a6+dirty1227.13 ms1230.90 ms3.77 ms
7871424+dirty1245.73 ms1235.39 ms-10.35 ms
bca5c58+dirty1224.23 ms1224.90 ms0.66 ms
f193e90+dirty1228.43 ms1229.02 ms0.59 ms
1e9894e+dirty1233.37 ms1226.96 ms-6.41 ms
e4c23be+dirty1232.21 ms1230.16 ms-2.05 ms
4a9de34+dirty1234.35 ms1230.35 ms-3.99 ms
App size
RevisionPlainWith SentryDiff
cdeca8b+dirty2.92 MiB3.64 MiB744.52 KiB
c0332a6+dirty2.92 MiB3.64 MiB742.47 KiB
7871424+dirty2.92 MiB3.66 MiB757.21 KiB
bca5c58+dirty2.92 MiB3.66 MiB757.55 KiB
f193e90+dirty2.92 MiB3.64 MiB742.92 KiB
1e9894e+dirty2.92 MiB3.66 MiB757.26 KiB
e4c23be+dirty2.92 MiB3.64 MiB742.98 KiB
4a9de34+dirty2.92 MiB3.66 MiB757.67 KiB
@github-actions
github-actionsBot
commented
Nov 20, 2024

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1225.23 ms1225.66 ms0.43 ms
Size2.36 MiB3.10 MiB753.50 KiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
cdeca8b+dirty1212.42 ms1223.69 ms11.27 ms
c0332a6+dirty1223.13 ms1232.31 ms9.18 ms
7871424+dirty1212.69 ms1224.40 ms11.72 ms
bca5c58+dirty1208.27 ms1212.41 ms4.14 ms
f193e90+dirty1224.20 ms1229.10 ms4.90 ms
1e9894e+dirty1213.33 ms1225.16 ms11.83 ms
e4c23be+dirty1225.25 ms1223.76 ms-1.49 ms
4a9de34+dirty1215.58 ms1218.76 ms3.17 ms
App size
RevisionPlainWith SentryDiff
cdeca8b+dirty2.36 MiB3.09 MiB743.02 KiB
c0332a6+dirty2.36 MiB3.08 MiB736.57 KiB
7871424+dirty2.36 MiB3.10 MiB752.86 KiB
bca5c58+dirty2.36 MiB3.10 MiB752.95 KiB
f193e90+dirty2.36 MiB3.08 MiB737.28 KiB
1e9894e+dirty2.36 MiB3.10 MiB752.76 KiB
e4c23be+dirty2.36 MiB3.08 MiB737.17 KiB
4a9de34+dirty2.36 MiB3.10 MiB753.19 KiB
@bruno-garcia
bruno-garciaforce-pushed
the
deps/scripts/update-javascript.sh
branch
5 times, most recently
from
7a5b973 to
652045eCompareNovember 21, 2024 09:33
@github-actions
github-actionsBot
commented
Nov 21, 2024

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time518.60 ms512.04 ms-6.56 ms
Size17.74 MiB20.08 MiB2.35 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
7871424462.63 ms445.80 ms-16.83 ms
1e9894e431.94 ms445.06 ms13.12 ms
c0332a6461.40 ms456.00 ms-5.40 ms
cdeca8b438.11 ms436.48 ms-1.63 ms
e4c23be452.76 ms438.16 ms-14.60 ms
d3ef7b9486.60 ms474.76 ms-11.84 ms
bca5c58498.31 ms498.32 ms0.01 ms
4a9de34423.00 ms429.66 ms6.66 ms
f193e90432.83 ms433.10 ms0.27 ms
App size
RevisionPlainWith SentryDiff
787142417.74 MiB20.08 MiB2.34 MiB
1e9894e17.74 MiB20.08 MiB2.34 MiB
c0332a617.74 MiB20.08 MiB2.34 MiB
cdeca8b17.74 MiB20.07 MiB2.34 MiB
e4c23be17.74 MiB20.08 MiB2.34 MiB
d3ef7b917.74 MiB20.08 MiB2.35 MiB
bca5c5817.74 MiB20.08 MiB2.34 MiB
4a9de3417.74 MiB20.08 MiB2.34 MiB
f193e9017.74 MiB20.08 MiB2.34 MiB
@antonis
antonis
commented
Nov 22, 2024

Copy link


Copy Markdown

ContributorAuthor
Merged the fix on #4293 with 61665c7
@antonisantonis
closed this
Nov 22, 2024
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@krystofwoldrichkrystofwoldrichAwaiting requested review from krystofwoldrich
@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimerman

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@web-flow

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test(fix): Add sentry.source custom in the navigation span.data - #4294
Closed
antonis wants to merge 2 commits into
deps/scripts/update-javascript.shfrom 
antonis/js-8.39.0-test-fix
Closed
test(fix): Add sentry.source custom in the navigation span.data#4294
antonis wants to merge 2 commits into
deps/scripts/update-javascript.shfrom 
antonis/js-8.39.0-test-fix
Conversation
@antonis
@antonisantonis
commented
Nov 20, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
⚠️Based on: #4293
📜 Description
Adds sentry.source: custom in the span.data to fix failing tests in the JavaScript SDK to v8.39.0 upgrade #4293

The change seems to be related with getsentry/sentry-javascript#14251
💡 Motivation and Context
Fix failing tests in the JavaScript SDK to v8.39.0 upgrade #4293 (comment)
- React Navigation - TTID › ttid enabled › should add processing navigation span
- React Navigation - TTID › ttid enabled › should add processing navigation span for application start up

💚 How did you test it?
CI
📝 Checklist
  •  I reviewed submitted code
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  All tests passing
  •  No breaking changes
🔮 Next steps
#skip-changelog
@antonisantonis
mentioned this pull request
Nov 20, 2024
 Merged

@antonisantonis
changed the title
test(fix) Add custom sentry.source in the span datatest(fix): Add sentry.source custom in the navigation span.dataNov 20, 2024
@antonis
antonis
marked this pull request as ready for review
November 20, 2024 09:01
@github-actions
github-actionsBot
commented
Nov 20, 2024

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time410.52 ms469.98 ms59.46 ms
Size7.15 MiB8.36 MiB1.21 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
1e9894e+dirty385.63 ms420.18 ms34.55 ms
4a9de34+dirty385.19 ms429.35 ms44.16 ms
cdeca8b+dirty418.09 ms468.62 ms50.53 ms
f193e90+dirty370.91 ms498.10 ms127.19 ms
e4c23be+dirty379.09 ms412.68 ms33.59 ms
bca5c58+dirty369.19 ms401.90 ms32.71 ms
7871424+dirty417.35 ms468.16 ms50.81 ms
c0332a6+dirty389.21 ms449.39 ms60.17 ms
App size
RevisionPlainWith SentryDiff
1e9894e+dirty7.15 MiB8.35 MiB1.20 MiB
4a9de34+dirty7.15 MiB8.35 MiB1.20 MiB
cdeca8b+dirty7.15 MiB8.35 MiB1.20 MiB
f193e90+dirty7.15 MiB8.35 MiB1.20 MiB
e4c23be+dirty7.15 MiB8.35 MiB1.20 MiB
bca5c58+dirty7.15 MiB8.35 MiB1.20 MiB
7871424+dirty7.15 MiB8.35 MiB1.20 MiB
c0332a6+dirty7.15 MiB8.35 MiB1.20 MiB
@github-actions
github-actionsBot
commented
Nov 20, 2024

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1241.37 ms1241.47 ms0.10 ms
Size2.92 MiB3.66 MiB758.74 KiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
cdeca8b+dirty1235.78 ms1225.23 ms-10.55 ms
c0332a6+dirty1227.13 ms1230.90 ms3.77 ms
7871424+dirty1245.73 ms1235.39 ms-10.35 ms
bca5c58+dirty1224.23 ms1224.90 ms0.66 ms
f193e90+dirty1228.43 ms1229.02 ms0.59 ms
1e9894e+dirty1233.37 ms1226.96 ms-6.41 ms
e4c23be+dirty1232.21 ms1230.16 ms-2.05 ms
4a9de34+dirty1234.35 ms1230.35 ms-3.99 ms
App size
RevisionPlainWith SentryDiff
cdeca8b+dirty2.92 MiB3.64 MiB744.52 KiB
c0332a6+dirty2.92 MiB3.64 MiB742.47 KiB
7871424+dirty2.92 MiB3.66 MiB757.21 KiB
bca5c58+dirty2.92 MiB3.66 MiB757.55 KiB
f193e90+dirty2.92 MiB3.64 MiB742.92 KiB
1e9894e+dirty2.92 MiB3.66 MiB757.26 KiB
e4c23be+dirty2.92 MiB3.64 MiB742.98 KiB
4a9de34+dirty2.92 MiB3.66 MiB757.67 KiB
@github-actions
github-actionsBot
commented
Nov 20, 2024

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1225.23 ms1225.66 ms0.43 ms
Size2.36 MiB3.10 MiB753.50 KiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
cdeca8b+dirty1212.42 ms1223.69 ms11.27 ms
c0332a6+dirty1223.13 ms1232.31 ms9.18 ms
7871424+dirty1212.69 ms1224.40 ms11.72 ms
bca5c58+dirty1208.27 ms1212.41 ms4.14 ms
f193e90+dirty1224.20 ms1229.10 ms4.90 ms
1e9894e+dirty1213.33 ms1225.16 ms11.83 ms
e4c23be+dirty1225.25 ms1223.76 ms-1.49 ms
4a9de34+dirty1215.58 ms1218.76 ms3.17 ms
App size
RevisionPlainWith SentryDiff
cdeca8b+dirty2.36 MiB3.09 MiB743.02 KiB
c0332a6+dirty2.36 MiB3.08 MiB736.57 KiB
7871424+dirty2.36 MiB3.10 MiB752.86 KiB
bca5c58+dirty2.36 MiB3.10 MiB752.95 KiB
f193e90+dirty2.36 MiB3.08 MiB737.28 KiB
1e9894e+dirty2.36 MiB3.10 MiB752.76 KiB
e4c23be+dirty2.36 MiB3.08 MiB737.17 KiB
4a9de34+dirty2.36 MiB3.10 MiB753.19 KiB
@bruno-garcia
bruno-garciaforce-pushed
the
deps/scripts/update-javascript.sh
branch
5 times, most recently
from
7a5b973 to
652045eCompareNovember 21, 2024 09:33
@github-actions
github-actionsBot
commented
Nov 21, 2024

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time518.60 ms512.04 ms-6.56 ms
Size17.74 MiB20.08 MiB2.35 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
7871424462.63 ms445.80 ms-16.83 ms
1e9894e431.94 ms445.06 ms13.12 ms
c0332a6461.40 ms456.00 ms-5.40 ms
cdeca8b438.11 ms436.48 ms-1.63 ms
e4c23be452.76 ms438.16 ms-14.60 ms
d3ef7b9486.60 ms474.76 ms-11.84 ms
bca5c58498.31 ms498.32 ms0.01 ms
4a9de34423.00 ms429.66 ms6.66 ms
f193e90432.83 ms433.10 ms0.27 ms
App size
RevisionPlainWith SentryDiff
787142417.74 MiB20.08 MiB2.34 MiB
1e9894e17.74 MiB20.08 MiB2.34 MiB
c0332a617.74 MiB20.08 MiB2.34 MiB
cdeca8b17.74 MiB20.07 MiB2.34 MiB
e4c23be17.74 MiB20.08 MiB2.34 MiB
d3ef7b917.74 MiB20.08 MiB2.35 MiB
bca5c5817.74 MiB20.08 MiB2.34 MiB
4a9de3417.74 MiB20.08 MiB2.34 MiB
f193e9017.74 MiB20.08 MiB2.34 MiB
@antonis
antonis
commented
Nov 22, 2024

Copy link


Copy Markdown

ContributorAuthor
Merged the fix on #4293 with 61665c7
@antonisantonis
closed this
Nov 22, 2024
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@krystofwoldrichkrystofwoldrichAwaiting requested review from krystofwoldrich
@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimerman

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@web-flow

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
test(fix): Add sentry.source custom in the navigation span.data - #4294
Closed
antonis wants to merge 2 commits into
deps/scripts/update-javascript.shfrom 
antonis/js-8.39.0-test-fix
Closed
test(fix): Add sentry.source custom in the navigation span.data#4294
antonis wants to merge 2 commits into
deps/scripts/update-javascript.shfrom 
antonis/js-8.39.0-test-fix
Conversation
@antonis
@antonisantonis
commented
Nov 20, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
⚠️Based on: #4293
📜 Description
Adds sentry.source: custom in the span.data to fix failing tests in the JavaScript SDK to v8.39.0 upgrade #4293

The change seems to be related with getsentry/sentry-javascript#14251
💡 Motivation and Context
Fix failing tests in the JavaScript SDK to v8.39.0 upgrade #4293 (comment)
- React Navigation - TTID › ttid enabled › should add processing navigation span
- React Navigation - TTID › ttid enabled › should add processing navigation span for application start up

💚 How did you test it?
CI
📝 Checklist
  •  I reviewed submitted code
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  All tests passing
  •  No breaking changes
🔮 Next steps
#skip-changelog
@antonisantonis
mentioned this pull request
Nov 20, 2024
 Merged

@antonisantonis
changed the title
test(fix) Add custom sentry.source in the span datatest(fix): Add sentry.source custom in the navigation span.dataNov 20, 2024
@antonis
antonis
marked this pull request as ready for review
November 20, 2024 09:01
@github-actions
github-actionsBot
commented
Nov 20, 2024

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time410.52 ms469.98 ms59.46 ms
Size7.15 MiB8.36 MiB1.21 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
1e9894e+dirty385.63 ms420.18 ms34.55 ms
4a9de34+dirty385.19 ms429.35 ms44.16 ms
cdeca8b+dirty418.09 ms468.62 ms50.53 ms
f193e90+dirty370.91 ms498.10 ms127.19 ms
e4c23be+dirty379.09 ms412.68 ms33.59 ms
bca5c58+dirty369.19 ms401.90 ms32.71 ms
7871424+dirty417.35 ms468.16 ms50.81 ms
c0332a6+dirty389.21 ms449.39 ms60.17 ms
App size
RevisionPlainWith SentryDiff
1e9894e+dirty7.15 MiB8.35 MiB1.20 MiB
4a9de34+dirty7.15 MiB8.35 MiB1.20 MiB
cdeca8b+dirty7.15 MiB8.35 MiB1.20 MiB
f193e90+dirty7.15 MiB8.35 MiB1.20 MiB
e4c23be+dirty7.15 MiB8.35 MiB1.20 MiB
bca5c58+dirty7.15 MiB8.35 MiB1.20 MiB
7871424+dirty7.15 MiB8.35 MiB1.20 MiB
c0332a6+dirty7.15 MiB8.35 MiB1.20 MiB
@github-actions
github-actionsBot
commented
Nov 20, 2024

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1241.37 ms1241.47 ms0.10 ms
Size2.92 MiB3.66 MiB758.74 KiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
cdeca8b+dirty1235.78 ms1225.23 ms-10.55 ms
c0332a6+dirty1227.13 ms1230.90 ms3.77 ms
7871424+dirty1245.73 ms1235.39 ms-10.35 ms
bca5c58+dirty1224.23 ms1224.90 ms0.66 ms
f193e90+dirty1228.43 ms1229.02 ms0.59 ms
1e9894e+dirty1233.37 ms1226.96 ms-6.41 ms
e4c23be+dirty1232.21 ms1230.16 ms-2.05 ms
4a9de34+dirty1234.35 ms1230.35 ms-3.99 ms
App size
RevisionPlainWith SentryDiff
cdeca8b+dirty2.92 MiB3.64 MiB744.52 KiB
c0332a6+dirty2.92 MiB3.64 MiB742.47 KiB
7871424+dirty2.92 MiB3.66 MiB757.21 KiB
bca5c58+dirty2.92 MiB3.66 MiB757.55 KiB
f193e90+dirty2.92 MiB3.64 MiB742.92 KiB
1e9894e+dirty2.92 MiB3.66 MiB757.26 KiB
e4c23be+dirty2.92 MiB3.64 MiB742.98 KiB
4a9de34+dirty2.92 MiB3.66 MiB757.67 KiB
@github-actions
github-actionsBot
commented
Nov 20, 2024

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1225.23 ms1225.66 ms0.43 ms
Size2.36 MiB3.10 MiB753.50 KiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
cdeca8b+dirty1212.42 ms1223.69 ms11.27 ms
c0332a6+dirty1223.13 ms1232.31 ms9.18 ms
7871424+dirty1212.69 ms1224.40 ms11.72 ms
bca5c58+dirty1208.27 ms1212.41 ms4.14 ms
f193e90+dirty1224.20 ms1229.10 ms4.90 ms
1e9894e+dirty1213.33 ms1225.16 ms11.83 ms
e4c23be+dirty1225.25 ms1223.76 ms-1.49 ms
4a9de34+dirty1215.58 ms1218.76 ms3.17 ms
App size
RevisionPlainWith SentryDiff
cdeca8b+dirty2.36 MiB3.09 MiB743.02 KiB
c0332a6+dirty2.36 MiB3.08 MiB736.57 KiB
7871424+dirty2.36 MiB3.10 MiB752.86 KiB
bca5c58+dirty2.36 MiB3.10 MiB752.95 KiB
f193e90+dirty2.36 MiB3.08 MiB737.28 KiB
1e9894e+dirty2.36 MiB3.10 MiB752.76 KiB
e4c23be+dirty2.36 MiB3.08 MiB737.17 KiB
4a9de34+dirty2.36 MiB3.10 MiB753.19 KiB
@bruno-garcia
bruno-garciaforce-pushed
the
deps/scripts/update-javascript.sh
branch
5 times, most recently
from
7a5b973 to
652045eCompareNovember 21, 2024 09:33
@github-actions
github-actionsBot
commented
Nov 21, 2024

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time518.60 ms512.04 ms-6.56 ms
Size17.74 MiB20.08 MiB2.35 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
7871424462.63 ms445.80 ms-16.83 ms
1e9894e431.94 ms445.06 ms13.12 ms
c0332a6461.40 ms456.00 ms-5.40 ms
cdeca8b438.11 ms436.48 ms-1.63 ms
e4c23be452.76 ms438.16 ms-14.60 ms
d3ef7b9486.60 ms474.76 ms-11.84 ms
bca5c58498.31 ms498.32 ms0.01 ms
4a9de34423.00 ms429.66 ms6.66 ms
f193e90432.83 ms433.10 ms0.27 ms
App size
RevisionPlainWith SentryDiff
787142417.74 MiB20.08 MiB2.34 MiB
1e9894e17.74 MiB20.08 MiB2.34 MiB
c0332a617.74 MiB20.08 MiB2.34 MiB
cdeca8b17.74 MiB20.07 MiB2.34 MiB
e4c23be17.74 MiB20.08 MiB2.34 MiB
d3ef7b917.74 MiB20.08 MiB2.35 MiB
bca5c5817.74 MiB20.08 MiB2.34 MiB
4a9de3417.74 MiB20.08 MiB2.34 MiB
f193e9017.74 MiB20.08 MiB2.34 MiB
@antonis
antonis
commented
Nov 22, 2024

Copy link


Copy Markdown

ContributorAuthor
Merged the fix on #4293 with 61665c7
@antonisantonis
closed this
Nov 22, 2024
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@krystofwoldrichkrystofwoldrichAwaiting requested review from krystofwoldrich
@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimerman

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@web-flow

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test(fix): Add sentry.source custom in the navigation span.data - #4294
Closed
antonis wants to merge 2 commits into
deps/scripts/update-javascript.shfrom 
antonis/js-8.39.0-test-fix
Closed
test(fix): Add sentry.source custom in the navigation span.data#4294
antonis wants to merge 2 commits into
deps/scripts/update-javascript.shfrom 
antonis/js-8.39.0-test-fix
Conversation
@antonis
@antonisantonis
commented
Nov 20, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
⚠️Based on: #4293
📜 Description
Adds sentry.source: custom in the span.data to fix failing tests in the JavaScript SDK to v8.39.0 upgrade #4293

The change seems to be related with getsentry/sentry-javascript#14251
💡 Motivation and Context
Fix failing tests in the JavaScript SDK to v8.39.0 upgrade #4293 (comment)
- React Navigation - TTID › ttid enabled › should add processing navigation span
- React Navigation - TTID › ttid enabled › should add processing navigation span for application start up

💚 How did you test it?
CI
📝 Checklist
  •  I reviewed submitted code
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  All tests passing
  •  No breaking changes
🔮 Next steps
#skip-changelog
@antonisantonis
mentioned this pull request
Nov 20, 2024
 Merged

@antonisantonis
changed the title
test(fix) Add custom sentry.source in the span datatest(fix): Add sentry.source custom in the navigation span.dataNov 20, 2024
@antonis
antonis
marked this pull request as ready for review
November 20, 2024 09:01
@github-actions
github-actionsBot
commented
Nov 20, 2024

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time410.52 ms469.98 ms59.46 ms
Size7.15 MiB8.36 MiB1.21 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
1e9894e+dirty385.63 ms420.18 ms34.55 ms
4a9de34+dirty385.19 ms429.35 ms44.16 ms
cdeca8b+dirty418.09 ms468.62 ms50.53 ms
f193e90+dirty370.91 ms498.10 ms127.19 ms
e4c23be+dirty379.09 ms412.68 ms33.59 ms
bca5c58+dirty369.19 ms401.90 ms32.71 ms
7871424+dirty417.35 ms468.16 ms50.81 ms
c0332a6+dirty389.21 ms449.39 ms60.17 ms
App size
RevisionPlainWith SentryDiff
1e9894e+dirty7.15 MiB8.35 MiB1.20 MiB
4a9de34+dirty7.15 MiB8.35 MiB1.20 MiB
cdeca8b+dirty7.15 MiB8.35 MiB1.20 MiB
f193e90+dirty7.15 MiB8.35 MiB1.20 MiB
e4c23be+dirty7.15 MiB8.35 MiB1.20 MiB
bca5c58+dirty7.15 MiB8.35 MiB1.20 MiB
7871424+dirty7.15 MiB8.35 MiB1.20 MiB
c0332a6+dirty7.15 MiB8.35 MiB1.20 MiB
@github-actions
github-actionsBot
commented
Nov 20, 2024

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1241.37 ms1241.47 ms0.10 ms
Size2.92 MiB3.66 MiB758.74 KiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
cdeca8b+dirty1235.78 ms1225.23 ms-10.55 ms
c0332a6+dirty1227.13 ms1230.90 ms3.77 ms
7871424+dirty1245.73 ms1235.39 ms-10.35 ms
bca5c58+dirty1224.23 ms1224.90 ms0.66 ms
f193e90+dirty1228.43 ms1229.02 ms0.59 ms
1e9894e+dirty1233.37 ms1226.96 ms-6.41 ms
e4c23be+dirty1232.21 ms1230.16 ms-2.05 ms
4a9de34+dirty1234.35 ms1230.35 ms-3.99 ms
App size
RevisionPlainWith SentryDiff
cdeca8b+dirty2.92 MiB3.64 MiB744.52 KiB
c0332a6+dirty2.92 MiB3.64 MiB742.47 KiB
7871424+dirty2.92 MiB3.66 MiB757.21 KiB
bca5c58+dirty2.92 MiB3.66 MiB757.55 KiB
f193e90+dirty2.92 MiB3.64 MiB742.92 KiB
1e9894e+dirty2.92 MiB3.66 MiB757.26 KiB
e4c23be+dirty2.92 MiB3.64 MiB742.98 KiB
4a9de34+dirty2.92 MiB3.66 MiB757.67 KiB
@github-actions
github-actionsBot
commented
Nov 20, 2024

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1225.23 ms1225.66 ms0.43 ms
Size2.36 MiB3.10 MiB753.50 KiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
cdeca8b+dirty1212.42 ms1223.69 ms11.27 ms
c0332a6+dirty1223.13 ms1232.31 ms9.18 ms
7871424+dirty1212.69 ms1224.40 ms11.72 ms
bca5c58+dirty1208.27 ms1212.41 ms4.14 ms
f193e90+dirty1224.20 ms1229.10 ms4.90 ms
1e9894e+dirty1213.33 ms1225.16 ms11.83 ms
e4c23be+dirty1225.25 ms1223.76 ms-1.49 ms
4a9de34+dirty1215.58 ms1218.76 ms3.17 ms
App size
RevisionPlainWith SentryDiff
cdeca8b+dirty2.36 MiB3.09 MiB743.02 KiB
c0332a6+dirty2.36 MiB3.08 MiB736.57 KiB
7871424+dirty2.36 MiB3.10 MiB752.86 KiB
bca5c58+dirty2.36 MiB3.10 MiB752.95 KiB
f193e90+dirty2.36 MiB3.08 MiB737.28 KiB
1e9894e+dirty2.36 MiB3.10 MiB752.76 KiB
e4c23be+dirty2.36 MiB3.08 MiB737.17 KiB
4a9de34+dirty2.36 MiB3.10 MiB753.19 KiB
@bruno-garcia
bruno-garciaforce-pushed
the
deps/scripts/update-javascript.sh
branch
5 times, most recently
from
7a5b973 to
652045eCompareNovember 21, 2024 09:33
@github-actions
github-actionsBot
commented
Nov 21, 2024

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time518.60 ms512.04 ms-6.56 ms
Size17.74 MiB20.08 MiB2.35 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
7871424462.63 ms445.80 ms-16.83 ms
1e9894e431.94 ms445.06 ms13.12 ms
c0332a6461.40 ms456.00 ms-5.40 ms
cdeca8b438.11 ms436.48 ms-1.63 ms
e4c23be452.76 ms438.16 ms-14.60 ms
d3ef7b9486.60 ms474.76 ms-11.84 ms
bca5c58498.31 ms498.32 ms0.01 ms
4a9de34423.00 ms429.66 ms6.66 ms
f193e90432.83 ms433.10 ms0.27 ms
App size
RevisionPlainWith SentryDiff
787142417.74 MiB20.08 MiB2.34 MiB
1e9894e17.74 MiB20.08 MiB2.34 MiB
c0332a617.74 MiB20.08 MiB2.34 MiB
cdeca8b17.74 MiB20.07 MiB2.34 MiB
e4c23be17.74 MiB20.08 MiB2.34 MiB
d3ef7b917.74 MiB20.08 MiB2.35 MiB
bca5c5817.74 MiB20.08 MiB2.34 MiB
4a9de3417.74 MiB20.08 MiB2.34 MiB
f193e9017.74 MiB20.08 MiB2.34 MiB
@antonis
antonis
commented
Nov 22, 2024

Copy link


Copy Markdown

ContributorAuthor
Merged the fix on #4293 with 61665c7
@antonisantonis
closed this
Nov 22, 2024
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@krystofwoldrichkrystofwoldrichAwaiting requested review from krystofwoldrich
@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimerman

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@web-flow

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test(fix): Add sentry.source custom in the navigation span.data - #4294
Closed
antonis wants to merge 2 commits into
deps/scripts/update-javascript.shfrom 
antonis/js-8.39.0-test-fix
Closed
test(fix): Add sentry.source custom in the navigation span.data#4294
antonis wants to merge 2 commits into
deps/scripts/update-javascript.shfrom 
antonis/js-8.39.0-test-fix
Conversation
@antonis
@antonisantonis
commented
Nov 20, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
⚠️Based on: #4293
📜 Description
Adds sentry.source: custom in the span.data to fix failing tests in the JavaScript SDK to v8.39.0 upgrade #4293

The change seems to be related with getsentry/sentry-javascript#14251
💡 Motivation and Context
Fix failing tests in the JavaScript SDK to v8.39.0 upgrade #4293 (comment)
- React Navigation - TTID › ttid enabled › should add processing navigation span
- React Navigation - TTID › ttid enabled › should add processing navigation span for application start up

💚 How did you test it?
CI
📝 Checklist
  •  I reviewed submitted code
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  All tests passing
  •  No breaking changes
🔮 Next steps
#skip-changelog
@antonisantonis
mentioned this pull request
Nov 20, 2024
 Merged

@antonisantonis
changed the title
test(fix) Add custom sentry.source in the span datatest(fix): Add sentry.source custom in the navigation span.dataNov 20, 2024
@antonis
antonis
marked this pull request as ready for review
November 20, 2024 09:01
@github-actions
github-actionsBot
commented
Nov 20, 2024

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time410.52 ms469.98 ms59.46 ms
Size7.15 MiB8.36 MiB1.21 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
1e9894e+dirty385.63 ms420.18 ms34.55 ms
4a9de34+dirty385.19 ms429.35 ms44.16 ms
cdeca8b+dirty418.09 ms468.62 ms50.53 ms
f193e90+dirty370.91 ms498.10 ms127.19 ms
e4c23be+dirty379.09 ms412.68 ms33.59 ms
bca5c58+dirty369.19 ms401.90 ms32.71 ms
7871424+dirty417.35 ms468.16 ms50.81 ms
c0332a6+dirty389.21 ms449.39 ms60.17 ms
App size
RevisionPlainWith SentryDiff
1e9894e+dirty7.15 MiB8.35 MiB1.20 MiB
4a9de34+dirty7.15 MiB8.35 MiB1.20 MiB
cdeca8b+dirty7.15 MiB8.35 MiB1.20 MiB
f193e90+dirty7.15 MiB8.35 MiB1.20 MiB
e4c23be+dirty7.15 MiB8.35 MiB1.20 MiB
bca5c58+dirty7.15 MiB8.35 MiB1.20 MiB
7871424+dirty7.15 MiB8.35 MiB1.20 MiB
c0332a6+dirty7.15 MiB8.35 MiB1.20 MiB
@github-actions
github-actionsBot
commented
Nov 20, 2024

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1241.37 ms1241.47 ms0.10 ms
Size2.92 MiB3.66 MiB758.74 KiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
cdeca8b+dirty1235.78 ms1225.23 ms-10.55 ms
c0332a6+dirty1227.13 ms1230.90 ms3.77 ms
7871424+dirty1245.73 ms1235.39 ms-10.35 ms
bca5c58+dirty1224.23 ms1224.90 ms0.66 ms
f193e90+dirty1228.43 ms1229.02 ms0.59 ms
1e9894e+dirty1233.37 ms1226.96 ms-6.41 ms
e4c23be+dirty1232.21 ms1230.16 ms-2.05 ms
4a9de34+dirty1234.35 ms1230.35 ms-3.99 ms
App size
RevisionPlainWith SentryDiff
cdeca8b+dirty2.92 MiB3.64 MiB744.52 KiB
c0332a6+dirty2.92 MiB3.64 MiB742.47 KiB
7871424+dirty2.92 MiB3.66 MiB757.21 KiB
bca5c58+dirty2.92 MiB3.66 MiB757.55 KiB
f193e90+dirty2.92 MiB3.64 MiB742.92 KiB
1e9894e+dirty2.92 MiB3.66 MiB757.26 KiB
e4c23be+dirty2.92 MiB3.64 MiB742.98 KiB
4a9de34+dirty2.92 MiB3.66 MiB757.67 KiB
@github-actions
github-actionsBot
commented
Nov 20, 2024

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1225.23 ms1225.66 ms0.43 ms
Size2.36 MiB3.10 MiB753.50 KiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
cdeca8b+dirty1212.42 ms1223.69 ms11.27 ms
c0332a6+dirty1223.13 ms1232.31 ms9.18 ms
7871424+dirty1212.69 ms1224.40 ms11.72 ms
bca5c58+dirty1208.27 ms1212.41 ms4.14 ms
f193e90+dirty1224.20 ms1229.10 ms4.90 ms
1e9894e+dirty1213.33 ms1225.16 ms11.83 ms
e4c23be+dirty1225.25 ms1223.76 ms-1.49 ms
4a9de34+dirty1215.58 ms1218.76 ms3.17 ms
App size
RevisionPlainWith SentryDiff
cdeca8b+dirty2.36 MiB3.09 MiB743.02 KiB
c0332a6+dirty2.36 MiB3.08 MiB736.57 KiB
7871424+dirty2.36 MiB3.10 MiB752.86 KiB
bca5c58+dirty2.36 MiB3.10 MiB752.95 KiB
f193e90+dirty2.36 MiB3.08 MiB737.28 KiB
1e9894e+dirty2.36 MiB3.10 MiB752.76 KiB
e4c23be+dirty2.36 MiB3.08 MiB737.17 KiB
4a9de34+dirty2.36 MiB3.10 MiB753.19 KiB
@bruno-garcia
bruno-garciaforce-pushed
the
deps/scripts/update-javascript.sh
branch
5 times, most recently
from
7a5b973 to
652045eCompareNovember 21, 2024 09:33
@github-actions
github-actionsBot
commented
Nov 21, 2024

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time518.60 ms512.04 ms-6.56 ms
Size17.74 MiB20.08 MiB2.35 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
7871424462.63 ms445.80 ms-16.83 ms
1e9894e431.94 ms445.06 ms13.12 ms
c0332a6461.40 ms456.00 ms-5.40 ms
cdeca8b438.11 ms436.48 ms-1.63 ms
e4c23be452.76 ms438.16 ms-14.60 ms
d3ef7b9486.60 ms474.76 ms-11.84 ms
bca5c58498.31 ms498.32 ms0.01 ms
4a9de34423.00 ms429.66 ms6.66 ms
f193e90432.83 ms433.10 ms0.27 ms
App size
RevisionPlainWith SentryDiff
787142417.74 MiB20.08 MiB2.34 MiB
1e9894e17.74 MiB20.08 MiB2.34 MiB
c0332a617.74 MiB20.08 MiB2.34 MiB
cdeca8b17.74 MiB20.07 MiB2.34 MiB
e4c23be17.74 MiB20.08 MiB2.34 MiB
d3ef7b917.74 MiB20.08 MiB2.35 MiB
bca5c5817.74 MiB20.08 MiB2.34 MiB
4a9de3417.74 MiB20.08 MiB2.34 MiB
f193e9017.74 MiB20.08 MiB2.34 MiB
@antonis
antonis
commented
Nov 22, 2024

Copy link


Copy Markdown

ContributorAuthor
Merged the fix on #4293 with 61665c7
@antonisantonis
closed this
Nov 22, 2024
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@krystofwoldrichkrystofwoldrichAwaiting requested review from krystofwoldrich
@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimerman

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@web-flow

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
test(fix): Add sentry.source custom in the navigation span.data - #4294
Closed
antonis wants to merge 2 commits into
deps/scripts/update-javascript.shfrom 
antonis/js-8.39.0-test-fix
Closed
test(fix): Add sentry.source custom in the navigation span.data#4294
antonis wants to merge 2 commits into
deps/scripts/update-javascript.shfrom 
antonis/js-8.39.0-test-fix
Conversation
@antonis
@antonisantonis
commented
Nov 20, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
⚠️Based on: #4293
📜 Description
Adds sentry.source: custom in the span.data to fix failing tests in the JavaScript SDK to v8.39.0 upgrade #4293

The change seems to be related with getsentry/sentry-javascript#14251
💡 Motivation and Context
Fix failing tests in the JavaScript SDK to v8.39.0 upgrade #4293 (comment)
- React Navigation - TTID › ttid enabled › should add processing navigation span
- React Navigation - TTID › ttid enabled › should add processing navigation span for application start up

💚 How did you test it?
CI
📝 Checklist
  •  I reviewed submitted code
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  All tests passing
  •  No breaking changes
🔮 Next steps
#skip-changelog
@antonisantonis
mentioned this pull request
Nov 20, 2024
 Merged

@antonisantonis
changed the title
test(fix) Add custom sentry.source in the span datatest(fix): Add sentry.source custom in the navigation span.dataNov 20, 2024
@antonis
antonis
marked this pull request as ready for review
November 20, 2024 09:01
@github-actions
github-actionsBot
commented
Nov 20, 2024

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time410.52 ms469.98 ms59.46 ms
Size7.15 MiB8.36 MiB1.21 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
1e9894e+dirty385.63 ms420.18 ms34.55 ms
4a9de34+dirty385.19 ms429.35 ms44.16 ms
cdeca8b+dirty418.09 ms468.62 ms50.53 ms
f193e90+dirty370.91 ms498.10 ms127.19 ms
e4c23be+dirty379.09 ms412.68 ms33.59 ms
bca5c58+dirty369.19 ms401.90 ms32.71 ms
7871424+dirty417.35 ms468.16 ms50.81 ms
c0332a6+dirty389.21 ms449.39 ms60.17 ms
App size
RevisionPlainWith SentryDiff
1e9894e+dirty7.15 MiB8.35 MiB1.20 MiB
4a9de34+dirty7.15 MiB8.35 MiB1.20 MiB
cdeca8b+dirty7.15 MiB8.35 MiB1.20 MiB
f193e90+dirty7.15 MiB8.35 MiB1.20 MiB
e4c23be+dirty7.15 MiB8.35 MiB1.20 MiB
bca5c58+dirty7.15 MiB8.35 MiB1.20 MiB
7871424+dirty7.15 MiB8.35 MiB1.20 MiB
c0332a6+dirty7.15 MiB8.35 MiB1.20 MiB
@github-actions
github-actionsBot
commented
Nov 20, 2024

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1241.37 ms1241.47 ms0.10 ms
Size2.92 MiB3.66 MiB758.74 KiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
cdeca8b+dirty1235.78 ms1225.23 ms-10.55 ms
c0332a6+dirty1227.13 ms1230.90 ms3.77 ms
7871424+dirty1245.73 ms1235.39 ms-10.35 ms
bca5c58+dirty1224.23 ms1224.90 ms0.66 ms
f193e90+dirty1228.43 ms1229.02 ms0.59 ms
1e9894e+dirty1233.37 ms1226.96 ms-6.41 ms
e4c23be+dirty1232.21 ms1230.16 ms-2.05 ms
4a9de34+dirty1234.35 ms1230.35 ms-3.99 ms
App size
RevisionPlainWith SentryDiff
cdeca8b+dirty2.92 MiB3.64 MiB744.52 KiB
c0332a6+dirty2.92 MiB3.64 MiB742.47 KiB
7871424+dirty2.92 MiB3.66 MiB757.21 KiB
bca5c58+dirty2.92 MiB3.66 MiB757.55 KiB
f193e90+dirty2.92 MiB3.64 MiB742.92 KiB
1e9894e+dirty2.92 MiB3.66 MiB757.26 KiB
e4c23be+dirty2.92 MiB3.64 MiB742.98 KiB
4a9de34+dirty2.92 MiB3.66 MiB757.67 KiB
@github-actions
github-actionsBot
commented
Nov 20, 2024

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1225.23 ms1225.66 ms0.43 ms
Size2.36 MiB3.10 MiB753.50 KiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
cdeca8b+dirty1212.42 ms1223.69 ms11.27 ms
c0332a6+dirty1223.13 ms1232.31 ms9.18 ms
7871424+dirty1212.69 ms1224.40 ms11.72 ms
bca5c58+dirty1208.27 ms1212.41 ms4.14 ms
f193e90+dirty1224.20 ms1229.10 ms4.90 ms
1e9894e+dirty1213.33 ms1225.16 ms11.83 ms
e4c23be+dirty1225.25 ms1223.76 ms-1.49 ms
4a9de34+dirty1215.58 ms1218.76 ms3.17 ms
App size
RevisionPlainWith SentryDiff
cdeca8b+dirty2.36 MiB3.09 MiB743.02 KiB
c0332a6+dirty2.36 MiB3.08 MiB736.57 KiB
7871424+dirty2.36 MiB3.10 MiB752.86 KiB
bca5c58+dirty2.36 MiB3.10 MiB752.95 KiB
f193e90+dirty2.36 MiB3.08 MiB737.28 KiB
1e9894e+dirty2.36 MiB3.10 MiB752.76 KiB
e4c23be+dirty2.36 MiB3.08 MiB737.17 KiB
4a9de34+dirty2.36 MiB3.10 MiB753.19 KiB
@bruno-garcia
bruno-garciaforce-pushed
the
deps/scripts/update-javascript.sh
branch
5 times, most recently
from
7a5b973 to
652045eCompareNovember 21, 2024 09:33
@github-actions
github-actionsBot
commented
Nov 21, 2024

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time518.60 ms512.04 ms-6.56 ms
Size17.74 MiB20.08 MiB2.35 MiB
Baseline results on branch: deps/scripts/update-javascript.sh
Startup times
RevisionPlainWith SentryDiff
7871424462.63 ms445.80 ms-16.83 ms
1e9894e431.94 ms445.06 ms13.12 ms
c0332a6461.40 ms456.00 ms-5.40 ms
cdeca8b438.11 ms436.48 ms-1.63 ms
e4c23be452.76 ms438.16 ms-14.60 ms
d3ef7b9486.60 ms474.76 ms-11.84 ms
bca5c58498.31 ms498.32 ms0.01 ms
4a9de34423.00 ms429.66 ms6.66 ms
f193e90432.83 ms433.10 ms0.27 ms
App size
RevisionPlainWith SentryDiff
787142417.74 MiB20.08 MiB2.34 MiB
1e9894e17.74 MiB20.08 MiB2.34 MiB
c0332a617.74 MiB20.08 MiB2.34 MiB
cdeca8b17.74 MiB20.07 MiB2.34 MiB
e4c23be17.74 MiB20.08 MiB2.34 MiB
d3ef7b917.74 MiB20.08 MiB2.35 MiB
bca5c5817.74 MiB20.08 MiB2.34 MiB
4a9de3417.74 MiB20.08 MiB2.34 MiB
f193e9017.74 MiB20.08 MiB2.34 MiB
@antonis
antonis
commented
Nov 22, 2024

Copy link


Copy Markdown

ContributorAuthor
Merged the fix on #4293 with 61665c7
@antonisantonis
closed this
Nov 22, 2024
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@krystofwoldrichkrystofwoldrichAwaiting requested review from krystofwoldrich
@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimerman

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@web-flow