Fix: V7 - JavaScript V9 - set undefined for updateProd when not set by lucas-zimerman · Pull Request #4740 · getsentry/sentry-react-native

lucas-zimerman · 2025-04-09T14:12:51Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Added tests to the wrap function that were missing.
Made updateProps always set but with undefined value, avoiding break changes and making the compiler happy.
Hide updateProps and children from wrap options.

💡 Motivation and Context

Fixes: #4728

💚 How did you test it?

Unit test, Sample app

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

#skip-changelog.

…heck / removed comment from rnerror handler / removed comment from span / fix test from userInteraction

krystofwoldrich · 2025-04-16T10:44:14Z

+ ...(options?.profilerProps ?? { removeUpdateProps: true }),
 name: RootComponent.displayName ?? 'Root',
- updateProps: {}
+ updateProps: options?.profilerProps


I thought we would keep the updateProps: {}? I think just removing the updateProps from the wrap type and here ensuring they will always be {} is enough. I would not delete them in the ReactNativeProfiler class.

Sorry, probably a misunderstanding, fixed here 517161c

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

lucas-zimerman · 2025-04-28T22:08:16Z

@krystofwoldrich I had to split the mocked and real tests from the wrap due to internal conflicts with the internal libraries when interacting with both on the same file (I can't properly remove the mocks otherwise it breaks the React Native testing hooks).

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

krystofwoldrich

Thank you for all the updates and fixing these props. Looks good.

lucas-zimerman · 2025-04-09T14:12:51Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Added tests to the wrap function that were missing.
Made updateProps always set but with undefined value, avoiding break changes and making the compiler happy.
Hide updateProps and children from wrap options.

💡 Motivation and Context

Fixes: #4728

💚 How did you test it?

Unit test, Sample app

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

#skip-changelog.

…heck / removed comment from rnerror handler / removed comment from span / fix test from userInteraction

krystofwoldrich · 2025-04-16T10:44:14Z

+ ...(options?.profilerProps ?? { removeUpdateProps: true }),
 name: RootComponent.displayName ?? 'Root',
- updateProps: {}
+ updateProps: options?.profilerProps


I thought we would keep the updateProps: {}? I think just removing the updateProps from the wrap type and here ensuring they will always be {} is enough. I would not delete them in the ReactNativeProfiler class.

Sorry, probably a misunderstanding, fixed here 517161c

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

lucas-zimerman · 2025-04-28T22:08:16Z

@krystofwoldrich I had to split the mocked and real tests from the wrap due to internal conflicts with the internal libraries when interacting with both on the same file (I can't properly remove the mocks otherwise it breaks the React Native testing hooks).

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

krystofwoldrich

Thank you for all the updates and fixing these props. Looks good.

lucas-zimerman · 2025-04-09T14:12:51Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Added tests to the wrap function that were missing.
Made updateProps always set but with undefined value, avoiding break changes and making the compiler happy.
Hide updateProps and children from wrap options.

💡 Motivation and Context

Fixes: #4728

💚 How did you test it?

Unit test, Sample app

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

#skip-changelog.

…heck / removed comment from rnerror handler / removed comment from span / fix test from userInteraction

krystofwoldrich · 2025-04-16T10:44:14Z

+ ...(options?.profilerProps ?? { removeUpdateProps: true }),
 name: RootComponent.displayName ?? 'Root',
- updateProps: {}
+ updateProps: options?.profilerProps


I thought we would keep the updateProps: {}? I think just removing the updateProps from the wrap type and here ensuring they will always be {} is enough. I would not delete them in the ReactNativeProfiler class.

Sorry, probably a misunderstanding, fixed here 517161c

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

lucas-zimerman · 2025-04-28T22:08:16Z

@krystofwoldrich I had to split the mocked and real tests from the wrap due to internal conflicts with the internal libraries when interacting with both on the same file (I can't properly remove the mocks otherwise it breaks the React Native testing hooks).

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

krystofwoldrich

Thank you for all the updates and fixing these props. Looks good.

lucas-zimerman · 2025-04-09T14:12:51Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Added tests to the wrap function that were missing.
Made updateProps always set but with undefined value, avoiding break changes and making the compiler happy.
Hide updateProps and children from wrap options.

💡 Motivation and Context

Fixes: #4728

💚 How did you test it?

Unit test, Sample app

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

#skip-changelog.

…heck / removed comment from rnerror handler / removed comment from span / fix test from userInteraction

krystofwoldrich · 2025-04-16T10:44:14Z

+ ...(options?.profilerProps ?? { removeUpdateProps: true }),
 name: RootComponent.displayName ?? 'Root',
- updateProps: {}
+ updateProps: options?.profilerProps


I thought we would keep the updateProps: {}? I think just removing the updateProps from the wrap type and here ensuring they will always be {} is enough. I would not delete them in the ReactNativeProfiler class.

Sorry, probably a misunderstanding, fixed here 517161c

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

lucas-zimerman · 2025-04-28T22:08:16Z

@krystofwoldrich I had to split the mocked and real tests from the wrap due to internal conflicts with the internal libraries when interacting with both on the same file (I can't properly remove the mocks otherwise it breaks the React Native testing hooks).

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

krystofwoldrich

Thank you for all the updates and fixing these props. Looks good.

lucas-zimerman · 2025-04-09T14:12:51Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Added tests to the wrap function that were missing.
Made updateProps always set but with undefined value, avoiding break changes and making the compiler happy.
Hide updateProps and children from wrap options.

💡 Motivation and Context

Fixes: #4728

💚 How did you test it?

Unit test, Sample app

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

#skip-changelog.

…heck / removed comment from rnerror handler / removed comment from span / fix test from userInteraction

krystofwoldrich · 2025-04-16T10:44:14Z

+ ...(options?.profilerProps ?? { removeUpdateProps: true }),
 name: RootComponent.displayName ?? 'Root',
- updateProps: {}
+ updateProps: options?.profilerProps


I thought we would keep the updateProps: {}? I think just removing the updateProps from the wrap type and here ensuring they will always be {} is enough. I would not delete them in the ReactNativeProfiler class.

Sorry, probably a misunderstanding, fixed here 517161c

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

lucas-zimerman · 2025-04-28T22:08:16Z

@krystofwoldrich I had to split the mocked and real tests from the wrap due to internal conflicts with the internal libraries when interacting with both on the same file (I can't properly remove the mocks otherwise it breaks the React Native testing hooks).

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

krystofwoldrich

Thank you for all the updates and fixing these props. Looks good.

lucas-zimerman · 2025-04-09T14:12:51Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Added tests to the wrap function that were missing.
Made updateProps always set but with undefined value, avoiding break changes and making the compiler happy.
Hide updateProps and children from wrap options.

💡 Motivation and Context

Fixes: #4728

💚 How did you test it?

Unit test, Sample app

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

#skip-changelog.

…heck / removed comment from rnerror handler / removed comment from span / fix test from userInteraction

krystofwoldrich · 2025-04-16T10:44:14Z

+ ...(options?.profilerProps ?? { removeUpdateProps: true }),
 name: RootComponent.displayName ?? 'Root',
- updateProps: {}
+ updateProps: options?.profilerProps


I thought we would keep the updateProps: {}? I think just removing the updateProps from the wrap type and here ensuring they will always be {} is enough. I would not delete them in the ReactNativeProfiler class.

Sorry, probably a misunderstanding, fixed here 517161c

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

lucas-zimerman · 2025-04-28T22:08:16Z

@krystofwoldrich I had to split the mocked and real tests from the wrap due to internal conflicts with the internal libraries when interacting with both on the same file (I can't properly remove the mocks otherwise it breaks the React Native testing hooks).

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

krystofwoldrich

Thank you for all the updates and fixing these props. Looks good.

lucas-zimerman · 2025-04-09T14:12:51Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Added tests to the wrap function that were missing.
Made updateProps always set but with undefined value, avoiding break changes and making the compiler happy.
Hide updateProps and children from wrap options.

💡 Motivation and Context

Fixes: #4728

💚 How did you test it?

Unit test, Sample app

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

#skip-changelog.

…heck / removed comment from rnerror handler / removed comment from span / fix test from userInteraction

krystofwoldrich · 2025-04-16T10:44:14Z

+ ...(options?.profilerProps ?? { removeUpdateProps: true }),
 name: RootComponent.displayName ?? 'Root',
- updateProps: {}
+ updateProps: options?.profilerProps


I thought we would keep the updateProps: {}? I think just removing the updateProps from the wrap type and here ensuring they will always be {} is enough. I would not delete them in the ReactNativeProfiler class.

Sorry, probably a misunderstanding, fixed here 517161c

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

lucas-zimerman · 2025-04-28T22:08:16Z

@krystofwoldrich I had to split the mocked and real tests from the wrap due to internal conflicts with the internal libraries when interacting with both on the same file (I can't properly remove the mocks otherwise it breaks the React Native testing hooks).

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

krystofwoldrich

Thank you for all the updates and fixing these props. Looks good.

lucas-zimerman · 2025-04-09T14:12:51Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Added tests to the wrap function that were missing.
Made updateProps always set but with undefined value, avoiding break changes and making the compiler happy.
Hide updateProps and children from wrap options.

💡 Motivation and Context

Fixes: #4728

💚 How did you test it?

Unit test, Sample app

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

#skip-changelog.

…heck / removed comment from rnerror handler / removed comment from span / fix test from userInteraction

krystofwoldrich · 2025-04-16T10:44:14Z

+ ...(options?.profilerProps ?? { removeUpdateProps: true }),
 name: RootComponent.displayName ?? 'Root',
- updateProps: {}
+ updateProps: options?.profilerProps


I thought we would keep the updateProps: {}? I think just removing the updateProps from the wrap type and here ensuring they will always be {} is enough. I would not delete them in the ReactNativeProfiler class.

Sorry, probably a misunderstanding, fixed here 517161c

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

lucas-zimerman · 2025-04-28T22:08:16Z

@krystofwoldrich I had to split the mocked and real tests from the wrap due to internal conflicts with the internal libraries when interacting with both on the same file (I can't properly remove the mocks otherwise it breaks the React Native testing hooks).

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

krystofwoldrich

Thank you for all the updates and fixing these props. Looks good.

lucas-zimerman added 30 commits February 14, 2025 14:02

bump SDKs
04b6c06

bump SDKs
0dc4bca

fix build
382fef6

fix tests
33af36c

fix tests
ad6a76c

fix lint errors
15342a2

test ts 5.0
c267f9b

rollback
efea84f

Merge branch 'v7' into lz/bump/jsv9
65a10d5

fix merge conflict with yarn
028dbf9

fix new lint issue
a57459a

sync yarn.lock with V7 branch and install new packages
5de9867

ensure we are using the JS version from the default node resolution
ae65521

update changelog with javascript version bump
bd64169

fix check type (#4587)
39a81c7

add major changes to the SDK
3a4fd4c

fix lint
d8088ad

review check: fix changelog PR number / Fix wrapper incorrect null c…
6f71cda
…heck / removed comment from rnerror handler / removed comment from span / fix test from userInteraction

fix incorrect cli version
55c1961

fix lint
97853c6

Merge branch 'v7' into lz/bump/jsv9
dc2e123

remove shutdowntimeout from android / use newer wizard version
9a0b21e

rollback feedback test change, rollback jest version, fix safe test
45ee6fa

return shutdowntimeout
816b506

explain tracing sample rate
25bf147

fix tracing extension test
8584214

Merge branch 'v7' into lz/bump/jsv9
a26497e

lint fix
499e5a3

update changelog
578ad2c

merge v7
d7fe6c6

lucas-zimerman added 2 commits April 15, 2025 22:43

lets also remove removeUpdateProps
222077c

Merge branch 'v7' into lz/jsv9/fix-props
a5f021e

krystofwoldrich reviewed Apr 16, 2025
View reviewed changes

Comment threadpackages/core/src/js/sdk.tsx Outdated

krystofwoldrich reviewed Apr 16, 2025
View reviewed changes

Comment threadpackages/core/src/js/sdk.tsx Outdated

krystofwoldrich reviewed Apr 16, 2025
View reviewed changes

lucas-zimermanand others added 4 commits April 16, 2025 11:00

Apply suggestions from code review
37e0c94
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

fix updateProps as {}, removeUpdateProps flag, clear tests
517161c

Merge branch 'v7' into lz/jsv9/fix-props
11dfba7

Merge branch 'v7' into lz/jsv9/fix-props
883a831

lucas-zimerman requested a review from krystofwoldrich April 28, 2025 22:08

lucas-zimerman added 7 commits April 28, 2025 21:24

do not affect test
415f623

checkpoint
4dc429f

split mock/real tests
8d9f65b

split mock/real tests
7c8c3d1

fix unused usings
0eb0901

Merge branch 'v7' into lz/jsv9/fix-props
0ad5d39

Merge branch 'v7' into lz/jsv9/fix-props
3fc3d9f

krystofwoldrich reviewed May 8, 2025
View reviewed changes

Comment threadpackages/core/src/js/options.ts Outdated

krystofwoldrich reviewed May 8, 2025
View reviewed changes

Comment threadpackages/core/src/js/tracing/reactnativeprofiler.tsx Outdated

krystofwoldrich reviewed May 8, 2025
View reviewed changes

Comment threadpackages/core/test/wrap.mocked.test.tsx Outdated

krystofwoldrich reviewed May 8, 2025
View reviewed changes

Comment threadpackages/core/test/wrap.mocked.test.tsx Outdated

lucas-zimerman marked this pull request as draft May 8, 2025 13:05

Apply suggestions from code review
cb615e1
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

krystofwoldrich marked this pull request as ready for review May 8, 2025 15:10

krystofwoldrich approved these changes May 8, 2025
View reviewed changes

krystofwoldrich merged commit a1bd56f into v7May 8, 2025

krystofwoldrich deleted the lz/jsv9/fix-props branch May 8, 2025 15:13

lucas-zimerman added 2 commits May 8, 2025 14:46

Remove removeUpdateProps
cf5c90f

fix lint
8b93d90