Skip to content

Fix(V6): missing ip settings from SDK package - #5092

Merged
antonis merged 5 commits into
mainfrom
lz/patch-pii-v6
Aug 25, 2025
Merged

Fix(V6): missing ip settings from SDK package#5092
antonis merged 5 commits into
mainfrom
lz/patch-pii-v6

Conversation

@lucas-zimerman

@lucas-zimermanlucas-zimerman commented Aug 20, 2025

Copy link
Copy Markdown
Collaborator

Based on getsentry/sentry-javascript#17364

original context;

This PR fixes a long-standing problem in the SDK where it would set incorrect information about when Relay should (not) infer IP addresses from sent envelope requests.
Previously, this was thought to be controlled by setting event.user.ip_address: '{{auto}}'. However, after an incident in Relay, it was determined that this is in fact not a reliably way to control IP inference. Instead, SDKs should set event.sdk.settings.infer_ip: 'auto' | 'never' (see closes https://github.com/getsentry/sentry-javascript/issues/16252).
Unfortunately, this wasn't implemented immediately but is taken care of in this PR.
(FWIW, the only reason why Relay continued to infer IP addresses for the JS SDK was because it is excempt from logic that would infer IP addresses only if user.ip_address was set to '{{auto}}'. This is necessary to backwards compatibility with older SDKs.)
Follow-ups: We likely also need to adjust the logic in Electron and Lynx (at the very least remove setting user.ip_address).
closes https://github.com/getsentry/sentry-javascript/issues/17351
closes https://github.com/getsentry/sentry-javascript/issues/16252

Instead of bumping o V10, the fix was patched on the current release.

@github-actions

github-actionsBot commented Aug 20, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Android (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time438.10 ms446.96 ms8.86 ms
Size17.75 MiB20.15 MiB2.41 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
64cd15c439.02 ms427.63 ms-11.39 ms
7be1f99454.83 ms461.36 ms6.53 ms
e2fa43d451.68 ms462.42 ms10.74 ms
3e0a5f9401.72 ms394.98 ms-6.74 ms
d916aa3425.37 ms427.02 ms1.65 ms
785ffb1471.92 ms460.96 ms-10.96 ms
534ba8c484.00 ms499.93 ms15.93 ms
eb07ba3470.04 ms473.35 ms3.31 ms

App size

RevisionPlainWith SentryDiff
64cd15c17.75 MiB20.15 MiB2.41 MiB
7be1f9917.75 MiB20.15 MiB2.41 MiB
e2fa43d17.75 MiB20.15 MiB2.41 MiB
3e0a5f917.75 MiB20.15 MiB2.41 MiB
d916aa317.75 MiB20.15 MiB2.41 MiB
785ffb117.75 MiB20.15 MiB2.41 MiB
534ba8c17.75 MiB20.15 MiB2.41 MiB
eb07ba317.75 MiB20.15 MiB2.41 MiB

lucas-zimerman
lucas-zimerman commented Aug 20, 2025
View reviewed changes
Comment threadCHANGELOG.md Outdated
lucas-zimerman
lucas-zimerman commented Aug 20, 2025
View reviewed changes
Comment threadsamples/react-native/src/App.tsx Outdated
@github-actions

github-actionsBot commented Aug 20, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Android (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time403.98 ms521.62 ms117.65 ms
Size7.15 MiB8.42 MiB1.27 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
3e0a5f9+dirty379.92 ms450.96 ms71.04 ms
d916aa3+dirty411.72 ms451.76 ms40.03 ms
785ffb1+dirty380.65 ms451.83 ms71.18 ms
534ba8c+dirty472.35 ms537.31 ms64.96 ms
7be1f99+dirty369.02 ms399.60 ms30.58 ms
64cd15c+dirty488.79 ms483.54 ms-5.24 ms
eb07ba3+dirty419.49 ms482.12 ms62.63 ms
e2fa43d+dirty326.56 ms372.88 ms46.32 ms

App size

RevisionPlainWith SentryDiff
3e0a5f9+dirty7.15 MiB8.42 MiB1.27 MiB
d916aa3+dirty7.15 MiB8.42 MiB1.27 MiB
785ffb1+dirty7.15 MiB8.42 MiB1.27 MiB
534ba8c+dirty7.15 MiB8.42 MiB1.27 MiB
7be1f99+dirty7.15 MiB8.42 MiB1.27 MiB
64cd15c+dirty7.15 MiB8.42 MiB1.27 MiB
eb07ba3+dirty7.15 MiB8.42 MiB1.27 MiB
e2fa43d+dirty7.15 MiB8.42 MiB1.27 MiB

@github-actions

github-actionsBot commented Aug 20, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

iOS (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time1230.90 ms1234.50 ms3.60 ms
Size2.63 MiB3.81 MiB1.18 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
eb07ba3+dirty1222.46 ms1220.37 ms-2.08 ms
d916aa3+dirty1221.02 ms1228.98 ms7.96 ms
3e0a5f9+dirty1226.94 ms1230.02 ms3.08 ms
e2fa43d+dirty1216.04 ms1232.65 ms16.61 ms
785ffb1+dirty1237.63 ms1240.50 ms2.87 ms
7be1f99+dirty1226.69 ms1217.76 ms-8.93 ms
98f632c+dirty1236.40 ms1241.62 ms5.22 ms
534ba8c+dirty1230.22 ms1231.18 ms0.96 ms
64cd15c+dirty1216.31 ms1214.04 ms-2.26 ms

App size

RevisionPlainWith SentryDiff
eb07ba3+dirty2.63 MiB3.81 MiB1.18 MiB
d916aa3+dirty2.63 MiB3.81 MiB1.18 MiB
3e0a5f9+dirty2.63 MiB3.81 MiB1.18 MiB
e2fa43d+dirty2.63 MiB3.81 MiB1.18 MiB
785ffb1+dirty2.63 MiB3.81 MiB1.18 MiB
7be1f99+dirty2.63 MiB3.81 MiB1.18 MiB
98f632c+dirty2.63 MiB3.81 MiB1.18 MiB
534ba8c+dirty2.63 MiB3.81 MiB1.18 MiB
64cd15c+dirty2.63 MiB3.81 MiB1.18 MiB

@github-actions

github-actionsBot commented Aug 20, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

iOS (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time1210.06 ms1214.27 ms4.21 ms
Size3.19 MiB4.38 MiB1.19 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
d916aa3+dirty1211.02 ms1221.33 ms10.31 ms
534ba8c+dirty1225.00 ms1237.43 ms12.43 ms
64cd15c+dirty1213.50 ms1223.54 ms10.04 ms
785ffb1+dirty1213.71 ms1213.37 ms-0.35 ms
3e0a5f9+dirty1233.65 ms1239.10 ms5.45 ms
eb07ba3+dirty1214.49 ms1221.59 ms7.10 ms
7be1f99+dirty1222.43 ms1217.15 ms-5.28 ms
e2fa43d+dirty1224.43 ms1235.40 ms10.98 ms

App size

RevisionPlainWith SentryDiff
d916aa3+dirty3.19 MiB4.38 MiB1.19 MiB
534ba8c+dirty3.19 MiB4.38 MiB1.19 MiB
64cd15c+dirty3.19 MiB4.38 MiB1.19 MiB
785ffb1+dirty3.19 MiB4.38 MiB1.19 MiB
3e0a5f9+dirty3.19 MiB4.38 MiB1.19 MiB
eb07ba3+dirty3.19 MiB4.38 MiB1.19 MiB
7be1f99+dirty3.19 MiB4.38 MiB1.19 MiB
e2fa43d+dirty3.19 MiB4.38 MiB1.19 MiB

@lucas-zimerman
lucas-zimerman marked this pull request as ready for review August 20, 2025 16:01
antonis
antonis approved these changes Aug 25, 2025
View reviewed changes

@antonisantonis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎸
Thank you for implementing this for V6 @lucas-zimerman 🙇

@antonis
antonis merged commit 21c9e75 into mainAug 25, 2025
87 of 88 checks passed
@antonis
antonis deleted the lz/patch-pii-v6 branch August 25, 2025 12:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonisantonisantonis approved these changes
@alwxalwxAwaiting requested review from alwxalwx is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lucas-zimerman@antonis