feat(core): Add includeFeedback Metro option to exclude feedback widget from bundle by antonis · Pull Request #6025 · getsentry/sentry-react-native

antonis · 2026-04-20T11:11:08Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Adds an includeFeedback option to SentryMetroConfigOptions (used by both withSentryConfig and getSentryExpoConfig). When set to false, a Metro resolver returns { type: 'empty' } for any module matching @sentry(?:-internal)?/feedback, removing the web user-feedback widget from the bundle.

Example:

constconfig=getSentryExpoConfig(__dirname,{includeFeedback: false,});

Also factored the shared resolver logic into buildSentryPackageExcludeResolver, so withSentryResolver (replay) and the new withSentryFeedbackResolver no longer duplicate the resolver body.

💡 Motivation and Context

Users who do not use the feedback feature are still paying for @sentry-internal/feedback in their bundle (see the expo-atlas screenshot in the linked issue). The existing includeWebReplay option solves the same problem for replay; this PR mirrors that pattern for feedback.

Closes#5629

💚 How did you test it?

Added unit tests in packages/core/test/tools/metroconfig.test.ts for the new withSentryFeedbackResolver, covering:
- includeFeedback true/false/undefined across web/android/ios/null platforms
- Both @sentry-internal/feedback and @sentry/feedback module names
- Falls through to the original resolver for non-feedback modules
- Old-Metro (<0.68) fallback path with process.exit(-1)
yarn test:tools — 254 passed
yarn test (full suite) — passing
yarn lint — passing
yarn circularDepCheck — passing
yarn build — passing

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed. feat(react-native): Document includeWebReplay and includeFeedback Metro options sentry-docs#17423
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

…et from bundle Mirrors the existing `includeWebReplay` option. When set to `false`, `@sentry-internal/feedback` (and related subpackages) are resolved to an empty module, removing the web user-feedback widget from the bundle. Refactored the shared resolver logic into `buildSentryPackageExcludeResolver` so `withSentryResolver` and the new `withSentryFeedbackResolver` both call into it instead of duplicating the resolver body. Closes#5629

github-actions · 2026-04-20T11:11:29Z

Semver Impact of This PR

⚪ None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

feat(core): Add includeFeedback Metro option to exclude feedback widget from bundle by antonis in #6025

feat(core): Expose scope-level attributes API by antonis in #6009
chore(deps): Force basic-ftp >=5.3.0 to fix GHSA-rp42-5vxx-qpwr by antonis in #6024
feat(core): Add GlobalErrorBoundary for non-rendering errors by alwx in #6023
chore(deps): update CLI to v3.4.0 by github-actions in #6026
feat: Expose screenshot masking options for error screenshots by antonis in #6007
fix(replay): Check captureReplay return value in iOS bridge by antonis in #6008
chore(deps): bump getsentry/craft from 2.25.2 to 2.25.4 by dependabot in #6019
chore(deps): bump getsentry/craft/.github/workflows/changelog-preview.yml from 2.25.2 to 2.25.4 by dependabot in #6021
chore(deps): bump github/codeql-action from 4.35.1 to 4.35.2 by dependabot in #6022
chore(deps): bump actions/setup-node from 6.3.0 to 6.4.0 by dependabot in #6020
ci(danger): Demote Android SDK version mismatch from fail to warn by antonis in #6018
chore(deps): update Android SDK to v8.39.1 by github-actions in #6010
chore(deps): update JavaScript SDK to v10.49.0 by github-actions in #6011
ci: Integrate Warden for AI-powered PR code review by antonis in #6003
chore(lint): Fixes lint issue on main by antonis in #6013
feat(expo): Warn when prebuilt native projects are missing Sentry config by alwx in #5984

_{🤖 This preview updates automatically when you update the PR.}

github-actions · 2026-04-20T11:11:46Z

	Fails
🚫	Pull request is not ready for merge, please add the "ready-to-merge" label to the pull request

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 395d462

antonis · 2026-04-20T11:28:45Z

@sentry review

antonis · 2026-04-20T11:28:56Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit d82da05. Configure here.}

alwx

Added one small comment

…eExcludeResolver Addresses review feedback: bare `include` is ambiguous in the helper — `includePackage` makes the intent obvious alongside `moduleRegex`.

lucas-zimerman · 2026-04-23T17:14:46Z

 - Expose scope-level attributes API (`setAttribute`, `setAttributes`, `removeAttribute`) bridging to native SDKs ([#6009](https://github.com/getsentry/sentry-react-native/pull/6009))
 - Expose screenshot masking options (`screenshot.maskAllText`, `screenshot.maskAllImages`, `screenshot.maskedViewClasses`, `screenshot.unmaskedViewClasses`) for error screenshots ([#6007](https://github.com/getsentry/sentry-react-native/pull/6007))
 - Warn Expo users at Metro startup when prebuilt native projects are missing Sentry configuration ([#5984](https://github.com/getsentry/sentry-react-native/pull/5984))
+- Add `includeFeedback` Metro config option to exclude `@sentry-internal/feedback` from the bundle ([#6025](https://github.com/getsentry/sentry-react-native/pull/6025))


since a release was done on main branch, this changelog may be out of sync

Updated with 395d462

…edback

@lucas-zimerman

Addresses review feedback from @lucas-zimerman: mirror the `includeWebReplay` naming to make it obvious the option only affects the web feedback package, not the native feedback integration. Also moves the changelog entry from 8.9.1 (where it landed during the merge with main) to Unreleased since this change hasn't shipped yet.

@lucas-zimerman

- Rename `includeFeedback` to `includeWebFeedback` (mirrors the SDK rename in getsentry/sentry-react-native#6025 after @lucas-zimerman's feedback). - Reword the intro to frame the bundle-size options around "not targeting React Native for Web", per @lucas-zimerman's suggestion.

lucas-zimerman

LGTM!

Issue tackled in 395d462

…ro options (#17423) ## DESCRIBE YOUR PR Adds a new \"Reduce Bundle Size\" section to the [React Native Metro](https://docs.sentry.io/platforms/react-native/manual-setup/metro/) page describing how to exclude the web Session Replay and User Feedback packages from the bundle for users who don't need them. Covers two Metro Plugin options: - \`includeWebReplay\` — already exists in the SDK but was previously undocumented. - \`includeFeedback\` — new in an upcoming Sentry React Native SDK release, added in [getsentry/sentry-react-native#6025](getsentry/sentry-react-native#6025) (closes [getsentry/sentry-react-native#5629](getsentry/sentry-react-native#5629)). > Note: there's a \`TODO\` in the doc pinning the exact SDK version for \`includeFeedback\` — will update before merge once the SDK release is cut. ## IS YOUR CHANGE URGENT? - [ ] Urgent deadline (GA date, etc.): - [ ] Other deadline: - [x] None: Not urgent, can wait up to 1 week+ ⚠️ Should be merged after getsentry/sentry-react-native#6025 is shipped ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) - [ ] SDK version for \`includeFeedback\` confirmed in the Alert callout ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)

antonis commented Apr 20, 2026
View reviewed changes

Comment threadCHANGELOG.md Outdated

Fix changelog
d82da05

cursorBot reviewed Apr 20, 2026
View reviewed changes

antonis marked this pull request as ready for review April 20, 2026 11:37

antonis requested review from alwx and lucas-zimerman as code owners April 20, 2026 11:37

alwx assigned alwx and unassigned alwx Apr 20, 2026

alwx reviewed Apr 21, 2026
View reviewed changes

Comment threadpackages/core/src/js/tools/metroconfig.ts Outdated

alwx previously requested changes Apr 21, 2026
View reviewed changes

antonis added 2 commits April 21, 2026 14:20

refactor(core): Rename include to includePackage in buildSentryPackag…
0449f5e
…eExcludeResolver Addresses review feedback: bare `include` is ambiguous in the helper — `includePackage` makes the intent obvious alongside `moduleRegex`.

Merge branch 'main' into feat/metro-include-feedback
8dcac24

antonis requested a review from alwx April 21, 2026 12:27

antonis mentioned this pull request Apr 21, 2026
feat(react-native): Document includeWebReplay and includeFeedback Metro options getsentry/sentry-docs#17423
Merged
7 tasks

Merge branch 'main' into feat/metro-include-feedback
8367db6

lucas-zimerman reviewed Apr 23, 2026
View reviewed changes

Comment threadpackages/core/src/js/tools/metroconfig.ts Outdated

lucas-zimerman reviewed Apr 23, 2026
View reviewed changes

Comment threadpackages/core/src/js/tools/metroconfig.ts

lucas-zimerman reviewed Apr 23, 2026
View reviewed changes

antonis added 2 commits April 24, 2026 10:40

Merge remote-tracking branch 'origin/main' into feat/metro-include-fe…
1a4ee9b
…edback

antonis requested a review from lucas-zimerman April 24, 2026 09:05

lucas-zimerman approved these changes Apr 24, 2026
View reviewed changes

antonis merged commit 8cd4c97 into mainApr 24, 2026
55 of 61 checks passed

antonis deleted the feat/metro-include-feedback branch April 24, 2026 13:06

github-actionsBot mentioned this pull request Apr 27, 2026
[skill-drift] fix(sentry-react-native-sdk): add includeWebFeedback Metro option and rage tap detection docs getsentry/sentry-for-ai#108
Merged

sentry-release-botBot mentioned this pull request Apr 30, 2026
publish: getsentry/sentry-react-native@8.10.0 getsentry/publish#8003
Closed
3 tasks

antonis mentioned this pull request May 15, 2026
fix(core): Fix includeWebFeedback crash by stubbing browser wrapper modules #6150
Merged
10 tasks

Navigation Menu

Uh oh!

Uh oh!

feat(core): Add includeFeedback Metro option to exclude feedback widget from bundle - #6025

feat(core): Add includeFeedback Metro option to exclude feedback widget from bundle#6025
antonis merged 7 commits into
mainfrom
feat/metro-include-feedback

antonis commented Apr 20, 2026•
edited
Loading

Uh oh!

github-actionsBot commented Apr 20, 2026•
edited
Loading

Uh oh!

github-actionsBot commented Apr 20, 2026•
edited
Loading

Uh oh!

Uh oh!

antonis commented Apr 20, 2026

Uh oh!

antonis commented Apr 20, 2026

Uh oh!

cursorBot left a comment

Uh oh!

Uh oh!

alwx left a comment

Uh oh!

Uh oh!

Uh oh!

lucas-zimermanApr 23, 2026

Uh oh!

antonisApr 24, 2026

Uh oh!

lucas-zimerman left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

antonis commented Apr 20, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actionsBot commented Apr 20, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Semver Impact of This PR

Uh oh!

github-actionsBot commented Apr 20, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

antonis commented Apr 20, 2026

Uh oh!

antonis commented Apr 20, 2026

Uh oh!

cursorBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alwx left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lucas-zimermanApr 23, 2026

Choose a reason for hiding this comment

Uh oh!

antonisApr 24, 2026

Choose a reason for hiding this comment

Uh oh!

lucas-zimerman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

antonis commented Apr 20, 2026•
edited
Loading

github-actionsBot commented Apr 20, 2026•
edited
Loading

github-actionsBot commented Apr 20, 2026•
edited
Loading