Skip to content

Expose span_id in Span constructor - #1945

Merged
sl0thentr0py merged 1 commit into
masterfrom
neel/otel/expose-span-id
Nov 29, 2022
Merged

Expose span_id in Span constructor#1945
sl0thentr0py merged 1 commit into
masterfrom
neel/otel/expose-span-id

Conversation

@sl0thentr0py

Copy link
Copy Markdown
Member

No description provided.

@sl0thentr0py
sl0thentr0py changed the base branch from master to neel/config-instrumenterNovember 23, 2022 15:22
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Base: 98.33% // Head: 96.56% // Decreases project coverage by -1.76%⚠️

Coverage data is based on head (954d6a2) compared to base (248ad25).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@ Coverage Diff @@## neel/config-instrumenter #1945 +/- ##
============================================================
- Coverage 98.33% 96.56% -1.77% 
============================================================
Files 151 121 -30 Lines 9369 7723 -1646 ============================================================
- Hits 9213 7458 -1755 - Misses 156 265 +109 
Impacted FilesCoverage Δ
sentry-ruby/lib/sentry/span.rb100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/span_spec.rb100.00% <100.00%> (ø)
sentry-rails/lib/sentry/rails/railtie.rb25.33% <0.00%> (-72.00%)⬇️
sentry-rails/lib/sentry/rails/tracing.rb34.21% <0.00%> (-65.79%)⬇️
...entry-rails/lib/sentry/rails/capture_exceptions.rb34.61% <0.00%> (-65.39%)⬇️
sentry-rails/lib/sentry/rails/active_job.rb39.47% <0.00%> (-60.53%)⬇️
sentry-rails/lib/sentry/rails/backtrace_cleaner.rb47.05% <0.00%> (-52.95%)⬇️
.../lib/sentry/rails/rescued_exception_interceptor.rb50.00% <0.00%> (-50.00%)⬇️
...ntry/rails/tracing/action_controller_subscriber.rb55.55% <0.00%> (-44.45%)⬇️
...ls/lib/sentry/rails/tracing/abstract_subscriber.rb37.03% <0.00%> (-37.04%)⬇️
... and 36 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@st0012

Copy link
Copy Markdown
Contributor

I feel this can be based on master?

@sl0thentr0py
sl0thentr0pyforce-pushed the neel/config-instrumenter branch 2 times, most recently from 9097a81 to 09f1c1bCompareNovember 28, 2022 14:25
Base automatically changed from neel/config-instrumenter to masterNovember 29, 2022 12:48
@sl0thentr0py
sl0thentr0pyforce-pushed the neel/otel/expose-span-id branch from 954d6a2 to 833392fCompareNovember 29, 2022 12:51
@sl0thentr0py
sl0thentr0py enabled auto-merge (squash) November 29, 2022 12:51
@sl0thentr0py
sl0thentr0py merged commit fa98335 into masterNov 29, 2022
@sl0thentr0py
sl0thentr0py deleted the neel/otel/expose-span-id branch November 29, 2022 12:52
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@sl0thentr0py@codecov-commenter@st0012@AbhiPrasad