Skip to content

fix(telemetry): Only trace step if there is an active span#345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Lms24 wants to merge 1 commit into from
Closed

fix(telemetry): Only trace step if there is an active span #345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/telemetry.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
import {
defaultStackParser,
getCurrentHub,
Hub,
Integrations,
makeMain,
Expand DownExpand Up@@ -76,8 +77,6 @@ function createSentryInstance(enabled: boolean, integration: string) {
},

transport: makeNodeTransport,

debug: true,
});

const hub = new Hub(client);
Expand All@@ -90,5 +89,8 @@ function createSentryInstance(enabled: boolean, integration: string) {
}

export function traceStep<T>(step: string, callback: () => T): T {
return trace({ name: step, op: 'wizard.step' }, () => callback());
if (getCurrentHub().getScope().getSpan()) {
return trace({ name: step, op: 'wizard.step' }, () => callback());
}
return callback();
}