fix(ourlogs): break ordering ties with timestamp.sequence - #120451
Draft
JoshuaKGoldberg wants to merge 4 commits into
Draft
fix(ourlogs): break ordering ties with timestamp.sequence#120451JoshuaKGoldberg wants to merge 4 commits into
JoshuaKGoldberg wants to merge 4 commits into
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Logs emitted in quick succession can share an identical timestamp_precise when the SDK environment can't produce sub-millisecond timestamps. Order by the SDK's monotonic timestamp.sequence attribute to break those ties.
JoshuaKGoldberg
force-pushed
the
joshgoldberg/logs-569-handle-logs-ordering-with-same-timestamptimestamp_precise
branch
from
July 23, 2026 14:32
7300e5d to
1335adc
Compare
Member
Author
|
@cursor review |
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 17f8851. Configure here.
JoshuaKGoldberg
marked this pull request as ready for review
July 23, 2026 15:46
adrianviquez
approved these changes
Jul 23, 2026
k-fish
reviewed
Jul 28, 2026
JoshuaKGoldberg
added a commit
that referenced
this pull request
Jul 29, 2026
#120451 will expose an internal `timestamp.sequence` attribute used to break log ordering ties when logs share an identical `timestamp_precise`. It's an ordering aid, not something users should see, so this hides it from the logs UI alongside the other internal timestamp fields. This PR should land first, before #120451, so users never see the field. Closes LOGS-569.
This was referenced Jul 30, 2026
Member
Author
|
(needs more backend work and Kevan is out, moving back to draft for now) |
JoshuaKGoldberg
marked this pull request as draft
August 10, 2026 14:09
k-fish
approved these changes
Aug 13, 2026
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDKs emit a per-millisecond
sentry.timestamp.sequencecounter so logs sharing a millisecond timestamp keep their emission order.timestamp_precisecan't recover that order on its own: it's stored as a float64, and at current epoch values a float64 only resolves down to ~256ns. So same-millisecond logs aren't reliably distinguishable bytimestamp_precise. Wamp wump.This adds the
timestamp.sequencealias and orders by it as a tiebreaker aftertimestampandtimestamp_precise. So we get back the nice ordering it's meant for.#120452 contains corresponding frontend changes to hide it in the UI. That PR should land first so we don't get an awkward blip of showing it to users.✅Starts on LOGS-569.