feat(events-v2) Add a event graph to the event modal by markstory · Pull Request #13568 · getsentry/sentry

markstory · 2019-06-06T15:02:28Z

Show an event graph for grouped views. The grouped view mode requires showing a single event + grouped data above the single event view. I've implemented a stripped down line graph as we don't need release markers or previous period markers on this graph. Additionally we'll need special click handling that navigates to other events in the series.

TODO

Add UI integration jest tests

Refs SEN-716

billyvg · 2019-06-06T16:55:54Z

How do you specify multiple groupIds?

Right now I don't have use-case where I need more than one group, I'll expand the proptype to allow for future scenarios though.

billyvg · 2019-06-06T16:56:53Z

The _ is not necessary here

markstory · 2019-06-06T17:50:51Z

Screenshot of what it looks like in action

markstory · 2019-06-07T14:56:45Z

@lynnagara I've rebased this on top of your branch and switched to using the /latest endpoint when getting event information for grouped views.

lynnagara · 2019-06-07T19:10:59Z

- params: PropTypes.object,
- eventSlug: PropTypes.string.isRequired,
+ organization: SentryTypes.Organization.isRequired,
+ eventSlug: PropTypes.string,


We could have a proptype that enforces the eventSlug format

Show an event graph for grouped views. The grouped view mode requires showing a single event + grouped data above the single event view. I've implemented a stripped down line graph as we don't need release markers or previous period markers on this graph. Additionally we'll need special click handling that navigates to other events in the series. Refs SEN-716

Use the new /latest endpoint in the grouped modal view. This pushes the complexity of finding the most recent event into the API where it should be.

Lyn prefers to keep the URL parameter `:` separated.

By creating a combined query parameter we have fewer state bits we need to manage together. Instead we can focus on the valid/invalid value states.

In grouped views we want to show pagination buttons to navigate between the events that match the current search filters including the query string. By creating URLs that use eventSlug and the current search criteria we'll end up at the right events. Refs SEN-715

markstory · 2019-06-10T19:55:23Z

I've included the pagination changes in this pull request now as well. The top half of the event modal looks like:

billyvg · 2019-06-11T14:40:09Z

+
+const slugValidator = function(props, propName, componentName) {
+ const value = props[propName];
+ if (value && !/^(?:[^:]+:)?(?:[^:]+):(?:[a-f0-9]+|latest|oldest)$/.test(value)) {


:nice:regex:
It'd help to have a comment with what a valid slug looks like. Are special characters (non alphanumerics) allowed in the first two groups?

billyvg · 2019-06-11T14:44:07Z

- params: PropTypes.object,
- eventSlug: PropTypes.string.isRequired,
+ organization: SentryTypes.Organization.isRequired,
+ eventSlug: slugValidator,


Do we want to validate these at runtime as well? (I guess receiving a 404 makes sense)

I think the 404 we display in the modal could use some work, but I can do that separately.

billyvg · 2019-06-11T14:49:00Z

+const ModalLineGraph = props => {
+ const {api, groupId, organization, location, selection} = props;
+
+ const isUtc = selection.datetime.utc;


So if selection.datetime.utc is null it won't necessarily mean that the user doesn't want it to be formatted UTC, it just means that they haven't use the UTC override in the global selection header. I think we'd want to fallback to user's timezone in ConfigStore.

…agination.jsx Co-Authored-By: Billy Vong <billyvg@users.noreply.github.com>

* master: (102 commits) fix(symbolicator): Tests are no longer allowed failures (#13566) fix(yarn): Fix yarn path in distutils (#13647) ref(ui): Remove OrganizationState from a bunch of places (#13646) ref(ui): Remove crufty global exports (#13578) feat(events-v2): Page loader improvements (#13645) fix: Query the right set of issues when given no set of envs for a given first release (#13551) feat(ui): update incidents icon (#13622) fix(ui): remove rate-limited values from graph when no events are present (#13624) feat(events-v2) Add a event graph to the event modal (#13568) fix(store): Check project.status is VISIBLE before attempting to process perf(snuba): Limit SnubaEvent.get_event to return the first result only. (#13644) tests(percy): Fix Incident status item dynamic time (#13640) ref(sentry10): Clean up action creators (#13636) ref(app-platform): Backfill IntegrationFeature table (#13548) ref(utils): Remove default / reexports from utils.jsx (#13581) feat(sentry10): Remove the ability to set a default environment (#13637) feat(api): Add url unfurls for incidents to slack integration (SEN-566) build(yarn): Upgrade yarn to 1.16.0, embed in repo (#13569) feat(api): Allow passing group_ids to `OrganizationGroupIndexEndpoint` for bulk fetching groups (SEN-701) feat(ui): Adds related issues to Incidents sidebar [SEN-695] (#13617) ...

markstory · 2019-06-06T15:02:28Z

Show an event graph for grouped views. The grouped view mode requires showing a single event + grouped data above the single event view. I've implemented a stripped down line graph as we don't need release markers or previous period markers on this graph. Additionally we'll need special click handling that navigates to other events in the series.

TODO

Add UI integration jest tests

Refs SEN-716

billyvg · 2019-06-06T16:55:54Z

How do you specify multiple groupIds?

Right now I don't have use-case where I need more than one group, I'll expand the proptype to allow for future scenarios though.

billyvg · 2019-06-06T16:56:53Z

The _ is not necessary here

markstory · 2019-06-06T17:50:51Z

Screenshot of what it looks like in action

markstory · 2019-06-07T14:56:45Z

@lynnagara I've rebased this on top of your branch and switched to using the /latest endpoint when getting event information for grouped views.

lynnagara · 2019-06-07T19:10:59Z

- params: PropTypes.object,
- eventSlug: PropTypes.string.isRequired,
+ organization: SentryTypes.Organization.isRequired,
+ eventSlug: PropTypes.string,


We could have a proptype that enforces the eventSlug format

Show an event graph for grouped views. The grouped view mode requires showing a single event + grouped data above the single event view. I've implemented a stripped down line graph as we don't need release markers or previous period markers on this graph. Additionally we'll need special click handling that navigates to other events in the series. Refs SEN-716

Use the new /latest endpoint in the grouped modal view. This pushes the complexity of finding the most recent event into the API where it should be.

Lyn prefers to keep the URL parameter `:` separated.

By creating a combined query parameter we have fewer state bits we need to manage together. Instead we can focus on the valid/invalid value states.

In grouped views we want to show pagination buttons to navigate between the events that match the current search filters including the query string. By creating URLs that use eventSlug and the current search criteria we'll end up at the right events. Refs SEN-715

markstory · 2019-06-10T19:55:23Z

I've included the pagination changes in this pull request now as well. The top half of the event modal looks like:

billyvg · 2019-06-11T14:40:09Z

+
+const slugValidator = function(props, propName, componentName) {
+ const value = props[propName];
+ if (value && !/^(?:[^:]+:)?(?:[^:]+):(?:[a-f0-9]+|latest|oldest)$/.test(value)) {


:nice:regex:
It'd help to have a comment with what a valid slug looks like. Are special characters (non alphanumerics) allowed in the first two groups?

billyvg · 2019-06-11T14:44:07Z

- params: PropTypes.object,
- eventSlug: PropTypes.string.isRequired,
+ organization: SentryTypes.Organization.isRequired,
+ eventSlug: slugValidator,


Do we want to validate these at runtime as well? (I guess receiving a 404 makes sense)

I think the 404 we display in the modal could use some work, but I can do that separately.

billyvg · 2019-06-11T14:49:00Z

+const ModalLineGraph = props => {
+ const {api, groupId, organization, location, selection} = props;
+
+ const isUtc = selection.datetime.utc;


So if selection.datetime.utc is null it won't necessarily mean that the user doesn't want it to be formatted UTC, it just means that they haven't use the UTC override in the global selection header. I think we'd want to fallback to user's timezone in ConfigStore.

…agination.jsx Co-Authored-By: Billy Vong <billyvg@users.noreply.github.com>

* master: (102 commits) fix(symbolicator): Tests are no longer allowed failures (#13566) fix(yarn): Fix yarn path in distutils (#13647) ref(ui): Remove OrganizationState from a bunch of places (#13646) ref(ui): Remove crufty global exports (#13578) feat(events-v2): Page loader improvements (#13645) fix: Query the right set of issues when given no set of envs for a given first release (#13551) feat(ui): update incidents icon (#13622) fix(ui): remove rate-limited values from graph when no events are present (#13624) feat(events-v2) Add a event graph to the event modal (#13568) fix(store): Check project.status is VISIBLE before attempting to process perf(snuba): Limit SnubaEvent.get_event to return the first result only. (#13644) tests(percy): Fix Incident status item dynamic time (#13640) ref(sentry10): Clean up action creators (#13636) ref(app-platform): Backfill IntegrationFeature table (#13548) ref(utils): Remove default / reexports from utils.jsx (#13581) feat(sentry10): Remove the ability to set a default environment (#13637) feat(api): Add url unfurls for incidents to slack integration (SEN-566) build(yarn): Upgrade yarn to 1.16.0, embed in repo (#13569) feat(api): Allow passing group_ids to `OrganizationGroupIndexEndpoint` for bulk fetching groups (SEN-701) feat(ui): Adds related issues to Incidents sidebar [SEN-695] (#13617) ...

markstory · 2019-06-06T15:02:28Z

Show an event graph for grouped views. The grouped view mode requires showing a single event + grouped data above the single event view. I've implemented a stripped down line graph as we don't need release markers or previous period markers on this graph. Additionally we'll need special click handling that navigates to other events in the series.

TODO

Add UI integration jest tests

Refs SEN-716

billyvg · 2019-06-06T16:55:54Z

How do you specify multiple groupIds?

Right now I don't have use-case where I need more than one group, I'll expand the proptype to allow for future scenarios though.

billyvg · 2019-06-06T16:56:53Z

The _ is not necessary here

markstory · 2019-06-06T17:50:51Z

Screenshot of what it looks like in action

markstory · 2019-06-07T14:56:45Z

@lynnagara I've rebased this on top of your branch and switched to using the /latest endpoint when getting event information for grouped views.

lynnagara · 2019-06-07T19:10:59Z

- params: PropTypes.object,
- eventSlug: PropTypes.string.isRequired,
+ organization: SentryTypes.Organization.isRequired,
+ eventSlug: PropTypes.string,


We could have a proptype that enforces the eventSlug format

Show an event graph for grouped views. The grouped view mode requires showing a single event + grouped data above the single event view. I've implemented a stripped down line graph as we don't need release markers or previous period markers on this graph. Additionally we'll need special click handling that navigates to other events in the series. Refs SEN-716

Use the new /latest endpoint in the grouped modal view. This pushes the complexity of finding the most recent event into the API where it should be.

Lyn prefers to keep the URL parameter `:` separated.

By creating a combined query parameter we have fewer state bits we need to manage together. Instead we can focus on the valid/invalid value states.

In grouped views we want to show pagination buttons to navigate between the events that match the current search filters including the query string. By creating URLs that use eventSlug and the current search criteria we'll end up at the right events. Refs SEN-715

markstory · 2019-06-10T19:55:23Z

I've included the pagination changes in this pull request now as well. The top half of the event modal looks like:

billyvg · 2019-06-11T14:40:09Z

+
+const slugValidator = function(props, propName, componentName) {
+ const value = props[propName];
+ if (value && !/^(?:[^:]+:)?(?:[^:]+):(?:[a-f0-9]+|latest|oldest)$/.test(value)) {


:nice:regex:
It'd help to have a comment with what a valid slug looks like. Are special characters (non alphanumerics) allowed in the first two groups?

billyvg · 2019-06-11T14:44:07Z

- params: PropTypes.object,
- eventSlug: PropTypes.string.isRequired,
+ organization: SentryTypes.Organization.isRequired,
+ eventSlug: slugValidator,


Do we want to validate these at runtime as well? (I guess receiving a 404 makes sense)

I think the 404 we display in the modal could use some work, but I can do that separately.

billyvg · 2019-06-11T14:49:00Z

+const ModalLineGraph = props => {
+ const {api, groupId, organization, location, selection} = props;
+
+ const isUtc = selection.datetime.utc;


So if selection.datetime.utc is null it won't necessarily mean that the user doesn't want it to be formatted UTC, it just means that they haven't use the UTC override in the global selection header. I think we'd want to fallback to user's timezone in ConfigStore.

…agination.jsx Co-Authored-By: Billy Vong <billyvg@users.noreply.github.com>

* master: (102 commits) fix(symbolicator): Tests are no longer allowed failures (#13566) fix(yarn): Fix yarn path in distutils (#13647) ref(ui): Remove OrganizationState from a bunch of places (#13646) ref(ui): Remove crufty global exports (#13578) feat(events-v2): Page loader improvements (#13645) fix: Query the right set of issues when given no set of envs for a given first release (#13551) feat(ui): update incidents icon (#13622) fix(ui): remove rate-limited values from graph when no events are present (#13624) feat(events-v2) Add a event graph to the event modal (#13568) fix(store): Check project.status is VISIBLE before attempting to process perf(snuba): Limit SnubaEvent.get_event to return the first result only. (#13644) tests(percy): Fix Incident status item dynamic time (#13640) ref(sentry10): Clean up action creators (#13636) ref(app-platform): Backfill IntegrationFeature table (#13548) ref(utils): Remove default / reexports from utils.jsx (#13581) feat(sentry10): Remove the ability to set a default environment (#13637) feat(api): Add url unfurls for incidents to slack integration (SEN-566) build(yarn): Upgrade yarn to 1.16.0, embed in repo (#13569) feat(api): Allow passing group_ids to `OrganizationGroupIndexEndpoint` for bulk fetching groups (SEN-701) feat(ui): Adds related issues to Incidents sidebar [SEN-695] (#13617) ...

markstory · 2019-06-06T15:02:28Z

Show an event graph for grouped views. The grouped view mode requires showing a single event + grouped data above the single event view. I've implemented a stripped down line graph as we don't need release markers or previous period markers on this graph. Additionally we'll need special click handling that navigates to other events in the series.

TODO

Add UI integration jest tests

Refs SEN-716

billyvg · 2019-06-06T16:55:54Z

How do you specify multiple groupIds?

Right now I don't have use-case where I need more than one group, I'll expand the proptype to allow for future scenarios though.

billyvg · 2019-06-06T16:56:53Z

The _ is not necessary here

markstory · 2019-06-06T17:50:51Z

Screenshot of what it looks like in action

markstory · 2019-06-07T14:56:45Z

@lynnagara I've rebased this on top of your branch and switched to using the /latest endpoint when getting event information for grouped views.

lynnagara · 2019-06-07T19:10:59Z

- params: PropTypes.object,
- eventSlug: PropTypes.string.isRequired,
+ organization: SentryTypes.Organization.isRequired,
+ eventSlug: PropTypes.string,


We could have a proptype that enforces the eventSlug format

Show an event graph for grouped views. The grouped view mode requires showing a single event + grouped data above the single event view. I've implemented a stripped down line graph as we don't need release markers or previous period markers on this graph. Additionally we'll need special click handling that navigates to other events in the series. Refs SEN-716

Use the new /latest endpoint in the grouped modal view. This pushes the complexity of finding the most recent event into the API where it should be.

Lyn prefers to keep the URL parameter `:` separated.

By creating a combined query parameter we have fewer state bits we need to manage together. Instead we can focus on the valid/invalid value states.

In grouped views we want to show pagination buttons to navigate between the events that match the current search filters including the query string. By creating URLs that use eventSlug and the current search criteria we'll end up at the right events. Refs SEN-715

markstory · 2019-06-10T19:55:23Z

I've included the pagination changes in this pull request now as well. The top half of the event modal looks like:

billyvg · 2019-06-11T14:40:09Z

+
+const slugValidator = function(props, propName, componentName) {
+ const value = props[propName];
+ if (value && !/^(?:[^:]+:)?(?:[^:]+):(?:[a-f0-9]+|latest|oldest)$/.test(value)) {


:nice:regex:
It'd help to have a comment with what a valid slug looks like. Are special characters (non alphanumerics) allowed in the first two groups?

billyvg · 2019-06-11T14:44:07Z

- params: PropTypes.object,
- eventSlug: PropTypes.string.isRequired,
+ organization: SentryTypes.Organization.isRequired,
+ eventSlug: slugValidator,


Do we want to validate these at runtime as well? (I guess receiving a 404 makes sense)

I think the 404 we display in the modal could use some work, but I can do that separately.

billyvg · 2019-06-11T14:49:00Z

+const ModalLineGraph = props => {
+ const {api, groupId, organization, location, selection} = props;
+
+ const isUtc = selection.datetime.utc;


So if selection.datetime.utc is null it won't necessarily mean that the user doesn't want it to be formatted UTC, it just means that they haven't use the UTC override in the global selection header. I think we'd want to fallback to user's timezone in ConfigStore.

…agination.jsx Co-Authored-By: Billy Vong <billyvg@users.noreply.github.com>

* master: (102 commits) fix(symbolicator): Tests are no longer allowed failures (#13566) fix(yarn): Fix yarn path in distutils (#13647) ref(ui): Remove OrganizationState from a bunch of places (#13646) ref(ui): Remove crufty global exports (#13578) feat(events-v2): Page loader improvements (#13645) fix: Query the right set of issues when given no set of envs for a given first release (#13551) feat(ui): update incidents icon (#13622) fix(ui): remove rate-limited values from graph when no events are present (#13624) feat(events-v2) Add a event graph to the event modal (#13568) fix(store): Check project.status is VISIBLE before attempting to process perf(snuba): Limit SnubaEvent.get_event to return the first result only. (#13644) tests(percy): Fix Incident status item dynamic time (#13640) ref(sentry10): Clean up action creators (#13636) ref(app-platform): Backfill IntegrationFeature table (#13548) ref(utils): Remove default / reexports from utils.jsx (#13581) feat(sentry10): Remove the ability to set a default environment (#13637) feat(api): Add url unfurls for incidents to slack integration (SEN-566) build(yarn): Upgrade yarn to 1.16.0, embed in repo (#13569) feat(api): Allow passing group_ids to `OrganizationGroupIndexEndpoint` for bulk fetching groups (SEN-701) feat(ui): Adds related issues to Incidents sidebar [SEN-695] (#13617) ...

markstory · 2019-06-06T15:02:28Z

Show an event graph for grouped views. The grouped view mode requires showing a single event + grouped data above the single event view. I've implemented a stripped down line graph as we don't need release markers or previous period markers on this graph. Additionally we'll need special click handling that navigates to other events in the series.

TODO

Add UI integration jest tests

Refs SEN-716

billyvg · 2019-06-06T16:55:54Z

How do you specify multiple groupIds?

Right now I don't have use-case where I need more than one group, I'll expand the proptype to allow for future scenarios though.

billyvg · 2019-06-06T16:56:53Z

The _ is not necessary here

markstory · 2019-06-06T17:50:51Z

Screenshot of what it looks like in action

markstory · 2019-06-07T14:56:45Z

@lynnagara I've rebased this on top of your branch and switched to using the /latest endpoint when getting event information for grouped views.

lynnagara · 2019-06-07T19:10:59Z

- params: PropTypes.object,
- eventSlug: PropTypes.string.isRequired,
+ organization: SentryTypes.Organization.isRequired,
+ eventSlug: PropTypes.string,


We could have a proptype that enforces the eventSlug format

Show an event graph for grouped views. The grouped view mode requires showing a single event + grouped data above the single event view. I've implemented a stripped down line graph as we don't need release markers or previous period markers on this graph. Additionally we'll need special click handling that navigates to other events in the series. Refs SEN-716

Use the new /latest endpoint in the grouped modal view. This pushes the complexity of finding the most recent event into the API where it should be.

Lyn prefers to keep the URL parameter `:` separated.

By creating a combined query parameter we have fewer state bits we need to manage together. Instead we can focus on the valid/invalid value states.

In grouped views we want to show pagination buttons to navigate between the events that match the current search filters including the query string. By creating URLs that use eventSlug and the current search criteria we'll end up at the right events. Refs SEN-715

markstory · 2019-06-10T19:55:23Z

I've included the pagination changes in this pull request now as well. The top half of the event modal looks like:

billyvg · 2019-06-11T14:40:09Z

+
+const slugValidator = function(props, propName, componentName) {
+ const value = props[propName];
+ if (value && !/^(?:[^:]+:)?(?:[^:]+):(?:[a-f0-9]+|latest|oldest)$/.test(value)) {


:nice:regex:
It'd help to have a comment with what a valid slug looks like. Are special characters (non alphanumerics) allowed in the first two groups?

billyvg · 2019-06-11T14:44:07Z

- params: PropTypes.object,
- eventSlug: PropTypes.string.isRequired,
+ organization: SentryTypes.Organization.isRequired,
+ eventSlug: slugValidator,


Do we want to validate these at runtime as well? (I guess receiving a 404 makes sense)

I think the 404 we display in the modal could use some work, but I can do that separately.

billyvg · 2019-06-11T14:49:00Z

+const ModalLineGraph = props => {
+ const {api, groupId, organization, location, selection} = props;
+
+ const isUtc = selection.datetime.utc;


So if selection.datetime.utc is null it won't necessarily mean that the user doesn't want it to be formatted UTC, it just means that they haven't use the UTC override in the global selection header. I think we'd want to fallback to user's timezone in ConfigStore.

…agination.jsx Co-Authored-By: Billy Vong <billyvg@users.noreply.github.com>

* master: (102 commits) fix(symbolicator): Tests are no longer allowed failures (#13566) fix(yarn): Fix yarn path in distutils (#13647) ref(ui): Remove OrganizationState from a bunch of places (#13646) ref(ui): Remove crufty global exports (#13578) feat(events-v2): Page loader improvements (#13645) fix: Query the right set of issues when given no set of envs for a given first release (#13551) feat(ui): update incidents icon (#13622) fix(ui): remove rate-limited values from graph when no events are present (#13624) feat(events-v2) Add a event graph to the event modal (#13568) fix(store): Check project.status is VISIBLE before attempting to process perf(snuba): Limit SnubaEvent.get_event to return the first result only. (#13644) tests(percy): Fix Incident status item dynamic time (#13640) ref(sentry10): Clean up action creators (#13636) ref(app-platform): Backfill IntegrationFeature table (#13548) ref(utils): Remove default / reexports from utils.jsx (#13581) feat(sentry10): Remove the ability to set a default environment (#13637) feat(api): Add url unfurls for incidents to slack integration (SEN-566) build(yarn): Upgrade yarn to 1.16.0, embed in repo (#13569) feat(api): Allow passing group_ids to `OrganizationGroupIndexEndpoint` for bulk fetching groups (SEN-701) feat(ui): Adds related issues to Incidents sidebar [SEN-695] (#13617) ...

markstory · 2019-06-06T15:02:28Z

Show an event graph for grouped views. The grouped view mode requires showing a single event + grouped data above the single event view. I've implemented a stripped down line graph as we don't need release markers or previous period markers on this graph. Additionally we'll need special click handling that navigates to other events in the series.

TODO

Add UI integration jest tests

Refs SEN-716

billyvg · 2019-06-06T16:55:54Z

How do you specify multiple groupIds?

Right now I don't have use-case where I need more than one group, I'll expand the proptype to allow for future scenarios though.

billyvg · 2019-06-06T16:56:53Z

The _ is not necessary here

markstory · 2019-06-06T17:50:51Z

Screenshot of what it looks like in action

markstory · 2019-06-07T14:56:45Z

@lynnagara I've rebased this on top of your branch and switched to using the /latest endpoint when getting event information for grouped views.

lynnagara · 2019-06-07T19:10:59Z

- params: PropTypes.object,
- eventSlug: PropTypes.string.isRequired,
+ organization: SentryTypes.Organization.isRequired,
+ eventSlug: PropTypes.string,


We could have a proptype that enforces the eventSlug format

Show an event graph for grouped views. The grouped view mode requires showing a single event + grouped data above the single event view. I've implemented a stripped down line graph as we don't need release markers or previous period markers on this graph. Additionally we'll need special click handling that navigates to other events in the series. Refs SEN-716

Use the new /latest endpoint in the grouped modal view. This pushes the complexity of finding the most recent event into the API where it should be.

Lyn prefers to keep the URL parameter `:` separated.

By creating a combined query parameter we have fewer state bits we need to manage together. Instead we can focus on the valid/invalid value states.

In grouped views we want to show pagination buttons to navigate between the events that match the current search filters including the query string. By creating URLs that use eventSlug and the current search criteria we'll end up at the right events. Refs SEN-715

markstory · 2019-06-10T19:55:23Z

I've included the pagination changes in this pull request now as well. The top half of the event modal looks like:

billyvg · 2019-06-11T14:40:09Z

+
+const slugValidator = function(props, propName, componentName) {
+ const value = props[propName];
+ if (value && !/^(?:[^:]+:)?(?:[^:]+):(?:[a-f0-9]+|latest|oldest)$/.test(value)) {


:nice:regex:
It'd help to have a comment with what a valid slug looks like. Are special characters (non alphanumerics) allowed in the first two groups?

billyvg · 2019-06-11T14:44:07Z

- params: PropTypes.object,
- eventSlug: PropTypes.string.isRequired,
+ organization: SentryTypes.Organization.isRequired,
+ eventSlug: slugValidator,


Do we want to validate these at runtime as well? (I guess receiving a 404 makes sense)

I think the 404 we display in the modal could use some work, but I can do that separately.

billyvg · 2019-06-11T14:49:00Z

+const ModalLineGraph = props => {
+ const {api, groupId, organization, location, selection} = props;
+
+ const isUtc = selection.datetime.utc;


So if selection.datetime.utc is null it won't necessarily mean that the user doesn't want it to be formatted UTC, it just means that they haven't use the UTC override in the global selection header. I think we'd want to fallback to user's timezone in ConfigStore.

…agination.jsx Co-Authored-By: Billy Vong <billyvg@users.noreply.github.com>

* master: (102 commits) fix(symbolicator): Tests are no longer allowed failures (#13566) fix(yarn): Fix yarn path in distutils (#13647) ref(ui): Remove OrganizationState from a bunch of places (#13646) ref(ui): Remove crufty global exports (#13578) feat(events-v2): Page loader improvements (#13645) fix: Query the right set of issues when given no set of envs for a given first release (#13551) feat(ui): update incidents icon (#13622) fix(ui): remove rate-limited values from graph when no events are present (#13624) feat(events-v2) Add a event graph to the event modal (#13568) fix(store): Check project.status is VISIBLE before attempting to process perf(snuba): Limit SnubaEvent.get_event to return the first result only. (#13644) tests(percy): Fix Incident status item dynamic time (#13640) ref(sentry10): Clean up action creators (#13636) ref(app-platform): Backfill IntegrationFeature table (#13548) ref(utils): Remove default / reexports from utils.jsx (#13581) feat(sentry10): Remove the ability to set a default environment (#13637) feat(api): Add url unfurls for incidents to slack integration (SEN-566) build(yarn): Upgrade yarn to 1.16.0, embed in repo (#13569) feat(api): Allow passing group_ids to `OrganizationGroupIndexEndpoint` for bulk fetching groups (SEN-701) feat(ui): Adds related issues to Incidents sidebar [SEN-695] (#13617) ...

markstory · 2019-06-06T15:02:28Z

Show an event graph for grouped views. The grouped view mode requires showing a single event + grouped data above the single event view. I've implemented a stripped down line graph as we don't need release markers or previous period markers on this graph. Additionally we'll need special click handling that navigates to other events in the series.

TODO

Add UI integration jest tests

Refs SEN-716

billyvg · 2019-06-06T16:55:54Z

How do you specify multiple groupIds?

Right now I don't have use-case where I need more than one group, I'll expand the proptype to allow for future scenarios though.

billyvg · 2019-06-06T16:56:53Z

The _ is not necessary here

markstory · 2019-06-06T17:50:51Z

Screenshot of what it looks like in action

markstory · 2019-06-07T14:56:45Z

@lynnagara I've rebased this on top of your branch and switched to using the /latest endpoint when getting event information for grouped views.

lynnagara · 2019-06-07T19:10:59Z

- params: PropTypes.object,
- eventSlug: PropTypes.string.isRequired,
+ organization: SentryTypes.Organization.isRequired,
+ eventSlug: PropTypes.string,


We could have a proptype that enforces the eventSlug format

Show an event graph for grouped views. The grouped view mode requires showing a single event + grouped data above the single event view. I've implemented a stripped down line graph as we don't need release markers or previous period markers on this graph. Additionally we'll need special click handling that navigates to other events in the series. Refs SEN-716

Use the new /latest endpoint in the grouped modal view. This pushes the complexity of finding the most recent event into the API where it should be.

Lyn prefers to keep the URL parameter `:` separated.

By creating a combined query parameter we have fewer state bits we need to manage together. Instead we can focus on the valid/invalid value states.

In grouped views we want to show pagination buttons to navigate between the events that match the current search filters including the query string. By creating URLs that use eventSlug and the current search criteria we'll end up at the right events. Refs SEN-715

markstory · 2019-06-10T19:55:23Z

I've included the pagination changes in this pull request now as well. The top half of the event modal looks like:

billyvg · 2019-06-11T14:40:09Z

+
+const slugValidator = function(props, propName, componentName) {
+ const value = props[propName];
+ if (value && !/^(?:[^:]+:)?(?:[^:]+):(?:[a-f0-9]+|latest|oldest)$/.test(value)) {


:nice:regex:
It'd help to have a comment with what a valid slug looks like. Are special characters (non alphanumerics) allowed in the first two groups?

billyvg · 2019-06-11T14:44:07Z

- params: PropTypes.object,
- eventSlug: PropTypes.string.isRequired,
+ organization: SentryTypes.Organization.isRequired,
+ eventSlug: slugValidator,


Do we want to validate these at runtime as well? (I guess receiving a 404 makes sense)

I think the 404 we display in the modal could use some work, but I can do that separately.

billyvg · 2019-06-11T14:49:00Z

+const ModalLineGraph = props => {
+ const {api, groupId, organization, location, selection} = props;
+
+ const isUtc = selection.datetime.utc;


So if selection.datetime.utc is null it won't necessarily mean that the user doesn't want it to be formatted UTC, it just means that they haven't use the UTC override in the global selection header. I think we'd want to fallback to user's timezone in ConfigStore.

…agination.jsx Co-Authored-By: Billy Vong <billyvg@users.noreply.github.com>

* master: (102 commits) fix(symbolicator): Tests are no longer allowed failures (#13566) fix(yarn): Fix yarn path in distutils (#13647) ref(ui): Remove OrganizationState from a bunch of places (#13646) ref(ui): Remove crufty global exports (#13578) feat(events-v2): Page loader improvements (#13645) fix: Query the right set of issues when given no set of envs for a given first release (#13551) feat(ui): update incidents icon (#13622) fix(ui): remove rate-limited values from graph when no events are present (#13624) feat(events-v2) Add a event graph to the event modal (#13568) fix(store): Check project.status is VISIBLE before attempting to process perf(snuba): Limit SnubaEvent.get_event to return the first result only. (#13644) tests(percy): Fix Incident status item dynamic time (#13640) ref(sentry10): Clean up action creators (#13636) ref(app-platform): Backfill IntegrationFeature table (#13548) ref(utils): Remove default / reexports from utils.jsx (#13581) feat(sentry10): Remove the ability to set a default environment (#13637) feat(api): Add url unfurls for incidents to slack integration (SEN-566) build(yarn): Upgrade yarn to 1.16.0, embed in repo (#13569) feat(api): Allow passing group_ids to `OrganizationGroupIndexEndpoint` for bulk fetching groups (SEN-701) feat(ui): Adds related issues to Incidents sidebar [SEN-695] (#13617) ...

markstory · 2019-06-06T15:02:28Z

Show an event graph for grouped views. The grouped view mode requires showing a single event + grouped data above the single event view. I've implemented a stripped down line graph as we don't need release markers or previous period markers on this graph. Additionally we'll need special click handling that navigates to other events in the series.

TODO

Add UI integration jest tests

Refs SEN-716

billyvg · 2019-06-06T16:55:54Z

How do you specify multiple groupIds?

Right now I don't have use-case where I need more than one group, I'll expand the proptype to allow for future scenarios though.

billyvg · 2019-06-06T16:56:53Z

The _ is not necessary here

markstory · 2019-06-06T17:50:51Z

Screenshot of what it looks like in action

markstory · 2019-06-07T14:56:45Z

@lynnagara I've rebased this on top of your branch and switched to using the /latest endpoint when getting event information for grouped views.

lynnagara · 2019-06-07T19:10:59Z

- params: PropTypes.object,
- eventSlug: PropTypes.string.isRequired,
+ organization: SentryTypes.Organization.isRequired,
+ eventSlug: PropTypes.string,


We could have a proptype that enforces the eventSlug format

Show an event graph for grouped views. The grouped view mode requires showing a single event + grouped data above the single event view. I've implemented a stripped down line graph as we don't need release markers or previous period markers on this graph. Additionally we'll need special click handling that navigates to other events in the series. Refs SEN-716

Use the new /latest endpoint in the grouped modal view. This pushes the complexity of finding the most recent event into the API where it should be.

Lyn prefers to keep the URL parameter `:` separated.

By creating a combined query parameter we have fewer state bits we need to manage together. Instead we can focus on the valid/invalid value states.

In grouped views we want to show pagination buttons to navigate between the events that match the current search filters including the query string. By creating URLs that use eventSlug and the current search criteria we'll end up at the right events. Refs SEN-715

markstory · 2019-06-10T19:55:23Z

I've included the pagination changes in this pull request now as well. The top half of the event modal looks like:

billyvg · 2019-06-11T14:40:09Z

+
+const slugValidator = function(props, propName, componentName) {
+ const value = props[propName];
+ if (value && !/^(?:[^:]+:)?(?:[^:]+):(?:[a-f0-9]+|latest|oldest)$/.test(value)) {


:nice:regex:
It'd help to have a comment with what a valid slug looks like. Are special characters (non alphanumerics) allowed in the first two groups?

billyvg · 2019-06-11T14:44:07Z

- params: PropTypes.object,
- eventSlug: PropTypes.string.isRequired,
+ organization: SentryTypes.Organization.isRequired,
+ eventSlug: slugValidator,


Do we want to validate these at runtime as well? (I guess receiving a 404 makes sense)

I think the 404 we display in the modal could use some work, but I can do that separately.

billyvg · 2019-06-11T14:49:00Z

+const ModalLineGraph = props => {
+ const {api, groupId, organization, location, selection} = props;
+
+ const isUtc = selection.datetime.utc;


So if selection.datetime.utc is null it won't necessarily mean that the user doesn't want it to be formatted UTC, it just means that they haven't use the UTC override in the global selection header. I think we'd want to fallback to user's timezone in ConfigStore.

…agination.jsx Co-Authored-By: Billy Vong <billyvg@users.noreply.github.com>

* master: (102 commits) fix(symbolicator): Tests are no longer allowed failures (#13566) fix(yarn): Fix yarn path in distutils (#13647) ref(ui): Remove OrganizationState from a bunch of places (#13646) ref(ui): Remove crufty global exports (#13578) feat(events-v2): Page loader improvements (#13645) fix: Query the right set of issues when given no set of envs for a given first release (#13551) feat(ui): update incidents icon (#13622) fix(ui): remove rate-limited values from graph when no events are present (#13624) feat(events-v2) Add a event graph to the event modal (#13568) fix(store): Check project.status is VISIBLE before attempting to process perf(snuba): Limit SnubaEvent.get_event to return the first result only. (#13644) tests(percy): Fix Incident status item dynamic time (#13640) ref(sentry10): Clean up action creators (#13636) ref(app-platform): Backfill IntegrationFeature table (#13548) ref(utils): Remove default / reexports from utils.jsx (#13581) feat(sentry10): Remove the ability to set a default environment (#13637) feat(api): Add url unfurls for incidents to slack integration (SEN-566) build(yarn): Upgrade yarn to 1.16.0, embed in repo (#13569) feat(api): Allow passing group_ids to `OrganizationGroupIndexEndpoint` for bulk fetching groups (SEN-701) feat(ui): Adds related issues to Incidents sidebar [SEN-695] (#13617) ...

markstory added the WIP label Jun 6, 2019

markstory requested a review from a teamJune 6, 2019 15:02

billyvg reviewed Jun 6, 2019
View reviewed changes

markstory force-pushed the sen-716-modal-chart branch from f806d94 to cc390b3Compare June 7, 2019 14:55

markstory changed the base branch from sen-716-endpoint-last-event to feat/org-event-detailsJune 7, 2019 14:55

markstory requested a review from lynnagara June 7, 2019 14:56

markstory removed the WIP label Jun 7, 2019

markstory mentioned this pull request Jun 7, 2019
feat(events-v2): Add an organization event details endpoint #13553
Merged

lynnagara reviewed Jun 7, 2019
View reviewed changes

Comment threadsrc/sentry/static/sentry/app/views/organizationEvents/utils/eventsRequest.jsx Outdated

lynnagara reviewed Jun 10, 2019
View reviewed changes

Comment threadsrc/sentry/api/urls.py Outdated

markstory changed the base branch from feat/org-event-details to masterJune 10, 2019 17:53

markstory added 7 commits June 10, 2019 13:54

Split out event details modal integration tests
4a718ee

Update proptype and remove redundant property.
6ad7312

Fix overflow
f72a994

Use new endpoints in grouped modal
0a4129e
Use the new /latest endpoint in the grouped modal view. This pushes the complexity of finding the most recent event into the API where it should be.

Fix NaN displaying
fc48f32

Add better proptype validator.
c2776f3

markstory mentioned this pull request Jun 10, 2019
feat(events-v2) Add pagination controls to event modal #13610
Closed

markstory added 4 commits June 10, 2019 15:13

Revert changes to projectSlug.
ae1bfe7
Lyn prefers to keep the URL parameter `:` separated.

Switch to groupSlug with the latest/oldest/eventid
8218c01
By creating a combined query parameter we have fewer state bits we need to manage together. Instead we can focus on the valid/invalid value states.

Add another test
36f6b86

markstory force-pushed the sen-716-modal-chart branch from 7681f97 to 36f6b86Compare June 10, 2019 19:54

markstory requested review from a team and lynnagara June 11, 2019 14:44

billyvg approved these changes Jun 11, 2019
View reviewed changes

lynnagara reviewed Jun 11, 2019
View reviewed changes

Comment threadsrc/sentry/static/sentry/app/views/organizationEventsV2/modalPagination.jsx Outdated

lynnagara approved these changes Jun 11, 2019
View reviewed changes

markstoryand others added 3 commits June 11, 2019 13:57

Update src/sentry/static/sentry/app/views/organizationEventsV2/modalP…
4a8f027
…agination.jsx Co-Authored-By: Billy Vong <billyvg@users.noreply.github.com>

Apply feedback from review
3ac70ae

Merge branch 'master' into sen-716-modal-chart
0b63c48

markstory merged commit dc4fbea into masterJun 11, 2019

markstory deleted the sen-716-modal-chart branch June 11, 2019 20:50

github-actionsBot locked and limited conversation to collaborators Dec 20, 2020

markstory added the WIP label Jun 6, 2019

markstory requested a review from a teamJune 6, 2019 15:02

billyvg reviewed Jun 6, 2019
View reviewed changes

markstory force-pushed the sen-716-modal-chart branch from f806d94 to cc390b3Compare June 7, 2019 14:55

markstory changed the base branch from sen-716-endpoint-last-event to feat/org-event-detailsJune 7, 2019 14:55

markstory requested a review from lynnagara June 7, 2019 14:56

markstory removed the WIP label Jun 7, 2019

markstory mentioned this pull request Jun 7, 2019
feat(events-v2): Add an organization event details endpoint #13553
Merged

lynnagara reviewed Jun 7, 2019
View reviewed changes

Comment threadsrc/sentry/static/sentry/app/views/organizationEvents/utils/eventsRequest.jsx Outdated

lynnagara reviewed Jun 10, 2019
View reviewed changes

Comment threadsrc/sentry/api/urls.py Outdated

markstory changed the base branch from feat/org-event-details to masterJune 10, 2019 17:53

markstory added 7 commits June 10, 2019 13:54

Split out event details modal integration tests
4a718ee

Update proptype and remove redundant property.
6ad7312

Fix overflow
f72a994

Use new endpoints in grouped modal
0a4129e
Use the new /latest endpoint in the grouped modal view. This pushes the complexity of finding the most recent event into the API where it should be.

Fix NaN displaying
fc48f32

Add better proptype validator.
c2776f3

markstory mentioned this pull request Jun 10, 2019
feat(events-v2) Add pagination controls to event modal #13610
Closed

markstory added 4 commits June 10, 2019 15:13

Revert changes to projectSlug.
ae1bfe7
Lyn prefers to keep the URL parameter `:` separated.

Switch to groupSlug with the latest/oldest/eventid
8218c01
By creating a combined query parameter we have fewer state bits we need to manage together. Instead we can focus on the valid/invalid value states.

Add another test
36f6b86

markstory force-pushed the sen-716-modal-chart branch from 7681f97 to 36f6b86Compare June 10, 2019 19:54

markstory requested review from a team and lynnagara June 11, 2019 14:44

billyvg approved these changes Jun 11, 2019
View reviewed changes

lynnagara reviewed Jun 11, 2019
View reviewed changes

Comment threadsrc/sentry/static/sentry/app/views/organizationEventsV2/modalPagination.jsx Outdated

lynnagara approved these changes Jun 11, 2019
View reviewed changes

markstoryand others added 3 commits June 11, 2019 13:57

Update src/sentry/static/sentry/app/views/organizationEventsV2/modalP…
4a8f027
…agination.jsx Co-Authored-By: Billy Vong <billyvg@users.noreply.github.com>

Apply feedback from review
3ac70ae

Merge branch 'master' into sen-716-modal-chart
0b63c48

markstory merged commit dc4fbea into masterJun 11, 2019

markstory deleted the sen-716-modal-chart branch June 11, 2019 20:50

github-actionsBot locked and limited conversation to collaborators Dec 20, 2020

markstory added the WIP label Jun 6, 2019

markstory requested a review from a teamJune 6, 2019 15:02

billyvg reviewed Jun 6, 2019
View reviewed changes

markstory force-pushed the sen-716-modal-chart branch from f806d94 to cc390b3Compare June 7, 2019 14:55

markstory changed the base branch from sen-716-endpoint-last-event to feat/org-event-detailsJune 7, 2019 14:55

markstory requested a review from lynnagara June 7, 2019 14:56

markstory removed the WIP label Jun 7, 2019

markstory mentioned this pull request Jun 7, 2019
feat(events-v2): Add an organization event details endpoint #13553
Merged

lynnagara reviewed Jun 7, 2019
View reviewed changes

Comment threadsrc/sentry/static/sentry/app/views/organizationEvents/utils/eventsRequest.jsx Outdated

lynnagara reviewed Jun 10, 2019
View reviewed changes

Comment threadsrc/sentry/api/urls.py Outdated

markstory changed the base branch from feat/org-event-details to masterJune 10, 2019 17:53

markstory added 7 commits June 10, 2019 13:54

Split out event details modal integration tests
4a718ee

Update proptype and remove redundant property.
6ad7312

Fix overflow
f72a994

Use new endpoints in grouped modal
0a4129e
Use the new /latest endpoint in the grouped modal view. This pushes the complexity of finding the most recent event into the API where it should be.

Fix NaN displaying
fc48f32

Add better proptype validator.
c2776f3

markstory mentioned this pull request Jun 10, 2019
feat(events-v2) Add pagination controls to event modal #13610
Closed

markstory added 4 commits June 10, 2019 15:13

Revert changes to projectSlug.
ae1bfe7
Lyn prefers to keep the URL parameter `:` separated.

Switch to groupSlug with the latest/oldest/eventid
8218c01
By creating a combined query parameter we have fewer state bits we need to manage together. Instead we can focus on the valid/invalid value states.

Add another test
36f6b86

markstory force-pushed the sen-716-modal-chart branch from 7681f97 to 36f6b86Compare June 10, 2019 19:54

markstory requested review from a team and lynnagara June 11, 2019 14:44

billyvg approved these changes Jun 11, 2019
View reviewed changes

lynnagara reviewed Jun 11, 2019
View reviewed changes

Comment threadsrc/sentry/static/sentry/app/views/organizationEventsV2/modalPagination.jsx Outdated

lynnagara approved these changes Jun 11, 2019
View reviewed changes

markstoryand others added 3 commits June 11, 2019 13:57

Update src/sentry/static/sentry/app/views/organizationEventsV2/modalP…
4a8f027
…agination.jsx Co-Authored-By: Billy Vong <billyvg@users.noreply.github.com>

Apply feedback from review
3ac70ae

Merge branch 'master' into sen-716-modal-chart
0b63c48

markstory merged commit dc4fbea into masterJun 11, 2019

markstory deleted the sen-716-modal-chart branch June 11, 2019 20:50

github-actionsBot locked and limited conversation to collaborators Dec 20, 2020

markstory added the WIP label Jun 6, 2019

markstory requested a review from a teamJune 6, 2019 15:02

billyvg reviewed Jun 6, 2019
View reviewed changes

markstory force-pushed the sen-716-modal-chart branch from f806d94 to cc390b3Compare June 7, 2019 14:55

markstory changed the base branch from sen-716-endpoint-last-event to feat/org-event-detailsJune 7, 2019 14:55

markstory requested a review from lynnagara June 7, 2019 14:56

markstory removed the WIP label Jun 7, 2019

markstory mentioned this pull request Jun 7, 2019
feat(events-v2): Add an organization event details endpoint #13553
Merged

lynnagara reviewed Jun 7, 2019
View reviewed changes

Comment threadsrc/sentry/static/sentry/app/views/organizationEvents/utils/eventsRequest.jsx Outdated

lynnagara reviewed Jun 10, 2019
View reviewed changes

Comment threadsrc/sentry/api/urls.py Outdated

markstory changed the base branch from feat/org-event-details to masterJune 10, 2019 17:53

markstory added 7 commits June 10, 2019 13:54

Split out event details modal integration tests
4a718ee

Update proptype and remove redundant property.
6ad7312

Fix overflow
f72a994

Use new endpoints in grouped modal
0a4129e
Use the new /latest endpoint in the grouped modal view. This pushes the complexity of finding the most recent event into the API where it should be.

Fix NaN displaying
fc48f32

Add better proptype validator.
c2776f3

markstory mentioned this pull request Jun 10, 2019
feat(events-v2) Add pagination controls to event modal #13610
Closed

markstory added 4 commits June 10, 2019 15:13

Revert changes to projectSlug.
ae1bfe7
Lyn prefers to keep the URL parameter `:` separated.

Switch to groupSlug with the latest/oldest/eventid
8218c01
By creating a combined query parameter we have fewer state bits we need to manage together. Instead we can focus on the valid/invalid value states.

Add another test
36f6b86

markstory force-pushed the sen-716-modal-chart branch from 7681f97 to 36f6b86Compare June 10, 2019 19:54

markstory requested review from a team and lynnagara June 11, 2019 14:44

billyvg approved these changes Jun 11, 2019
View reviewed changes

lynnagara reviewed Jun 11, 2019
View reviewed changes

Comment threadsrc/sentry/static/sentry/app/views/organizationEventsV2/modalPagination.jsx Outdated

lynnagara approved these changes Jun 11, 2019
View reviewed changes

markstoryand others added 3 commits June 11, 2019 13:57

Update src/sentry/static/sentry/app/views/organizationEventsV2/modalP…
4a8f027
…agination.jsx Co-Authored-By: Billy Vong <billyvg@users.noreply.github.com>

Apply feedback from review
3ac70ae

Merge branch 'master' into sen-716-modal-chart
0b63c48

markstory merged commit dc4fbea into masterJun 11, 2019

markstory deleted the sen-716-modal-chart branch June 11, 2019 20:50

github-actionsBot locked and limited conversation to collaborators Dec 20, 2020

markstory added the WIP label Jun 6, 2019

markstory requested a review from a teamJune 6, 2019 15:02

billyvg reviewed Jun 6, 2019
View reviewed changes

markstory force-pushed the sen-716-modal-chart branch from f806d94 to cc390b3Compare June 7, 2019 14:55

markstory changed the base branch from sen-716-endpoint-last-event to feat/org-event-detailsJune 7, 2019 14:55

markstory requested a review from lynnagara June 7, 2019 14:56

markstory removed the WIP label Jun 7, 2019

markstory mentioned this pull request Jun 7, 2019
feat(events-v2): Add an organization event details endpoint #13553
Merged

lynnagara reviewed Jun 7, 2019
View reviewed changes

Comment threadsrc/sentry/static/sentry/app/views/organizationEvents/utils/eventsRequest.jsx Outdated

lynnagara reviewed Jun 10, 2019
View reviewed changes

Comment threadsrc/sentry/api/urls.py Outdated

markstory changed the base branch from feat/org-event-details to masterJune 10, 2019 17:53

markstory added 7 commits June 10, 2019 13:54

Split out event details modal integration tests
4a718ee

Update proptype and remove redundant property.
6ad7312

Fix overflow
f72a994

Use new endpoints in grouped modal
0a4129e
Use the new /latest endpoint in the grouped modal view. This pushes the complexity of finding the most recent event into the API where it should be.

Fix NaN displaying
fc48f32

Add better proptype validator.
c2776f3

markstory mentioned this pull request Jun 10, 2019
feat(events-v2) Add pagination controls to event modal #13610
Closed

markstory added 4 commits June 10, 2019 15:13

Revert changes to projectSlug.
ae1bfe7
Lyn prefers to keep the URL parameter `:` separated.

Switch to groupSlug with the latest/oldest/eventid
8218c01
By creating a combined query parameter we have fewer state bits we need to manage together. Instead we can focus on the valid/invalid value states.

Add another test
36f6b86

markstory force-pushed the sen-716-modal-chart branch from 7681f97 to 36f6b86Compare June 10, 2019 19:54

markstory requested review from a team and lynnagara June 11, 2019 14:44

billyvg approved these changes Jun 11, 2019
View reviewed changes

lynnagara reviewed Jun 11, 2019
View reviewed changes

Comment threadsrc/sentry/static/sentry/app/views/organizationEventsV2/modalPagination.jsx Outdated

lynnagara approved these changes Jun 11, 2019
View reviewed changes

markstoryand others added 3 commits June 11, 2019 13:57

Update src/sentry/static/sentry/app/views/organizationEventsV2/modalP…
4a8f027
…agination.jsx Co-Authored-By: Billy Vong <billyvg@users.noreply.github.com>

Apply feedback from review
3ac70ae

Merge branch 'master' into sen-716-modal-chart
0b63c48

markstory merged commit dc4fbea into masterJun 11, 2019

markstory deleted the sen-716-modal-chart branch June 11, 2019 20:50

github-actionsBot locked and limited conversation to collaborators Dec 20, 2020

markstory added the WIP label Jun 6, 2019

markstory requested a review from a teamJune 6, 2019 15:02

billyvg reviewed Jun 6, 2019
View reviewed changes

markstory force-pushed the sen-716-modal-chart branch from f806d94 to cc390b3Compare June 7, 2019 14:55

markstory changed the base branch from sen-716-endpoint-last-event to feat/org-event-detailsJune 7, 2019 14:55

markstory requested a review from lynnagara June 7, 2019 14:56

markstory removed the WIP label Jun 7, 2019

markstory mentioned this pull request Jun 7, 2019
feat(events-v2): Add an organization event details endpoint #13553
Merged

lynnagara reviewed Jun 7, 2019
View reviewed changes

Comment threadsrc/sentry/static/sentry/app/views/organizationEvents/utils/eventsRequest.jsx Outdated

lynnagara reviewed Jun 10, 2019
View reviewed changes

Comment threadsrc/sentry/api/urls.py Outdated

markstory changed the base branch from feat/org-event-details to masterJune 10, 2019 17:53

markstory added 7 commits June 10, 2019 13:54

Split out event details modal integration tests
4a718ee

Update proptype and remove redundant property.
6ad7312

Fix overflow
f72a994

Use new endpoints in grouped modal
0a4129e
Use the new /latest endpoint in the grouped modal view. This pushes the complexity of finding the most recent event into the API where it should be.

Fix NaN displaying
fc48f32

Add better proptype validator.
c2776f3

markstory mentioned this pull request Jun 10, 2019
feat(events-v2) Add pagination controls to event modal #13610
Closed

markstory added 4 commits June 10, 2019 15:13

Revert changes to projectSlug.
ae1bfe7
Lyn prefers to keep the URL parameter `:` separated.

Switch to groupSlug with the latest/oldest/eventid
8218c01
By creating a combined query parameter we have fewer state bits we need to manage together. Instead we can focus on the valid/invalid value states.

Add another test
36f6b86

markstory force-pushed the sen-716-modal-chart branch from 7681f97 to 36f6b86Compare June 10, 2019 19:54

markstory requested review from a team and lynnagara June 11, 2019 14:44

billyvg approved these changes Jun 11, 2019
View reviewed changes

lynnagara reviewed Jun 11, 2019
View reviewed changes

Comment threadsrc/sentry/static/sentry/app/views/organizationEventsV2/modalPagination.jsx Outdated

lynnagara approved these changes Jun 11, 2019
View reviewed changes

markstoryand others added 3 commits June 11, 2019 13:57

Update src/sentry/static/sentry/app/views/organizationEventsV2/modalP…
4a8f027
…agination.jsx Co-Authored-By: Billy Vong <billyvg@users.noreply.github.com>

Apply feedback from review
3ac70ae

Merge branch 'master' into sen-716-modal-chart
0b63c48

markstory merged commit dc4fbea into masterJun 11, 2019

markstory deleted the sen-716-modal-chart branch June 11, 2019 20:50

github-actionsBot locked and limited conversation to collaborators Dec 20, 2020

markstory added the WIP label Jun 6, 2019

markstory requested a review from a teamJune 6, 2019 15:02

billyvg reviewed Jun 6, 2019
View reviewed changes

markstory force-pushed the sen-716-modal-chart branch from f806d94 to cc390b3Compare June 7, 2019 14:55

markstory changed the base branch from sen-716-endpoint-last-event to feat/org-event-detailsJune 7, 2019 14:55

markstory requested a review from lynnagara June 7, 2019 14:56

markstory removed the WIP label Jun 7, 2019

markstory mentioned this pull request Jun 7, 2019
feat(events-v2): Add an organization event details endpoint #13553
Merged

lynnagara reviewed Jun 7, 2019
View reviewed changes

Comment threadsrc/sentry/static/sentry/app/views/organizationEvents/utils/eventsRequest.jsx Outdated

lynnagara reviewed Jun 10, 2019
View reviewed changes

Comment threadsrc/sentry/api/urls.py Outdated

markstory changed the base branch from feat/org-event-details to masterJune 10, 2019 17:53

markstory added 7 commits June 10, 2019 13:54

Split out event details modal integration tests
4a718ee

Update proptype and remove redundant property.
6ad7312

Fix overflow
f72a994

Use new endpoints in grouped modal
0a4129e
Use the new /latest endpoint in the grouped modal view. This pushes the complexity of finding the most recent event into the API where it should be.

Fix NaN displaying
fc48f32

Add better proptype validator.
c2776f3

markstory mentioned this pull request Jun 10, 2019
feat(events-v2) Add pagination controls to event modal #13610
Closed

markstory added 4 commits June 10, 2019 15:13

Revert changes to projectSlug.
ae1bfe7
Lyn prefers to keep the URL parameter `:` separated.

Switch to groupSlug with the latest/oldest/eventid
8218c01
By creating a combined query parameter we have fewer state bits we need to manage together. Instead we can focus on the valid/invalid value states.

Add another test
36f6b86

markstory force-pushed the sen-716-modal-chart branch from 7681f97 to 36f6b86Compare June 10, 2019 19:54

markstory requested review from a team and lynnagara June 11, 2019 14:44

billyvg approved these changes Jun 11, 2019
View reviewed changes

lynnagara reviewed Jun 11, 2019
View reviewed changes

Comment threadsrc/sentry/static/sentry/app/views/organizationEventsV2/modalPagination.jsx Outdated

lynnagara approved these changes Jun 11, 2019
View reviewed changes

markstoryand others added 3 commits June 11, 2019 13:57

Update src/sentry/static/sentry/app/views/organizationEventsV2/modalP…
4a8f027
…agination.jsx Co-Authored-By: Billy Vong <billyvg@users.noreply.github.com>

Apply feedback from review
3ac70ae

Merge branch 'master' into sen-716-modal-chart
0b63c48

markstory merged commit dc4fbea into masterJun 11, 2019

markstory deleted the sen-716-modal-chart branch June 11, 2019 20:50

github-actionsBot locked and limited conversation to collaborators Dec 20, 2020

markstory added the WIP label Jun 6, 2019

markstory requested a review from a teamJune 6, 2019 15:02

billyvg reviewed Jun 6, 2019
View reviewed changes

markstory force-pushed the sen-716-modal-chart branch from f806d94 to cc390b3Compare June 7, 2019 14:55

markstory changed the base branch from sen-716-endpoint-last-event to feat/org-event-detailsJune 7, 2019 14:55

markstory requested a review from lynnagara June 7, 2019 14:56

markstory removed the WIP label Jun 7, 2019

markstory mentioned this pull request Jun 7, 2019
feat(events-v2): Add an organization event details endpoint #13553
Merged

lynnagara reviewed Jun 7, 2019
View reviewed changes

Comment threadsrc/sentry/static/sentry/app/views/organizationEvents/utils/eventsRequest.jsx Outdated

lynnagara reviewed Jun 10, 2019
View reviewed changes

Comment threadsrc/sentry/api/urls.py Outdated

markstory changed the base branch from feat/org-event-details to masterJune 10, 2019 17:53

markstory added 7 commits June 10, 2019 13:54

Split out event details modal integration tests
4a718ee

Update proptype and remove redundant property.
6ad7312

Fix overflow
f72a994

Use new endpoints in grouped modal
0a4129e
Use the new /latest endpoint in the grouped modal view. This pushes the complexity of finding the most recent event into the API where it should be.

Fix NaN displaying
fc48f32

Add better proptype validator.
c2776f3

markstory mentioned this pull request Jun 10, 2019
feat(events-v2) Add pagination controls to event modal #13610
Closed

markstory added 4 commits June 10, 2019 15:13

Revert changes to projectSlug.
ae1bfe7
Lyn prefers to keep the URL parameter `:` separated.

Switch to groupSlug with the latest/oldest/eventid
8218c01
By creating a combined query parameter we have fewer state bits we need to manage together. Instead we can focus on the valid/invalid value states.

Add another test
36f6b86

markstory force-pushed the sen-716-modal-chart branch from 7681f97 to 36f6b86Compare June 10, 2019 19:54

markstory requested review from a team and lynnagara June 11, 2019 14:44

billyvg approved these changes Jun 11, 2019
View reviewed changes

lynnagara reviewed Jun 11, 2019
View reviewed changes

Comment threadsrc/sentry/static/sentry/app/views/organizationEventsV2/modalPagination.jsx Outdated

lynnagara approved these changes Jun 11, 2019
View reviewed changes

markstoryand others added 3 commits June 11, 2019 13:57

Update src/sentry/static/sentry/app/views/organizationEventsV2/modalP…
4a8f027
…agination.jsx Co-Authored-By: Billy Vong <billyvg@users.noreply.github.com>

Apply feedback from review
3ac70ae

Merge branch 'master' into sen-716-modal-chart
0b63c48

markstory merged commit dc4fbea into masterJun 11, 2019

markstory deleted the sen-716-modal-chart branch June 11, 2019 20:50

github-actionsBot locked and limited conversation to collaborators Dec 20, 2020

Uh oh!

Uh oh!

Conversation

markstory commented Jun 6, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

markstory commented Jun 6, 2019

Uh oh!

markstory commented Jun 7, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

markstory commented Jun 10, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

markstory commented Jun 6, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

markstory commented Jun 6, 2019

Uh oh!

markstory commented Jun 7, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

markstory commented Jun 10, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

markstory commented Jun 6, 2019•
edited
Loading

markstory commented Jun 6, 2019•
edited
Loading

markstory commented Jun 6, 2019•
edited
Loading