feat(api): Add option to fetch Organization details without Projects and Teams - #13925

Merged
billyvg merged 6 commits into
masterfrom
feat/api/skinny-org-details
Jul 23, 2019
Merged

feat(api): Add option to fetch Organization details without Projects and Teams#13925
billyvg merged 6 commits into
masterfrom
feat/api/skinny-org-details

Conversation

@billyvg

@billyvgbillyvg commented Jul 9, 2019•
edited
Loading

Copy link
Copy Markdown
Member

This adds an option to fetch Organization details without projects and teams. This is direction we want to move towards, but we do not want to break the existing details endpoint

Fixes SEN-389

@billyvg
feat(api): Add option to fetch Org details without projects and teams
ea15e1a
This adds an option to fetch Organization details without projects and teams. This isdirection we want to move towards, but we do not want to break the existing details endpoint
@billyvg

billyvg commented Jul 9, 2019

Copy link
Copy Markdown
MemberAuthor

Thoughts on something like this @wedamija, @markstory ?

markstory
markstory reviewed Jul 9, 2019
View reviewed changes

@markstorymarkstory left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having an opt-in parameter for the endpoint is a good way to go about this. It will allow us to incrementally adopt this behavior where it will help without impacting existing use-cases.

Comment threadsrc/sentry/api/endpoints/organization_details.py Outdated
wedamija
wedamija reviewed Jul 9, 2019
View reviewed changes
Comment threadsrc/sentry/api/serializers/models/organization.py Outdated
@billyvg
rename DetailedOrganizationSerializer --> DetailedOrganizationWithPro…
7006b05
…jectsAndTeamsSerializer, change url param to `detailed=0`
billyvg
billyvg commented Jul 9, 2019
View reviewed changes
Comment threadsrc/sentry/api/serializers/models/organization.py
wedamija
wedamija approved these changes Jul 9, 2019
View reviewed changes
Comment threadsrc/sentry/api/serializers/models/organization.py
Comment threadsrc/sentry/api/serializers/models/organization.py Outdated
@billyvgbillyvg changed the title feat(api): Add option to fetch Org details without projects and teamsfeat(api): Add option to fetch Organization details without Projects and TeamsJul 23, 2019
@billyvg
billyvg merged commit f63f2a7 into masterJul 23, 2019
@billyvg
billyvg deleted the feat/api/skinny-org-details branch July 23, 2019 19:01
jan-auer added a commit that referenced this pull request Jul 24, 2019
@jan-auer
Merge branch 'master' into ref/relay-config-endpoint
f2e08ef
* master: (115 commits)
feat: Update to JS SDK 5.6.0-beta.1 + 0.10.2 sentry-python (#14116)
fix(apm): Whitelist dev.getsentry.net for local development (#14117)
test(datasets): Make Sentry use generic test functions in Snuba (#14111)
ref(suspect-commits): Add text changes to empty state (#14121)
build: Switch to psycopg2-binary
feat(api): Add option to fetch Organization details without Pr… (#13925)
ref: Remove EventDetails endpoint (#14107)
test(ui): Mock the onboarding learn more video (#14108)
tests(acceptance): Add tests for resolving issues in Issues Li… (#14069)
feat(ui): Add basic templates for Incident Rules in settings (#14112)
feat(eventsv2) Add basic transaction list (#14103)
ref(environments) Optimize environment queries (#14102)
fix(events-v2) Add additional user attributes to the user column (#14101)
fix: Don't start pageload transaction (#14115)
feat: APM Sentry Frontend (#14027)
ref(onboarding): Fix install promprt URL (#14106)
fix(app-platform): Allow GET requests for published apps (#14109)
feat: Update Group.get_latest_event to use Snuba event (#14039)
ref(onboarding): Rename wizardNew -> onboarding (#14104)
feat(apm): Update props to address proptype warnings for new transaction attributes (SEN-800) (#14040)
...
@billyvgbillyvg mentioned this pull request Jul 30, 2019
Merged
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Dec 20, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@markstorymarkstorymarkstory left review comments
@wedamijawedamijawedamija approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@billyvg@markstory@wedamija
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
feat(api): Add option to fetch Organization details without Projects and Teams - #13925
Merged
billyvg merged 6 commits into
masterfrom 
feat/api/skinny-org-details
Jul 23, 2019
Merged
feat(api): Add option to fetch Organization details without Projects and Teams#13925
billyvg merged 6 commits into
masterfrom 
feat/api/skinny-org-details
Conversation
@billyvg
@billyvgbillyvg
commented
Jul 9, 2019•

edited

Loading

Copy link


Copy Markdown

Member
This adds an option to fetch Organization details without projects and teams. This is direction we want to move towards, but we do not want to break the existing details endpoint
Fixes SEN-389
@billyvg
feat(api): Add option to fetch Org details without projects and teams
ea15e1a
This adds an option to fetch Organization details without projects and teams. This isdirection we want to move towards, but we do not want to break the existing details endpoint
@billyvg
billyvg
commented
Jul 9, 2019

Copy link


Copy Markdown

MemberAuthor
Thoughts on something like this @wedamija, @markstory ?
markstory
markstory
reviewed
Jul 9, 2019
View reviewed changes
@markstorymarkstory
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having an opt-in parameter for the endpoint is a good way to go about this. It will allow us to incrementally adopt this behavior where it will help without impacting existing use-cases.
Comment threadsrc/sentry/api/endpoints/organization_details.py
Outdated

wedamija
wedamija
reviewed
Jul 9, 2019
View reviewed changes
Comment threadsrc/sentry/api/serializers/models/organization.py
Outdated

@billyvg
rename DetailedOrganizationSerializer --> DetailedOrganizationWithPro…
7006b05
…jectsAndTeamsSerializer, change url param to `detailed=0`
billyvg
billyvg
commented
Jul 9, 2019
View reviewed changes
Comment threadsrc/sentry/api/serializers/models/organization.py
wedamija
wedamija
approved these changes
Jul 9, 2019
View reviewed changes
Comment threadsrc/sentry/api/serializers/models/organization.py
Comment threadsrc/sentry/api/serializers/models/organization.py
Outdated

@billyvgbillyvg
changed the title
feat(api): Add option to fetch Org details without projects and teamsfeat(api): Add option to fetch Organization details without Projects and TeamsJul 23, 2019
@billyvg
billyvg
merged commit f63f2a7
into
masterJul 23, 2019
@billyvg
billyvg
deleted the

feat/api/skinny-org-details

branch
July 23, 2019 19:01
jan-auer added a commit
that referenced
this pull request
Jul 24, 2019
@jan-auer
Merge branch 'master' into ref/relay-config-endpoint
f2e08ef
* master: (115 commits)
feat: Update to JS SDK 5.6.0-beta.1 + 0.10.2 sentry-python (#14116)
fix(apm): Whitelist dev.getsentry.net for local development (#14117)
test(datasets): Make Sentry use generic test functions in Snuba (#14111)
ref(suspect-commits): Add text changes to empty state (#14121)
build: Switch to psycopg2-binary
feat(api): Add option to fetch Organization details without Pr… (#13925)
ref: Remove EventDetails endpoint (#14107)
test(ui): Mock the onboarding learn more video (#14108)
tests(acceptance): Add tests for resolving issues in Issues Li… (#14069)
feat(ui): Add basic templates for Incident Rules in settings (#14112)
feat(eventsv2) Add basic transaction list (#14103)
ref(environments) Optimize environment queries (#14102)
fix(events-v2) Add additional user attributes to the user column (#14101)
fix: Don't start pageload transaction (#14115)
feat: APM Sentry Frontend (#14027)
ref(onboarding): Fix install promprt URL (#14106)
fix(app-platform): Allow GET requests for published apps (#14109)
feat: Update Group.get_latest_event to use Snuba event (#14039)
ref(onboarding): Rename wizardNew -> onboarding (#14104)
feat(apm): Update props to address proptype warnings for new transaction attributes (SEN-800) (#14040)
...
@billyvgbillyvg
mentioned this pull request
Jul 30, 2019
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Dec 20, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@markstorymarkstorymarkstory left review comments
@wedamijawedamijawedamija approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@billyvg@markstory@wedamija

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(api): Add option to fetch Organization details without Projects and Teams - #13925
Merged
billyvg merged 6 commits into
masterfrom 
feat/api/skinny-org-details
Jul 23, 2019
Merged
feat(api): Add option to fetch Organization details without Projects and Teams#13925
billyvg merged 6 commits into
masterfrom 
feat/api/skinny-org-details
Conversation
@billyvg
@billyvgbillyvg
commented
Jul 9, 2019•

edited

Loading

Copy link


Copy Markdown

Member
This adds an option to fetch Organization details without projects and teams. This is direction we want to move towards, but we do not want to break the existing details endpoint
Fixes SEN-389
@billyvg
feat(api): Add option to fetch Org details without projects and teams
ea15e1a
This adds an option to fetch Organization details without projects and teams. This isdirection we want to move towards, but we do not want to break the existing details endpoint
@billyvg
billyvg
commented
Jul 9, 2019

Copy link


Copy Markdown

MemberAuthor
Thoughts on something like this @wedamija, @markstory ?
markstory
markstory
reviewed
Jul 9, 2019
View reviewed changes
@markstorymarkstory
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having an opt-in parameter for the endpoint is a good way to go about this. It will allow us to incrementally adopt this behavior where it will help without impacting existing use-cases.
Comment threadsrc/sentry/api/endpoints/organization_details.py
Outdated

wedamija
wedamija
reviewed
Jul 9, 2019
View reviewed changes
Comment threadsrc/sentry/api/serializers/models/organization.py
Outdated

@billyvg
rename DetailedOrganizationSerializer --> DetailedOrganizationWithPro…
7006b05
…jectsAndTeamsSerializer, change url param to `detailed=0`
billyvg
billyvg
commented
Jul 9, 2019
View reviewed changes
Comment threadsrc/sentry/api/serializers/models/organization.py
wedamija
wedamija
approved these changes
Jul 9, 2019
View reviewed changes
Comment threadsrc/sentry/api/serializers/models/organization.py
Comment threadsrc/sentry/api/serializers/models/organization.py
Outdated

@billyvgbillyvg
changed the title
feat(api): Add option to fetch Org details without projects and teamsfeat(api): Add option to fetch Organization details without Projects and TeamsJul 23, 2019
@billyvg
billyvg
merged commit f63f2a7
into
masterJul 23, 2019
@billyvg
billyvg
deleted the

feat/api/skinny-org-details

branch
July 23, 2019 19:01
jan-auer added a commit
that referenced
this pull request
Jul 24, 2019
@jan-auer
Merge branch 'master' into ref/relay-config-endpoint
f2e08ef
* master: (115 commits)
feat: Update to JS SDK 5.6.0-beta.1 + 0.10.2 sentry-python (#14116)
fix(apm): Whitelist dev.getsentry.net for local development (#14117)
test(datasets): Make Sentry use generic test functions in Snuba (#14111)
ref(suspect-commits): Add text changes to empty state (#14121)
build: Switch to psycopg2-binary
feat(api): Add option to fetch Organization details without Pr… (#13925)
ref: Remove EventDetails endpoint (#14107)
test(ui): Mock the onboarding learn more video (#14108)
tests(acceptance): Add tests for resolving issues in Issues Li… (#14069)
feat(ui): Add basic templates for Incident Rules in settings (#14112)
feat(eventsv2) Add basic transaction list (#14103)
ref(environments) Optimize environment queries (#14102)
fix(events-v2) Add additional user attributes to the user column (#14101)
fix: Don't start pageload transaction (#14115)
feat: APM Sentry Frontend (#14027)
ref(onboarding): Fix install promprt URL (#14106)
fix(app-platform): Allow GET requests for published apps (#14109)
feat: Update Group.get_latest_event to use Snuba event (#14039)
ref(onboarding): Rename wizardNew -> onboarding (#14104)
feat(apm): Update props to address proptype warnings for new transaction attributes (SEN-800) (#14040)
...
@billyvgbillyvg
mentioned this pull request
Jul 30, 2019
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Dec 20, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@markstorymarkstorymarkstory left review comments
@wedamijawedamijawedamija approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@billyvg@markstory@wedamija

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(api): Add option to fetch Organization details without Projects and Teams - #13925
Merged
billyvg merged 6 commits into
masterfrom 
feat/api/skinny-org-details
Jul 23, 2019
Merged
feat(api): Add option to fetch Organization details without Projects and Teams#13925
billyvg merged 6 commits into
masterfrom 
feat/api/skinny-org-details
Conversation
@billyvg
@billyvgbillyvg
commented
Jul 9, 2019•

edited

Loading

Copy link


Copy Markdown

Member
This adds an option to fetch Organization details without projects and teams. This is direction we want to move towards, but we do not want to break the existing details endpoint
Fixes SEN-389
@billyvg
feat(api): Add option to fetch Org details without projects and teams
ea15e1a
This adds an option to fetch Organization details without projects and teams. This isdirection we want to move towards, but we do not want to break the existing details endpoint
@billyvg
billyvg
commented
Jul 9, 2019

Copy link


Copy Markdown

MemberAuthor
Thoughts on something like this @wedamija, @markstory ?
markstory
markstory
reviewed
Jul 9, 2019
View reviewed changes
@markstorymarkstory
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having an opt-in parameter for the endpoint is a good way to go about this. It will allow us to incrementally adopt this behavior where it will help without impacting existing use-cases.
Comment threadsrc/sentry/api/endpoints/organization_details.py
Outdated

wedamija
wedamija
reviewed
Jul 9, 2019
View reviewed changes
Comment threadsrc/sentry/api/serializers/models/organization.py
Outdated

@billyvg
rename DetailedOrganizationSerializer --> DetailedOrganizationWithPro…
7006b05
…jectsAndTeamsSerializer, change url param to `detailed=0`
billyvg
billyvg
commented
Jul 9, 2019
View reviewed changes
Comment threadsrc/sentry/api/serializers/models/organization.py
wedamija
wedamija
approved these changes
Jul 9, 2019
View reviewed changes
Comment threadsrc/sentry/api/serializers/models/organization.py
Comment threadsrc/sentry/api/serializers/models/organization.py
Outdated

@billyvgbillyvg
changed the title
feat(api): Add option to fetch Org details without projects and teamsfeat(api): Add option to fetch Organization details without Projects and TeamsJul 23, 2019
@billyvg
billyvg
merged commit f63f2a7
into
masterJul 23, 2019
@billyvg
billyvg
deleted the

feat/api/skinny-org-details

branch
July 23, 2019 19:01
jan-auer added a commit
that referenced
this pull request
Jul 24, 2019
@jan-auer
Merge branch 'master' into ref/relay-config-endpoint
f2e08ef
* master: (115 commits)
feat: Update to JS SDK 5.6.0-beta.1 + 0.10.2 sentry-python (#14116)
fix(apm): Whitelist dev.getsentry.net for local development (#14117)
test(datasets): Make Sentry use generic test functions in Snuba (#14111)
ref(suspect-commits): Add text changes to empty state (#14121)
build: Switch to psycopg2-binary
feat(api): Add option to fetch Organization details without Pr… (#13925)
ref: Remove EventDetails endpoint (#14107)
test(ui): Mock the onboarding learn more video (#14108)
tests(acceptance): Add tests for resolving issues in Issues Li… (#14069)
feat(ui): Add basic templates for Incident Rules in settings (#14112)
feat(eventsv2) Add basic transaction list (#14103)
ref(environments) Optimize environment queries (#14102)
fix(events-v2) Add additional user attributes to the user column (#14101)
fix: Don't start pageload transaction (#14115)
feat: APM Sentry Frontend (#14027)
ref(onboarding): Fix install promprt URL (#14106)
fix(app-platform): Allow GET requests for published apps (#14109)
feat: Update Group.get_latest_event to use Snuba event (#14039)
ref(onboarding): Rename wizardNew -> onboarding (#14104)
feat(apm): Update props to address proptype warnings for new transaction attributes (SEN-800) (#14040)
...
@billyvgbillyvg
mentioned this pull request
Jul 30, 2019
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Dec 20, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@markstorymarkstorymarkstory left review comments
@wedamijawedamijawedamija approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@billyvg@markstory@wedamija

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
feat(api): Add option to fetch Organization details without Projects and Teams - #13925
Merged
billyvg merged 6 commits into
masterfrom 
feat/api/skinny-org-details
Jul 23, 2019
Merged
feat(api): Add option to fetch Organization details without Projects and Teams#13925
billyvg merged 6 commits into
masterfrom 
feat/api/skinny-org-details
Conversation
@billyvg
@billyvgbillyvg
commented
Jul 9, 2019•

edited

Loading

Copy link


Copy Markdown

Member
This adds an option to fetch Organization details without projects and teams. This is direction we want to move towards, but we do not want to break the existing details endpoint
Fixes SEN-389
@billyvg
feat(api): Add option to fetch Org details without projects and teams
ea15e1a
This adds an option to fetch Organization details without projects and teams. This isdirection we want to move towards, but we do not want to break the existing details endpoint
@billyvg
billyvg
commented
Jul 9, 2019

Copy link


Copy Markdown

MemberAuthor
Thoughts on something like this @wedamija, @markstory ?
markstory
markstory
reviewed
Jul 9, 2019
View reviewed changes
@markstorymarkstory
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having an opt-in parameter for the endpoint is a good way to go about this. It will allow us to incrementally adopt this behavior where it will help without impacting existing use-cases.
Comment threadsrc/sentry/api/endpoints/organization_details.py
Outdated

wedamija
wedamija
reviewed
Jul 9, 2019
View reviewed changes
Comment threadsrc/sentry/api/serializers/models/organization.py
Outdated

@billyvg
rename DetailedOrganizationSerializer --> DetailedOrganizationWithPro…
7006b05
…jectsAndTeamsSerializer, change url param to `detailed=0`
billyvg
billyvg
commented
Jul 9, 2019
View reviewed changes
Comment threadsrc/sentry/api/serializers/models/organization.py
wedamija
wedamija
approved these changes
Jul 9, 2019
View reviewed changes
Comment threadsrc/sentry/api/serializers/models/organization.py
Comment threadsrc/sentry/api/serializers/models/organization.py
Outdated

@billyvgbillyvg
changed the title
feat(api): Add option to fetch Org details without projects and teamsfeat(api): Add option to fetch Organization details without Projects and TeamsJul 23, 2019
@billyvg
billyvg
merged commit f63f2a7
into
masterJul 23, 2019
@billyvg
billyvg
deleted the

feat/api/skinny-org-details

branch
July 23, 2019 19:01
jan-auer added a commit
that referenced
this pull request
Jul 24, 2019
@jan-auer
Merge branch 'master' into ref/relay-config-endpoint
f2e08ef
* master: (115 commits)
feat: Update to JS SDK 5.6.0-beta.1 + 0.10.2 sentry-python (#14116)
fix(apm): Whitelist dev.getsentry.net for local development (#14117)
test(datasets): Make Sentry use generic test functions in Snuba (#14111)
ref(suspect-commits): Add text changes to empty state (#14121)
build: Switch to psycopg2-binary
feat(api): Add option to fetch Organization details without Pr… (#13925)
ref: Remove EventDetails endpoint (#14107)
test(ui): Mock the onboarding learn more video (#14108)
tests(acceptance): Add tests for resolving issues in Issues Li… (#14069)
feat(ui): Add basic templates for Incident Rules in settings (#14112)
feat(eventsv2) Add basic transaction list (#14103)
ref(environments) Optimize environment queries (#14102)
fix(events-v2) Add additional user attributes to the user column (#14101)
fix: Don't start pageload transaction (#14115)
feat: APM Sentry Frontend (#14027)
ref(onboarding): Fix install promprt URL (#14106)
fix(app-platform): Allow GET requests for published apps (#14109)
feat: Update Group.get_latest_event to use Snuba event (#14039)
ref(onboarding): Rename wizardNew -> onboarding (#14104)
feat(apm): Update props to address proptype warnings for new transaction attributes (SEN-800) (#14040)
...
@billyvgbillyvg
mentioned this pull request
Jul 30, 2019
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Dec 20, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@markstorymarkstorymarkstory left review comments
@wedamijawedamijawedamija approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@billyvg@markstory@wedamija

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(api): Add option to fetch Organization details without Projects and Teams - #13925
Merged
billyvg merged 6 commits into
masterfrom 
feat/api/skinny-org-details
Jul 23, 2019
Merged
feat(api): Add option to fetch Organization details without Projects and Teams#13925
billyvg merged 6 commits into
masterfrom 
feat/api/skinny-org-details
Conversation
@billyvg
@billyvgbillyvg
commented
Jul 9, 2019•

edited

Loading

Copy link


Copy Markdown

Member
This adds an option to fetch Organization details without projects and teams. This is direction we want to move towards, but we do not want to break the existing details endpoint
Fixes SEN-389
@billyvg
feat(api): Add option to fetch Org details without projects and teams
ea15e1a
This adds an option to fetch Organization details without projects and teams. This isdirection we want to move towards, but we do not want to break the existing details endpoint
@billyvg
billyvg
commented
Jul 9, 2019

Copy link


Copy Markdown

MemberAuthor
Thoughts on something like this @wedamija, @markstory ?
markstory
markstory
reviewed
Jul 9, 2019
View reviewed changes
@markstorymarkstory
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having an opt-in parameter for the endpoint is a good way to go about this. It will allow us to incrementally adopt this behavior where it will help without impacting existing use-cases.
Comment threadsrc/sentry/api/endpoints/organization_details.py
Outdated

wedamija
wedamija
reviewed
Jul 9, 2019
View reviewed changes
Comment threadsrc/sentry/api/serializers/models/organization.py
Outdated

@billyvg
rename DetailedOrganizationSerializer --> DetailedOrganizationWithPro…
7006b05
…jectsAndTeamsSerializer, change url param to `detailed=0`
billyvg
billyvg
commented
Jul 9, 2019
View reviewed changes
Comment threadsrc/sentry/api/serializers/models/organization.py
wedamija
wedamija
approved these changes
Jul 9, 2019
View reviewed changes
Comment threadsrc/sentry/api/serializers/models/organization.py
Comment threadsrc/sentry/api/serializers/models/organization.py
Outdated

@billyvgbillyvg
changed the title
feat(api): Add option to fetch Org details without projects and teamsfeat(api): Add option to fetch Organization details without Projects and TeamsJul 23, 2019
@billyvg
billyvg
merged commit f63f2a7
into
masterJul 23, 2019
@billyvg
billyvg
deleted the

feat/api/skinny-org-details

branch
July 23, 2019 19:01
jan-auer added a commit
that referenced
this pull request
Jul 24, 2019
@jan-auer
Merge branch 'master' into ref/relay-config-endpoint
f2e08ef
* master: (115 commits)
feat: Update to JS SDK 5.6.0-beta.1 + 0.10.2 sentry-python (#14116)
fix(apm): Whitelist dev.getsentry.net for local development (#14117)
test(datasets): Make Sentry use generic test functions in Snuba (#14111)
ref(suspect-commits): Add text changes to empty state (#14121)
build: Switch to psycopg2-binary
feat(api): Add option to fetch Organization details without Pr… (#13925)
ref: Remove EventDetails endpoint (#14107)
test(ui): Mock the onboarding learn more video (#14108)
tests(acceptance): Add tests for resolving issues in Issues Li… (#14069)
feat(ui): Add basic templates for Incident Rules in settings (#14112)
feat(eventsv2) Add basic transaction list (#14103)
ref(environments) Optimize environment queries (#14102)
fix(events-v2) Add additional user attributes to the user column (#14101)
fix: Don't start pageload transaction (#14115)
feat: APM Sentry Frontend (#14027)
ref(onboarding): Fix install promprt URL (#14106)
fix(app-platform): Allow GET requests for published apps (#14109)
feat: Update Group.get_latest_event to use Snuba event (#14039)
ref(onboarding): Rename wizardNew -> onboarding (#14104)
feat(apm): Update props to address proptype warnings for new transaction attributes (SEN-800) (#14040)
...
@billyvgbillyvg
mentioned this pull request
Jul 30, 2019
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Dec 20, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@markstorymarkstorymarkstory left review comments
@wedamijawedamijawedamija approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@billyvg@markstory@wedamija

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(api): Add option to fetch Organization details without Projects and Teams - #13925
Merged
billyvg merged 6 commits into
masterfrom 
feat/api/skinny-org-details
Jul 23, 2019
Merged
feat(api): Add option to fetch Organization details without Projects and Teams#13925
billyvg merged 6 commits into
masterfrom 
feat/api/skinny-org-details
Conversation
@billyvg
@billyvgbillyvg
commented
Jul 9, 2019•

edited

Loading

Copy link


Copy Markdown

Member
This adds an option to fetch Organization details without projects and teams. This is direction we want to move towards, but we do not want to break the existing details endpoint
Fixes SEN-389
@billyvg
feat(api): Add option to fetch Org details without projects and teams
ea15e1a
This adds an option to fetch Organization details without projects and teams. This isdirection we want to move towards, but we do not want to break the existing details endpoint
@billyvg
billyvg
commented
Jul 9, 2019

Copy link


Copy Markdown

MemberAuthor
Thoughts on something like this @wedamija, @markstory ?
markstory
markstory
reviewed
Jul 9, 2019
View reviewed changes
@markstorymarkstory
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having an opt-in parameter for the endpoint is a good way to go about this. It will allow us to incrementally adopt this behavior where it will help without impacting existing use-cases.
Comment threadsrc/sentry/api/endpoints/organization_details.py
Outdated

wedamija
wedamija
reviewed
Jul 9, 2019
View reviewed changes
Comment threadsrc/sentry/api/serializers/models/organization.py
Outdated

@billyvg
rename DetailedOrganizationSerializer --> DetailedOrganizationWithPro…
7006b05
…jectsAndTeamsSerializer, change url param to `detailed=0`
billyvg
billyvg
commented
Jul 9, 2019
View reviewed changes
Comment threadsrc/sentry/api/serializers/models/organization.py
wedamija
wedamija
approved these changes
Jul 9, 2019
View reviewed changes
Comment threadsrc/sentry/api/serializers/models/organization.py
Comment threadsrc/sentry/api/serializers/models/organization.py
Outdated

@billyvgbillyvg
changed the title
feat(api): Add option to fetch Org details without projects and teamsfeat(api): Add option to fetch Organization details without Projects and TeamsJul 23, 2019
@billyvg
billyvg
merged commit f63f2a7
into
masterJul 23, 2019
@billyvg
billyvg
deleted the

feat/api/skinny-org-details

branch
July 23, 2019 19:01
jan-auer added a commit
that referenced
this pull request
Jul 24, 2019
@jan-auer
Merge branch 'master' into ref/relay-config-endpoint
f2e08ef
* master: (115 commits)
feat: Update to JS SDK 5.6.0-beta.1 + 0.10.2 sentry-python (#14116)
fix(apm): Whitelist dev.getsentry.net for local development (#14117)
test(datasets): Make Sentry use generic test functions in Snuba (#14111)
ref(suspect-commits): Add text changes to empty state (#14121)
build: Switch to psycopg2-binary
feat(api): Add option to fetch Organization details without Pr… (#13925)
ref: Remove EventDetails endpoint (#14107)
test(ui): Mock the onboarding learn more video (#14108)
tests(acceptance): Add tests for resolving issues in Issues Li… (#14069)
feat(ui): Add basic templates for Incident Rules in settings (#14112)
feat(eventsv2) Add basic transaction list (#14103)
ref(environments) Optimize environment queries (#14102)
fix(events-v2) Add additional user attributes to the user column (#14101)
fix: Don't start pageload transaction (#14115)
feat: APM Sentry Frontend (#14027)
ref(onboarding): Fix install promprt URL (#14106)
fix(app-platform): Allow GET requests for published apps (#14109)
feat: Update Group.get_latest_event to use Snuba event (#14039)
ref(onboarding): Rename wizardNew -> onboarding (#14104)
feat(apm): Update props to address proptype warnings for new transaction attributes (SEN-800) (#14040)
...
@billyvgbillyvg
mentioned this pull request
Jul 30, 2019
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Dec 20, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@markstorymarkstorymarkstory left review comments
@wedamijawedamijawedamija approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@billyvg@markstory@wedamija

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
feat(api): Add option to fetch Organization details without Projects and Teams - #13925
Merged
billyvg merged 6 commits into
masterfrom 
feat/api/skinny-org-details
Jul 23, 2019
Merged
feat(api): Add option to fetch Organization details without Projects and Teams#13925
billyvg merged 6 commits into
masterfrom 
feat/api/skinny-org-details
Conversation
@billyvg
@billyvgbillyvg
commented
Jul 9, 2019•

edited

Loading

Copy link


Copy Markdown

Member
This adds an option to fetch Organization details without projects and teams. This is direction we want to move towards, but we do not want to break the existing details endpoint
Fixes SEN-389
@billyvg
feat(api): Add option to fetch Org details without projects and teams
ea15e1a
This adds an option to fetch Organization details without projects and teams. This isdirection we want to move towards, but we do not want to break the existing details endpoint
@billyvg
billyvg
commented
Jul 9, 2019

Copy link


Copy Markdown

MemberAuthor
Thoughts on something like this @wedamija, @markstory ?
markstory
markstory
reviewed
Jul 9, 2019
View reviewed changes
@markstorymarkstory
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having an opt-in parameter for the endpoint is a good way to go about this. It will allow us to incrementally adopt this behavior where it will help without impacting existing use-cases.
Comment threadsrc/sentry/api/endpoints/organization_details.py
Outdated

wedamija
wedamija
reviewed
Jul 9, 2019
View reviewed changes
Comment threadsrc/sentry/api/serializers/models/organization.py
Outdated

@billyvg
rename DetailedOrganizationSerializer --> DetailedOrganizationWithPro…
7006b05
…jectsAndTeamsSerializer, change url param to `detailed=0`
billyvg
billyvg
commented
Jul 9, 2019
View reviewed changes
Comment threadsrc/sentry/api/serializers/models/organization.py
wedamija
wedamija
approved these changes
Jul 9, 2019
View reviewed changes
Comment threadsrc/sentry/api/serializers/models/organization.py
Comment threadsrc/sentry/api/serializers/models/organization.py
Outdated

@billyvgbillyvg
changed the title
feat(api): Add option to fetch Org details without projects and teamsfeat(api): Add option to fetch Organization details without Projects and TeamsJul 23, 2019
@billyvg
billyvg
merged commit f63f2a7
into
masterJul 23, 2019
@billyvg
billyvg
deleted the

feat/api/skinny-org-details

branch
July 23, 2019 19:01
jan-auer added a commit
that referenced
this pull request
Jul 24, 2019
@jan-auer
Merge branch 'master' into ref/relay-config-endpoint
f2e08ef
* master: (115 commits)
feat: Update to JS SDK 5.6.0-beta.1 + 0.10.2 sentry-python (#14116)
fix(apm): Whitelist dev.getsentry.net for local development (#14117)
test(datasets): Make Sentry use generic test functions in Snuba (#14111)
ref(suspect-commits): Add text changes to empty state (#14121)
build: Switch to psycopg2-binary
feat(api): Add option to fetch Organization details without Pr… (#13925)
ref: Remove EventDetails endpoint (#14107)
test(ui): Mock the onboarding learn more video (#14108)
tests(acceptance): Add tests for resolving issues in Issues Li… (#14069)
feat(ui): Add basic templates for Incident Rules in settings (#14112)
feat(eventsv2) Add basic transaction list (#14103)
ref(environments) Optimize environment queries (#14102)
fix(events-v2) Add additional user attributes to the user column (#14101)
fix: Don't start pageload transaction (#14115)
feat: APM Sentry Frontend (#14027)
ref(onboarding): Fix install promprt URL (#14106)
fix(app-platform): Allow GET requests for published apps (#14109)
feat: Update Group.get_latest_event to use Snuba event (#14039)
ref(onboarding): Rename wizardNew -> onboarding (#14104)
feat(apm): Update props to address proptype warnings for new transaction attributes (SEN-800) (#14040)
...
@billyvgbillyvg
mentioned this pull request
Jul 30, 2019
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Dec 20, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@markstorymarkstorymarkstory left review comments
@wedamijawedamijawedamija approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@billyvg@markstory@wedamija