Skip to content

feat(ui): Render errored threads in issue details - #15516

Merged
jan-auer merged 7 commits into
masterfrom
feat/ui-thread-errored
Nov 14, 2019
Merged

feat(ui): Render errored threads in issue details#15516
jan-auer merged 7 commits into
masterfrom
feat/ui-thread-errored

Conversation

@jan-auer

@jan-auerjan-auer commented Nov 8, 2019

Copy link
Copy Markdown
Member

We're introducing a new thread attribute called errored. It indicates that a thread is the cause of an error, without having crashed the application. Formally, the UI would only handle crashed threads.

This extends the UI to also consider threads with errored, if there is no crashed thread. Such a thread is marked specially in the thread list, and selected by default.

See getsentry/relay#306

@jan-auerjan-auer self-assigned this Nov 8, 2019
@jan-auer

jan-auer commented Nov 8, 2019

Copy link
Copy Markdown
MemberAuthor

This still requires an acceptance test, which @marandaneto is helping me to create right now.

@jan-auer

jan-auer commented Nov 8, 2019

Copy link
Copy Markdown
MemberAuthor

Store normalization at the moment still deletes the errored attribute in the integration test. Once libsemaphore is released, we can bump and should see correct snapshots.

bruno-garcia
bruno-garcia approved these changes Nov 8, 2019
View reviewed changes
Comment threadsrc/sentry/static/sentry/app/components/events/interfaces/threads.jsx Outdated
billyvg
billyvg reviewed Nov 8, 2019
View reviewed changes
Comment threadsrc/sentry/static/sentry/app/components/events/interfaces/threads.jsx Outdated
Comment threadsrc/sentry/static/sentry/app/components/events/interfaces/threads.jsx Outdated
Comment threadsrc/sentry/static/sentry/app/components/events/interfaces/threads.jsx
@jan-auer
Merge branch 'master' into feat/ui-thread-errored
ee1d316
* master: (59 commits)
fix(btn-group-break): quick fix for issues table nav items (#15585)
feat(ui): Change `<SmartSearchBar>` to simulate "search" on En… (#15345)
ref: Update semaphore to 0.4.61 (#15574)
fix(api): Fix failing snuba test in Django 1.9
chore(ts): convert sentry app component files (#15575)
build(github-actions): RIP github actions (#15577)
feat(ui): Adapt user-feedback page to lightweight organization context (#15551)
ref(logo replacement): converted pngs to svgs (#15552)
Remove unused animated-ellipsis (#15515)
fix: Fix `get_participants` to use `__in` correctly.
build(webpack): Remove `lodash-webpack-plugin` (#15521)
moved the bulk of plugins from test_only_plugins into new_sentry_plugins (#15468)
ref: Remove "store.save-event-skips-nodestore" option from code (#15568)
logging(app-context): adds more logging context for slack api errors (#15557)
build(babel): Remove `@babel/polyfill` (#15564)
chore(ts): convert sentryApps (#15565)
chore(ts): convert SentryAppIcon (#15569)
fix: Avoid updating with None (#15549)
feat(api): Project key creation rate limit params (#15366)
fix(api): Fix failing snuba test in Django 1.9
...
@jan-auer
ref(ui): Apply review feedback
2d98c3a
@jan-auer
test(acceptance): Load correct mock data for android
f50a29d
@jan-auer
fix(api): Serialize thread.errored in API
a783f7b
@jan-auer
fix(event_manager): Update thread schema normalization
508c82e
@jan-auer
jan-auer merged commit 80de8a9 into masterNov 14, 2019
@jan-auer
jan-auer deleted the feat/ui-thread-errored branch November 14, 2019 12:01
bruno-garcia added a commit that referenced this pull request Dec 12, 2019
@bruno-garcia
ref: Rollback#15516
8878590
@bruno-garciabruno-garcia mentioned this pull request Dec 12, 2019
Merged
bruno-garcia added a commit that referenced this pull request Dec 13, 2019
@bruno-garcia
ref: Rollback#15516(#16086)
e1b7ab0
scefali pushed a commit that referenced this pull request Dec 23, 2019
@bruno-garciaStephen Cefali
ref: Rollback#15516(#16086)
92b0920
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Dec 19, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@billyvgbillyvgbillyvg left review comments
@bruno-garciabruno-garciabruno-garcia approved these changes

Assignees

@jan-auerjan-auer

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jan-auer@billyvg@bruno-garcia
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
feat(ui): Render errored threads in issue details by jan-auer · Pull Request #15516 · getsentry/sentry · GitHub
Skip to content
feat(ui): Render errored threads in issue details - #15516
Merged
jan-auer merged 7 commits into
masterfrom 
feat/ui-thread-errored
Nov 14, 2019
Merged
feat(ui): Render errored threads in issue details#15516
jan-auer merged 7 commits into
masterfrom 
feat/ui-thread-errored
Conversation
@jan-auer
@jan-auerjan-auer
commented
Nov 8, 2019

Copy link


Copy Markdown

Member
We're introducing a new thread attribute called errored. It indicates that a thread is the cause of an error, without having crashed the application. Formally, the UI would only handle crashed threads.
This extends the UI to also consider threads with errored, if there is no crashed thread. Such a thread is marked specially in the thread list, and selected by default.
See getsentry/relay#306
@jan-auerjan-auer
self-assigned this
Nov 8, 2019
@jan-auer
jan-auer
commented
Nov 8, 2019

Copy link


Copy Markdown

MemberAuthor
This still requires an acceptance test, which @marandaneto is helping me to create right now.
@jan-auer
jan-auer
commented
Nov 8, 2019

Copy link


Copy Markdown

MemberAuthor
Store normalization at the moment still deletes the errored attribute in the integration test. Once libsemaphore is released, we can bump and should see correct snapshots.
bruno-garcia
bruno-garcia
approved these changes
Nov 8, 2019
View reviewed changes
Comment threadsrc/sentry/static/sentry/app/components/events/interfaces/threads.jsx
Outdated

billyvg
billyvg
reviewed
Nov 8, 2019
View reviewed changes
Comment threadsrc/sentry/static/sentry/app/components/events/interfaces/threads.jsx
Outdated

Comment threadsrc/sentry/static/sentry/app/components/events/interfaces/threads.jsx
Outdated

Comment threadsrc/sentry/static/sentry/app/components/events/interfaces/threads.jsx
@jan-auer
Merge branch 'master' into feat/ui-thread-errored
ee1d316
* master: (59 commits)
fix(btn-group-break): quick fix for issues table nav items (#15585)
feat(ui): Change `<SmartSearchBar>` to simulate "search" on En… (#15345)
ref: Update semaphore to 0.4.61 (#15574)
fix(api): Fix failing snuba test in Django 1.9
chore(ts): convert sentry app component files (#15575)
build(github-actions): RIP github actions (#15577)
feat(ui): Adapt user-feedback page to lightweight organization context (#15551)
ref(logo replacement): converted pngs to svgs (#15552)
Remove unused animated-ellipsis (#15515)
fix: Fix `get_participants` to use `__in` correctly.
build(webpack): Remove `lodash-webpack-plugin` (#15521)
moved the bulk of plugins from test_only_plugins into new_sentry_plugins (#15468)
ref: Remove "store.save-event-skips-nodestore" option from code (#15568)
logging(app-context): adds more logging context for slack api errors (#15557)
build(babel): Remove `@babel/polyfill` (#15564)
chore(ts): convert sentryApps (#15565)
chore(ts): convert SentryAppIcon (#15569)
fix: Avoid updating with None (#15549)
feat(api): Project key creation rate limit params (#15366)
fix(api): Fix failing snuba test in Django 1.9
...
@jan-auer
ref(ui): Apply review feedback
2d98c3a
@jan-auer
test(acceptance): Load correct mock data for android
f50a29d
@jan-auer
fix(api): Serialize thread.errored in API
a783f7b
@jan-auer
fix(event_manager): Update thread schema normalization
508c82e
@jan-auer
jan-auer
merged commit 80de8a9
into
masterNov 14, 2019
@jan-auer
jan-auer
deleted the

feat/ui-thread-errored

branch
November 14, 2019 12:01
bruno-garcia added a commit
that referenced
this pull request
Dec 12, 2019
@bruno-garcia
ref: Rollback#15516
8878590
@bruno-garciabruno-garcia
mentioned this pull request
Dec 12, 2019
 Merged

bruno-garcia added a commit
that referenced
this pull request
Dec 13, 2019
@bruno-garcia
ref: Rollback#15516(#16086)
e1b7ab0
scefali pushed a commit
that referenced
this pull request
Dec 23, 2019
@bruno-garciaStephen Cefali
ref: Rollback#15516(#16086)
92b0920
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Dec 19, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@billyvgbillyvgbillyvg left review comments
@bruno-garciabruno-garciabruno-garcia approved these changes

Assignees

@jan-auerjan-auer

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@jan-auer@billyvg@bruno-garcia

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(ui): Render errored threads in issue details by jan-auer · Pull Request #15516 · getsentry/sentry · GitHub
Skip to content
feat(ui): Render errored threads in issue details - #15516
Merged
jan-auer merged 7 commits into
masterfrom 
feat/ui-thread-errored
Nov 14, 2019
Merged
feat(ui): Render errored threads in issue details#15516
jan-auer merged 7 commits into
masterfrom 
feat/ui-thread-errored
Conversation
@jan-auer
@jan-auerjan-auer
commented
Nov 8, 2019

Copy link


Copy Markdown

Member
We're introducing a new thread attribute called errored. It indicates that a thread is the cause of an error, without having crashed the application. Formally, the UI would only handle crashed threads.
This extends the UI to also consider threads with errored, if there is no crashed thread. Such a thread is marked specially in the thread list, and selected by default.
See getsentry/relay#306
@jan-auerjan-auer
self-assigned this
Nov 8, 2019
@jan-auer
jan-auer
commented
Nov 8, 2019

Copy link


Copy Markdown

MemberAuthor
This still requires an acceptance test, which @marandaneto is helping me to create right now.
@jan-auer
jan-auer
commented
Nov 8, 2019

Copy link


Copy Markdown

MemberAuthor
Store normalization at the moment still deletes the errored attribute in the integration test. Once libsemaphore is released, we can bump and should see correct snapshots.
bruno-garcia
bruno-garcia
approved these changes
Nov 8, 2019
View reviewed changes
Comment threadsrc/sentry/static/sentry/app/components/events/interfaces/threads.jsx
Outdated

billyvg
billyvg
reviewed
Nov 8, 2019
View reviewed changes
Comment threadsrc/sentry/static/sentry/app/components/events/interfaces/threads.jsx
Outdated

Comment threadsrc/sentry/static/sentry/app/components/events/interfaces/threads.jsx
Outdated

Comment threadsrc/sentry/static/sentry/app/components/events/interfaces/threads.jsx
@jan-auer
Merge branch 'master' into feat/ui-thread-errored
ee1d316
* master: (59 commits)
fix(btn-group-break): quick fix for issues table nav items (#15585)
feat(ui): Change `<SmartSearchBar>` to simulate "search" on En… (#15345)
ref: Update semaphore to 0.4.61 (#15574)
fix(api): Fix failing snuba test in Django 1.9
chore(ts): convert sentry app component files (#15575)
build(github-actions): RIP github actions (#15577)
feat(ui): Adapt user-feedback page to lightweight organization context (#15551)
ref(logo replacement): converted pngs to svgs (#15552)
Remove unused animated-ellipsis (#15515)
fix: Fix `get_participants` to use `__in` correctly.
build(webpack): Remove `lodash-webpack-plugin` (#15521)
moved the bulk of plugins from test_only_plugins into new_sentry_plugins (#15468)
ref: Remove "store.save-event-skips-nodestore" option from code (#15568)
logging(app-context): adds more logging context for slack api errors (#15557)
build(babel): Remove `@babel/polyfill` (#15564)
chore(ts): convert sentryApps (#15565)
chore(ts): convert SentryAppIcon (#15569)
fix: Avoid updating with None (#15549)
feat(api): Project key creation rate limit params (#15366)
fix(api): Fix failing snuba test in Django 1.9
...
@jan-auer
ref(ui): Apply review feedback
2d98c3a
@jan-auer
test(acceptance): Load correct mock data for android
f50a29d
@jan-auer
fix(api): Serialize thread.errored in API
a783f7b
@jan-auer
fix(event_manager): Update thread schema normalization
508c82e
@jan-auer
jan-auer
merged commit 80de8a9
into
masterNov 14, 2019
@jan-auer
jan-auer
deleted the

feat/ui-thread-errored

branch
November 14, 2019 12:01
bruno-garcia added a commit
that referenced
this pull request
Dec 12, 2019
@bruno-garcia
ref: Rollback#15516
8878590
@bruno-garciabruno-garcia
mentioned this pull request
Dec 12, 2019
 Merged

bruno-garcia added a commit
that referenced
this pull request
Dec 13, 2019
@bruno-garcia
ref: Rollback#15516(#16086)
e1b7ab0
scefali pushed a commit
that referenced
this pull request
Dec 23, 2019
@bruno-garciaStephen Cefali
ref: Rollback#15516(#16086)
92b0920
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Dec 19, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@billyvgbillyvgbillyvg left review comments
@bruno-garciabruno-garciabruno-garcia approved these changes

Assignees

@jan-auerjan-auer

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@jan-auer@billyvg@bruno-garcia

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(ui): Render errored threads in issue details by jan-auer · Pull Request #15516 · getsentry/sentry · GitHub
Skip to content
feat(ui): Render errored threads in issue details - #15516
Merged
jan-auer merged 7 commits into
masterfrom 
feat/ui-thread-errored
Nov 14, 2019
Merged
feat(ui): Render errored threads in issue details#15516
jan-auer merged 7 commits into
masterfrom 
feat/ui-thread-errored
Conversation
@jan-auer
@jan-auerjan-auer
commented
Nov 8, 2019

Copy link


Copy Markdown

Member
We're introducing a new thread attribute called errored. It indicates that a thread is the cause of an error, without having crashed the application. Formally, the UI would only handle crashed threads.
This extends the UI to also consider threads with errored, if there is no crashed thread. Such a thread is marked specially in the thread list, and selected by default.
See getsentry/relay#306
@jan-auerjan-auer
self-assigned this
Nov 8, 2019
@jan-auer
jan-auer
commented
Nov 8, 2019

Copy link


Copy Markdown

MemberAuthor
This still requires an acceptance test, which @marandaneto is helping me to create right now.
@jan-auer
jan-auer
commented
Nov 8, 2019

Copy link


Copy Markdown

MemberAuthor
Store normalization at the moment still deletes the errored attribute in the integration test. Once libsemaphore is released, we can bump and should see correct snapshots.
bruno-garcia
bruno-garcia
approved these changes
Nov 8, 2019
View reviewed changes
Comment threadsrc/sentry/static/sentry/app/components/events/interfaces/threads.jsx
Outdated

billyvg
billyvg
reviewed
Nov 8, 2019
View reviewed changes
Comment threadsrc/sentry/static/sentry/app/components/events/interfaces/threads.jsx
Outdated

Comment threadsrc/sentry/static/sentry/app/components/events/interfaces/threads.jsx
Outdated

Comment threadsrc/sentry/static/sentry/app/components/events/interfaces/threads.jsx
@jan-auer
Merge branch 'master' into feat/ui-thread-errored
ee1d316
* master: (59 commits)
fix(btn-group-break): quick fix for issues table nav items (#15585)
feat(ui): Change `<SmartSearchBar>` to simulate "search" on En… (#15345)
ref: Update semaphore to 0.4.61 (#15574)
fix(api): Fix failing snuba test in Django 1.9
chore(ts): convert sentry app component files (#15575)
build(github-actions): RIP github actions (#15577)
feat(ui): Adapt user-feedback page to lightweight organization context (#15551)
ref(logo replacement): converted pngs to svgs (#15552)
Remove unused animated-ellipsis (#15515)
fix: Fix `get_participants` to use `__in` correctly.
build(webpack): Remove `lodash-webpack-plugin` (#15521)
moved the bulk of plugins from test_only_plugins into new_sentry_plugins (#15468)
ref: Remove "store.save-event-skips-nodestore" option from code (#15568)
logging(app-context): adds more logging context for slack api errors (#15557)
build(babel): Remove `@babel/polyfill` (#15564)
chore(ts): convert sentryApps (#15565)
chore(ts): convert SentryAppIcon (#15569)
fix: Avoid updating with None (#15549)
feat(api): Project key creation rate limit params (#15366)
fix(api): Fix failing snuba test in Django 1.9
...
@jan-auer
ref(ui): Apply review feedback
2d98c3a
@jan-auer
test(acceptance): Load correct mock data for android
f50a29d
@jan-auer
fix(api): Serialize thread.errored in API
a783f7b
@jan-auer
fix(event_manager): Update thread schema normalization
508c82e
@jan-auer
jan-auer
merged commit 80de8a9
into
masterNov 14, 2019
@jan-auer
jan-auer
deleted the

feat/ui-thread-errored

branch
November 14, 2019 12:01
bruno-garcia added a commit
that referenced
this pull request
Dec 12, 2019
@bruno-garcia
ref: Rollback#15516
8878590
@bruno-garciabruno-garcia
mentioned this pull request
Dec 12, 2019
 Merged

bruno-garcia added a commit
that referenced
this pull request
Dec 13, 2019
@bruno-garcia
ref: Rollback#15516(#16086)
e1b7ab0
scefali pushed a commit
that referenced
this pull request
Dec 23, 2019
@bruno-garciaStephen Cefali
ref: Rollback#15516(#16086)
92b0920
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Dec 19, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@billyvgbillyvgbillyvg left review comments
@bruno-garciabruno-garciabruno-garcia approved these changes

Assignees

@jan-auerjan-auer

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@jan-auer@billyvg@bruno-garcia

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
feat(ui): Render errored threads in issue details by jan-auer · Pull Request #15516 · getsentry/sentry · GitHub
Skip to content
feat(ui): Render errored threads in issue details - #15516
Merged
jan-auer merged 7 commits into
masterfrom 
feat/ui-thread-errored
Nov 14, 2019
Merged
feat(ui): Render errored threads in issue details#15516
jan-auer merged 7 commits into
masterfrom 
feat/ui-thread-errored
Conversation
@jan-auer
@jan-auerjan-auer
commented
Nov 8, 2019

Copy link


Copy Markdown

Member
We're introducing a new thread attribute called errored. It indicates that a thread is the cause of an error, without having crashed the application. Formally, the UI would only handle crashed threads.
This extends the UI to also consider threads with errored, if there is no crashed thread. Such a thread is marked specially in the thread list, and selected by default.
See getsentry/relay#306
@jan-auerjan-auer
self-assigned this
Nov 8, 2019
@jan-auer
jan-auer
commented
Nov 8, 2019

Copy link


Copy Markdown

MemberAuthor
This still requires an acceptance test, which @marandaneto is helping me to create right now.
@jan-auer
jan-auer
commented
Nov 8, 2019

Copy link


Copy Markdown

MemberAuthor
Store normalization at the moment still deletes the errored attribute in the integration test. Once libsemaphore is released, we can bump and should see correct snapshots.
bruno-garcia
bruno-garcia
approved these changes
Nov 8, 2019
View reviewed changes
Comment threadsrc/sentry/static/sentry/app/components/events/interfaces/threads.jsx
Outdated

billyvg
billyvg
reviewed
Nov 8, 2019
View reviewed changes
Comment threadsrc/sentry/static/sentry/app/components/events/interfaces/threads.jsx
Outdated

Comment threadsrc/sentry/static/sentry/app/components/events/interfaces/threads.jsx
Outdated

Comment threadsrc/sentry/static/sentry/app/components/events/interfaces/threads.jsx
@jan-auer
Merge branch 'master' into feat/ui-thread-errored
ee1d316
* master: (59 commits)
fix(btn-group-break): quick fix for issues table nav items (#15585)
feat(ui): Change `<SmartSearchBar>` to simulate "search" on En… (#15345)
ref: Update semaphore to 0.4.61 (#15574)
fix(api): Fix failing snuba test in Django 1.9
chore(ts): convert sentry app component files (#15575)
build(github-actions): RIP github actions (#15577)
feat(ui): Adapt user-feedback page to lightweight organization context (#15551)
ref(logo replacement): converted pngs to svgs (#15552)
Remove unused animated-ellipsis (#15515)
fix: Fix `get_participants` to use `__in` correctly.
build(webpack): Remove `lodash-webpack-plugin` (#15521)
moved the bulk of plugins from test_only_plugins into new_sentry_plugins (#15468)
ref: Remove "store.save-event-skips-nodestore" option from code (#15568)
logging(app-context): adds more logging context for slack api errors (#15557)
build(babel): Remove `@babel/polyfill` (#15564)
chore(ts): convert sentryApps (#15565)
chore(ts): convert SentryAppIcon (#15569)
fix: Avoid updating with None (#15549)
feat(api): Project key creation rate limit params (#15366)
fix(api): Fix failing snuba test in Django 1.9
...
@jan-auer
ref(ui): Apply review feedback
2d98c3a
@jan-auer
test(acceptance): Load correct mock data for android
f50a29d
@jan-auer
fix(api): Serialize thread.errored in API
a783f7b
@jan-auer
fix(event_manager): Update thread schema normalization
508c82e
@jan-auer
jan-auer
merged commit 80de8a9
into
masterNov 14, 2019
@jan-auer
jan-auer
deleted the

feat/ui-thread-errored

branch
November 14, 2019 12:01
bruno-garcia added a commit
that referenced
this pull request
Dec 12, 2019
@bruno-garcia
ref: Rollback#15516
8878590
@bruno-garciabruno-garcia
mentioned this pull request
Dec 12, 2019
 Merged

bruno-garcia added a commit
that referenced
this pull request
Dec 13, 2019
@bruno-garcia
ref: Rollback#15516(#16086)
e1b7ab0
scefali pushed a commit
that referenced
this pull request
Dec 23, 2019
@bruno-garciaStephen Cefali
ref: Rollback#15516(#16086)
92b0920
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Dec 19, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@billyvgbillyvgbillyvg left review comments
@bruno-garciabruno-garciabruno-garcia approved these changes

Assignees

@jan-auerjan-auer

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@jan-auer@billyvg@bruno-garcia

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(ui): Render errored threads in issue details by jan-auer · Pull Request #15516 · getsentry/sentry · GitHub
Skip to content
feat(ui): Render errored threads in issue details - #15516
Merged
jan-auer merged 7 commits into
masterfrom 
feat/ui-thread-errored
Nov 14, 2019
Merged
feat(ui): Render errored threads in issue details#15516
jan-auer merged 7 commits into
masterfrom 
feat/ui-thread-errored
Conversation
@jan-auer
@jan-auerjan-auer
commented
Nov 8, 2019

Copy link


Copy Markdown

Member
We're introducing a new thread attribute called errored. It indicates that a thread is the cause of an error, without having crashed the application. Formally, the UI would only handle crashed threads.
This extends the UI to also consider threads with errored, if there is no crashed thread. Such a thread is marked specially in the thread list, and selected by default.
See getsentry/relay#306
@jan-auerjan-auer
self-assigned this
Nov 8, 2019
@jan-auer
jan-auer
commented
Nov 8, 2019

Copy link


Copy Markdown

MemberAuthor
This still requires an acceptance test, which @marandaneto is helping me to create right now.
@jan-auer
jan-auer
commented
Nov 8, 2019

Copy link


Copy Markdown

MemberAuthor
Store normalization at the moment still deletes the errored attribute in the integration test. Once libsemaphore is released, we can bump and should see correct snapshots.
bruno-garcia
bruno-garcia
approved these changes
Nov 8, 2019
View reviewed changes
Comment threadsrc/sentry/static/sentry/app/components/events/interfaces/threads.jsx
Outdated

billyvg
billyvg
reviewed
Nov 8, 2019
View reviewed changes
Comment threadsrc/sentry/static/sentry/app/components/events/interfaces/threads.jsx
Outdated

Comment threadsrc/sentry/static/sentry/app/components/events/interfaces/threads.jsx
Outdated

Comment threadsrc/sentry/static/sentry/app/components/events/interfaces/threads.jsx
@jan-auer
Merge branch 'master' into feat/ui-thread-errored
ee1d316
* master: (59 commits)
fix(btn-group-break): quick fix for issues table nav items (#15585)
feat(ui): Change `<SmartSearchBar>` to simulate "search" on En… (#15345)
ref: Update semaphore to 0.4.61 (#15574)
fix(api): Fix failing snuba test in Django 1.9
chore(ts): convert sentry app component files (#15575)
build(github-actions): RIP github actions (#15577)
feat(ui): Adapt user-feedback page to lightweight organization context (#15551)
ref(logo replacement): converted pngs to svgs (#15552)
Remove unused animated-ellipsis (#15515)
fix: Fix `get_participants` to use `__in` correctly.
build(webpack): Remove `lodash-webpack-plugin` (#15521)
moved the bulk of plugins from test_only_plugins into new_sentry_plugins (#15468)
ref: Remove "store.save-event-skips-nodestore" option from code (#15568)
logging(app-context): adds more logging context for slack api errors (#15557)
build(babel): Remove `@babel/polyfill` (#15564)
chore(ts): convert sentryApps (#15565)
chore(ts): convert SentryAppIcon (#15569)
fix: Avoid updating with None (#15549)
feat(api): Project key creation rate limit params (#15366)
fix(api): Fix failing snuba test in Django 1.9
...
@jan-auer
ref(ui): Apply review feedback
2d98c3a
@jan-auer
test(acceptance): Load correct mock data for android
f50a29d
@jan-auer
fix(api): Serialize thread.errored in API
a783f7b
@jan-auer
fix(event_manager): Update thread schema normalization
508c82e
@jan-auer
jan-auer
merged commit 80de8a9
into
masterNov 14, 2019
@jan-auer
jan-auer
deleted the

feat/ui-thread-errored

branch
November 14, 2019 12:01
bruno-garcia added a commit
that referenced
this pull request
Dec 12, 2019
@bruno-garcia
ref: Rollback#15516
8878590
@bruno-garciabruno-garcia
mentioned this pull request
Dec 12, 2019
 Merged

bruno-garcia added a commit
that referenced
this pull request
Dec 13, 2019
@bruno-garcia
ref: Rollback#15516(#16086)
e1b7ab0
scefali pushed a commit
that referenced
this pull request
Dec 23, 2019
@bruno-garciaStephen Cefali
ref: Rollback#15516(#16086)
92b0920
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Dec 19, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@billyvgbillyvgbillyvg left review comments
@bruno-garciabruno-garciabruno-garcia approved these changes

Assignees

@jan-auerjan-auer

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@jan-auer@billyvg@bruno-garcia

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(ui): Render errored threads in issue details by jan-auer · Pull Request #15516 · getsentry/sentry · GitHub
Skip to content
feat(ui): Render errored threads in issue details - #15516
Merged
jan-auer merged 7 commits into
masterfrom 
feat/ui-thread-errored
Nov 14, 2019
Merged
feat(ui): Render errored threads in issue details#15516
jan-auer merged 7 commits into
masterfrom 
feat/ui-thread-errored
Conversation
@jan-auer
@jan-auerjan-auer
commented
Nov 8, 2019

Copy link


Copy Markdown

Member
We're introducing a new thread attribute called errored. It indicates that a thread is the cause of an error, without having crashed the application. Formally, the UI would only handle crashed threads.
This extends the UI to also consider threads with errored, if there is no crashed thread. Such a thread is marked specially in the thread list, and selected by default.
See getsentry/relay#306
@jan-auerjan-auer
self-assigned this
Nov 8, 2019
@jan-auer
jan-auer
commented
Nov 8, 2019

Copy link


Copy Markdown

MemberAuthor
This still requires an acceptance test, which @marandaneto is helping me to create right now.
@jan-auer
jan-auer
commented
Nov 8, 2019

Copy link


Copy Markdown

MemberAuthor
Store normalization at the moment still deletes the errored attribute in the integration test. Once libsemaphore is released, we can bump and should see correct snapshots.
bruno-garcia
bruno-garcia
approved these changes
Nov 8, 2019
View reviewed changes
Comment threadsrc/sentry/static/sentry/app/components/events/interfaces/threads.jsx
Outdated

billyvg
billyvg
reviewed
Nov 8, 2019
View reviewed changes
Comment threadsrc/sentry/static/sentry/app/components/events/interfaces/threads.jsx
Outdated

Comment threadsrc/sentry/static/sentry/app/components/events/interfaces/threads.jsx
Outdated

Comment threadsrc/sentry/static/sentry/app/components/events/interfaces/threads.jsx
@jan-auer
Merge branch 'master' into feat/ui-thread-errored
ee1d316
* master: (59 commits)
fix(btn-group-break): quick fix for issues table nav items (#15585)
feat(ui): Change `<SmartSearchBar>` to simulate "search" on En… (#15345)
ref: Update semaphore to 0.4.61 (#15574)
fix(api): Fix failing snuba test in Django 1.9
chore(ts): convert sentry app component files (#15575)
build(github-actions): RIP github actions (#15577)
feat(ui): Adapt user-feedback page to lightweight organization context (#15551)
ref(logo replacement): converted pngs to svgs (#15552)
Remove unused animated-ellipsis (#15515)
fix: Fix `get_participants` to use `__in` correctly.
build(webpack): Remove `lodash-webpack-plugin` (#15521)
moved the bulk of plugins from test_only_plugins into new_sentry_plugins (#15468)
ref: Remove "store.save-event-skips-nodestore" option from code (#15568)
logging(app-context): adds more logging context for slack api errors (#15557)
build(babel): Remove `@babel/polyfill` (#15564)
chore(ts): convert sentryApps (#15565)
chore(ts): convert SentryAppIcon (#15569)
fix: Avoid updating with None (#15549)
feat(api): Project key creation rate limit params (#15366)
fix(api): Fix failing snuba test in Django 1.9
...
@jan-auer
ref(ui): Apply review feedback
2d98c3a
@jan-auer
test(acceptance): Load correct mock data for android
f50a29d
@jan-auer
fix(api): Serialize thread.errored in API
a783f7b
@jan-auer
fix(event_manager): Update thread schema normalization
508c82e
@jan-auer
jan-auer
merged commit 80de8a9
into
masterNov 14, 2019
@jan-auer
jan-auer
deleted the

feat/ui-thread-errored

branch
November 14, 2019 12:01
bruno-garcia added a commit
that referenced
this pull request
Dec 12, 2019
@bruno-garcia
ref: Rollback#15516
8878590
@bruno-garciabruno-garcia
mentioned this pull request
Dec 12, 2019
 Merged

bruno-garcia added a commit
that referenced
this pull request
Dec 13, 2019
@bruno-garcia
ref: Rollback#15516(#16086)
e1b7ab0
scefali pushed a commit
that referenced
this pull request
Dec 23, 2019
@bruno-garciaStephen Cefali
ref: Rollback#15516(#16086)
92b0920
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Dec 19, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@billyvgbillyvgbillyvg left review comments
@bruno-garciabruno-garciabruno-garcia approved these changes

Assignees

@jan-auerjan-auer

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@jan-auer@billyvg@bruno-garcia

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
feat(ui): Render errored threads in issue details by jan-auer · Pull Request #15516 · getsentry/sentry · GitHub
Skip to content
feat(ui): Render errored threads in issue details - #15516
Merged
jan-auer merged 7 commits into
masterfrom 
feat/ui-thread-errored
Nov 14, 2019
Merged
feat(ui): Render errored threads in issue details#15516
jan-auer merged 7 commits into
masterfrom 
feat/ui-thread-errored
Conversation
@jan-auer
@jan-auerjan-auer
commented
Nov 8, 2019

Copy link


Copy Markdown

Member
We're introducing a new thread attribute called errored. It indicates that a thread is the cause of an error, without having crashed the application. Formally, the UI would only handle crashed threads.
This extends the UI to also consider threads with errored, if there is no crashed thread. Such a thread is marked specially in the thread list, and selected by default.
See getsentry/relay#306
@jan-auerjan-auer
self-assigned this
Nov 8, 2019
@jan-auer
jan-auer
commented
Nov 8, 2019

Copy link


Copy Markdown

MemberAuthor
This still requires an acceptance test, which @marandaneto is helping me to create right now.
@jan-auer
jan-auer
commented
Nov 8, 2019

Copy link


Copy Markdown

MemberAuthor
Store normalization at the moment still deletes the errored attribute in the integration test. Once libsemaphore is released, we can bump and should see correct snapshots.
bruno-garcia
bruno-garcia
approved these changes
Nov 8, 2019
View reviewed changes
Comment threadsrc/sentry/static/sentry/app/components/events/interfaces/threads.jsx
Outdated

billyvg
billyvg
reviewed
Nov 8, 2019
View reviewed changes
Comment threadsrc/sentry/static/sentry/app/components/events/interfaces/threads.jsx
Outdated

Comment threadsrc/sentry/static/sentry/app/components/events/interfaces/threads.jsx
Outdated

Comment threadsrc/sentry/static/sentry/app/components/events/interfaces/threads.jsx
@jan-auer
Merge branch 'master' into feat/ui-thread-errored
ee1d316
* master: (59 commits)
fix(btn-group-break): quick fix for issues table nav items (#15585)
feat(ui): Change `<SmartSearchBar>` to simulate "search" on En… (#15345)
ref: Update semaphore to 0.4.61 (#15574)
fix(api): Fix failing snuba test in Django 1.9
chore(ts): convert sentry app component files (#15575)
build(github-actions): RIP github actions (#15577)
feat(ui): Adapt user-feedback page to lightweight organization context (#15551)
ref(logo replacement): converted pngs to svgs (#15552)
Remove unused animated-ellipsis (#15515)
fix: Fix `get_participants` to use `__in` correctly.
build(webpack): Remove `lodash-webpack-plugin` (#15521)
moved the bulk of plugins from test_only_plugins into new_sentry_plugins (#15468)
ref: Remove "store.save-event-skips-nodestore" option from code (#15568)
logging(app-context): adds more logging context for slack api errors (#15557)
build(babel): Remove `@babel/polyfill` (#15564)
chore(ts): convert sentryApps (#15565)
chore(ts): convert SentryAppIcon (#15569)
fix: Avoid updating with None (#15549)
feat(api): Project key creation rate limit params (#15366)
fix(api): Fix failing snuba test in Django 1.9
...
@jan-auer
ref(ui): Apply review feedback
2d98c3a
@jan-auer
test(acceptance): Load correct mock data for android
f50a29d
@jan-auer
fix(api): Serialize thread.errored in API
a783f7b
@jan-auer
fix(event_manager): Update thread schema normalization
508c82e
@jan-auer
jan-auer
merged commit 80de8a9
into
masterNov 14, 2019
@jan-auer
jan-auer
deleted the

feat/ui-thread-errored

branch
November 14, 2019 12:01
bruno-garcia added a commit
that referenced
this pull request
Dec 12, 2019
@bruno-garcia
ref: Rollback#15516
8878590
@bruno-garciabruno-garcia
mentioned this pull request
Dec 12, 2019
 Merged

bruno-garcia added a commit
that referenced
this pull request
Dec 13, 2019
@bruno-garcia
ref: Rollback#15516(#16086)
e1b7ab0
scefali pushed a commit
that referenced
this pull request
Dec 23, 2019
@bruno-garciaStephen Cefali
ref: Rollback#15516(#16086)
92b0920
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Dec 19, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@billyvgbillyvgbillyvg left review comments
@bruno-garciabruno-garciabruno-garcia approved these changes

Assignees

@jan-auerjan-auer

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@jan-auer@billyvg@bruno-garcia