build(webpack): Remove lodash-webpack-plugin#15521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
billyvg merged 9 commits into from
Nov 13, 2019
Merged

build(webpack): Remove lodash-webpack-plugin#15521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fe5fb5d
build(webpack): Remove `lodash-webpack-plugin` [WIP]
billyvg Nov 8, 2019
ae60e9f
wip change import
billyvg Nov 8, 2019
772d088
change lodash imports to be modular
billyvg Nov 8, 2019
2a74310
remove babel-plugin-lodash
billyvg Nov 9, 2019
e8d12df
fix missing import
billyvg Nov 11, 2019
a5c84d1
fix prettier
billyvg Nov 11, 2019
d171663
update tests
billyvg Nov 11, 2019
2e2ebd0
use eslint config that enforces lodash imports
billyvg Nov 12, 2019
88d467a
fix storybook
billyvg Nov 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .storybook/.babelrc
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@
"presets": ["@babel/react", "@babel/env"],
"plugins": [
"emotion",
"lodash",
"react-hot-loader/babel",
"@babel/plugin-syntax-dynamic-import",
"@babel/plugin-proposal-object-rest-spread",
Expand Down
1 change: 0 additions & 1 deletion babel.config.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@ module.exports = {
presets: ['@babel/react', '@babel/env', '@babel/preset-typescript'],
plugins: [
'emotion',
'lodash',
'react-hot-loader/babel',
'@babel/plugin-syntax-dynamic-import',
'@babel/plugin-proposal-object-rest-spread',
Expand Down
4 changes: 1 addition & 3 deletions package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -44,7 +44,6 @@
"babel-loader": "^8.0.0",
"babel-plugin-add-react-displayname": "^0.0.5",
"babel-plugin-emotion": "9.2.11",
"babel-plugin-lodash": "^3.3.4",
"babel-plugin-transform-react-remove-prop-types": "^0.4.24",
"bootstrap": "3.4.0",
"classnames": "2.2.0",
Expand DownExpand Up@@ -76,7 +75,6 @@
"less": "^3.9.0",
"less-loader": "^4.1.0",
"lodash": "^4.17.11",
"lodash-webpack-plugin": "^0.11.5",
"marked": "0.6.2",
"mini-css-extract-plugin": "^v0.5.0",
"mobx": "^5.13.0",
Expand DownExpand Up@@ -146,7 +144,7 @@
"enzyme-adapter-react-16": "1.14.0",
"enzyme-to-json": "3.4.0",
"eslint": "5.11.1",
"eslint-config-sentry-app": "1.26.0",
"eslint-config-sentry-app": "1.27.0",
"jest": "24.1.0",
"jest-canvas-mock": "^2.1.0",
"jest-junit": "^3.4.1",
Expand Down
4 changes: 3 additions & 1 deletion src/sentry/static/sentry/app/actionCreators/formSearch.jsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import {flatten, flatMap} from 'lodash';
import flatten from 'lodash/flatten';

import flatMap from 'lodash/flatMap';

import FormSearchActions from 'app/actions/formSearchActions';

Expand Down
4 changes: 3 additions & 1 deletion src/sentry/static/sentry/app/actionCreators/globalSelection.jsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import {isEqual, isInteger, omit} from 'lodash';
import isEqual from 'lodash/isEqual';
import isInteger from 'lodash/isInteger';
import omit from 'lodash/omit';
import * as Sentry from '@sentry/browser';

import {defined} from 'app/utils';
Expand Down
4 changes: 3 additions & 1 deletion src/sentry/static/sentry/app/actionCreators/projects.jsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import {chunk, debounce} from 'lodash';
import chunk from 'lodash/chunk';

import debounce from 'lodash/debounce';

import {
addLoadingMessage,
Expand Down
4 changes: 3 additions & 1 deletion src/sentry/static/sentry/app/api.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import {isUndefined, isNil, get} from 'lodash';
import isUndefined from 'lodash/isUndefined';
import isNil from 'lodash/isNil';
import get from 'lodash/get';
import $ from 'jquery';
import * as Sentry from '@sentry/browser';

Expand Down
4 changes: 2 additions & 2 deletions src/sentry/static/sentry/app/components/activity/note/inputWithStorage.jsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import _ from 'lodash';
import debounce from 'lodash/debounce';
import PropTypes from 'prop-types';
import React from 'react';
import * as Sentry from '@sentry/browser';
Expand DownExpand Up@@ -75,7 +75,7 @@ class NoteInputWithStorage extends React.Component {
return onLoad(storageObj[itemKey]);
};

save = _.debounce(value => {
save = debounce(value => {
const {itemKey, onSave} = this.props;

const currentObj = this.fetchFromStorage() || {};
Expand Down
2 changes: 1 addition & 1 deletion src/sentry/static/sentry/app/components/activity/note/mentionables.jsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {uniqBy} from 'lodash';
import uniqBy from 'lodash/uniqBy';
import PropTypes from 'prop-types';
import React from 'react';
import Reflux from 'reflux';
Expand Down
2 changes: 1 addition & 1 deletion src/sentry/static/sentry/app/components/asyncComponent.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {isEqual} from 'lodash';
import isEqual from 'lodash/isEqual';
import PropTypes from 'prop-types';
import React from 'react';
import {Location} from 'history';
Expand Down
2 changes: 1 addition & 1 deletion src/sentry/static/sentry/app/components/asyncComponentSearchInput.jsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {debounce} from 'lodash';
import debounce from 'lodash/debounce';
import {withRouter} from 'react-router';
import PropTypes from 'prop-types';
import React from 'react';
Expand Down
4 changes: 2 additions & 2 deletions src/sentry/static/sentry/app/components/bases/pluginComponentBase.jsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
import React from 'react';
import _ from 'lodash';
import isFunction from 'lodash/isFunction';

import {Client} from 'app/api';
import {FormState, GenericField} from 'app/components/forms';
import IndicatorStore from 'app/stores/indicatorStore';
import {t} from 'app/locale';

const callbackWithArgs = function(callback, ...args) {
if (_.isFunction(callback)) {
if (isFunction(callback)) {
callback = callback.bind(this, ...args);
} else {
callback = null;
Expand Down
2 changes: 1 addition & 1 deletion src/sentry/static/sentry/app/components/button.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@ import PropTypes from 'prop-types';
import React from 'react';
import styled, {css} from 'react-emotion';
import isPropValid from '@emotion/is-prop-valid';
import {pickBy} from 'lodash';
import pickBy from 'lodash/pickBy';

import ExternalLink from 'app/components/links/externalLink';
import InlineSvg from 'app/components/inlineSvg';
Expand Down
2 changes: 1 addition & 1 deletion src/sentry/static/sentry/app/components/charts/components/tooltip.jsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import 'echarts/lib/component/tooltip';

import {get} from 'lodash';
import get from 'lodash/get';
import {getFormattedDate} from 'app/utils/dates';
import {truncationFormatter} from '../utils';

Expand Down
2 changes: 1 addition & 1 deletion src/sentry/static/sentry/app/components/charts/releaseSeries.jsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@ import {withRouter} from 'react-router';
import PropTypes from 'prop-types';
import React from 'react';
import moment from 'moment';
import {isEqual} from 'lodash';
import isEqual from 'lodash/isEqual';

import {addErrorMessage} from 'app/actionCreators/indicator';
import {getUserTimezone} from 'app/utils/dates';
Expand Down
2 changes: 1 addition & 1 deletion src/sentry/static/sentry/app/components/charts/worldMapChart.jsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {max} from 'lodash';
import max from 'lodash/max';
import PropTypes from 'prop-types';
import React from 'react';

Expand Down
12 changes: 7 additions & 5 deletions src/sentry/static/sentry/app/components/contextData.jsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,9 @@ import React from 'react';

import classNames from 'classnames';

import _ from 'lodash';
import isString from 'lodash/isString';
import isNumber from 'lodash/isNumber';
import isArray from 'lodash/isArray';

import {isUrl} from 'app/utils';

Expand DownExpand Up@@ -116,7 +118,7 @@ class ContextData extends React.Component {
return <span className="val-null">{'None'}</span>;
} else if (value === true || value === false) {
return <span className="val-bool">{value ? 'True' : 'False'}</span>;
} else if (_.isString(value)) {
} else if (isString(value)) {
const valueInfo = analyzeStringForRepr(value);

const out = [
Expand All@@ -141,9 +143,9 @@ class ContextData extends React.Component {
}

return out;
} else if (_.isNumber(value)) {
} else if (isNumber(value)) {
return <span className="val-number">{value}</span>;
} else if (_.isArray(value)) {
} else if (isArray(value)) {
for (i = 0; i < value.length; i++) {
children.push(
<span className="val-array-item" key={i}>
Expand DownExpand Up@@ -204,7 +206,7 @@ class ContextData extends React.Component {
};

renderKeyPosValue = value => {
if (_.isString(value)) {
if (isString(value)) {
return <span className="val-string">{value}</span>;
}
return this.renderValue(value);
Expand Down
1 change: 0 additions & 1 deletion src/sentry/static/sentry/app/components/dateTime.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
import PropTypes from 'prop-types';
import React from 'react';
import moment from 'moment-timezone';
import _ from 'lodash';

import ConfigStore from 'app/stores/configStore';

Expand Down
4 changes: 2 additions & 2 deletions src/sentry/static/sentry/app/components/dropdownAutoCompleteMenu.jsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import {AutoSizer, List} from 'react-virtualized';
import PropTypes from 'prop-types';
import React from 'react';
import _ from 'lodash';
import flatMap from 'lodash/flatMap';
import styled from 'react-emotion';

import {t} from 'app/locale';
Expand DownExpand Up@@ -202,7 +202,7 @@ class DropdownAutoCompleteMenu extends React.Component {

if (items[0] && items[0].items) {
//if the first item has children, we assume it is a group
return _.flatMap(this.filterGroupedItems(items, inputValue), item => {
return flatMap(this.filterGroupedItems(items, inputValue), item => {
const groupItems = item.items.map(groupedItem => ({
...groupedItem,
index: itemCount++,
Expand Down
2 changes: 1 addition & 1 deletion src/sentry/static/sentry/app/components/dropdownButton.jsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@ import React from 'react';
import styled from 'react-emotion';
import Button from 'app/components/button';
import InlineSvg from 'app/components/inlineSvg';
import {omit} from 'lodash';
import omit from 'lodash/omit';

class DropdownButton extends React.Component {
static propTypes = {
Expand Down
2 changes: 1 addition & 1 deletion src/sentry/static/sentry/app/components/eventOrGroupHeader.jsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@ import React from 'react';
import {withRouter} from 'react-router';
import styled, {css} from 'react-emotion';
import classNames from 'classnames';
import {capitalize} from 'lodash';
import capitalize from 'lodash/capitalize';

import SentryTypes from 'app/sentryTypes';
import EventOrGroupTitle from 'app/components/eventOrGroupTitle';
Expand Down
2 changes: 1 addition & 1 deletion src/sentry/static/sentry/app/components/events/contexts.jsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import PropTypes from 'prop-types';
import React from 'react';

import {get} from 'lodash';
import get from 'lodash/get';
import {objectIsEmpty, toTitleCase, defined} from 'app/utils';
import EventDataSection from 'app/components/events/eventDataSection';
import plugins from 'app/plugins';
Expand Down
4 changes: 2 additions & 2 deletions src/sentry/static/sentry/app/components/events/contexts/contextBlock.jsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import PropTypes from 'prop-types';
import React from 'react';
import _ from 'lodash';
import sortBy from 'lodash/sortBy';

import {defined} from 'app/utils';
import ErrorBoundary from 'app/components/errorBoundary';
Expand DownExpand Up@@ -39,7 +39,7 @@ class ContextBlock extends React.Component {
}

if (extraData.length > 0) {
data = data.concat(_.sortBy(extraData, (key, value) => key));
data = data.concat(sortBy(extraData, (key, value) => key));
}

return (
Expand Down
2 changes: 1 addition & 1 deletion src/sentry/static/sentry/app/components/events/contexts/device.jsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {isString} from 'lodash';
import isString from 'lodash/isString';
import PropTypes from 'prop-types';
import React from 'react';

Expand Down
4 changes: 2 additions & 2 deletions src/sentry/static/sentry/app/components/events/contexts/user.jsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
/*eslint react/jsx-key:0*/
import PropTypes from 'prop-types';
import React from 'react';
import _ from 'lodash';
import each from 'lodash/each';

import Avatar from 'app/components/avatar';
import ErrorBoundary from 'app/components/errorBoundary';
Expand DownExpand Up@@ -40,7 +40,7 @@ class UserContextType extends React.Component {
user.name && builtins.push(['Name', <pre>{user.name}</pre>]);

// We also attach user supplied data as 'user.data'
_.each(user.data, function(value, key) {
each(user.data, function(value, key) {
children.push([key, value]);
});

Expand Down
8 changes: 5 additions & 3 deletions src/sentry/static/sentry/app/components/events/errorItem.jsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import _ from 'lodash';
import mapKeys from 'lodash/mapKeys';
import startCase from 'lodash/startCase';
import isEmpty from 'lodash/isEmpty';
import React from 'react';
import KeyValueList from 'app/components/events/interfaces/keyValueList';
import {t} from 'app/locale';
Expand DownExpand Up@@ -51,7 +53,7 @@ class EventErrorItem extends React.Component {
data.image_path = path.length ? path.join(separator) + separator : '';
}

return _.mapKeys(data, (value, key) => t(keyMapping[key] || _.startCase(key)));
return mapKeys(data, (value, key) => t(keyMapping[key] || startCase(key)));
}

renderPath() {
Expand All@@ -77,7 +79,7 @@ class EventErrorItem extends React.Component {
<li>
{this.renderPath()}
{error.message}
{!_.isEmpty(data) && (
{!isEmpty(data) && (
<small>
{' '}
<a style={{marginLeft: 10}} onClick={this.toggle}>
Expand Down
5 changes: 3 additions & 2 deletions src/sentry/static/sentry/app/components/events/errors.jsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
import React from 'react';
import _ from 'lodash';
import uniqWith from 'lodash/uniqWith';
import isEqual from 'lodash/isEqual';

import EventDataSection from 'app/components/events/eventDataSection';
import EventErrorItem from 'app/components/events/errorItem';
Expand DownExpand Up@@ -32,7 +33,7 @@ class EventErrors extends React.Component {
};

uniqueErrors = errors => {
return _.uniqWith(errors, _.isEqual);
return uniqWith(errors, isEqual);
};

render() {
Expand Down
3 changes: 2 additions & 1 deletion src/sentry/static/sentry/app/components/events/eventCause.jsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import PropTypes from 'prop-types';
import React from 'react';
import {uniqBy, flatMap} from 'lodash';
import uniqBy from 'lodash/uniqBy';
import flatMap from 'lodash/flatMap';
import styled from 'react-emotion';

import CommitRow from 'app/components/commitRow';
Expand Down
4 changes: 2 additions & 2 deletions src/sentry/static/sentry/app/components/events/eventTags.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import React from 'react';
import {Link} from 'react-router';
import _ from 'lodash';
import isEmpty from 'lodash/isEmpty';
import queryString from 'query-string';

import {Location} from 'history';
Expand DownExpand Up@@ -75,7 +75,7 @@ class EventTags extends React.Component<EventTagsProps> {
const {event, orgId, hideGuide} = this.props;
const {tags} = event;

if (_.isEmpty(tags)) {
if (isEmpty(tags)) {
return null;
}

Expand Down
2 changes: 1 addition & 1 deletion src/sentry/static/sentry/app/components/events/groupingInfo.jsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import React from 'react';
import PropTypes from 'prop-types';
import styled from 'react-emotion';
import {isObject} from 'lodash';
import isObject from 'lodash/isObject';
import AsyncComponent from 'app/components/asyncComponent';
import DropdownAutoComplete from 'app/components/dropdownAutoComplete';
import DropdownButton from 'app/components/dropdownButton';
Expand Down
7 changes: 4 additions & 3 deletions src/sentry/static/sentry/app/components/events/interfaces/breadcrumbs/crumbTable.jsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import PropTypes from 'prop-types';
import React from 'react';
import _ from 'lodash';
import map from 'lodash/map';
import isObject from 'lodash/isObject';

import Category from 'app/components/events/interfaces/breadcrumbs/category';

Expand All@@ -15,12 +16,12 @@ class CrumbTable extends React.Component {
if (!this.props.kvData) {
return null;
}
return _.map(this.props.kvData, (val, key) => {
return map(this.props.kvData, (val, key) => {
return (
<tr key={key}>
<td className="key">{key}</td>
<td className="value">
<pre>{_.isObject(val) ? JSON.stringify(val) : val}</pre>
<pre>{isObject(val) ? JSON.stringify(val) : val}</pre>
</td>
</tr>
);
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
build(webpack): Remove lodash-webpack-plugin#15521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

billyvg
merged 9 commits into

from

Nov 13, 2019
 Merged


build(webpack): Remove lodash-webpack-plugin#15521
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


9 commits


Select commit
Hold shift + click to select a range
fe5fb5d

build(webpack): Remove `lodash-webpack-plugin` [WIP]


billyvg Nov 8, 2019
ae60e9f

wip change import


billyvg Nov 8, 2019
772d088

change lodash imports to be modular


billyvg Nov 8, 2019
2a74310

remove babel-plugin-lodash


billyvg Nov 9, 2019
e8d12df

fix missing import


billyvg Nov 11, 2019
a5c84d1

fix prettier


billyvg Nov 11, 2019
d171663

update tests


billyvg Nov 11, 2019
2e2ebd0

use eslint config that enforces lodash imports


billyvg Nov 12, 2019
88d467a

fix storybook


billyvg Nov 13, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
.storybook/.babelrc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@
 "presets": ["@babel/react", "@babel/env"],
 "plugins": [
 "emotion",
 "lodash",
 "react-hot-loader/babel",
 "@babel/plugin-syntax-dynamic-import",
 "@babel/plugin-proposal-object-rest-spread",
Expand Down

1 change: 0 additions & 1 deletion
babel.config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@ module.exports = {
 presets: ['@babel/react', '@babel/env', '@babel/preset-typescript'],
 plugins: [
 'emotion',
 'lodash',
 'react-hot-loader/babel',
 '@babel/plugin-syntax-dynamic-import',
 '@babel/plugin-proposal-object-rest-spread',
Expand Down

4 changes: 1 addition & 3 deletions
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,7 +44,6 @@
 "babel-loader": "^8.0.0",
 "babel-plugin-add-react-displayname": "^0.0.5",
 "babel-plugin-emotion": "9.2.11",
 "babel-plugin-lodash": "^3.3.4",
 "babel-plugin-transform-react-remove-prop-types": "^0.4.24",
 "bootstrap": "3.4.0",
 "classnames": "2.2.0",
Expand DownExpand Up@@ -76,7 +75,6 @@
 "less": "^3.9.0",
 "less-loader": "^4.1.0",
 "lodash": "^4.17.11",
 "lodash-webpack-plugin": "^0.11.5",
 "marked": "0.6.2",
 "mini-css-extract-plugin": "^v0.5.0",
 "mobx": "^5.13.0",
Expand DownExpand Up@@ -146,7 +144,7 @@
 "enzyme-adapter-react-16": "1.14.0",
 "enzyme-to-json": "3.4.0",
 "eslint": "5.11.1",
 "eslint-config-sentry-app": "1.26.0",
 "eslint-config-sentry-app": "1.27.0",
 "jest": "24.1.0",
 "jest-canvas-mock": "^2.1.0",
 "jest-junit": "^3.4.1",
Expand Down

4 changes: 3 additions & 1 deletion
src/sentry/static/sentry/app/actionCreators/formSearch.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import {flatten, flatMap} from 'lodash';
import flatten from 'lodash/flatten';

import flatMap from 'lodash/flatMap';

import FormSearchActions from 'app/actions/formSearchActions';

Expand Down

4 changes: 3 additions & 1 deletion
src/sentry/static/sentry/app/actionCreators/globalSelection.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import {isEqual, isInteger, omit} from 'lodash';
import isEqual from 'lodash/isEqual';
import isInteger from 'lodash/isInteger';
import omit from 'lodash/omit';
import * as Sentry from '@sentry/browser';

import {defined} from 'app/utils';
Expand Down

4 changes: 3 additions & 1 deletion
src/sentry/static/sentry/app/actionCreators/projects.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import {chunk, debounce} from 'lodash';
import chunk from 'lodash/chunk';

import debounce from 'lodash/debounce';

import {
 addLoadingMessage,
Expand Down

4 changes: 3 additions & 1 deletion
src/sentry/static/sentry/app/api.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import {isUndefined, isNil, get} from 'lodash';
import isUndefined from 'lodash/isUndefined';
import isNil from 'lodash/isNil';
import get from 'lodash/get';
import $ from 'jquery';
import * as Sentry from '@sentry/browser';

Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/activity/note/inputWithStorage.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import _ from 'lodash';
import debounce from 'lodash/debounce';
import PropTypes from 'prop-types';
import React from 'react';
import * as Sentry from '@sentry/browser';
Expand DownExpand Up@@ -75,7 +75,7 @@ class NoteInputWithStorage extends React.Component {
 return onLoad(storageObj[itemKey]);
 };

 save = _.debounce(value => {
 save = debounce(value => {
 const {itemKey, onSave} = this.props;

 const currentObj = this.fetchFromStorage() || {};
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/activity/note/mentionables.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {uniqBy} from 'lodash';
import uniqBy from 'lodash/uniqBy';
import PropTypes from 'prop-types';
import React from 'react';
import Reflux from 'reflux';
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/asyncComponent.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {isEqual} from 'lodash';
import isEqual from 'lodash/isEqual';
import PropTypes from 'prop-types';
import React from 'react';
import {Location} from 'history';
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/asyncComponentSearchInput.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {debounce} from 'lodash';
import debounce from 'lodash/debounce';
import {withRouter} from 'react-router';
import PropTypes from 'prop-types';
import React from 'react';
Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/bases/pluginComponentBase.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
import React from 'react';
import _ from 'lodash';
import isFunction from 'lodash/isFunction';

import {Client} from 'app/api';
import {FormState, GenericField} from 'app/components/forms';
import IndicatorStore from 'app/stores/indicatorStore';
import {t} from 'app/locale';

const callbackWithArgs = function(callback, ...args) {
 if (_.isFunction(callback)) {
 if (isFunction(callback)) {
 callback = callback.bind(this, ...args);
 } else {
 callback = null;
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/button.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@ import PropTypes from 'prop-types';
import React from 'react';
import styled, {css} from 'react-emotion';
import isPropValid from '@emotion/is-prop-valid';
import {pickBy} from 'lodash';
import pickBy from 'lodash/pickBy';

import ExternalLink from 'app/components/links/externalLink';
import InlineSvg from 'app/components/inlineSvg';
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/charts/components/tooltip.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import 'echarts/lib/component/tooltip';

import {get} from 'lodash';
import get from 'lodash/get';
import {getFormattedDate} from 'app/utils/dates';
import {truncationFormatter} from '../utils';

Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/charts/releaseSeries.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@ import {withRouter} from 'react-router';
import PropTypes from 'prop-types';
import React from 'react';
import moment from 'moment';
import {isEqual} from 'lodash';
import isEqual from 'lodash/isEqual';

import {addErrorMessage} from 'app/actionCreators/indicator';
import {getUserTimezone} from 'app/utils/dates';
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/charts/worldMapChart.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {max} from 'lodash';
import max from 'lodash/max';
import PropTypes from 'prop-types';
import React from 'react';

Expand Down

12 changes: 7 additions & 5 deletions
src/sentry/static/sentry/app/components/contextData.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,9 @@ import React from 'react';

import classNames from 'classnames';

import _ from 'lodash';
import isString from 'lodash/isString';
import isNumber from 'lodash/isNumber';
import isArray from 'lodash/isArray';

import {isUrl} from 'app/utils';

Expand DownExpand Up@@ -116,7 +118,7 @@ class ContextData extends React.Component {
 return <span className="val-null">{'None'}</span>;
 } else if (value === true || value === false) {
 return <span className="val-bool">{value ? 'True' : 'False'}</span>;
 } else if (_.isString(value)) {
 } else if (isString(value)) {
 const valueInfo = analyzeStringForRepr(value);

 const out = [
Expand All@@ -141,9 +143,9 @@ class ContextData extends React.Component {
 }

 return out;
 } else if (_.isNumber(value)) {
 } else if (isNumber(value)) {
 return <span className="val-number">{value}</span>;
 } else if (_.isArray(value)) {
 } else if (isArray(value)) {
 for (i = 0; i < value.length; i++) {
 children.push(
 <span className="val-array-item" key={i}>
Expand DownExpand Up@@ -204,7 +206,7 @@ class ContextData extends React.Component {
 };

 renderKeyPosValue = value => {
 if (_.isString(value)) {
 if (isString(value)) {
 return <span className="val-string">{value}</span>;
 }
 return this.renderValue(value);
Expand Down

1 change: 0 additions & 1 deletion
src/sentry/static/sentry/app/components/dateTime.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
import PropTypes from 'prop-types';
import React from 'react';
import moment from 'moment-timezone';
import _ from 'lodash';

import ConfigStore from 'app/stores/configStore';

Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/dropdownAutoCompleteMenu.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import {AutoSizer, List} from 'react-virtualized';
import PropTypes from 'prop-types';
import React from 'react';
import _ from 'lodash';
import flatMap from 'lodash/flatMap';
import styled from 'react-emotion';

import {t} from 'app/locale';
Expand DownExpand Up@@ -202,7 +202,7 @@ class DropdownAutoCompleteMenu extends React.Component {

 if (items[0] && items[0].items) {
 //if the first item has children, we assume it is a group
 return _.flatMap(this.filterGroupedItems(items, inputValue), item => {
 return flatMap(this.filterGroupedItems(items, inputValue), item => {
 const groupItems = item.items.map(groupedItem => ({
 ...groupedItem,
 index: itemCount++,
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/dropdownButton.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@ import React from 'react';
import styled from 'react-emotion';
import Button from 'app/components/button';
import InlineSvg from 'app/components/inlineSvg';
import {omit} from 'lodash';
import omit from 'lodash/omit';

class DropdownButton extends React.Component {
 static propTypes = {
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/eventOrGroupHeader.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@ import React from 'react';
import {withRouter} from 'react-router';
import styled, {css} from 'react-emotion';
import classNames from 'classnames';
import {capitalize} from 'lodash';
import capitalize from 'lodash/capitalize';

import SentryTypes from 'app/sentryTypes';
import EventOrGroupTitle from 'app/components/eventOrGroupTitle';
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/events/contexts.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import PropTypes from 'prop-types';
import React from 'react';

import {get} from 'lodash';
import get from 'lodash/get';
import {objectIsEmpty, toTitleCase, defined} from 'app/utils';
import EventDataSection from 'app/components/events/eventDataSection';
import plugins from 'app/plugins';
Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/events/contexts/contextBlock.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import PropTypes from 'prop-types';
import React from 'react';
import _ from 'lodash';
import sortBy from 'lodash/sortBy';

import {defined} from 'app/utils';
import ErrorBoundary from 'app/components/errorBoundary';
Expand DownExpand Up@@ -39,7 +39,7 @@ class ContextBlock extends React.Component {
 }

 if (extraData.length > 0) {
 data = data.concat(_.sortBy(extraData, (key, value) => key));
 data = data.concat(sortBy(extraData, (key, value) => key));
 }

 return (
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/events/contexts/device.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {isString} from 'lodash';
import isString from 'lodash/isString';
import PropTypes from 'prop-types';
import React from 'react';

Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/events/contexts/user.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
/*eslint react/jsx-key:0*/
import PropTypes from 'prop-types';
import React from 'react';
import _ from 'lodash';
import each from 'lodash/each';

import Avatar from 'app/components/avatar';
import ErrorBoundary from 'app/components/errorBoundary';
Expand DownExpand Up@@ -40,7 +40,7 @@ class UserContextType extends React.Component {
 user.name && builtins.push(['Name', <pre>{user.name}</pre>]);

 // We also attach user supplied data as 'user.data'
_.each(user.data, function(value, key) {
 each(user.data, function(value, key) {
 children.push([key, value]);
 });

Expand Down

8 changes: 5 additions & 3 deletions
src/sentry/static/sentry/app/components/events/errorItem.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import _ from 'lodash';
import mapKeys from 'lodash/mapKeys';
import startCase from 'lodash/startCase';
import isEmpty from 'lodash/isEmpty';
import React from 'react';
import KeyValueList from 'app/components/events/interfaces/keyValueList';
import {t} from 'app/locale';
Expand DownExpand Up@@ -51,7 +53,7 @@ class EventErrorItem extends React.Component {
 data.image_path = path.length ? path.join(separator) + separator : '';
 }

 return _.mapKeys(data, (value, key) => t(keyMapping[key] || _.startCase(key)));
 return mapKeys(data, (value, key) => t(keyMapping[key] || startCase(key)));
 }

 renderPath() {
Expand All@@ -77,7 +79,7 @@ class EventErrorItem extends React.Component {
 <li>
 {this.renderPath()}
 {error.message}
 {!_.isEmpty(data) && (
 {!isEmpty(data) && (
 <small>
 {' '}
 <a style={{marginLeft: 10}} onClick={this.toggle}>
Expand Down

5 changes: 3 additions & 2 deletions
src/sentry/static/sentry/app/components/events/errors.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
import React from 'react';
import _ from 'lodash';
import uniqWith from 'lodash/uniqWith';
import isEqual from 'lodash/isEqual';

import EventDataSection from 'app/components/events/eventDataSection';
import EventErrorItem from 'app/components/events/errorItem';
Expand DownExpand Up@@ -32,7 +33,7 @@ class EventErrors extends React.Component {
 };

 uniqueErrors = errors => {
 return _.uniqWith(errors, _.isEqual);
 return uniqWith(errors, isEqual);
 };

 render() {
Expand Down

3 changes: 2 additions & 1 deletion
src/sentry/static/sentry/app/components/events/eventCause.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import PropTypes from 'prop-types';
import React from 'react';
import {uniqBy, flatMap} from 'lodash';
import uniqBy from 'lodash/uniqBy';
import flatMap from 'lodash/flatMap';
import styled from 'react-emotion';

import CommitRow from 'app/components/commitRow';
Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/events/eventTags.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import React from 'react';
import {Link} from 'react-router';
import _ from 'lodash';
import isEmpty from 'lodash/isEmpty';
import queryString from 'query-string';

import {Location} from 'history';
Expand DownExpand Up@@ -75,7 +75,7 @@ class EventTags extends React.Component<EventTagsProps> {
 const {event, orgId, hideGuide} = this.props;
 const {tags} = event;

 if (_.isEmpty(tags)) {
 if (isEmpty(tags)) {
 return null;
 }

Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/events/groupingInfo.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import React from 'react';
import PropTypes from 'prop-types';
import styled from 'react-emotion';
import {isObject} from 'lodash';
import isObject from 'lodash/isObject';
import AsyncComponent from 'app/components/asyncComponent';
import DropdownAutoComplete from 'app/components/dropdownAutoComplete';
import DropdownButton from 'app/components/dropdownButton';
Expand Down

7 changes: 4 additions & 3 deletions
src/sentry/static/sentry/app/components/events/interfaces/breadcrumbs/crumbTable.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import PropTypes from 'prop-types';
import React from 'react';
import _ from 'lodash';
import map from 'lodash/map';
import isObject from 'lodash/isObject';

import Category from 'app/components/events/interfaces/breadcrumbs/category';

Expand All@@ -15,12 +16,12 @@ class CrumbTable extends React.Component {
 if (!this.props.kvData) {
 return null;
 }
 return _.map(this.props.kvData, (val, key) => {
 return map(this.props.kvData, (val, key) => {
 return (
 <tr key={key}>
 <td className="key">{key}</td>
 <td className="value">
 <pre>{_.isObject(val) ? JSON.stringify(val) : val}</pre>
 <pre>{isObject(val) ? JSON.stringify(val) : val}</pre>
 </td>
 </tr>
 );
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
build(webpack): Remove lodash-webpack-plugin#15521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

billyvg
merged 9 commits into

from

Nov 13, 2019
 Merged


build(webpack): Remove lodash-webpack-plugin#15521
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


9 commits


Select commit
Hold shift + click to select a range
fe5fb5d

build(webpack): Remove `lodash-webpack-plugin` [WIP]


billyvg Nov 8, 2019
ae60e9f

wip change import


billyvg Nov 8, 2019
772d088

change lodash imports to be modular


billyvg Nov 8, 2019
2a74310

remove babel-plugin-lodash


billyvg Nov 9, 2019
e8d12df

fix missing import


billyvg Nov 11, 2019
a5c84d1

fix prettier


billyvg Nov 11, 2019
d171663

update tests


billyvg Nov 11, 2019
2e2ebd0

use eslint config that enforces lodash imports


billyvg Nov 12, 2019
88d467a

fix storybook


billyvg Nov 13, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
.storybook/.babelrc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@
 "presets": ["@babel/react", "@babel/env"],
 "plugins": [
 "emotion",
 "lodash",
 "react-hot-loader/babel",
 "@babel/plugin-syntax-dynamic-import",
 "@babel/plugin-proposal-object-rest-spread",
Expand Down

1 change: 0 additions & 1 deletion
babel.config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@ module.exports = {
 presets: ['@babel/react', '@babel/env', '@babel/preset-typescript'],
 plugins: [
 'emotion',
 'lodash',
 'react-hot-loader/babel',
 '@babel/plugin-syntax-dynamic-import',
 '@babel/plugin-proposal-object-rest-spread',
Expand Down

4 changes: 1 addition & 3 deletions
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,7 +44,6 @@
 "babel-loader": "^8.0.0",
 "babel-plugin-add-react-displayname": "^0.0.5",
 "babel-plugin-emotion": "9.2.11",
 "babel-plugin-lodash": "^3.3.4",
 "babel-plugin-transform-react-remove-prop-types": "^0.4.24",
 "bootstrap": "3.4.0",
 "classnames": "2.2.0",
Expand DownExpand Up@@ -76,7 +75,6 @@
 "less": "^3.9.0",
 "less-loader": "^4.1.0",
 "lodash": "^4.17.11",
 "lodash-webpack-plugin": "^0.11.5",
 "marked": "0.6.2",
 "mini-css-extract-plugin": "^v0.5.0",
 "mobx": "^5.13.0",
Expand DownExpand Up@@ -146,7 +144,7 @@
 "enzyme-adapter-react-16": "1.14.0",
 "enzyme-to-json": "3.4.0",
 "eslint": "5.11.1",
 "eslint-config-sentry-app": "1.26.0",
 "eslint-config-sentry-app": "1.27.0",
 "jest": "24.1.0",
 "jest-canvas-mock": "^2.1.0",
 "jest-junit": "^3.4.1",
Expand Down

4 changes: 3 additions & 1 deletion
src/sentry/static/sentry/app/actionCreators/formSearch.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import {flatten, flatMap} from 'lodash';
import flatten from 'lodash/flatten';

import flatMap from 'lodash/flatMap';

import FormSearchActions from 'app/actions/formSearchActions';

Expand Down

4 changes: 3 additions & 1 deletion
src/sentry/static/sentry/app/actionCreators/globalSelection.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import {isEqual, isInteger, omit} from 'lodash';
import isEqual from 'lodash/isEqual';
import isInteger from 'lodash/isInteger';
import omit from 'lodash/omit';
import * as Sentry from '@sentry/browser';

import {defined} from 'app/utils';
Expand Down

4 changes: 3 additions & 1 deletion
src/sentry/static/sentry/app/actionCreators/projects.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import {chunk, debounce} from 'lodash';
import chunk from 'lodash/chunk';

import debounce from 'lodash/debounce';

import {
 addLoadingMessage,
Expand Down

4 changes: 3 additions & 1 deletion
src/sentry/static/sentry/app/api.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import {isUndefined, isNil, get} from 'lodash';
import isUndefined from 'lodash/isUndefined';
import isNil from 'lodash/isNil';
import get from 'lodash/get';
import $ from 'jquery';
import * as Sentry from '@sentry/browser';

Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/activity/note/inputWithStorage.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import _ from 'lodash';
import debounce from 'lodash/debounce';
import PropTypes from 'prop-types';
import React from 'react';
import * as Sentry from '@sentry/browser';
Expand DownExpand Up@@ -75,7 +75,7 @@ class NoteInputWithStorage extends React.Component {
 return onLoad(storageObj[itemKey]);
 };

 save = _.debounce(value => {
 save = debounce(value => {
 const {itemKey, onSave} = this.props;

 const currentObj = this.fetchFromStorage() || {};
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/activity/note/mentionables.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {uniqBy} from 'lodash';
import uniqBy from 'lodash/uniqBy';
import PropTypes from 'prop-types';
import React from 'react';
import Reflux from 'reflux';
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/asyncComponent.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {isEqual} from 'lodash';
import isEqual from 'lodash/isEqual';
import PropTypes from 'prop-types';
import React from 'react';
import {Location} from 'history';
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/asyncComponentSearchInput.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {debounce} from 'lodash';
import debounce from 'lodash/debounce';
import {withRouter} from 'react-router';
import PropTypes from 'prop-types';
import React from 'react';
Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/bases/pluginComponentBase.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
import React from 'react';
import _ from 'lodash';
import isFunction from 'lodash/isFunction';

import {Client} from 'app/api';
import {FormState, GenericField} from 'app/components/forms';
import IndicatorStore from 'app/stores/indicatorStore';
import {t} from 'app/locale';

const callbackWithArgs = function(callback, ...args) {
 if (_.isFunction(callback)) {
 if (isFunction(callback)) {
 callback = callback.bind(this, ...args);
 } else {
 callback = null;
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/button.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@ import PropTypes from 'prop-types';
import React from 'react';
import styled, {css} from 'react-emotion';
import isPropValid from '@emotion/is-prop-valid';
import {pickBy} from 'lodash';
import pickBy from 'lodash/pickBy';

import ExternalLink from 'app/components/links/externalLink';
import InlineSvg from 'app/components/inlineSvg';
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/charts/components/tooltip.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import 'echarts/lib/component/tooltip';

import {get} from 'lodash';
import get from 'lodash/get';
import {getFormattedDate} from 'app/utils/dates';
import {truncationFormatter} from '../utils';

Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/charts/releaseSeries.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@ import {withRouter} from 'react-router';
import PropTypes from 'prop-types';
import React from 'react';
import moment from 'moment';
import {isEqual} from 'lodash';
import isEqual from 'lodash/isEqual';

import {addErrorMessage} from 'app/actionCreators/indicator';
import {getUserTimezone} from 'app/utils/dates';
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/charts/worldMapChart.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {max} from 'lodash';
import max from 'lodash/max';
import PropTypes from 'prop-types';
import React from 'react';

Expand Down

12 changes: 7 additions & 5 deletions
src/sentry/static/sentry/app/components/contextData.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,9 @@ import React from 'react';

import classNames from 'classnames';

import _ from 'lodash';
import isString from 'lodash/isString';
import isNumber from 'lodash/isNumber';
import isArray from 'lodash/isArray';

import {isUrl} from 'app/utils';

Expand DownExpand Up@@ -116,7 +118,7 @@ class ContextData extends React.Component {
 return <span className="val-null">{'None'}</span>;
 } else if (value === true || value === false) {
 return <span className="val-bool">{value ? 'True' : 'False'}</span>;
 } else if (_.isString(value)) {
 } else if (isString(value)) {
 const valueInfo = analyzeStringForRepr(value);

 const out = [
Expand All@@ -141,9 +143,9 @@ class ContextData extends React.Component {
 }

 return out;
 } else if (_.isNumber(value)) {
 } else if (isNumber(value)) {
 return <span className="val-number">{value}</span>;
 } else if (_.isArray(value)) {
 } else if (isArray(value)) {
 for (i = 0; i < value.length; i++) {
 children.push(
 <span className="val-array-item" key={i}>
Expand DownExpand Up@@ -204,7 +206,7 @@ class ContextData extends React.Component {
 };

 renderKeyPosValue = value => {
 if (_.isString(value)) {
 if (isString(value)) {
 return <span className="val-string">{value}</span>;
 }
 return this.renderValue(value);
Expand Down

1 change: 0 additions & 1 deletion
src/sentry/static/sentry/app/components/dateTime.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
import PropTypes from 'prop-types';
import React from 'react';
import moment from 'moment-timezone';
import _ from 'lodash';

import ConfigStore from 'app/stores/configStore';

Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/dropdownAutoCompleteMenu.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import {AutoSizer, List} from 'react-virtualized';
import PropTypes from 'prop-types';
import React from 'react';
import _ from 'lodash';
import flatMap from 'lodash/flatMap';
import styled from 'react-emotion';

import {t} from 'app/locale';
Expand DownExpand Up@@ -202,7 +202,7 @@ class DropdownAutoCompleteMenu extends React.Component {

 if (items[0] && items[0].items) {
 //if the first item has children, we assume it is a group
 return _.flatMap(this.filterGroupedItems(items, inputValue), item => {
 return flatMap(this.filterGroupedItems(items, inputValue), item => {
 const groupItems = item.items.map(groupedItem => ({
 ...groupedItem,
 index: itemCount++,
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/dropdownButton.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@ import React from 'react';
import styled from 'react-emotion';
import Button from 'app/components/button';
import InlineSvg from 'app/components/inlineSvg';
import {omit} from 'lodash';
import omit from 'lodash/omit';

class DropdownButton extends React.Component {
 static propTypes = {
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/eventOrGroupHeader.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@ import React from 'react';
import {withRouter} from 'react-router';
import styled, {css} from 'react-emotion';
import classNames from 'classnames';
import {capitalize} from 'lodash';
import capitalize from 'lodash/capitalize';

import SentryTypes from 'app/sentryTypes';
import EventOrGroupTitle from 'app/components/eventOrGroupTitle';
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/events/contexts.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import PropTypes from 'prop-types';
import React from 'react';

import {get} from 'lodash';
import get from 'lodash/get';
import {objectIsEmpty, toTitleCase, defined} from 'app/utils';
import EventDataSection from 'app/components/events/eventDataSection';
import plugins from 'app/plugins';
Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/events/contexts/contextBlock.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import PropTypes from 'prop-types';
import React from 'react';
import _ from 'lodash';
import sortBy from 'lodash/sortBy';

import {defined} from 'app/utils';
import ErrorBoundary from 'app/components/errorBoundary';
Expand DownExpand Up@@ -39,7 +39,7 @@ class ContextBlock extends React.Component {
 }

 if (extraData.length > 0) {
 data = data.concat(_.sortBy(extraData, (key, value) => key));
 data = data.concat(sortBy(extraData, (key, value) => key));
 }

 return (
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/events/contexts/device.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {isString} from 'lodash';
import isString from 'lodash/isString';
import PropTypes from 'prop-types';
import React from 'react';

Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/events/contexts/user.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
/*eslint react/jsx-key:0*/
import PropTypes from 'prop-types';
import React from 'react';
import _ from 'lodash';
import each from 'lodash/each';

import Avatar from 'app/components/avatar';
import ErrorBoundary from 'app/components/errorBoundary';
Expand DownExpand Up@@ -40,7 +40,7 @@ class UserContextType extends React.Component {
 user.name && builtins.push(['Name', <pre>{user.name}</pre>]);

 // We also attach user supplied data as 'user.data'
_.each(user.data, function(value, key) {
 each(user.data, function(value, key) {
 children.push([key, value]);
 });

Expand Down

8 changes: 5 additions & 3 deletions
src/sentry/static/sentry/app/components/events/errorItem.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import _ from 'lodash';
import mapKeys from 'lodash/mapKeys';
import startCase from 'lodash/startCase';
import isEmpty from 'lodash/isEmpty';
import React from 'react';
import KeyValueList from 'app/components/events/interfaces/keyValueList';
import {t} from 'app/locale';
Expand DownExpand Up@@ -51,7 +53,7 @@ class EventErrorItem extends React.Component {
 data.image_path = path.length ? path.join(separator) + separator : '';
 }

 return _.mapKeys(data, (value, key) => t(keyMapping[key] || _.startCase(key)));
 return mapKeys(data, (value, key) => t(keyMapping[key] || startCase(key)));
 }

 renderPath() {
Expand All@@ -77,7 +79,7 @@ class EventErrorItem extends React.Component {
 <li>
 {this.renderPath()}
 {error.message}
 {!_.isEmpty(data) && (
 {!isEmpty(data) && (
 <small>
 {' '}
 <a style={{marginLeft: 10}} onClick={this.toggle}>
Expand Down

5 changes: 3 additions & 2 deletions
src/sentry/static/sentry/app/components/events/errors.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
import React from 'react';
import _ from 'lodash';
import uniqWith from 'lodash/uniqWith';
import isEqual from 'lodash/isEqual';

import EventDataSection from 'app/components/events/eventDataSection';
import EventErrorItem from 'app/components/events/errorItem';
Expand DownExpand Up@@ -32,7 +33,7 @@ class EventErrors extends React.Component {
 };

 uniqueErrors = errors => {
 return _.uniqWith(errors, _.isEqual);
 return uniqWith(errors, isEqual);
 };

 render() {
Expand Down

3 changes: 2 additions & 1 deletion
src/sentry/static/sentry/app/components/events/eventCause.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import PropTypes from 'prop-types';
import React from 'react';
import {uniqBy, flatMap} from 'lodash';
import uniqBy from 'lodash/uniqBy';
import flatMap from 'lodash/flatMap';
import styled from 'react-emotion';

import CommitRow from 'app/components/commitRow';
Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/events/eventTags.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import React from 'react';
import {Link} from 'react-router';
import _ from 'lodash';
import isEmpty from 'lodash/isEmpty';
import queryString from 'query-string';

import {Location} from 'history';
Expand DownExpand Up@@ -75,7 +75,7 @@ class EventTags extends React.Component<EventTagsProps> {
 const {event, orgId, hideGuide} = this.props;
 const {tags} = event;

 if (_.isEmpty(tags)) {
 if (isEmpty(tags)) {
 return null;
 }

Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/events/groupingInfo.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import React from 'react';
import PropTypes from 'prop-types';
import styled from 'react-emotion';
import {isObject} from 'lodash';
import isObject from 'lodash/isObject';
import AsyncComponent from 'app/components/asyncComponent';
import DropdownAutoComplete from 'app/components/dropdownAutoComplete';
import DropdownButton from 'app/components/dropdownButton';
Expand Down

7 changes: 4 additions & 3 deletions
src/sentry/static/sentry/app/components/events/interfaces/breadcrumbs/crumbTable.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import PropTypes from 'prop-types';
import React from 'react';
import _ from 'lodash';
import map from 'lodash/map';
import isObject from 'lodash/isObject';

import Category from 'app/components/events/interfaces/breadcrumbs/category';

Expand All@@ -15,12 +16,12 @@ class CrumbTable extends React.Component {
 if (!this.props.kvData) {
 return null;
 }
 return _.map(this.props.kvData, (val, key) => {
 return map(this.props.kvData, (val, key) => {
 return (
 <tr key={key}>
 <td className="key">{key}</td>
 <td className="value">
 <pre>{_.isObject(val) ? JSON.stringify(val) : val}</pre>
 <pre>{isObject(val) ? JSON.stringify(val) : val}</pre>
 </td>
 </tr>
 );
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
build(webpack): Remove lodash-webpack-plugin#15521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

billyvg
merged 9 commits into

from

Nov 13, 2019
 Merged


build(webpack): Remove lodash-webpack-plugin#15521
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


9 commits


Select commit
Hold shift + click to select a range
fe5fb5d

build(webpack): Remove `lodash-webpack-plugin` [WIP]


billyvg Nov 8, 2019
ae60e9f

wip change import


billyvg Nov 8, 2019
772d088

change lodash imports to be modular


billyvg Nov 8, 2019
2a74310

remove babel-plugin-lodash


billyvg Nov 9, 2019
e8d12df

fix missing import


billyvg Nov 11, 2019
a5c84d1

fix prettier


billyvg Nov 11, 2019
d171663

update tests


billyvg Nov 11, 2019
2e2ebd0

use eslint config that enforces lodash imports


billyvg Nov 12, 2019
88d467a

fix storybook


billyvg Nov 13, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
.storybook/.babelrc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@
 "presets": ["@babel/react", "@babel/env"],
 "plugins": [
 "emotion",
 "lodash",
 "react-hot-loader/babel",
 "@babel/plugin-syntax-dynamic-import",
 "@babel/plugin-proposal-object-rest-spread",
Expand Down

1 change: 0 additions & 1 deletion
babel.config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@ module.exports = {
 presets: ['@babel/react', '@babel/env', '@babel/preset-typescript'],
 plugins: [
 'emotion',
 'lodash',
 'react-hot-loader/babel',
 '@babel/plugin-syntax-dynamic-import',
 '@babel/plugin-proposal-object-rest-spread',
Expand Down

4 changes: 1 addition & 3 deletions
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,7 +44,6 @@
 "babel-loader": "^8.0.0",
 "babel-plugin-add-react-displayname": "^0.0.5",
 "babel-plugin-emotion": "9.2.11",
 "babel-plugin-lodash": "^3.3.4",
 "babel-plugin-transform-react-remove-prop-types": "^0.4.24",
 "bootstrap": "3.4.0",
 "classnames": "2.2.0",
Expand DownExpand Up@@ -76,7 +75,6 @@
 "less": "^3.9.0",
 "less-loader": "^4.1.0",
 "lodash": "^4.17.11",
 "lodash-webpack-plugin": "^0.11.5",
 "marked": "0.6.2",
 "mini-css-extract-plugin": "^v0.5.0",
 "mobx": "^5.13.0",
Expand DownExpand Up@@ -146,7 +144,7 @@
 "enzyme-adapter-react-16": "1.14.0",
 "enzyme-to-json": "3.4.0",
 "eslint": "5.11.1",
 "eslint-config-sentry-app": "1.26.0",
 "eslint-config-sentry-app": "1.27.0",
 "jest": "24.1.0",
 "jest-canvas-mock": "^2.1.0",
 "jest-junit": "^3.4.1",
Expand Down

4 changes: 3 additions & 1 deletion
src/sentry/static/sentry/app/actionCreators/formSearch.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import {flatten, flatMap} from 'lodash';
import flatten from 'lodash/flatten';

import flatMap from 'lodash/flatMap';

import FormSearchActions from 'app/actions/formSearchActions';

Expand Down

4 changes: 3 additions & 1 deletion
src/sentry/static/sentry/app/actionCreators/globalSelection.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import {isEqual, isInteger, omit} from 'lodash';
import isEqual from 'lodash/isEqual';
import isInteger from 'lodash/isInteger';
import omit from 'lodash/omit';
import * as Sentry from '@sentry/browser';

import {defined} from 'app/utils';
Expand Down

4 changes: 3 additions & 1 deletion
src/sentry/static/sentry/app/actionCreators/projects.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import {chunk, debounce} from 'lodash';
import chunk from 'lodash/chunk';

import debounce from 'lodash/debounce';

import {
 addLoadingMessage,
Expand Down

4 changes: 3 additions & 1 deletion
src/sentry/static/sentry/app/api.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import {isUndefined, isNil, get} from 'lodash';
import isUndefined from 'lodash/isUndefined';
import isNil from 'lodash/isNil';
import get from 'lodash/get';
import $ from 'jquery';
import * as Sentry from '@sentry/browser';

Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/activity/note/inputWithStorage.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import _ from 'lodash';
import debounce from 'lodash/debounce';
import PropTypes from 'prop-types';
import React from 'react';
import * as Sentry from '@sentry/browser';
Expand DownExpand Up@@ -75,7 +75,7 @@ class NoteInputWithStorage extends React.Component {
 return onLoad(storageObj[itemKey]);
 };

 save = _.debounce(value => {
 save = debounce(value => {
 const {itemKey, onSave} = this.props;

 const currentObj = this.fetchFromStorage() || {};
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/activity/note/mentionables.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {uniqBy} from 'lodash';
import uniqBy from 'lodash/uniqBy';
import PropTypes from 'prop-types';
import React from 'react';
import Reflux from 'reflux';
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/asyncComponent.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {isEqual} from 'lodash';
import isEqual from 'lodash/isEqual';
import PropTypes from 'prop-types';
import React from 'react';
import {Location} from 'history';
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/asyncComponentSearchInput.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {debounce} from 'lodash';
import debounce from 'lodash/debounce';
import {withRouter} from 'react-router';
import PropTypes from 'prop-types';
import React from 'react';
Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/bases/pluginComponentBase.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
import React from 'react';
import _ from 'lodash';
import isFunction from 'lodash/isFunction';

import {Client} from 'app/api';
import {FormState, GenericField} from 'app/components/forms';
import IndicatorStore from 'app/stores/indicatorStore';
import {t} from 'app/locale';

const callbackWithArgs = function(callback, ...args) {
 if (_.isFunction(callback)) {
 if (isFunction(callback)) {
 callback = callback.bind(this, ...args);
 } else {
 callback = null;
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/button.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@ import PropTypes from 'prop-types';
import React from 'react';
import styled, {css} from 'react-emotion';
import isPropValid from '@emotion/is-prop-valid';
import {pickBy} from 'lodash';
import pickBy from 'lodash/pickBy';

import ExternalLink from 'app/components/links/externalLink';
import InlineSvg from 'app/components/inlineSvg';
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/charts/components/tooltip.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import 'echarts/lib/component/tooltip';

import {get} from 'lodash';
import get from 'lodash/get';
import {getFormattedDate} from 'app/utils/dates';
import {truncationFormatter} from '../utils';

Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/charts/releaseSeries.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@ import {withRouter} from 'react-router';
import PropTypes from 'prop-types';
import React from 'react';
import moment from 'moment';
import {isEqual} from 'lodash';
import isEqual from 'lodash/isEqual';

import {addErrorMessage} from 'app/actionCreators/indicator';
import {getUserTimezone} from 'app/utils/dates';
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/charts/worldMapChart.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {max} from 'lodash';
import max from 'lodash/max';
import PropTypes from 'prop-types';
import React from 'react';

Expand Down

12 changes: 7 additions & 5 deletions
src/sentry/static/sentry/app/components/contextData.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,9 @@ import React from 'react';

import classNames from 'classnames';

import _ from 'lodash';
import isString from 'lodash/isString';
import isNumber from 'lodash/isNumber';
import isArray from 'lodash/isArray';

import {isUrl} from 'app/utils';

Expand DownExpand Up@@ -116,7 +118,7 @@ class ContextData extends React.Component {
 return <span className="val-null">{'None'}</span>;
 } else if (value === true || value === false) {
 return <span className="val-bool">{value ? 'True' : 'False'}</span>;
 } else if (_.isString(value)) {
 } else if (isString(value)) {
 const valueInfo = analyzeStringForRepr(value);

 const out = [
Expand All@@ -141,9 +143,9 @@ class ContextData extends React.Component {
 }

 return out;
 } else if (_.isNumber(value)) {
 } else if (isNumber(value)) {
 return <span className="val-number">{value}</span>;
 } else if (_.isArray(value)) {
 } else if (isArray(value)) {
 for (i = 0; i < value.length; i++) {
 children.push(
 <span className="val-array-item" key={i}>
Expand DownExpand Up@@ -204,7 +206,7 @@ class ContextData extends React.Component {
 };

 renderKeyPosValue = value => {
 if (_.isString(value)) {
 if (isString(value)) {
 return <span className="val-string">{value}</span>;
 }
 return this.renderValue(value);
Expand Down

1 change: 0 additions & 1 deletion
src/sentry/static/sentry/app/components/dateTime.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
import PropTypes from 'prop-types';
import React from 'react';
import moment from 'moment-timezone';
import _ from 'lodash';

import ConfigStore from 'app/stores/configStore';

Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/dropdownAutoCompleteMenu.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import {AutoSizer, List} from 'react-virtualized';
import PropTypes from 'prop-types';
import React from 'react';
import _ from 'lodash';
import flatMap from 'lodash/flatMap';
import styled from 'react-emotion';

import {t} from 'app/locale';
Expand DownExpand Up@@ -202,7 +202,7 @@ class DropdownAutoCompleteMenu extends React.Component {

 if (items[0] && items[0].items) {
 //if the first item has children, we assume it is a group
 return _.flatMap(this.filterGroupedItems(items, inputValue), item => {
 return flatMap(this.filterGroupedItems(items, inputValue), item => {
 const groupItems = item.items.map(groupedItem => ({
 ...groupedItem,
 index: itemCount++,
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/dropdownButton.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@ import React from 'react';
import styled from 'react-emotion';
import Button from 'app/components/button';
import InlineSvg from 'app/components/inlineSvg';
import {omit} from 'lodash';
import omit from 'lodash/omit';

class DropdownButton extends React.Component {
 static propTypes = {
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/eventOrGroupHeader.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@ import React from 'react';
import {withRouter} from 'react-router';
import styled, {css} from 'react-emotion';
import classNames from 'classnames';
import {capitalize} from 'lodash';
import capitalize from 'lodash/capitalize';

import SentryTypes from 'app/sentryTypes';
import EventOrGroupTitle from 'app/components/eventOrGroupTitle';
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/events/contexts.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import PropTypes from 'prop-types';
import React from 'react';

import {get} from 'lodash';
import get from 'lodash/get';
import {objectIsEmpty, toTitleCase, defined} from 'app/utils';
import EventDataSection from 'app/components/events/eventDataSection';
import plugins from 'app/plugins';
Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/events/contexts/contextBlock.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import PropTypes from 'prop-types';
import React from 'react';
import _ from 'lodash';
import sortBy from 'lodash/sortBy';

import {defined} from 'app/utils';
import ErrorBoundary from 'app/components/errorBoundary';
Expand DownExpand Up@@ -39,7 +39,7 @@ class ContextBlock extends React.Component {
 }

 if (extraData.length > 0) {
 data = data.concat(_.sortBy(extraData, (key, value) => key));
 data = data.concat(sortBy(extraData, (key, value) => key));
 }

 return (
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/events/contexts/device.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {isString} from 'lodash';
import isString from 'lodash/isString';
import PropTypes from 'prop-types';
import React from 'react';

Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/events/contexts/user.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
/*eslint react/jsx-key:0*/
import PropTypes from 'prop-types';
import React from 'react';
import _ from 'lodash';
import each from 'lodash/each';

import Avatar from 'app/components/avatar';
import ErrorBoundary from 'app/components/errorBoundary';
Expand DownExpand Up@@ -40,7 +40,7 @@ class UserContextType extends React.Component {
 user.name && builtins.push(['Name', <pre>{user.name}</pre>]);

 // We also attach user supplied data as 'user.data'
_.each(user.data, function(value, key) {
 each(user.data, function(value, key) {
 children.push([key, value]);
 });

Expand Down

8 changes: 5 additions & 3 deletions
src/sentry/static/sentry/app/components/events/errorItem.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import _ from 'lodash';
import mapKeys from 'lodash/mapKeys';
import startCase from 'lodash/startCase';
import isEmpty from 'lodash/isEmpty';
import React from 'react';
import KeyValueList from 'app/components/events/interfaces/keyValueList';
import {t} from 'app/locale';
Expand DownExpand Up@@ -51,7 +53,7 @@ class EventErrorItem extends React.Component {
 data.image_path = path.length ? path.join(separator) + separator : '';
 }

 return _.mapKeys(data, (value, key) => t(keyMapping[key] || _.startCase(key)));
 return mapKeys(data, (value, key) => t(keyMapping[key] || startCase(key)));
 }

 renderPath() {
Expand All@@ -77,7 +79,7 @@ class EventErrorItem extends React.Component {
 <li>
 {this.renderPath()}
 {error.message}
 {!_.isEmpty(data) && (
 {!isEmpty(data) && (
 <small>
 {' '}
 <a style={{marginLeft: 10}} onClick={this.toggle}>
Expand Down

5 changes: 3 additions & 2 deletions
src/sentry/static/sentry/app/components/events/errors.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
import React from 'react';
import _ from 'lodash';
import uniqWith from 'lodash/uniqWith';
import isEqual from 'lodash/isEqual';

import EventDataSection from 'app/components/events/eventDataSection';
import EventErrorItem from 'app/components/events/errorItem';
Expand DownExpand Up@@ -32,7 +33,7 @@ class EventErrors extends React.Component {
 };

 uniqueErrors = errors => {
 return _.uniqWith(errors, _.isEqual);
 return uniqWith(errors, isEqual);
 };

 render() {
Expand Down

3 changes: 2 additions & 1 deletion
src/sentry/static/sentry/app/components/events/eventCause.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import PropTypes from 'prop-types';
import React from 'react';
import {uniqBy, flatMap} from 'lodash';
import uniqBy from 'lodash/uniqBy';
import flatMap from 'lodash/flatMap';
import styled from 'react-emotion';

import CommitRow from 'app/components/commitRow';
Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/events/eventTags.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import React from 'react';
import {Link} from 'react-router';
import _ from 'lodash';
import isEmpty from 'lodash/isEmpty';
import queryString from 'query-string';

import {Location} from 'history';
Expand DownExpand Up@@ -75,7 +75,7 @@ class EventTags extends React.Component<EventTagsProps> {
 const {event, orgId, hideGuide} = this.props;
 const {tags} = event;

 if (_.isEmpty(tags)) {
 if (isEmpty(tags)) {
 return null;
 }

Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/events/groupingInfo.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import React from 'react';
import PropTypes from 'prop-types';
import styled from 'react-emotion';
import {isObject} from 'lodash';
import isObject from 'lodash/isObject';
import AsyncComponent from 'app/components/asyncComponent';
import DropdownAutoComplete from 'app/components/dropdownAutoComplete';
import DropdownButton from 'app/components/dropdownButton';
Expand Down

7 changes: 4 additions & 3 deletions
src/sentry/static/sentry/app/components/events/interfaces/breadcrumbs/crumbTable.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import PropTypes from 'prop-types';
import React from 'react';
import _ from 'lodash';
import map from 'lodash/map';
import isObject from 'lodash/isObject';

import Category from 'app/components/events/interfaces/breadcrumbs/category';

Expand All@@ -15,12 +16,12 @@ class CrumbTable extends React.Component {
 if (!this.props.kvData) {
 return null;
 }
 return _.map(this.props.kvData, (val, key) => {
 return map(this.props.kvData, (val, key) => {
 return (
 <tr key={key}>
 <td className="key">{key}</td>
 <td className="value">
 <pre>{_.isObject(val) ? JSON.stringify(val) : val}</pre>
 <pre>{isObject(val) ? JSON.stringify(val) : val}</pre>
 </td>
 </tr>
 );
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
build(webpack): Remove lodash-webpack-plugin#15521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

billyvg
merged 9 commits into

from

Nov 13, 2019
 Merged


build(webpack): Remove lodash-webpack-plugin#15521
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


9 commits


Select commit
Hold shift + click to select a range
fe5fb5d

build(webpack): Remove `lodash-webpack-plugin` [WIP]


billyvg Nov 8, 2019
ae60e9f

wip change import


billyvg Nov 8, 2019
772d088

change lodash imports to be modular


billyvg Nov 8, 2019
2a74310

remove babel-plugin-lodash


billyvg Nov 9, 2019
e8d12df

fix missing import


billyvg Nov 11, 2019
a5c84d1

fix prettier


billyvg Nov 11, 2019
d171663

update tests


billyvg Nov 11, 2019
2e2ebd0

use eslint config that enforces lodash imports


billyvg Nov 12, 2019
88d467a

fix storybook


billyvg Nov 13, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
.storybook/.babelrc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@
 "presets": ["@babel/react", "@babel/env"],
 "plugins": [
 "emotion",
 "lodash",
 "react-hot-loader/babel",
 "@babel/plugin-syntax-dynamic-import",
 "@babel/plugin-proposal-object-rest-spread",
Expand Down

1 change: 0 additions & 1 deletion
babel.config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@ module.exports = {
 presets: ['@babel/react', '@babel/env', '@babel/preset-typescript'],
 plugins: [
 'emotion',
 'lodash',
 'react-hot-loader/babel',
 '@babel/plugin-syntax-dynamic-import',
 '@babel/plugin-proposal-object-rest-spread',
Expand Down

4 changes: 1 addition & 3 deletions
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,7 +44,6 @@
 "babel-loader": "^8.0.0",
 "babel-plugin-add-react-displayname": "^0.0.5",
 "babel-plugin-emotion": "9.2.11",
 "babel-plugin-lodash": "^3.3.4",
 "babel-plugin-transform-react-remove-prop-types": "^0.4.24",
 "bootstrap": "3.4.0",
 "classnames": "2.2.0",
Expand DownExpand Up@@ -76,7 +75,6 @@
 "less": "^3.9.0",
 "less-loader": "^4.1.0",
 "lodash": "^4.17.11",
 "lodash-webpack-plugin": "^0.11.5",
 "marked": "0.6.2",
 "mini-css-extract-plugin": "^v0.5.0",
 "mobx": "^5.13.0",
Expand DownExpand Up@@ -146,7 +144,7 @@
 "enzyme-adapter-react-16": "1.14.0",
 "enzyme-to-json": "3.4.0",
 "eslint": "5.11.1",
 "eslint-config-sentry-app": "1.26.0",
 "eslint-config-sentry-app": "1.27.0",
 "jest": "24.1.0",
 "jest-canvas-mock": "^2.1.0",
 "jest-junit": "^3.4.1",
Expand Down

4 changes: 3 additions & 1 deletion
src/sentry/static/sentry/app/actionCreators/formSearch.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import {flatten, flatMap} from 'lodash';
import flatten from 'lodash/flatten';

import flatMap from 'lodash/flatMap';

import FormSearchActions from 'app/actions/formSearchActions';

Expand Down

4 changes: 3 additions & 1 deletion
src/sentry/static/sentry/app/actionCreators/globalSelection.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import {isEqual, isInteger, omit} from 'lodash';
import isEqual from 'lodash/isEqual';
import isInteger from 'lodash/isInteger';
import omit from 'lodash/omit';
import * as Sentry from '@sentry/browser';

import {defined} from 'app/utils';
Expand Down

4 changes: 3 additions & 1 deletion
src/sentry/static/sentry/app/actionCreators/projects.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import {chunk, debounce} from 'lodash';
import chunk from 'lodash/chunk';

import debounce from 'lodash/debounce';

import {
 addLoadingMessage,
Expand Down

4 changes: 3 additions & 1 deletion
src/sentry/static/sentry/app/api.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import {isUndefined, isNil, get} from 'lodash';
import isUndefined from 'lodash/isUndefined';
import isNil from 'lodash/isNil';
import get from 'lodash/get';
import $ from 'jquery';
import * as Sentry from '@sentry/browser';

Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/activity/note/inputWithStorage.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import _ from 'lodash';
import debounce from 'lodash/debounce';
import PropTypes from 'prop-types';
import React from 'react';
import * as Sentry from '@sentry/browser';
Expand DownExpand Up@@ -75,7 +75,7 @@ class NoteInputWithStorage extends React.Component {
 return onLoad(storageObj[itemKey]);
 };

 save = _.debounce(value => {
 save = debounce(value => {
 const {itemKey, onSave} = this.props;

 const currentObj = this.fetchFromStorage() || {};
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/activity/note/mentionables.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {uniqBy} from 'lodash';
import uniqBy from 'lodash/uniqBy';
import PropTypes from 'prop-types';
import React from 'react';
import Reflux from 'reflux';
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/asyncComponent.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {isEqual} from 'lodash';
import isEqual from 'lodash/isEqual';
import PropTypes from 'prop-types';
import React from 'react';
import {Location} from 'history';
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/asyncComponentSearchInput.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {debounce} from 'lodash';
import debounce from 'lodash/debounce';
import {withRouter} from 'react-router';
import PropTypes from 'prop-types';
import React from 'react';
Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/bases/pluginComponentBase.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
import React from 'react';
import _ from 'lodash';
import isFunction from 'lodash/isFunction';

import {Client} from 'app/api';
import {FormState, GenericField} from 'app/components/forms';
import IndicatorStore from 'app/stores/indicatorStore';
import {t} from 'app/locale';

const callbackWithArgs = function(callback, ...args) {
 if (_.isFunction(callback)) {
 if (isFunction(callback)) {
 callback = callback.bind(this, ...args);
 } else {
 callback = null;
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/button.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@ import PropTypes from 'prop-types';
import React from 'react';
import styled, {css} from 'react-emotion';
import isPropValid from '@emotion/is-prop-valid';
import {pickBy} from 'lodash';
import pickBy from 'lodash/pickBy';

import ExternalLink from 'app/components/links/externalLink';
import InlineSvg from 'app/components/inlineSvg';
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/charts/components/tooltip.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import 'echarts/lib/component/tooltip';

import {get} from 'lodash';
import get from 'lodash/get';
import {getFormattedDate} from 'app/utils/dates';
import {truncationFormatter} from '../utils';

Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/charts/releaseSeries.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@ import {withRouter} from 'react-router';
import PropTypes from 'prop-types';
import React from 'react';
import moment from 'moment';
import {isEqual} from 'lodash';
import isEqual from 'lodash/isEqual';

import {addErrorMessage} from 'app/actionCreators/indicator';
import {getUserTimezone} from 'app/utils/dates';
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/charts/worldMapChart.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {max} from 'lodash';
import max from 'lodash/max';
import PropTypes from 'prop-types';
import React from 'react';

Expand Down

12 changes: 7 additions & 5 deletions
src/sentry/static/sentry/app/components/contextData.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,9 @@ import React from 'react';

import classNames from 'classnames';

import _ from 'lodash';
import isString from 'lodash/isString';
import isNumber from 'lodash/isNumber';
import isArray from 'lodash/isArray';

import {isUrl} from 'app/utils';

Expand DownExpand Up@@ -116,7 +118,7 @@ class ContextData extends React.Component {
 return <span className="val-null">{'None'}</span>;
 } else if (value === true || value === false) {
 return <span className="val-bool">{value ? 'True' : 'False'}</span>;
 } else if (_.isString(value)) {
 } else if (isString(value)) {
 const valueInfo = analyzeStringForRepr(value);

 const out = [
Expand All@@ -141,9 +143,9 @@ class ContextData extends React.Component {
 }

 return out;
 } else if (_.isNumber(value)) {
 } else if (isNumber(value)) {
 return <span className="val-number">{value}</span>;
 } else if (_.isArray(value)) {
 } else if (isArray(value)) {
 for (i = 0; i < value.length; i++) {
 children.push(
 <span className="val-array-item" key={i}>
Expand DownExpand Up@@ -204,7 +206,7 @@ class ContextData extends React.Component {
 };

 renderKeyPosValue = value => {
 if (_.isString(value)) {
 if (isString(value)) {
 return <span className="val-string">{value}</span>;
 }
 return this.renderValue(value);
Expand Down

1 change: 0 additions & 1 deletion
src/sentry/static/sentry/app/components/dateTime.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
import PropTypes from 'prop-types';
import React from 'react';
import moment from 'moment-timezone';
import _ from 'lodash';

import ConfigStore from 'app/stores/configStore';

Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/dropdownAutoCompleteMenu.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import {AutoSizer, List} from 'react-virtualized';
import PropTypes from 'prop-types';
import React from 'react';
import _ from 'lodash';
import flatMap from 'lodash/flatMap';
import styled from 'react-emotion';

import {t} from 'app/locale';
Expand DownExpand Up@@ -202,7 +202,7 @@ class DropdownAutoCompleteMenu extends React.Component {

 if (items[0] && items[0].items) {
 //if the first item has children, we assume it is a group
 return _.flatMap(this.filterGroupedItems(items, inputValue), item => {
 return flatMap(this.filterGroupedItems(items, inputValue), item => {
 const groupItems = item.items.map(groupedItem => ({
 ...groupedItem,
 index: itemCount++,
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/dropdownButton.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@ import React from 'react';
import styled from 'react-emotion';
import Button from 'app/components/button';
import InlineSvg from 'app/components/inlineSvg';
import {omit} from 'lodash';
import omit from 'lodash/omit';

class DropdownButton extends React.Component {
 static propTypes = {
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/eventOrGroupHeader.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@ import React from 'react';
import {withRouter} from 'react-router';
import styled, {css} from 'react-emotion';
import classNames from 'classnames';
import {capitalize} from 'lodash';
import capitalize from 'lodash/capitalize';

import SentryTypes from 'app/sentryTypes';
import EventOrGroupTitle from 'app/components/eventOrGroupTitle';
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/events/contexts.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import PropTypes from 'prop-types';
import React from 'react';

import {get} from 'lodash';
import get from 'lodash/get';
import {objectIsEmpty, toTitleCase, defined} from 'app/utils';
import EventDataSection from 'app/components/events/eventDataSection';
import plugins from 'app/plugins';
Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/events/contexts/contextBlock.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import PropTypes from 'prop-types';
import React from 'react';
import _ from 'lodash';
import sortBy from 'lodash/sortBy';

import {defined} from 'app/utils';
import ErrorBoundary from 'app/components/errorBoundary';
Expand DownExpand Up@@ -39,7 +39,7 @@ class ContextBlock extends React.Component {
 }

 if (extraData.length > 0) {
 data = data.concat(_.sortBy(extraData, (key, value) => key));
 data = data.concat(sortBy(extraData, (key, value) => key));
 }

 return (
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/events/contexts/device.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {isString} from 'lodash';
import isString from 'lodash/isString';
import PropTypes from 'prop-types';
import React from 'react';

Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/events/contexts/user.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
/*eslint react/jsx-key:0*/
import PropTypes from 'prop-types';
import React from 'react';
import _ from 'lodash';
import each from 'lodash/each';

import Avatar from 'app/components/avatar';
import ErrorBoundary from 'app/components/errorBoundary';
Expand DownExpand Up@@ -40,7 +40,7 @@ class UserContextType extends React.Component {
 user.name && builtins.push(['Name', <pre>{user.name}</pre>]);

 // We also attach user supplied data as 'user.data'
_.each(user.data, function(value, key) {
 each(user.data, function(value, key) {
 children.push([key, value]);
 });

Expand Down

8 changes: 5 additions & 3 deletions
src/sentry/static/sentry/app/components/events/errorItem.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import _ from 'lodash';
import mapKeys from 'lodash/mapKeys';
import startCase from 'lodash/startCase';
import isEmpty from 'lodash/isEmpty';
import React from 'react';
import KeyValueList from 'app/components/events/interfaces/keyValueList';
import {t} from 'app/locale';
Expand DownExpand Up@@ -51,7 +53,7 @@ class EventErrorItem extends React.Component {
 data.image_path = path.length ? path.join(separator) + separator : '';
 }

 return _.mapKeys(data, (value, key) => t(keyMapping[key] || _.startCase(key)));
 return mapKeys(data, (value, key) => t(keyMapping[key] || startCase(key)));
 }

 renderPath() {
Expand All@@ -77,7 +79,7 @@ class EventErrorItem extends React.Component {
 <li>
 {this.renderPath()}
 {error.message}
 {!_.isEmpty(data) && (
 {!isEmpty(data) && (
 <small>
 {' '}
 <a style={{marginLeft: 10}} onClick={this.toggle}>
Expand Down

5 changes: 3 additions & 2 deletions
src/sentry/static/sentry/app/components/events/errors.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
import React from 'react';
import _ from 'lodash';
import uniqWith from 'lodash/uniqWith';
import isEqual from 'lodash/isEqual';

import EventDataSection from 'app/components/events/eventDataSection';
import EventErrorItem from 'app/components/events/errorItem';
Expand DownExpand Up@@ -32,7 +33,7 @@ class EventErrors extends React.Component {
 };

 uniqueErrors = errors => {
 return _.uniqWith(errors, _.isEqual);
 return uniqWith(errors, isEqual);
 };

 render() {
Expand Down

3 changes: 2 additions & 1 deletion
src/sentry/static/sentry/app/components/events/eventCause.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import PropTypes from 'prop-types';
import React from 'react';
import {uniqBy, flatMap} from 'lodash';
import uniqBy from 'lodash/uniqBy';
import flatMap from 'lodash/flatMap';
import styled from 'react-emotion';

import CommitRow from 'app/components/commitRow';
Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/events/eventTags.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import React from 'react';
import {Link} from 'react-router';
import _ from 'lodash';
import isEmpty from 'lodash/isEmpty';
import queryString from 'query-string';

import {Location} from 'history';
Expand DownExpand Up@@ -75,7 +75,7 @@ class EventTags extends React.Component<EventTagsProps> {
 const {event, orgId, hideGuide} = this.props;
 const {tags} = event;

 if (_.isEmpty(tags)) {
 if (isEmpty(tags)) {
 return null;
 }

Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/events/groupingInfo.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import React from 'react';
import PropTypes from 'prop-types';
import styled from 'react-emotion';
import {isObject} from 'lodash';
import isObject from 'lodash/isObject';
import AsyncComponent from 'app/components/asyncComponent';
import DropdownAutoComplete from 'app/components/dropdownAutoComplete';
import DropdownButton from 'app/components/dropdownButton';
Expand Down

7 changes: 4 additions & 3 deletions
src/sentry/static/sentry/app/components/events/interfaces/breadcrumbs/crumbTable.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import PropTypes from 'prop-types';
import React from 'react';
import _ from 'lodash';
import map from 'lodash/map';
import isObject from 'lodash/isObject';

import Category from 'app/components/events/interfaces/breadcrumbs/category';

Expand All@@ -15,12 +16,12 @@ class CrumbTable extends React.Component {
 if (!this.props.kvData) {
 return null;
 }
 return _.map(this.props.kvData, (val, key) => {
 return map(this.props.kvData, (val, key) => {
 return (
 <tr key={key}>
 <td className="key">{key}</td>
 <td className="value">
 <pre>{_.isObject(val) ? JSON.stringify(val) : val}</pre>
 <pre>{isObject(val) ? JSON.stringify(val) : val}</pre>
 </td>
 </tr>
 );
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
build(webpack): Remove lodash-webpack-plugin#15521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

billyvg
merged 9 commits into

from

Nov 13, 2019
 Merged


build(webpack): Remove lodash-webpack-plugin#15521
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


9 commits


Select commit
Hold shift + click to select a range
fe5fb5d

build(webpack): Remove `lodash-webpack-plugin` [WIP]


billyvg Nov 8, 2019
ae60e9f

wip change import


billyvg Nov 8, 2019
772d088

change lodash imports to be modular


billyvg Nov 8, 2019
2a74310

remove babel-plugin-lodash


billyvg Nov 9, 2019
e8d12df

fix missing import


billyvg Nov 11, 2019
a5c84d1

fix prettier


billyvg Nov 11, 2019
d171663

update tests


billyvg Nov 11, 2019
2e2ebd0

use eslint config that enforces lodash imports


billyvg Nov 12, 2019
88d467a

fix storybook


billyvg Nov 13, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
.storybook/.babelrc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@
 "presets": ["@babel/react", "@babel/env"],
 "plugins": [
 "emotion",
 "lodash",
 "react-hot-loader/babel",
 "@babel/plugin-syntax-dynamic-import",
 "@babel/plugin-proposal-object-rest-spread",
Expand Down

1 change: 0 additions & 1 deletion
babel.config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@ module.exports = {
 presets: ['@babel/react', '@babel/env', '@babel/preset-typescript'],
 plugins: [
 'emotion',
 'lodash',
 'react-hot-loader/babel',
 '@babel/plugin-syntax-dynamic-import',
 '@babel/plugin-proposal-object-rest-spread',
Expand Down

4 changes: 1 addition & 3 deletions
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,7 +44,6 @@
 "babel-loader": "^8.0.0",
 "babel-plugin-add-react-displayname": "^0.0.5",
 "babel-plugin-emotion": "9.2.11",
 "babel-plugin-lodash": "^3.3.4",
 "babel-plugin-transform-react-remove-prop-types": "^0.4.24",
 "bootstrap": "3.4.0",
 "classnames": "2.2.0",
Expand DownExpand Up@@ -76,7 +75,6 @@
 "less": "^3.9.0",
 "less-loader": "^4.1.0",
 "lodash": "^4.17.11",
 "lodash-webpack-plugin": "^0.11.5",
 "marked": "0.6.2",
 "mini-css-extract-plugin": "^v0.5.0",
 "mobx": "^5.13.0",
Expand DownExpand Up@@ -146,7 +144,7 @@
 "enzyme-adapter-react-16": "1.14.0",
 "enzyme-to-json": "3.4.0",
 "eslint": "5.11.1",
 "eslint-config-sentry-app": "1.26.0",
 "eslint-config-sentry-app": "1.27.0",
 "jest": "24.1.0",
 "jest-canvas-mock": "^2.1.0",
 "jest-junit": "^3.4.1",
Expand Down

4 changes: 3 additions & 1 deletion
src/sentry/static/sentry/app/actionCreators/formSearch.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import {flatten, flatMap} from 'lodash';
import flatten from 'lodash/flatten';

import flatMap from 'lodash/flatMap';

import FormSearchActions from 'app/actions/formSearchActions';

Expand Down

4 changes: 3 additions & 1 deletion
src/sentry/static/sentry/app/actionCreators/globalSelection.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import {isEqual, isInteger, omit} from 'lodash';
import isEqual from 'lodash/isEqual';
import isInteger from 'lodash/isInteger';
import omit from 'lodash/omit';
import * as Sentry from '@sentry/browser';

import {defined} from 'app/utils';
Expand Down

4 changes: 3 additions & 1 deletion
src/sentry/static/sentry/app/actionCreators/projects.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import {chunk, debounce} from 'lodash';
import chunk from 'lodash/chunk';

import debounce from 'lodash/debounce';

import {
 addLoadingMessage,
Expand Down

4 changes: 3 additions & 1 deletion
src/sentry/static/sentry/app/api.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import {isUndefined, isNil, get} from 'lodash';
import isUndefined from 'lodash/isUndefined';
import isNil from 'lodash/isNil';
import get from 'lodash/get';
import $ from 'jquery';
import * as Sentry from '@sentry/browser';

Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/activity/note/inputWithStorage.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import _ from 'lodash';
import debounce from 'lodash/debounce';
import PropTypes from 'prop-types';
import React from 'react';
import * as Sentry from '@sentry/browser';
Expand DownExpand Up@@ -75,7 +75,7 @@ class NoteInputWithStorage extends React.Component {
 return onLoad(storageObj[itemKey]);
 };

 save = _.debounce(value => {
 save = debounce(value => {
 const {itemKey, onSave} = this.props;

 const currentObj = this.fetchFromStorage() || {};
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/activity/note/mentionables.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {uniqBy} from 'lodash';
import uniqBy from 'lodash/uniqBy';
import PropTypes from 'prop-types';
import React from 'react';
import Reflux from 'reflux';
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/asyncComponent.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {isEqual} from 'lodash';
import isEqual from 'lodash/isEqual';
import PropTypes from 'prop-types';
import React from 'react';
import {Location} from 'history';
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/asyncComponentSearchInput.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {debounce} from 'lodash';
import debounce from 'lodash/debounce';
import {withRouter} from 'react-router';
import PropTypes from 'prop-types';
import React from 'react';
Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/bases/pluginComponentBase.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
import React from 'react';
import _ from 'lodash';
import isFunction from 'lodash/isFunction';

import {Client} from 'app/api';
import {FormState, GenericField} from 'app/components/forms';
import IndicatorStore from 'app/stores/indicatorStore';
import {t} from 'app/locale';

const callbackWithArgs = function(callback, ...args) {
 if (_.isFunction(callback)) {
 if (isFunction(callback)) {
 callback = callback.bind(this, ...args);
 } else {
 callback = null;
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/button.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@ import PropTypes from 'prop-types';
import React from 'react';
import styled, {css} from 'react-emotion';
import isPropValid from '@emotion/is-prop-valid';
import {pickBy} from 'lodash';
import pickBy from 'lodash/pickBy';

import ExternalLink from 'app/components/links/externalLink';
import InlineSvg from 'app/components/inlineSvg';
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/charts/components/tooltip.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import 'echarts/lib/component/tooltip';

import {get} from 'lodash';
import get from 'lodash/get';
import {getFormattedDate} from 'app/utils/dates';
import {truncationFormatter} from '../utils';

Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/charts/releaseSeries.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@ import {withRouter} from 'react-router';
import PropTypes from 'prop-types';
import React from 'react';
import moment from 'moment';
import {isEqual} from 'lodash';
import isEqual from 'lodash/isEqual';

import {addErrorMessage} from 'app/actionCreators/indicator';
import {getUserTimezone} from 'app/utils/dates';
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/charts/worldMapChart.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {max} from 'lodash';
import max from 'lodash/max';
import PropTypes from 'prop-types';
import React from 'react';

Expand Down

12 changes: 7 additions & 5 deletions
src/sentry/static/sentry/app/components/contextData.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,9 @@ import React from 'react';

import classNames from 'classnames';

import _ from 'lodash';
import isString from 'lodash/isString';
import isNumber from 'lodash/isNumber';
import isArray from 'lodash/isArray';

import {isUrl} from 'app/utils';

Expand DownExpand Up@@ -116,7 +118,7 @@ class ContextData extends React.Component {
 return <span className="val-null">{'None'}</span>;
 } else if (value === true || value === false) {
 return <span className="val-bool">{value ? 'True' : 'False'}</span>;
 } else if (_.isString(value)) {
 } else if (isString(value)) {
 const valueInfo = analyzeStringForRepr(value);

 const out = [
Expand All@@ -141,9 +143,9 @@ class ContextData extends React.Component {
 }

 return out;
 } else if (_.isNumber(value)) {
 } else if (isNumber(value)) {
 return <span className="val-number">{value}</span>;
 } else if (_.isArray(value)) {
 } else if (isArray(value)) {
 for (i = 0; i < value.length; i++) {
 children.push(
 <span className="val-array-item" key={i}>
Expand DownExpand Up@@ -204,7 +206,7 @@ class ContextData extends React.Component {
 };

 renderKeyPosValue = value => {
 if (_.isString(value)) {
 if (isString(value)) {
 return <span className="val-string">{value}</span>;
 }
 return this.renderValue(value);
Expand Down

1 change: 0 additions & 1 deletion
src/sentry/static/sentry/app/components/dateTime.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
import PropTypes from 'prop-types';
import React from 'react';
import moment from 'moment-timezone';
import _ from 'lodash';

import ConfigStore from 'app/stores/configStore';

Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/dropdownAutoCompleteMenu.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import {AutoSizer, List} from 'react-virtualized';
import PropTypes from 'prop-types';
import React from 'react';
import _ from 'lodash';
import flatMap from 'lodash/flatMap';
import styled from 'react-emotion';

import {t} from 'app/locale';
Expand DownExpand Up@@ -202,7 +202,7 @@ class DropdownAutoCompleteMenu extends React.Component {

 if (items[0] && items[0].items) {
 //if the first item has children, we assume it is a group
 return _.flatMap(this.filterGroupedItems(items, inputValue), item => {
 return flatMap(this.filterGroupedItems(items, inputValue), item => {
 const groupItems = item.items.map(groupedItem => ({
 ...groupedItem,
 index: itemCount++,
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/dropdownButton.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@ import React from 'react';
import styled from 'react-emotion';
import Button from 'app/components/button';
import InlineSvg from 'app/components/inlineSvg';
import {omit} from 'lodash';
import omit from 'lodash/omit';

class DropdownButton extends React.Component {
 static propTypes = {
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/eventOrGroupHeader.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@ import React from 'react';
import {withRouter} from 'react-router';
import styled, {css} from 'react-emotion';
import classNames from 'classnames';
import {capitalize} from 'lodash';
import capitalize from 'lodash/capitalize';

import SentryTypes from 'app/sentryTypes';
import EventOrGroupTitle from 'app/components/eventOrGroupTitle';
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/events/contexts.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import PropTypes from 'prop-types';
import React from 'react';

import {get} from 'lodash';
import get from 'lodash/get';
import {objectIsEmpty, toTitleCase, defined} from 'app/utils';
import EventDataSection from 'app/components/events/eventDataSection';
import plugins from 'app/plugins';
Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/events/contexts/contextBlock.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import PropTypes from 'prop-types';
import React from 'react';
import _ from 'lodash';
import sortBy from 'lodash/sortBy';

import {defined} from 'app/utils';
import ErrorBoundary from 'app/components/errorBoundary';
Expand DownExpand Up@@ -39,7 +39,7 @@ class ContextBlock extends React.Component {
 }

 if (extraData.length > 0) {
 data = data.concat(_.sortBy(extraData, (key, value) => key));
 data = data.concat(sortBy(extraData, (key, value) => key));
 }

 return (
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/events/contexts/device.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {isString} from 'lodash';
import isString from 'lodash/isString';
import PropTypes from 'prop-types';
import React from 'react';

Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/events/contexts/user.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
/*eslint react/jsx-key:0*/
import PropTypes from 'prop-types';
import React from 'react';
import _ from 'lodash';
import each from 'lodash/each';

import Avatar from 'app/components/avatar';
import ErrorBoundary from 'app/components/errorBoundary';
Expand DownExpand Up@@ -40,7 +40,7 @@ class UserContextType extends React.Component {
 user.name && builtins.push(['Name', <pre>{user.name}</pre>]);

 // We also attach user supplied data as 'user.data'
_.each(user.data, function(value, key) {
 each(user.data, function(value, key) {
 children.push([key, value]);
 });

Expand Down

8 changes: 5 additions & 3 deletions
src/sentry/static/sentry/app/components/events/errorItem.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import _ from 'lodash';
import mapKeys from 'lodash/mapKeys';
import startCase from 'lodash/startCase';
import isEmpty from 'lodash/isEmpty';
import React from 'react';
import KeyValueList from 'app/components/events/interfaces/keyValueList';
import {t} from 'app/locale';
Expand DownExpand Up@@ -51,7 +53,7 @@ class EventErrorItem extends React.Component {
 data.image_path = path.length ? path.join(separator) + separator : '';
 }

 return _.mapKeys(data, (value, key) => t(keyMapping[key] || _.startCase(key)));
 return mapKeys(data, (value, key) => t(keyMapping[key] || startCase(key)));
 }

 renderPath() {
Expand All@@ -77,7 +79,7 @@ class EventErrorItem extends React.Component {
 <li>
 {this.renderPath()}
 {error.message}
 {!_.isEmpty(data) && (
 {!isEmpty(data) && (
 <small>
 {' '}
 <a style={{marginLeft: 10}} onClick={this.toggle}>
Expand Down

5 changes: 3 additions & 2 deletions
src/sentry/static/sentry/app/components/events/errors.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
import React from 'react';
import _ from 'lodash';
import uniqWith from 'lodash/uniqWith';
import isEqual from 'lodash/isEqual';

import EventDataSection from 'app/components/events/eventDataSection';
import EventErrorItem from 'app/components/events/errorItem';
Expand DownExpand Up@@ -32,7 +33,7 @@ class EventErrors extends React.Component {
 };

 uniqueErrors = errors => {
 return _.uniqWith(errors, _.isEqual);
 return uniqWith(errors, isEqual);
 };

 render() {
Expand Down

3 changes: 2 additions & 1 deletion
src/sentry/static/sentry/app/components/events/eventCause.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import PropTypes from 'prop-types';
import React from 'react';
import {uniqBy, flatMap} from 'lodash';
import uniqBy from 'lodash/uniqBy';
import flatMap from 'lodash/flatMap';
import styled from 'react-emotion';

import CommitRow from 'app/components/commitRow';
Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/events/eventTags.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import React from 'react';
import {Link} from 'react-router';
import _ from 'lodash';
import isEmpty from 'lodash/isEmpty';
import queryString from 'query-string';

import {Location} from 'history';
Expand DownExpand Up@@ -75,7 +75,7 @@ class EventTags extends React.Component<EventTagsProps> {
 const {event, orgId, hideGuide} = this.props;
 const {tags} = event;

 if (_.isEmpty(tags)) {
 if (isEmpty(tags)) {
 return null;
 }

Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/events/groupingInfo.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import React from 'react';
import PropTypes from 'prop-types';
import styled from 'react-emotion';
import {isObject} from 'lodash';
import isObject from 'lodash/isObject';
import AsyncComponent from 'app/components/asyncComponent';
import DropdownAutoComplete from 'app/components/dropdownAutoComplete';
import DropdownButton from 'app/components/dropdownButton';
Expand Down

7 changes: 4 additions & 3 deletions
src/sentry/static/sentry/app/components/events/interfaces/breadcrumbs/crumbTable.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import PropTypes from 'prop-types';
import React from 'react';
import _ from 'lodash';
import map from 'lodash/map';
import isObject from 'lodash/isObject';

import Category from 'app/components/events/interfaces/breadcrumbs/category';

Expand All@@ -15,12 +16,12 @@ class CrumbTable extends React.Component {
 if (!this.props.kvData) {
 return null;
 }
 return _.map(this.props.kvData, (val, key) => {
 return map(this.props.kvData, (val, key) => {
 return (
 <tr key={key}>
 <td className="key">{key}</td>
 <td className="value">
 <pre>{_.isObject(val) ? JSON.stringify(val) : val}</pre>
 <pre>{isObject(val) ? JSON.stringify(val) : val}</pre>
 </td>
 </tr>
 );
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
build(webpack): Remove lodash-webpack-plugin#15521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

billyvg
merged 9 commits into

from

Nov 13, 2019
 Merged


build(webpack): Remove lodash-webpack-plugin#15521
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


9 commits


Select commit
Hold shift + click to select a range
fe5fb5d

build(webpack): Remove `lodash-webpack-plugin` [WIP]


billyvg Nov 8, 2019
ae60e9f

wip change import


billyvg Nov 8, 2019
772d088

change lodash imports to be modular


billyvg Nov 8, 2019
2a74310

remove babel-plugin-lodash


billyvg Nov 9, 2019
e8d12df

fix missing import


billyvg Nov 11, 2019
a5c84d1

fix prettier


billyvg Nov 11, 2019
d171663

update tests


billyvg Nov 11, 2019
2e2ebd0

use eslint config that enforces lodash imports


billyvg Nov 12, 2019
88d467a

fix storybook


billyvg Nov 13, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
.storybook/.babelrc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@
 "presets": ["@babel/react", "@babel/env"],
 "plugins": [
 "emotion",
 "lodash",
 "react-hot-loader/babel",
 "@babel/plugin-syntax-dynamic-import",
 "@babel/plugin-proposal-object-rest-spread",
Expand Down

1 change: 0 additions & 1 deletion
babel.config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@ module.exports = {
 presets: ['@babel/react', '@babel/env', '@babel/preset-typescript'],
 plugins: [
 'emotion',
 'lodash',
 'react-hot-loader/babel',
 '@babel/plugin-syntax-dynamic-import',
 '@babel/plugin-proposal-object-rest-spread',
Expand Down

4 changes: 1 addition & 3 deletions
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,7 +44,6 @@
 "babel-loader": "^8.0.0",
 "babel-plugin-add-react-displayname": "^0.0.5",
 "babel-plugin-emotion": "9.2.11",
 "babel-plugin-lodash": "^3.3.4",
 "babel-plugin-transform-react-remove-prop-types": "^0.4.24",
 "bootstrap": "3.4.0",
 "classnames": "2.2.0",
Expand DownExpand Up@@ -76,7 +75,6 @@
 "less": "^3.9.0",
 "less-loader": "^4.1.0",
 "lodash": "^4.17.11",
 "lodash-webpack-plugin": "^0.11.5",
 "marked": "0.6.2",
 "mini-css-extract-plugin": "^v0.5.0",
 "mobx": "^5.13.0",
Expand DownExpand Up@@ -146,7 +144,7 @@
 "enzyme-adapter-react-16": "1.14.0",
 "enzyme-to-json": "3.4.0",
 "eslint": "5.11.1",
 "eslint-config-sentry-app": "1.26.0",
 "eslint-config-sentry-app": "1.27.0",
 "jest": "24.1.0",
 "jest-canvas-mock": "^2.1.0",
 "jest-junit": "^3.4.1",
Expand Down

4 changes: 3 additions & 1 deletion
src/sentry/static/sentry/app/actionCreators/formSearch.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import {flatten, flatMap} from 'lodash';
import flatten from 'lodash/flatten';

import flatMap from 'lodash/flatMap';

import FormSearchActions from 'app/actions/formSearchActions';

Expand Down

4 changes: 3 additions & 1 deletion
src/sentry/static/sentry/app/actionCreators/globalSelection.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import {isEqual, isInteger, omit} from 'lodash';
import isEqual from 'lodash/isEqual';
import isInteger from 'lodash/isInteger';
import omit from 'lodash/omit';
import * as Sentry from '@sentry/browser';

import {defined} from 'app/utils';
Expand Down

4 changes: 3 additions & 1 deletion
src/sentry/static/sentry/app/actionCreators/projects.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import {chunk, debounce} from 'lodash';
import chunk from 'lodash/chunk';

import debounce from 'lodash/debounce';

import {
 addLoadingMessage,
Expand Down

4 changes: 3 additions & 1 deletion
src/sentry/static/sentry/app/api.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import {isUndefined, isNil, get} from 'lodash';
import isUndefined from 'lodash/isUndefined';
import isNil from 'lodash/isNil';
import get from 'lodash/get';
import $ from 'jquery';
import * as Sentry from '@sentry/browser';

Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/activity/note/inputWithStorage.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import _ from 'lodash';
import debounce from 'lodash/debounce';
import PropTypes from 'prop-types';
import React from 'react';
import * as Sentry from '@sentry/browser';
Expand DownExpand Up@@ -75,7 +75,7 @@ class NoteInputWithStorage extends React.Component {
 return onLoad(storageObj[itemKey]);
 };

 save = _.debounce(value => {
 save = debounce(value => {
 const {itemKey, onSave} = this.props;

 const currentObj = this.fetchFromStorage() || {};
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/activity/note/mentionables.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {uniqBy} from 'lodash';
import uniqBy from 'lodash/uniqBy';
import PropTypes from 'prop-types';
import React from 'react';
import Reflux from 'reflux';
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/asyncComponent.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {isEqual} from 'lodash';
import isEqual from 'lodash/isEqual';
import PropTypes from 'prop-types';
import React from 'react';
import {Location} from 'history';
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/asyncComponentSearchInput.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {debounce} from 'lodash';
import debounce from 'lodash/debounce';
import {withRouter} from 'react-router';
import PropTypes from 'prop-types';
import React from 'react';
Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/bases/pluginComponentBase.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
import React from 'react';
import _ from 'lodash';
import isFunction from 'lodash/isFunction';

import {Client} from 'app/api';
import {FormState, GenericField} from 'app/components/forms';
import IndicatorStore from 'app/stores/indicatorStore';
import {t} from 'app/locale';

const callbackWithArgs = function(callback, ...args) {
 if (_.isFunction(callback)) {
 if (isFunction(callback)) {
 callback = callback.bind(this, ...args);
 } else {
 callback = null;
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/button.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@ import PropTypes from 'prop-types';
import React from 'react';
import styled, {css} from 'react-emotion';
import isPropValid from '@emotion/is-prop-valid';
import {pickBy} from 'lodash';
import pickBy from 'lodash/pickBy';

import ExternalLink from 'app/components/links/externalLink';
import InlineSvg from 'app/components/inlineSvg';
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/charts/components/tooltip.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import 'echarts/lib/component/tooltip';

import {get} from 'lodash';
import get from 'lodash/get';
import {getFormattedDate} from 'app/utils/dates';
import {truncationFormatter} from '../utils';

Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/charts/releaseSeries.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@ import {withRouter} from 'react-router';
import PropTypes from 'prop-types';
import React from 'react';
import moment from 'moment';
import {isEqual} from 'lodash';
import isEqual from 'lodash/isEqual';

import {addErrorMessage} from 'app/actionCreators/indicator';
import {getUserTimezone} from 'app/utils/dates';
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/charts/worldMapChart.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {max} from 'lodash';
import max from 'lodash/max';
import PropTypes from 'prop-types';
import React from 'react';

Expand Down

12 changes: 7 additions & 5 deletions
src/sentry/static/sentry/app/components/contextData.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,9 @@ import React from 'react';

import classNames from 'classnames';

import _ from 'lodash';
import isString from 'lodash/isString';
import isNumber from 'lodash/isNumber';
import isArray from 'lodash/isArray';

import {isUrl} from 'app/utils';

Expand DownExpand Up@@ -116,7 +118,7 @@ class ContextData extends React.Component {
 return <span className="val-null">{'None'}</span>;
 } else if (value === true || value === false) {
 return <span className="val-bool">{value ? 'True' : 'False'}</span>;
 } else if (_.isString(value)) {
 } else if (isString(value)) {
 const valueInfo = analyzeStringForRepr(value);

 const out = [
Expand All@@ -141,9 +143,9 @@ class ContextData extends React.Component {
 }

 return out;
 } else if (_.isNumber(value)) {
 } else if (isNumber(value)) {
 return <span className="val-number">{value}</span>;
 } else if (_.isArray(value)) {
 } else if (isArray(value)) {
 for (i = 0; i < value.length; i++) {
 children.push(
 <span className="val-array-item" key={i}>
Expand DownExpand Up@@ -204,7 +206,7 @@ class ContextData extends React.Component {
 };

 renderKeyPosValue = value => {
 if (_.isString(value)) {
 if (isString(value)) {
 return <span className="val-string">{value}</span>;
 }
 return this.renderValue(value);
Expand Down

1 change: 0 additions & 1 deletion
src/sentry/static/sentry/app/components/dateTime.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
import PropTypes from 'prop-types';
import React from 'react';
import moment from 'moment-timezone';
import _ from 'lodash';

import ConfigStore from 'app/stores/configStore';

Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/dropdownAutoCompleteMenu.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import {AutoSizer, List} from 'react-virtualized';
import PropTypes from 'prop-types';
import React from 'react';
import _ from 'lodash';
import flatMap from 'lodash/flatMap';
import styled from 'react-emotion';

import {t} from 'app/locale';
Expand DownExpand Up@@ -202,7 +202,7 @@ class DropdownAutoCompleteMenu extends React.Component {

 if (items[0] && items[0].items) {
 //if the first item has children, we assume it is a group
 return _.flatMap(this.filterGroupedItems(items, inputValue), item => {
 return flatMap(this.filterGroupedItems(items, inputValue), item => {
 const groupItems = item.items.map(groupedItem => ({
 ...groupedItem,
 index: itemCount++,
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/dropdownButton.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@ import React from 'react';
import styled from 'react-emotion';
import Button from 'app/components/button';
import InlineSvg from 'app/components/inlineSvg';
import {omit} from 'lodash';
import omit from 'lodash/omit';

class DropdownButton extends React.Component {
 static propTypes = {
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/eventOrGroupHeader.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@ import React from 'react';
import {withRouter} from 'react-router';
import styled, {css} from 'react-emotion';
import classNames from 'classnames';
import {capitalize} from 'lodash';
import capitalize from 'lodash/capitalize';

import SentryTypes from 'app/sentryTypes';
import EventOrGroupTitle from 'app/components/eventOrGroupTitle';
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/events/contexts.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import PropTypes from 'prop-types';
import React from 'react';

import {get} from 'lodash';
import get from 'lodash/get';
import {objectIsEmpty, toTitleCase, defined} from 'app/utils';
import EventDataSection from 'app/components/events/eventDataSection';
import plugins from 'app/plugins';
Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/events/contexts/contextBlock.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import PropTypes from 'prop-types';
import React from 'react';
import _ from 'lodash';
import sortBy from 'lodash/sortBy';

import {defined} from 'app/utils';
import ErrorBoundary from 'app/components/errorBoundary';
Expand DownExpand Up@@ -39,7 +39,7 @@ class ContextBlock extends React.Component {
 }

 if (extraData.length > 0) {
 data = data.concat(_.sortBy(extraData, (key, value) => key));
 data = data.concat(sortBy(extraData, (key, value) => key));
 }

 return (
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/events/contexts/device.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {isString} from 'lodash';
import isString from 'lodash/isString';
import PropTypes from 'prop-types';
import React from 'react';

Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/events/contexts/user.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
/*eslint react/jsx-key:0*/
import PropTypes from 'prop-types';
import React from 'react';
import _ from 'lodash';
import each from 'lodash/each';

import Avatar from 'app/components/avatar';
import ErrorBoundary from 'app/components/errorBoundary';
Expand DownExpand Up@@ -40,7 +40,7 @@ class UserContextType extends React.Component {
 user.name && builtins.push(['Name', <pre>{user.name}</pre>]);

 // We also attach user supplied data as 'user.data'
_.each(user.data, function(value, key) {
 each(user.data, function(value, key) {
 children.push([key, value]);
 });

Expand Down

8 changes: 5 additions & 3 deletions
src/sentry/static/sentry/app/components/events/errorItem.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import _ from 'lodash';
import mapKeys from 'lodash/mapKeys';
import startCase from 'lodash/startCase';
import isEmpty from 'lodash/isEmpty';
import React from 'react';
import KeyValueList from 'app/components/events/interfaces/keyValueList';
import {t} from 'app/locale';
Expand DownExpand Up@@ -51,7 +53,7 @@ class EventErrorItem extends React.Component {
 data.image_path = path.length ? path.join(separator) + separator : '';
 }

 return _.mapKeys(data, (value, key) => t(keyMapping[key] || _.startCase(key)));
 return mapKeys(data, (value, key) => t(keyMapping[key] || startCase(key)));
 }

 renderPath() {
Expand All@@ -77,7 +79,7 @@ class EventErrorItem extends React.Component {
 <li>
 {this.renderPath()}
 {error.message}
 {!_.isEmpty(data) && (
 {!isEmpty(data) && (
 <small>
 {' '}
 <a style={{marginLeft: 10}} onClick={this.toggle}>
Expand Down

5 changes: 3 additions & 2 deletions
src/sentry/static/sentry/app/components/events/errors.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
import React from 'react';
import _ from 'lodash';
import uniqWith from 'lodash/uniqWith';
import isEqual from 'lodash/isEqual';

import EventDataSection from 'app/components/events/eventDataSection';
import EventErrorItem from 'app/components/events/errorItem';
Expand DownExpand Up@@ -32,7 +33,7 @@ class EventErrors extends React.Component {
 };

 uniqueErrors = errors => {
 return _.uniqWith(errors, _.isEqual);
 return uniqWith(errors, isEqual);
 };

 render() {
Expand Down

3 changes: 2 additions & 1 deletion
src/sentry/static/sentry/app/components/events/eventCause.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import PropTypes from 'prop-types';
import React from 'react';
import {uniqBy, flatMap} from 'lodash';
import uniqBy from 'lodash/uniqBy';
import flatMap from 'lodash/flatMap';
import styled from 'react-emotion';

import CommitRow from 'app/components/commitRow';
Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/events/eventTags.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import React from 'react';
import {Link} from 'react-router';
import _ from 'lodash';
import isEmpty from 'lodash/isEmpty';
import queryString from 'query-string';

import {Location} from 'history';
Expand DownExpand Up@@ -75,7 +75,7 @@ class EventTags extends React.Component<EventTagsProps> {
 const {event, orgId, hideGuide} = this.props;
 const {tags} = event;

 if (_.isEmpty(tags)) {
 if (isEmpty(tags)) {
 return null;
 }

Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/events/groupingInfo.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import React from 'react';
import PropTypes from 'prop-types';
import styled from 'react-emotion';
import {isObject} from 'lodash';
import isObject from 'lodash/isObject';
import AsyncComponent from 'app/components/asyncComponent';
import DropdownAutoComplete from 'app/components/dropdownAutoComplete';
import DropdownButton from 'app/components/dropdownButton';
Expand Down

7 changes: 4 additions & 3 deletions
src/sentry/static/sentry/app/components/events/interfaces/breadcrumbs/crumbTable.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import PropTypes from 'prop-types';
import React from 'react';
import _ from 'lodash';
import map from 'lodash/map';
import isObject from 'lodash/isObject';

import Category from 'app/components/events/interfaces/breadcrumbs/category';

Expand All@@ -15,12 +16,12 @@ class CrumbTable extends React.Component {
 if (!this.props.kvData) {
 return null;
 }
 return _.map(this.props.kvData, (val, key) => {
 return map(this.props.kvData, (val, key) => {
 return (
 <tr key={key}>
 <td className="key">{key}</td>
 <td className="value">
 <pre>{_.isObject(val) ? JSON.stringify(val) : val}</pre>
 <pre>{isObject(val) ? JSON.stringify(val) : val}</pre>
 </td>
 </tr>
 );
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
build(webpack): Remove lodash-webpack-plugin#15521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

billyvg
merged 9 commits into

from

Nov 13, 2019
 Merged


build(webpack): Remove lodash-webpack-plugin#15521
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


9 commits


Select commit
Hold shift + click to select a range
fe5fb5d

build(webpack): Remove `lodash-webpack-plugin` [WIP]


billyvg Nov 8, 2019
ae60e9f

wip change import


billyvg Nov 8, 2019
772d088

change lodash imports to be modular


billyvg Nov 8, 2019
2a74310

remove babel-plugin-lodash


billyvg Nov 9, 2019
e8d12df

fix missing import


billyvg Nov 11, 2019
a5c84d1

fix prettier


billyvg Nov 11, 2019
d171663

update tests


billyvg Nov 11, 2019
2e2ebd0

use eslint config that enforces lodash imports


billyvg Nov 12, 2019
88d467a

fix storybook


billyvg Nov 13, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
.storybook/.babelrc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@
 "presets": ["@babel/react", "@babel/env"],
 "plugins": [
 "emotion",
 "lodash",
 "react-hot-loader/babel",
 "@babel/plugin-syntax-dynamic-import",
 "@babel/plugin-proposal-object-rest-spread",
Expand Down

1 change: 0 additions & 1 deletion
babel.config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@ module.exports = {
 presets: ['@babel/react', '@babel/env', '@babel/preset-typescript'],
 plugins: [
 'emotion',
 'lodash',
 'react-hot-loader/babel',
 '@babel/plugin-syntax-dynamic-import',
 '@babel/plugin-proposal-object-rest-spread',
Expand Down

4 changes: 1 addition & 3 deletions
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,7 +44,6 @@
 "babel-loader": "^8.0.0",
 "babel-plugin-add-react-displayname": "^0.0.5",
 "babel-plugin-emotion": "9.2.11",
 "babel-plugin-lodash": "^3.3.4",
 "babel-plugin-transform-react-remove-prop-types": "^0.4.24",
 "bootstrap": "3.4.0",
 "classnames": "2.2.0",
Expand DownExpand Up@@ -76,7 +75,6 @@
 "less": "^3.9.0",
 "less-loader": "^4.1.0",
 "lodash": "^4.17.11",
 "lodash-webpack-plugin": "^0.11.5",
 "marked": "0.6.2",
 "mini-css-extract-plugin": "^v0.5.0",
 "mobx": "^5.13.0",
Expand DownExpand Up@@ -146,7 +144,7 @@
 "enzyme-adapter-react-16": "1.14.0",
 "enzyme-to-json": "3.4.0",
 "eslint": "5.11.1",
 "eslint-config-sentry-app": "1.26.0",
 "eslint-config-sentry-app": "1.27.0",
 "jest": "24.1.0",
 "jest-canvas-mock": "^2.1.0",
 "jest-junit": "^3.4.1",
Expand Down

4 changes: 3 additions & 1 deletion
src/sentry/static/sentry/app/actionCreators/formSearch.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import {flatten, flatMap} from 'lodash';
import flatten from 'lodash/flatten';

import flatMap from 'lodash/flatMap';

import FormSearchActions from 'app/actions/formSearchActions';

Expand Down

4 changes: 3 additions & 1 deletion
src/sentry/static/sentry/app/actionCreators/globalSelection.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import {isEqual, isInteger, omit} from 'lodash';
import isEqual from 'lodash/isEqual';
import isInteger from 'lodash/isInteger';
import omit from 'lodash/omit';
import * as Sentry from '@sentry/browser';

import {defined} from 'app/utils';
Expand Down

4 changes: 3 additions & 1 deletion
src/sentry/static/sentry/app/actionCreators/projects.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import {chunk, debounce} from 'lodash';
import chunk from 'lodash/chunk';

import debounce from 'lodash/debounce';

import {
 addLoadingMessage,
Expand Down

4 changes: 3 additions & 1 deletion
src/sentry/static/sentry/app/api.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import {isUndefined, isNil, get} from 'lodash';
import isUndefined from 'lodash/isUndefined';
import isNil from 'lodash/isNil';
import get from 'lodash/get';
import $ from 'jquery';
import * as Sentry from '@sentry/browser';

Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/activity/note/inputWithStorage.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import _ from 'lodash';
import debounce from 'lodash/debounce';
import PropTypes from 'prop-types';
import React from 'react';
import * as Sentry from '@sentry/browser';
Expand DownExpand Up@@ -75,7 +75,7 @@ class NoteInputWithStorage extends React.Component {
 return onLoad(storageObj[itemKey]);
 };

 save = _.debounce(value => {
 save = debounce(value => {
 const {itemKey, onSave} = this.props;

 const currentObj = this.fetchFromStorage() || {};
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/activity/note/mentionables.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {uniqBy} from 'lodash';
import uniqBy from 'lodash/uniqBy';
import PropTypes from 'prop-types';
import React from 'react';
import Reflux from 'reflux';
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/asyncComponent.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {isEqual} from 'lodash';
import isEqual from 'lodash/isEqual';
import PropTypes from 'prop-types';
import React from 'react';
import {Location} from 'history';
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/asyncComponentSearchInput.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {debounce} from 'lodash';
import debounce from 'lodash/debounce';
import {withRouter} from 'react-router';
import PropTypes from 'prop-types';
import React from 'react';
Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/bases/pluginComponentBase.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
import React from 'react';
import _ from 'lodash';
import isFunction from 'lodash/isFunction';

import {Client} from 'app/api';
import {FormState, GenericField} from 'app/components/forms';
import IndicatorStore from 'app/stores/indicatorStore';
import {t} from 'app/locale';

const callbackWithArgs = function(callback, ...args) {
 if (_.isFunction(callback)) {
 if (isFunction(callback)) {
 callback = callback.bind(this, ...args);
 } else {
 callback = null;
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/button.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@ import PropTypes from 'prop-types';
import React from 'react';
import styled, {css} from 'react-emotion';
import isPropValid from '@emotion/is-prop-valid';
import {pickBy} from 'lodash';
import pickBy from 'lodash/pickBy';

import ExternalLink from 'app/components/links/externalLink';
import InlineSvg from 'app/components/inlineSvg';
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/charts/components/tooltip.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import 'echarts/lib/component/tooltip';

import {get} from 'lodash';
import get from 'lodash/get';
import {getFormattedDate} from 'app/utils/dates';
import {truncationFormatter} from '../utils';

Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/charts/releaseSeries.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@ import {withRouter} from 'react-router';
import PropTypes from 'prop-types';
import React from 'react';
import moment from 'moment';
import {isEqual} from 'lodash';
import isEqual from 'lodash/isEqual';

import {addErrorMessage} from 'app/actionCreators/indicator';
import {getUserTimezone} from 'app/utils/dates';
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/charts/worldMapChart.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {max} from 'lodash';
import max from 'lodash/max';
import PropTypes from 'prop-types';
import React from 'react';

Expand Down

12 changes: 7 additions & 5 deletions
src/sentry/static/sentry/app/components/contextData.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,9 @@ import React from 'react';

import classNames from 'classnames';

import _ from 'lodash';
import isString from 'lodash/isString';
import isNumber from 'lodash/isNumber';
import isArray from 'lodash/isArray';

import {isUrl} from 'app/utils';

Expand DownExpand Up@@ -116,7 +118,7 @@ class ContextData extends React.Component {
 return <span className="val-null">{'None'}</span>;
 } else if (value === true || value === false) {
 return <span className="val-bool">{value ? 'True' : 'False'}</span>;
 } else if (_.isString(value)) {
 } else if (isString(value)) {
 const valueInfo = analyzeStringForRepr(value);

 const out = [
Expand All@@ -141,9 +143,9 @@ class ContextData extends React.Component {
 }

 return out;
 } else if (_.isNumber(value)) {
 } else if (isNumber(value)) {
 return <span className="val-number">{value}</span>;
 } else if (_.isArray(value)) {
 } else if (isArray(value)) {
 for (i = 0; i < value.length; i++) {
 children.push(
 <span className="val-array-item" key={i}>
Expand DownExpand Up@@ -204,7 +206,7 @@ class ContextData extends React.Component {
 };

 renderKeyPosValue = value => {
 if (_.isString(value)) {
 if (isString(value)) {
 return <span className="val-string">{value}</span>;
 }
 return this.renderValue(value);
Expand Down

1 change: 0 additions & 1 deletion
src/sentry/static/sentry/app/components/dateTime.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
import PropTypes from 'prop-types';
import React from 'react';
import moment from 'moment-timezone';
import _ from 'lodash';

import ConfigStore from 'app/stores/configStore';

Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/dropdownAutoCompleteMenu.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import {AutoSizer, List} from 'react-virtualized';
import PropTypes from 'prop-types';
import React from 'react';
import _ from 'lodash';
import flatMap from 'lodash/flatMap';
import styled from 'react-emotion';

import {t} from 'app/locale';
Expand DownExpand Up@@ -202,7 +202,7 @@ class DropdownAutoCompleteMenu extends React.Component {

 if (items[0] && items[0].items) {
 //if the first item has children, we assume it is a group
 return _.flatMap(this.filterGroupedItems(items, inputValue), item => {
 return flatMap(this.filterGroupedItems(items, inputValue), item => {
 const groupItems = item.items.map(groupedItem => ({
 ...groupedItem,
 index: itemCount++,
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/dropdownButton.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@ import React from 'react';
import styled from 'react-emotion';
import Button from 'app/components/button';
import InlineSvg from 'app/components/inlineSvg';
import {omit} from 'lodash';
import omit from 'lodash/omit';

class DropdownButton extends React.Component {
 static propTypes = {
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/eventOrGroupHeader.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@ import React from 'react';
import {withRouter} from 'react-router';
import styled, {css} from 'react-emotion';
import classNames from 'classnames';
import {capitalize} from 'lodash';
import capitalize from 'lodash/capitalize';

import SentryTypes from 'app/sentryTypes';
import EventOrGroupTitle from 'app/components/eventOrGroupTitle';
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/events/contexts.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import PropTypes from 'prop-types';
import React from 'react';

import {get} from 'lodash';
import get from 'lodash/get';
import {objectIsEmpty, toTitleCase, defined} from 'app/utils';
import EventDataSection from 'app/components/events/eventDataSection';
import plugins from 'app/plugins';
Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/events/contexts/contextBlock.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import PropTypes from 'prop-types';
import React from 'react';
import _ from 'lodash';
import sortBy from 'lodash/sortBy';

import {defined} from 'app/utils';
import ErrorBoundary from 'app/components/errorBoundary';
Expand DownExpand Up@@ -39,7 +39,7 @@ class ContextBlock extends React.Component {
 }

 if (extraData.length > 0) {
 data = data.concat(_.sortBy(extraData, (key, value) => key));
 data = data.concat(sortBy(extraData, (key, value) => key));
 }

 return (
Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/events/contexts/device.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import {isString} from 'lodash';
import isString from 'lodash/isString';
import PropTypes from 'prop-types';
import React from 'react';

Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/events/contexts/user.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
/*eslint react/jsx-key:0*/
import PropTypes from 'prop-types';
import React from 'react';
import _ from 'lodash';
import each from 'lodash/each';

import Avatar from 'app/components/avatar';
import ErrorBoundary from 'app/components/errorBoundary';
Expand DownExpand Up@@ -40,7 +40,7 @@ class UserContextType extends React.Component {
 user.name && builtins.push(['Name', <pre>{user.name}</pre>]);

 // We also attach user supplied data as 'user.data'
_.each(user.data, function(value, key) {
 each(user.data, function(value, key) {
 children.push([key, value]);
 });

Expand Down

8 changes: 5 additions & 3 deletions
src/sentry/static/sentry/app/components/events/errorItem.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
import _ from 'lodash';
import mapKeys from 'lodash/mapKeys';
import startCase from 'lodash/startCase';
import isEmpty from 'lodash/isEmpty';
import React from 'react';
import KeyValueList from 'app/components/events/interfaces/keyValueList';
import {t} from 'app/locale';
Expand DownExpand Up@@ -51,7 +53,7 @@ class EventErrorItem extends React.Component {
 data.image_path = path.length ? path.join(separator) + separator : '';
 }

 return _.mapKeys(data, (value, key) => t(keyMapping[key] || _.startCase(key)));
 return mapKeys(data, (value, key) => t(keyMapping[key] || startCase(key)));
 }

 renderPath() {
Expand All@@ -77,7 +79,7 @@ class EventErrorItem extends React.Component {
 <li>
 {this.renderPath()}
 {error.message}
 {!_.isEmpty(data) && (
 {!isEmpty(data) && (
 <small>
 {' '}
 <a style={{marginLeft: 10}} onClick={this.toggle}>
Expand Down

5 changes: 3 additions & 2 deletions
src/sentry/static/sentry/app/components/events/errors.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
import React from 'react';
import _ from 'lodash';
import uniqWith from 'lodash/uniqWith';
import isEqual from 'lodash/isEqual';

import EventDataSection from 'app/components/events/eventDataSection';
import EventErrorItem from 'app/components/events/errorItem';
Expand DownExpand Up@@ -32,7 +33,7 @@ class EventErrors extends React.Component {
 };

 uniqueErrors = errors => {
 return _.uniqWith(errors, _.isEqual);
 return uniqWith(errors, isEqual);
 };

 render() {
Expand Down

3 changes: 2 additions & 1 deletion
src/sentry/static/sentry/app/components/events/eventCause.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import PropTypes from 'prop-types';
import React from 'react';
import {uniqBy, flatMap} from 'lodash';
import uniqBy from 'lodash/uniqBy';
import flatMap from 'lodash/flatMap';
import styled from 'react-emotion';

import CommitRow from 'app/components/commitRow';
Expand Down

4 changes: 2 additions & 2 deletions
src/sentry/static/sentry/app/components/events/eventTags.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import React from 'react';
import {Link} from 'react-router';
import _ from 'lodash';
import isEmpty from 'lodash/isEmpty';
import queryString from 'query-string';

import {Location} from 'history';
Expand DownExpand Up@@ -75,7 +75,7 @@ class EventTags extends React.Component<EventTagsProps> {
 const {event, orgId, hideGuide} = this.props;
 const {tags} = event;

 if (_.isEmpty(tags)) {
 if (isEmpty(tags)) {
 return null;
 }

Expand Down

2 changes: 1 addition & 1 deletion
src/sentry/static/sentry/app/components/events/groupingInfo.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import React from 'react';
import PropTypes from 'prop-types';
import styled from 'react-emotion';
import {isObject} from 'lodash';
import isObject from 'lodash/isObject';
import AsyncComponent from 'app/components/asyncComponent';
import DropdownAutoComplete from 'app/components/dropdownAutoComplete';
import DropdownButton from 'app/components/dropdownButton';
Expand Down

7 changes: 4 additions & 3 deletions
src/sentry/static/sentry/app/components/events/interfaces/breadcrumbs/crumbTable.jsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import PropTypes from 'prop-types';
import React from 'react';
import _ from 'lodash';
import map from 'lodash/map';
import isObject from 'lodash/isObject';

import Category from 'app/components/events/interfaces/breadcrumbs/category';

Expand All@@ -15,12 +16,12 @@ class CrumbTable extends React.Component {
 if (!this.props.kvData) {
 return null;
 }
 return _.map(this.props.kvData, (val, key) => {
 return map(this.props.kvData, (val, key) => {
 return (
 <tr key={key}>
 <td className="key">{key}</td>
 <td className="value">
 <pre>{_.isObject(val) ? JSON.stringify(val) : val}</pre>
 <pre>{isObject(val) ? JSON.stringify(val) : val}</pre>
 </td>
 </tr>
 );
Expand Down
Loading