Skip to content

feat(platforms): Add Svelte as a platform - #37909

Merged
AbhiPrasad merged 2 commits into
masterfrom
feature/lms-svelte-platform
Sep 7, 2022
Merged

feat(platforms): Add Svelte as a platform#37909
AbhiPrasad merged 2 commits into
masterfrom
feature/lms-svelte-platform

Conversation

@Lms24

@Lms24Lms24 commented Aug 17, 2022•
edited by AbhiPrasad
Loading

Copy link
Copy Markdown
Member

This PR adds Svelte as a platform, following the alpha release of our Svelte SDK.

Our SDK docs (getsentry/sentry-docs#5413)

Ref and SDK Roadmap: getsentry/sentry-javascript#5492getsentry/sentry-javascript#5671

@Lms24Lms24 self-assigned this Aug 17, 2022
@github-actionsgithub-actionsBot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 17, 2022
@Lms24Lms24 mentioned this pull request Aug 17, 2022
Closed
6 tasks
@Lms24
Lms24 marked this pull request as ready for review August 17, 2022 13:15
@Lms24
Lms24 requested review from a team and AbhiPrasadAugust 17, 2022 13:15
@PixelDust22

PixelDust22 commented Aug 18, 2022

Copy link
Copy Markdown
Contributor

Hey! Can you update to master and update the platform_categories.py file on the backend as well?
#37894

@Lms24

Lms24 commented Aug 19, 2022

Copy link
Copy Markdown
MemberAuthor

Sure @Neo-Zhixing will do. Should this go into a separate PR (as it is a backend change)?

This was referenced Sep 1, 2022
Closed
Closed
@Lms24
feat(platforms): Add Svelte as a platform
8d34534
add platform entries and links to Svelte docs
@Lms24
Lms24force-pushed the feature/lms-svelte-platform branch from aa3342a to 91495a2CompareSeptember 1, 2022 10:40
@github-actionsgithub-actionsBot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 1, 2022
@github-actions

github-actionsBot commented Sep 1, 2022

Copy link
Copy Markdown
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@Lms24
Lms24force-pushed the feature/lms-svelte-platform branch from 91495a2 to 8d34534CompareSeptember 1, 2022 10:43
@Lms24Lms24 mentioned this pull request Sep 1, 2022
Merged
@Lms24

Lms24 commented Sep 1, 2022•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@Neo-Zhixing opened a separate PR for the backend change (#38379)

@Lms24Lms24 removed the Scope: Backend Automatically applied to PRs that change backend components label Sep 1, 2022
@AbhiPrasad
AbhiPrasad merged commit 2f14341 into masterSep 7, 2022
@AbhiPrasad
AbhiPrasad deleted the feature/lms-svelte-platform branch September 7, 2022 12:16
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Sep 22, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@AbhiPrasadAbhiPrasadAbhiPrasad approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@Lms24Lms24

Labels

Scope: FrontendAutomatically applied to PRs that change frontend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Lms24@PixelDust22@AbhiPrasad