Uh oh!
There was an error while loading. Please reload this page.
support custom header name for source maps - #4017
Conversation
I think this is the minimum change to support HTTP basic auth: You set I want basic auth support because its difficult (read without compiling modules) to configure nginx to compare a token securely. The config: location/static/source-maps/{set$auth_realmRestricted;if($http_x_sentry_token='redacted'){set$auth_realmoff;}auth_basic$auth_realm;auth_basic_user_file/etc/nginx/.htpasswd;expiresmax;add_headerCache-Control"private";}Isn't secure because the token can be discovered using a timing attack, however basic_auth does hashing (therefore secure compare), salts and multiple access lists etc etc and is generally really handy for this sort of thing. |
499baa9 to
07202dfCompare07202df to
e92868eComparemattrobenolt
commented
Nov 9, 2016
Hey @graingert, I'm ok with this change. Sorry for the delay. I'm going to pull this and test it manually to make sure everything is correct against current master. |
mattrobenolt
commented
Dec 2, 2016
@graingert I'm closing this in favor of #4630 since it needed a few things to make it fully work. :) |
* support custom header name for source maps * Carrying GH-4017
This change is