Skip to content

ref(db): Drop project_id from Environment (model state) - #45094

Merged
evanpurkhiser merged 1 commit into
masterfrom
evanpurkhiser/ref-db-drop-project-id-from-environment-model-state-
Feb 28, 2023
Merged

ref(db): Drop project_id from Environment (model state)#45094
evanpurkhiser merged 1 commit into
masterfrom
evanpurkhiser/ref-db-drop-project-id-from-environment-model-state-

Conversation

@evanpurkhiser

Copy link
Copy Markdown
Member

We'll do db state after

@evanpurkhiser
evanpurkhiser requested a review from a team as a code ownerFebruary 24, 2023 20:37
@evanpurkhiser
evanpurkhiser requested review from wedamija and removed request for a teamFebruary 24, 2023 20:37
@github-actionsgithub-actionsBot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 24, 2023
@github-actions

Copy link
Copy Markdown
Contributor

This PR has a migration; here is the generated SQL for src/sentry/migrations/0363_remove_project_id_from_environment.py ()

---- Custom state/database change combination--

@wedamijawedamija left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration looks good, but just need to catch all the places it's being passed

@evanpurkhiser
evanpurkhiserforce-pushed the evanpurkhiser/ref-db-drop-project-id-from-environment-model-state- branch from 55db101 to 5a7b92fCompareFebruary 24, 2023 23:15
@evanpurkhiser
evanpurkhiserforce-pushed the evanpurkhiser/ref-db-drop-project-id-from-environment-model-state- branch from 5a7b92f to 2e92035CompareFebruary 25, 2023 01:16
@evanpurkhiser
evanpurkhiserforce-pushed the evanpurkhiser/ref-db-drop-project-id-from-environment-model-state- branch from 2e92035 to b43e281CompareFebruary 27, 2023 22:41
@evanpurkhiser
evanpurkhiserforce-pushed the evanpurkhiser/ref-db-drop-project-id-from-environment-model-state- branch from b43e281 to 9a4ce9bCompareFebruary 28, 2023 19:23
@github-actions

Copy link
Copy Markdown
Contributor

This PR has a migration; here is the generated SQL for src/sentry/migrations/0364_remove_project_id_from_environment.py ()

---- Custom state/database change combination--

@evanpurkhiser
evanpurkhiser merged commit 6aaa964 into masterFeb 28, 2023
@evanpurkhiser
evanpurkhiser deleted the evanpurkhiser/ref-db-drop-project-id-from-environment-model-state- branch February 28, 2023 19:46
@evanpurkhiser

Copy link
Copy Markdown
MemberAuthor

Going to fast revert this because I want to baby sit the deploy, and the previous deploy is taking longer than expected.

@evanpurkhiserevanpurkhiser added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Feb 28, 2023
@getsentry-bot

Copy link
Copy Markdown
Contributor

PR reverted: f70eb24

getsentry-bot added a commit that referenced this pull request Feb 28, 2023
…5094)"
This reverts commit 6aaa964.
Co-authored-by: evanpurkhiser <1421724+evanpurkhiser@users.noreply.github.com>
jan-auer added a commit that referenced this pull request Mar 1, 2023
* master: (37 commits)
ref(ppf): Don't use --commit-batch-size for futures queue length (#45182)
feat(codecov-v2): Add more logging (#45225)
fix(alerts): Center table items on alert history page (#45226)
feat(CapMan): Pass `tenant_ids` to Snuba (#44788)
ref(db): Drop `project_id` from Environment (model state) (#45207)
chore(profiling): Rename context in profiles task (#45208)
feat(replays): Improve index page query performance (#45098)
chore(issue assignment): Add logging for`GroupOwner` auto assignment (#45142)
fix(hybrid-cloud): Uncache organization when queueing it for deletion (#45213)
fix(perf): Navigating to Transaction Summary from Trends widget should persist custom date selection (#45190)
fix(pageFilter): Fix overflow (#45169)
ref(git hooks): Only suggest autoupdate variable when pulling if not already set (#45179)
fix(dashboard): Include dashboard filters in widget viewer (#45106)
fix(alerts): Remove null projects from alerts list (#45202)
feat(replay): Update Inline replay onboarding img to support dark mode (#45084)
__iexact reduce call has default value now. (#45206)
feat(replay): Use SDK value for LCP (#44868)
chore(hybrid-cloud): breaking foreign keys (#45203)
Revert "ref(db): Drop `project_id` from Environment (model state) (#45094)"
ref(db): Drop `project_id` from Environment (model state) (#45094)
...
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 16, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: BackendAutomatically applied to PRs that change backend componentsTrigger: RevertAdd to a merged PR to revert it (skips CI)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@evanpurkhiser@getsentry-bot@JoshFerge@wedamija