Uh oh!
There was an error while loading. Please reload this page.
feat(CapMan): More tenant_ids for TSDB Queries - #45274
Merged
Merged
Conversation
| except Environment.DoesNotExist: | ||
| stats = {g.id: tsdb.make_series(0, **query_params) for g in groups} | ||
| else: | ||
| org_id = groups[0].project.organization_id if groups else None |
ContributorAuthor
There was a problem hiding this comment.
Assumes all groups in the list belong to a single org, let me know if this assumption is incorrect.
Contributor
There was a problem hiding this comment.
that assumption seems correct. is groups guaranteed to have at least one element though?
Contributor
There was a problem hiding this comment.
ah right, if groups will evaluate to False if it is empty.
JoshFerge
suggested changes
Mar 2, 2023
JoshFerge
left a comment
Contributor
There was a problem hiding this comment.
all look good to me except for group_stream.
| except Environment.DoesNotExist: | ||
| stats = {g.id: tsdb.make_series(0, **query_params) for g in groups} | ||
| else: | ||
| org_id = groups[0].project.organization_id if groups else None |
Contributor
There was a problem hiding this comment.
that assumption seems correct. is groups guaranteed to have at least one element though?
JoshFerge
approved these changes
Mar 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
organization_idto more Snuba Requests, specifically targetingtsdb-modelid:4queries as they are the biggest chunk of queries Snuba is handling in productiontsdb.get_rangehandled as well, some I wasn't able to figure outtenant_idsto Snuba #44788