Skip to content

feat(CapMan): More tsdb and legacy queries with tenant_ids - #45405

Merged
rahul-kumar-saini merged 7 commits into
masterfrom
rahul/feat/even_more_tsdb_tenant_ids
Mar 7, 2023
Merged

feat(CapMan): More tsdb and legacy queries with tenant_ids#45405
rahul-kumar-saini merged 7 commits into
masterfrom
rahul/feat/even_more_tsdb_tenant_ids

Conversation

@rahul-kumar-saini

@rahul-kumar-sainirahul-kumar-saini commented Mar 3, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Overview

  • Added organization_id to more Snuba Requests, specifically targeting tsdb-modelid:300 and tsdb-modelid:100
  • Legacy queries now pass tenant_ids to Snuba as well
  • Removed hardcoded referrer in tenant_ids, moved to populate referrer in query functions
  • More context: feat(CapMan): Pass tenant_ids to Snuba #44788

@github-actionsgithub-actionsBot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 3, 2023
@rahul-kumar-saini
rahul-kumar-saini marked this pull request as ready for review March 4, 2023 00:53
@rahul-kumar-saini
rahul-kumar-saini requested review from a teamMarch 4, 2023 00:53
@rahul-kumar-saini
rahul-kumar-saini requested a review from a team as a code ownerMarch 4, 2023 00:53
evanh
evanh reviewed Mar 6, 2023
View reviewed changes
Comment threadsrc/sentry/tsdb/snuba.py Outdated
@rahul-kumar-saini
rahul-kumar-saini requested a review from a team as a code ownerMarch 7, 2023 00:04
@rahul-kumar-saini
rahul-kumar-saini requested review from a teamMarch 7, 2023 00:04
JoshFerge
JoshFerge reviewed Mar 7, 2023
View reviewed changes

@JoshFergeJoshFerge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

endpoint and serializer changes look good. would have someone from sns double check utils/snuba.py and can approve!

Comment threadsrc/sentry/api/endpoints/organization_stats.py
Comment threadsrc/sentry/tsdb/snuba.py Outdated
@rahul-kumar-saini
rahul-kumar-saini merged commit 0183b07 into masterMar 7, 2023
@rahul-kumar-saini
rahul-kumar-saini deleted the rahul/feat/even_more_tsdb_tenant_ids branch March 7, 2023 18:41
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 23, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@evanhevanhevanh approved these changes
+1 more reviewer
@JoshFergeJoshFergeJoshFerge left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Scope: BackendAutomatically applied to PRs that change backend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rahul-kumar-saini@JoshFerge@evanh