feat(CapMan): Tagstore Org IDs passed to Snuba

[rahul-kumar-saini]

• All Tagstore Snuba queries now pass the organization_id tenant_id in the request
• See feat(CapMan): Pass tenant_ids to Snuba #44788 for more context

[wedamija]

lgtm, although looks like you need to add tenant ids to sentry.snuba.metrics.get_tag_values

[wedamija]

Just noting that we preload group projects here

sentry/src/sentry/api/serializers/models/group.py

Line 214 in c8bbb69

prefetch_related_objects(item_list, "project__organization")

, so this won't cause an extra query.

[rahul-kumar-saini]

I'm new to Django, are you saying I'm causing an extra query by doing .project.organization_id? How can I avoid this if so?

[wedamija]

No, just noting for anyone else reading that it won't cause any extra load

[rahul-kumar-saini]

lgtm, although looks like you need to add tenant ids to sentry.snuba.metrics.get_tag_values

sentry.snuba.metrics.get_tag_values calls _fetch... which calls run_metrics_query which contains the tenant_ids in the Request.

Lmk if I'm missing any other query somewhere in this stack 😅

[wedamija]

lgtm, although looks like you need to add tenant ids to sentry.snuba.metrics.get_tag_values

sentry.snuba.metrics.get_tag_values calls _fetch... which calls run_metrics_query which contains the tenant_ids in the Request.

Lmk if I'm missing any other query somewhere in this stack 😅

This is what's causing the test failure though - something is attempting to pass tenant_ids to sentry.snuba.metrics.get_tag_values and it's not part of the function definition