Skip to content

fix(gitlab): Do not mistag org slug - #45691

Merged
armenzg merged 2 commits into
masterfrom
armenzg/gitlab/tags
Mar 13, 2023
Merged

fix(gitlab): Do not mistag org slug#45691
armenzg merged 2 commits into
masterfrom
armenzg/gitlab/tags

Conversation

@armenzg

@armenzg armenzg commented Mar 13, 2023

Copy link
Copy Markdown
Member

This error is tagged with a different org's slug.

This is a follow up to #45368 and #45139

The extra variable (trimmed to prevent PII leakeage) shows the correct slug but the organization.slug tag points to a different one.
image

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 13, 2023
@armenzg armenzg self-assigned this Mar 13, 2023
@armenzg
armenzg marked this pull request as ready for review March 13, 2023 13:07
@armenzg
armenzg requested review from a team March 13, 2023 13:07
@armenzg
armenzg enabled auto-merge (squash) March 13, 2023 13:08

@lobsterkatie lobsterkatie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, but would you mind including in the PR description a quick note about which two pieces of data don't match (or, better yet, a screenshot)? I went to the linked but it wasn't immediately clear to me where the mismatch was.

EDIT: Okay, I did find it, but I still think it'd be nice to make it obvious (or link to a previous PR on this topic where it's pointed out more obviously).

@armenzg
armenzg merged commit 20f4c1b into master Mar 13, 2023
@armenzg
armenzg deleted the armenzg/gitlab/tags branch March 13, 2023 14:44
@armenzg

armenzg commented Mar 13, 2023

Copy link
Copy Markdown
Member Author

I've updated the description. Thanks!

@github-actions github-actions Bot locked and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants