feat: hash support for user auth token middleware - #65941

Merged
mdtro merged 11 commits into
masterfrom
mdtro/apitoken-middleware-hash
Mar 18, 2024
Merged

feat: hash support for user auth token middleware#65941
mdtro merged 11 commits into
masterfrom
mdtro/apitoken-middleware-hash

Conversation

@mdtro

@mdtromdtro commented Feb 27, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor
  • Update the UserAuthTokenAuthentication middleware to support hashed token values. As tokens are used, it will store the appropriate hash value.
  • Introduce a temporary option, apitoken.save-hash-on-create. This will be used in the model logic and in pre and post backfill migration tests in the future.

@mdtro
mdtro marked this pull request as ready for review February 27, 2024 23:48
@mdtro
mdtro requested a review from a team as a code ownerFebruary 27, 2024 23:48
@mdtro
mdtro requested review from a team and wedamijaFebruary 27, 2024 23:48
@github-actionsgithub-actionsBot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 27, 2024
@mdtro
mdtro marked this pull request as draft February 27, 2024 23:51
markstory
markstory reviewed Feb 28, 2024
View reviewed changes
Comment threadsrc/sentry/api/authentication.py Outdated
Comment threadsrc/sentry/api/authentication.py
@mdtromdtro mentioned this pull request Mar 11, 2024
Merged
mdtro added a commit that referenced this pull request Mar 12, 2024
@mdtro
hybridcloud: add hashed_token to apitokenreplica (#66679)
744d9c7
Add `hashed_token` to `ApiTokenReplica`.
Prerequisite for #65941
@mdtro
mdtroforce-pushed the mdtro/apitoken-middleware-hash branch from 4b13f18 to 334283cCompareMarch 12, 2024 10:53
@mdtro
mdtro marked this pull request as ready for review March 12, 2024 11:46
@mdtro
mdtro requested a review from a team as a code ownerMarch 12, 2024 11:46
mdtro
mdtro commented Mar 12, 2024
View reviewed changes
Comment threadsrc/sentry/api/authentication.py Outdated
markstory
markstory reviewed Mar 13, 2024
View reviewed changes
Comment threadsrc/sentry/api/authentication.py
Comment threadsrc/sentry/services/hybrid_cloud/auth/serial.py
@mdtromdtro mentioned this pull request Mar 14, 2024
Merged
mdtro added a commit that referenced this pull request Mar 14, 2024
@mdtro
feat(hybridcloud): add index to apitokenreplica (#66947)
a806379
In support of: #65941
Adds an index for the `hashed_token` column on `ApiTokenReplica`.
@mdtro
mdtroforce-pushed the mdtro/apitoken-middleware-hash branch from 086c2f4 to 24c56a4CompareMarch 15, 2024 11:05
@codecov

codecovBot commented Mar 15, 2024•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.32%. Comparing base (ee2cbd0) to head (3a736dc).
Report is 5 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #65941 +/- ##
=======================================
Coverage 84.32% 84.32% =======================================
Files 5306 5306 Lines 237077 237093 +16 Branches 41000 41001 +1 =======================================
+ Hits 199904 199922 +18 + Misses 36955 36953 -2 
Partials 218 218
FilesCoverage Δ
src/sentry/api/authentication.py90.45% <100.00%> (+0.49%)⬆️
src/sentry/options/defaults.py100.00% <100.00%> (ø)
src/sentry/services/hybrid_cloud/auth/model.py94.16% <100.00%> (+0.04%)⬆️
src/sentry/services/hybrid_cloud/auth/serial.py100.00% <ø> (ø)
src/sentry/services/hybrid_cloud/replica/impl.py93.61% <ø> (ø)

... and 7 files with indirect coverage changes

JonasBa pushed a commit that referenced this pull request Mar 17, 2024
@mdtro@JonasBa
feat(hybridcloud): add index to apitokenreplica (#66947)
5ca4415
In support of: #65941
Adds an index for the `hashed_token` column on `ApiTokenReplica`.
@mdtro
mdtroforce-pushed the mdtro/apitoken-middleware-hash branch from 88a554f to 3a736dcCompareMarch 18, 2024 16:14
markstory
markstory approved these changes Mar 18, 2024
View reviewed changes

@markstorymarkstory left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mdtro
mdtro merged commit 3ae4a10 into masterMar 18, 2024
@mdtro
mdtro deleted the mdtro/apitoken-middleware-hash branch March 18, 2024 20:13
@mdtromdtro added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Mar 18, 2024
@getsentry-bot

getsentry-bot commented Mar 18, 2024

Copy link
Copy Markdown
Contributor

PR reverted: 92e8bd5

getsentry-bot added a commit that referenced this pull request Mar 18, 2024
@getsentry-bot@mdtro
Revert "feat: hash support for user auth token middleware (#65941)"
92e8bd5
This reverts commit 3ae4a10.
Co-authored-by: mdtro <20070360+mdtro@users.noreply.github.com>
@mdtromdtro mentioned this pull request Mar 29, 2024
Merged
mdtro added a commit that referenced this pull request Apr 2, 2024
@mdtro
feat: hashed user auth tokens (#67969)
db950e3
- Update the `UserAuthTokenAuthentication` middleware to support hashed
token values. As tokens are used, it will store the appropriate hash
value.
- Use an option, `apitoken.use-and-update-hash-rate` that will apply the
code paths using the hashed values for lookups and updating the hashed
values on plaintext tokens randomly based on the configured rate.
- Introduce a temporary option, `apitoken.save-hash-on-create`. This
will be used in the model logic and in pre and post backfill migration
tests in the future.
This previously resulted in INC-684 via PR
#65941. The `hashed_token` and
`hashed_refresh_token` columns now have indexes.
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Apr 3, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@markstorymarkstorymarkstory approved these changes
@wedamijawedamijaAwaiting requested review from wedamija

Assignees

No one assigned

Labels

Scope: BackendAutomatically applied to PRs that change backend componentsTrigger: RevertAdd to a merged PR to revert it (skips CI)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdtro@getsentry-bot@markstory
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
feat: hash support for user auth token middleware - #65941
Merged
mdtro merged 11 commits into
masterfrom 
mdtro/apitoken-middleware-hash
Mar 18, 2024
Merged
feat: hash support for user auth token middleware#65941
mdtro merged 11 commits into
masterfrom 
mdtro/apitoken-middleware-hash
Conversation
@mdtro
@mdtromdtro
commented
Feb 27, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
  • Update the UserAuthTokenAuthentication middleware to support hashed token values. As tokens are used, it will store the appropriate hash value.
  • Introduce a temporary option, apitoken.save-hash-on-create. This will be used in the model logic and in pre and post backfill migration tests in the future.
@mdtro
mdtro
marked this pull request as ready for review
February 27, 2024 23:48
@mdtro
mdtro
requested a review
from a team
as a code ownerFebruary 27, 2024 23:48
@mdtro
mdtro
requested review from
a team and wedamijaFebruary 27, 2024 23:48
@github-actionsgithub-actionsBot
added
the 
Scope: Backend
Automatically applied to PRs that change backend components
label
Feb 27, 2024
@mdtro
mdtro
marked this pull request as draft
February 27, 2024 23:51
markstory
markstory
reviewed
Feb 28, 2024
View reviewed changes
Comment threadsrc/sentry/api/authentication.py
Outdated

Comment threadsrc/sentry/api/authentication.py
@mdtromdtro
mentioned this pull request
Mar 11, 2024
 Merged

mdtro added a commit
that referenced
this pull request
Mar 12, 2024
@mdtro
hybridcloud: add hashed_token to apitokenreplica (#66679)
744d9c7
Add `hashed_token` to `ApiTokenReplica`.
Prerequisite for #65941
@mdtro
mdtroforce-pushed
the
mdtro/apitoken-middleware-hash
branch
from
4b13f18 to
334283cCompareMarch 12, 2024 10:53
@mdtro
mdtro
marked this pull request as ready for review
March 12, 2024 11:46
@mdtro
mdtro
requested a review
from a team
as a code ownerMarch 12, 2024 11:46
mdtro
mdtro
commented
Mar 12, 2024
View reviewed changes
Comment threadsrc/sentry/api/authentication.py
Outdated

markstory
markstory
reviewed
Mar 13, 2024
View reviewed changes
Comment threadsrc/sentry/api/authentication.py
Comment threadsrc/sentry/services/hybrid_cloud/auth/serial.py
@mdtromdtro
mentioned this pull request
Mar 14, 2024
 Merged

mdtro added a commit
that referenced
this pull request
Mar 14, 2024
@mdtro
feat(hybridcloud): add index to apitokenreplica (#66947)
a806379
In support of: #65941
Adds an index for the `hashed_token` column on `ApiTokenReplica`.
@mdtro
mdtroforce-pushed
the
mdtro/apitoken-middleware-hash
branch
from
086c2f4 to
24c56a4CompareMarch 15, 2024 11:05
@codecov
codecovBot
commented
Mar 15, 2024•

edited

Loading

Copy link


Copy Markdown

Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 84.32%. Comparing base (ee2cbd0) to head (3a736dc).

Report is 5 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@## master #65941 +/- ##
=======================================
Coverage 84.32% 84.32% =======================================
Files 5306 5306 Lines 237077 237093 +16 Branches 41000 41001 +1 =======================================
+ Hits 199904 199922 +18 + Misses 36955 36953 -2 
Partials 218 218 
FilesCoverage Δ
src/sentry/api/authentication.py90.45% <100.00%> (+0.49%)⬆️
src/sentry/options/defaults.py100.00% <100.00%> (ø)
src/sentry/services/hybrid_cloud/auth/model.py94.16% <100.00%> (+0.04%)⬆️
src/sentry/services/hybrid_cloud/auth/serial.py100.00% <ø> (ø)
src/sentry/services/hybrid_cloud/replica/impl.py93.61% <ø> (ø)
... and 7 files with indirect coverage changes
JonasBa pushed a commit
that referenced
this pull request
Mar 17, 2024
@mdtro@JonasBa
feat(hybridcloud): add index to apitokenreplica (#66947)
5ca4415
In support of: #65941
Adds an index for the `hashed_token` column on `ApiTokenReplica`.
@mdtro
mdtroforce-pushed
the
mdtro/apitoken-middleware-hash
branch
from
88a554f to
3a736dcCompareMarch 18, 2024 16:14
markstory
markstory
approved these changes
Mar 18, 2024
View reviewed changes
@markstorymarkstory
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
@mdtro
mdtro
merged commit 3ae4a10
into
masterMar 18, 2024
@mdtro
mdtro
deleted the

mdtro/apitoken-middleware-hash

branch
March 18, 2024 20:13
@mdtromdtro
added
the 
Trigger: Revert
Add to a merged PR to revert it (skips CI)
label
Mar 18, 2024
@getsentry-bot
getsentry-bot
commented
Mar 18, 2024

Copy link


Copy Markdown

Contributor
PR reverted: 92e8bd5
getsentry-bot added a commit
that referenced
this pull request
Mar 18, 2024
@getsentry-bot@mdtro
Revert "feat: hash support for user auth token middleware (#65941)"
92e8bd5
This reverts commit 3ae4a10.
Co-authored-by: mdtro <20070360+mdtro@users.noreply.github.com>
@mdtromdtro
mentioned this pull request
Mar 29, 2024
 Merged

mdtro added a commit
that referenced
this pull request
Apr 2, 2024
@mdtro
feat: hashed user auth tokens (#67969)
db950e3
- Update the `UserAuthTokenAuthentication` middleware to support hashed
token values. As tokens are used, it will store the appropriate hash
value.
- Use an option, `apitoken.use-and-update-hash-rate` that will apply the
code paths using the hashed values for lookups and updating the hashed
values on plaintext tokens randomly based on the configured rate.
- Introduce a temporary option, `apitoken.save-hash-on-create`. This
will be used in the model logic and in pre and post backfill migration
tests in the future.
This previously resulted in INC-684 via PR
#65941. The `hashed_token` and
`hashed_refresh_token` columns now have indexes.
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Apr 3, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@markstorymarkstorymarkstory approved these changes
@wedamijawedamijaAwaiting requested review from wedamija

Assignees


No one assigned


Labels

Scope: BackendAutomatically applied to PRs that change backend componentsTrigger: RevertAdd to a merged PR to revert it (skips CI)

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@mdtro@getsentry-bot@markstory

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: hash support for user auth token middleware - #65941
Merged
mdtro merged 11 commits into
masterfrom 
mdtro/apitoken-middleware-hash
Mar 18, 2024
Merged
feat: hash support for user auth token middleware#65941
mdtro merged 11 commits into
masterfrom 
mdtro/apitoken-middleware-hash
Conversation
@mdtro
@mdtromdtro
commented
Feb 27, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
  • Update the UserAuthTokenAuthentication middleware to support hashed token values. As tokens are used, it will store the appropriate hash value.
  • Introduce a temporary option, apitoken.save-hash-on-create. This will be used in the model logic and in pre and post backfill migration tests in the future.
@mdtro
mdtro
marked this pull request as ready for review
February 27, 2024 23:48
@mdtro
mdtro
requested a review
from a team
as a code ownerFebruary 27, 2024 23:48
@mdtro
mdtro
requested review from
a team and wedamijaFebruary 27, 2024 23:48
@github-actionsgithub-actionsBot
added
the 
Scope: Backend
Automatically applied to PRs that change backend components
label
Feb 27, 2024
@mdtro
mdtro
marked this pull request as draft
February 27, 2024 23:51
markstory
markstory
reviewed
Feb 28, 2024
View reviewed changes
Comment threadsrc/sentry/api/authentication.py
Outdated

Comment threadsrc/sentry/api/authentication.py
@mdtromdtro
mentioned this pull request
Mar 11, 2024
 Merged

mdtro added a commit
that referenced
this pull request
Mar 12, 2024
@mdtro
hybridcloud: add hashed_token to apitokenreplica (#66679)
744d9c7
Add `hashed_token` to `ApiTokenReplica`.
Prerequisite for #65941
@mdtro
mdtroforce-pushed
the
mdtro/apitoken-middleware-hash
branch
from
4b13f18 to
334283cCompareMarch 12, 2024 10:53
@mdtro
mdtro
marked this pull request as ready for review
March 12, 2024 11:46
@mdtro
mdtro
requested a review
from a team
as a code ownerMarch 12, 2024 11:46
mdtro
mdtro
commented
Mar 12, 2024
View reviewed changes
Comment threadsrc/sentry/api/authentication.py
Outdated

markstory
markstory
reviewed
Mar 13, 2024
View reviewed changes
Comment threadsrc/sentry/api/authentication.py
Comment threadsrc/sentry/services/hybrid_cloud/auth/serial.py
@mdtromdtro
mentioned this pull request
Mar 14, 2024
 Merged

mdtro added a commit
that referenced
this pull request
Mar 14, 2024
@mdtro
feat(hybridcloud): add index to apitokenreplica (#66947)
a806379
In support of: #65941
Adds an index for the `hashed_token` column on `ApiTokenReplica`.
@mdtro
mdtroforce-pushed
the
mdtro/apitoken-middleware-hash
branch
from
086c2f4 to
24c56a4CompareMarch 15, 2024 11:05
@codecov
codecovBot
commented
Mar 15, 2024•

edited

Loading

Copy link


Copy Markdown

Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 84.32%. Comparing base (ee2cbd0) to head (3a736dc).

Report is 5 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@## master #65941 +/- ##
=======================================
Coverage 84.32% 84.32% =======================================
Files 5306 5306 Lines 237077 237093 +16 Branches 41000 41001 +1 =======================================
+ Hits 199904 199922 +18 + Misses 36955 36953 -2 
Partials 218 218 
FilesCoverage Δ
src/sentry/api/authentication.py90.45% <100.00%> (+0.49%)⬆️
src/sentry/options/defaults.py100.00% <100.00%> (ø)
src/sentry/services/hybrid_cloud/auth/model.py94.16% <100.00%> (+0.04%)⬆️
src/sentry/services/hybrid_cloud/auth/serial.py100.00% <ø> (ø)
src/sentry/services/hybrid_cloud/replica/impl.py93.61% <ø> (ø)
... and 7 files with indirect coverage changes
JonasBa pushed a commit
that referenced
this pull request
Mar 17, 2024
@mdtro@JonasBa
feat(hybridcloud): add index to apitokenreplica (#66947)
5ca4415
In support of: #65941
Adds an index for the `hashed_token` column on `ApiTokenReplica`.
@mdtro
mdtroforce-pushed
the
mdtro/apitoken-middleware-hash
branch
from
88a554f to
3a736dcCompareMarch 18, 2024 16:14
markstory
markstory
approved these changes
Mar 18, 2024
View reviewed changes
@markstorymarkstory
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
@mdtro
mdtro
merged commit 3ae4a10
into
masterMar 18, 2024
@mdtro
mdtro
deleted the

mdtro/apitoken-middleware-hash

branch
March 18, 2024 20:13
@mdtromdtro
added
the 
Trigger: Revert
Add to a merged PR to revert it (skips CI)
label
Mar 18, 2024
@getsentry-bot
getsentry-bot
commented
Mar 18, 2024

Copy link


Copy Markdown

Contributor
PR reverted: 92e8bd5
getsentry-bot added a commit
that referenced
this pull request
Mar 18, 2024
@getsentry-bot@mdtro
Revert "feat: hash support for user auth token middleware (#65941)"
92e8bd5
This reverts commit 3ae4a10.
Co-authored-by: mdtro <20070360+mdtro@users.noreply.github.com>
@mdtromdtro
mentioned this pull request
Mar 29, 2024
 Merged

mdtro added a commit
that referenced
this pull request
Apr 2, 2024
@mdtro
feat: hashed user auth tokens (#67969)
db950e3
- Update the `UserAuthTokenAuthentication` middleware to support hashed
token values. As tokens are used, it will store the appropriate hash
value.
- Use an option, `apitoken.use-and-update-hash-rate` that will apply the
code paths using the hashed values for lookups and updating the hashed
values on plaintext tokens randomly based on the configured rate.
- Introduce a temporary option, `apitoken.save-hash-on-create`. This
will be used in the model logic and in pre and post backfill migration
tests in the future.
This previously resulted in INC-684 via PR
#65941. The `hashed_token` and
`hashed_refresh_token` columns now have indexes.
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Apr 3, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@markstorymarkstorymarkstory approved these changes
@wedamijawedamijaAwaiting requested review from wedamija

Assignees


No one assigned


Labels

Scope: BackendAutomatically applied to PRs that change backend componentsTrigger: RevertAdd to a merged PR to revert it (skips CI)

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@mdtro@getsentry-bot@markstory

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: hash support for user auth token middleware - #65941
Merged
mdtro merged 11 commits into
masterfrom 
mdtro/apitoken-middleware-hash
Mar 18, 2024
Merged
feat: hash support for user auth token middleware#65941
mdtro merged 11 commits into
masterfrom 
mdtro/apitoken-middleware-hash
Conversation
@mdtro
@mdtromdtro
commented
Feb 27, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
  • Update the UserAuthTokenAuthentication middleware to support hashed token values. As tokens are used, it will store the appropriate hash value.
  • Introduce a temporary option, apitoken.save-hash-on-create. This will be used in the model logic and in pre and post backfill migration tests in the future.
@mdtro
mdtro
marked this pull request as ready for review
February 27, 2024 23:48
@mdtro
mdtro
requested a review
from a team
as a code ownerFebruary 27, 2024 23:48
@mdtro
mdtro
requested review from
a team and wedamijaFebruary 27, 2024 23:48
@github-actionsgithub-actionsBot
added
the 
Scope: Backend
Automatically applied to PRs that change backend components
label
Feb 27, 2024
@mdtro
mdtro
marked this pull request as draft
February 27, 2024 23:51
markstory
markstory
reviewed
Feb 28, 2024
View reviewed changes
Comment threadsrc/sentry/api/authentication.py
Outdated

Comment threadsrc/sentry/api/authentication.py
@mdtromdtro
mentioned this pull request
Mar 11, 2024
 Merged

mdtro added a commit
that referenced
this pull request
Mar 12, 2024
@mdtro
hybridcloud: add hashed_token to apitokenreplica (#66679)
744d9c7
Add `hashed_token` to `ApiTokenReplica`.
Prerequisite for #65941
@mdtro
mdtroforce-pushed
the
mdtro/apitoken-middleware-hash
branch
from
4b13f18 to
334283cCompareMarch 12, 2024 10:53
@mdtro
mdtro
marked this pull request as ready for review
March 12, 2024 11:46
@mdtro
mdtro
requested a review
from a team
as a code ownerMarch 12, 2024 11:46
mdtro
mdtro
commented
Mar 12, 2024
View reviewed changes
Comment threadsrc/sentry/api/authentication.py
Outdated

markstory
markstory
reviewed
Mar 13, 2024
View reviewed changes
Comment threadsrc/sentry/api/authentication.py
Comment threadsrc/sentry/services/hybrid_cloud/auth/serial.py
@mdtromdtro
mentioned this pull request
Mar 14, 2024
 Merged

mdtro added a commit
that referenced
this pull request
Mar 14, 2024
@mdtro
feat(hybridcloud): add index to apitokenreplica (#66947)
a806379
In support of: #65941
Adds an index for the `hashed_token` column on `ApiTokenReplica`.
@mdtro
mdtroforce-pushed
the
mdtro/apitoken-middleware-hash
branch
from
086c2f4 to
24c56a4CompareMarch 15, 2024 11:05
@codecov
codecovBot
commented
Mar 15, 2024•

edited

Loading

Copy link


Copy Markdown

Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 84.32%. Comparing base (ee2cbd0) to head (3a736dc).

Report is 5 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@## master #65941 +/- ##
=======================================
Coverage 84.32% 84.32% =======================================
Files 5306 5306 Lines 237077 237093 +16 Branches 41000 41001 +1 =======================================
+ Hits 199904 199922 +18 + Misses 36955 36953 -2 
Partials 218 218 
FilesCoverage Δ
src/sentry/api/authentication.py90.45% <100.00%> (+0.49%)⬆️
src/sentry/options/defaults.py100.00% <100.00%> (ø)
src/sentry/services/hybrid_cloud/auth/model.py94.16% <100.00%> (+0.04%)⬆️
src/sentry/services/hybrid_cloud/auth/serial.py100.00% <ø> (ø)
src/sentry/services/hybrid_cloud/replica/impl.py93.61% <ø> (ø)
... and 7 files with indirect coverage changes
JonasBa pushed a commit
that referenced
this pull request
Mar 17, 2024
@mdtro@JonasBa
feat(hybridcloud): add index to apitokenreplica (#66947)
5ca4415
In support of: #65941
Adds an index for the `hashed_token` column on `ApiTokenReplica`.
@mdtro
mdtroforce-pushed
the
mdtro/apitoken-middleware-hash
branch
from
88a554f to
3a736dcCompareMarch 18, 2024 16:14
markstory
markstory
approved these changes
Mar 18, 2024
View reviewed changes
@markstorymarkstory
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
@mdtro
mdtro
merged commit 3ae4a10
into
masterMar 18, 2024
@mdtro
mdtro
deleted the

mdtro/apitoken-middleware-hash

branch
March 18, 2024 20:13
@mdtromdtro
added
the 
Trigger: Revert
Add to a merged PR to revert it (skips CI)
label
Mar 18, 2024
@getsentry-bot
getsentry-bot
commented
Mar 18, 2024

Copy link


Copy Markdown

Contributor
PR reverted: 92e8bd5
getsentry-bot added a commit
that referenced
this pull request
Mar 18, 2024
@getsentry-bot@mdtro
Revert "feat: hash support for user auth token middleware (#65941)"
92e8bd5
This reverts commit 3ae4a10.
Co-authored-by: mdtro <20070360+mdtro@users.noreply.github.com>
@mdtromdtro
mentioned this pull request
Mar 29, 2024
 Merged

mdtro added a commit
that referenced
this pull request
Apr 2, 2024
@mdtro
feat: hashed user auth tokens (#67969)
db950e3
- Update the `UserAuthTokenAuthentication` middleware to support hashed
token values. As tokens are used, it will store the appropriate hash
value.
- Use an option, `apitoken.use-and-update-hash-rate` that will apply the
code paths using the hashed values for lookups and updating the hashed
values on plaintext tokens randomly based on the configured rate.
- Introduce a temporary option, `apitoken.save-hash-on-create`. This
will be used in the model logic and in pre and post backfill migration
tests in the future.
This previously resulted in INC-684 via PR
#65941. The `hashed_token` and
`hashed_refresh_token` columns now have indexes.
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Apr 3, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@markstorymarkstorymarkstory approved these changes
@wedamijawedamijaAwaiting requested review from wedamija

Assignees


No one assigned


Labels

Scope: BackendAutomatically applied to PRs that change backend componentsTrigger: RevertAdd to a merged PR to revert it (skips CI)

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@mdtro@getsentry-bot@markstory

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
feat: hash support for user auth token middleware - #65941
Merged
mdtro merged 11 commits into
masterfrom 
mdtro/apitoken-middleware-hash
Mar 18, 2024
Merged
feat: hash support for user auth token middleware#65941
mdtro merged 11 commits into
masterfrom 
mdtro/apitoken-middleware-hash
Conversation
@mdtro
@mdtromdtro
commented
Feb 27, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
  • Update the UserAuthTokenAuthentication middleware to support hashed token values. As tokens are used, it will store the appropriate hash value.
  • Introduce a temporary option, apitoken.save-hash-on-create. This will be used in the model logic and in pre and post backfill migration tests in the future.
@mdtro
mdtro
marked this pull request as ready for review
February 27, 2024 23:48
@mdtro
mdtro
requested a review
from a team
as a code ownerFebruary 27, 2024 23:48
@mdtro
mdtro
requested review from
a team and wedamijaFebruary 27, 2024 23:48
@github-actionsgithub-actionsBot
added
the 
Scope: Backend
Automatically applied to PRs that change backend components
label
Feb 27, 2024
@mdtro
mdtro
marked this pull request as draft
February 27, 2024 23:51
markstory
markstory
reviewed
Feb 28, 2024
View reviewed changes
Comment threadsrc/sentry/api/authentication.py
Outdated

Comment threadsrc/sentry/api/authentication.py
@mdtromdtro
mentioned this pull request
Mar 11, 2024
 Merged

mdtro added a commit
that referenced
this pull request
Mar 12, 2024
@mdtro
hybridcloud: add hashed_token to apitokenreplica (#66679)
744d9c7
Add `hashed_token` to `ApiTokenReplica`.
Prerequisite for #65941
@mdtro
mdtroforce-pushed
the
mdtro/apitoken-middleware-hash
branch
from
4b13f18 to
334283cCompareMarch 12, 2024 10:53
@mdtro
mdtro
marked this pull request as ready for review
March 12, 2024 11:46
@mdtro
mdtro
requested a review
from a team
as a code ownerMarch 12, 2024 11:46
mdtro
mdtro
commented
Mar 12, 2024
View reviewed changes
Comment threadsrc/sentry/api/authentication.py
Outdated

markstory
markstory
reviewed
Mar 13, 2024
View reviewed changes
Comment threadsrc/sentry/api/authentication.py
Comment threadsrc/sentry/services/hybrid_cloud/auth/serial.py
@mdtromdtro
mentioned this pull request
Mar 14, 2024
 Merged

mdtro added a commit
that referenced
this pull request
Mar 14, 2024
@mdtro
feat(hybridcloud): add index to apitokenreplica (#66947)
a806379
In support of: #65941
Adds an index for the `hashed_token` column on `ApiTokenReplica`.
@mdtro
mdtroforce-pushed
the
mdtro/apitoken-middleware-hash
branch
from
086c2f4 to
24c56a4CompareMarch 15, 2024 11:05
@codecov
codecovBot
commented
Mar 15, 2024•

edited

Loading

Copy link


Copy Markdown

Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 84.32%. Comparing base (ee2cbd0) to head (3a736dc).

Report is 5 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@## master #65941 +/- ##
=======================================
Coverage 84.32% 84.32% =======================================
Files 5306 5306 Lines 237077 237093 +16 Branches 41000 41001 +1 =======================================
+ Hits 199904 199922 +18 + Misses 36955 36953 -2 
Partials 218 218 
FilesCoverage Δ
src/sentry/api/authentication.py90.45% <100.00%> (+0.49%)⬆️
src/sentry/options/defaults.py100.00% <100.00%> (ø)
src/sentry/services/hybrid_cloud/auth/model.py94.16% <100.00%> (+0.04%)⬆️
src/sentry/services/hybrid_cloud/auth/serial.py100.00% <ø> (ø)
src/sentry/services/hybrid_cloud/replica/impl.py93.61% <ø> (ø)
... and 7 files with indirect coverage changes
JonasBa pushed a commit
that referenced
this pull request
Mar 17, 2024
@mdtro@JonasBa
feat(hybridcloud): add index to apitokenreplica (#66947)
5ca4415
In support of: #65941
Adds an index for the `hashed_token` column on `ApiTokenReplica`.
@mdtro
mdtroforce-pushed
the
mdtro/apitoken-middleware-hash
branch
from
88a554f to
3a736dcCompareMarch 18, 2024 16:14
markstory
markstory
approved these changes
Mar 18, 2024
View reviewed changes
@markstorymarkstory
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
@mdtro
mdtro
merged commit 3ae4a10
into
masterMar 18, 2024
@mdtro
mdtro
deleted the

mdtro/apitoken-middleware-hash

branch
March 18, 2024 20:13
@mdtromdtro
added
the 
Trigger: Revert
Add to a merged PR to revert it (skips CI)
label
Mar 18, 2024
@getsentry-bot
getsentry-bot
commented
Mar 18, 2024

Copy link


Copy Markdown

Contributor
PR reverted: 92e8bd5
getsentry-bot added a commit
that referenced
this pull request
Mar 18, 2024
@getsentry-bot@mdtro
Revert "feat: hash support for user auth token middleware (#65941)"
92e8bd5
This reverts commit 3ae4a10.
Co-authored-by: mdtro <20070360+mdtro@users.noreply.github.com>
@mdtromdtro
mentioned this pull request
Mar 29, 2024
 Merged

mdtro added a commit
that referenced
this pull request
Apr 2, 2024
@mdtro
feat: hashed user auth tokens (#67969)
db950e3
- Update the `UserAuthTokenAuthentication` middleware to support hashed
token values. As tokens are used, it will store the appropriate hash
value.
- Use an option, `apitoken.use-and-update-hash-rate` that will apply the
code paths using the hashed values for lookups and updating the hashed
values on plaintext tokens randomly based on the configured rate.
- Introduce a temporary option, `apitoken.save-hash-on-create`. This
will be used in the model logic and in pre and post backfill migration
tests in the future.
This previously resulted in INC-684 via PR
#65941. The `hashed_token` and
`hashed_refresh_token` columns now have indexes.
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Apr 3, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@markstorymarkstorymarkstory approved these changes
@wedamijawedamijaAwaiting requested review from wedamija

Assignees


No one assigned


Labels

Scope: BackendAutomatically applied to PRs that change backend componentsTrigger: RevertAdd to a merged PR to revert it (skips CI)

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@mdtro@getsentry-bot@markstory

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: hash support for user auth token middleware - #65941
Merged
mdtro merged 11 commits into
masterfrom 
mdtro/apitoken-middleware-hash
Mar 18, 2024
Merged
feat: hash support for user auth token middleware#65941
mdtro merged 11 commits into
masterfrom 
mdtro/apitoken-middleware-hash
Conversation
@mdtro
@mdtromdtro
commented
Feb 27, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
  • Update the UserAuthTokenAuthentication middleware to support hashed token values. As tokens are used, it will store the appropriate hash value.
  • Introduce a temporary option, apitoken.save-hash-on-create. This will be used in the model logic and in pre and post backfill migration tests in the future.
@mdtro
mdtro
marked this pull request as ready for review
February 27, 2024 23:48
@mdtro
mdtro
requested a review
from a team
as a code ownerFebruary 27, 2024 23:48
@mdtro
mdtro
requested review from
a team and wedamijaFebruary 27, 2024 23:48
@github-actionsgithub-actionsBot
added
the 
Scope: Backend
Automatically applied to PRs that change backend components
label
Feb 27, 2024
@mdtro
mdtro
marked this pull request as draft
February 27, 2024 23:51
markstory
markstory
reviewed
Feb 28, 2024
View reviewed changes
Comment threadsrc/sentry/api/authentication.py
Outdated

Comment threadsrc/sentry/api/authentication.py
@mdtromdtro
mentioned this pull request
Mar 11, 2024
 Merged

mdtro added a commit
that referenced
this pull request
Mar 12, 2024
@mdtro
hybridcloud: add hashed_token to apitokenreplica (#66679)
744d9c7
Add `hashed_token` to `ApiTokenReplica`.
Prerequisite for #65941
@mdtro
mdtroforce-pushed
the
mdtro/apitoken-middleware-hash
branch
from
4b13f18 to
334283cCompareMarch 12, 2024 10:53
@mdtro
mdtro
marked this pull request as ready for review
March 12, 2024 11:46
@mdtro
mdtro
requested a review
from a team
as a code ownerMarch 12, 2024 11:46
mdtro
mdtro
commented
Mar 12, 2024
View reviewed changes
Comment threadsrc/sentry/api/authentication.py
Outdated

markstory
markstory
reviewed
Mar 13, 2024
View reviewed changes
Comment threadsrc/sentry/api/authentication.py
Comment threadsrc/sentry/services/hybrid_cloud/auth/serial.py
@mdtromdtro
mentioned this pull request
Mar 14, 2024
 Merged

mdtro added a commit
that referenced
this pull request
Mar 14, 2024
@mdtro
feat(hybridcloud): add index to apitokenreplica (#66947)
a806379
In support of: #65941
Adds an index for the `hashed_token` column on `ApiTokenReplica`.
@mdtro
mdtroforce-pushed
the
mdtro/apitoken-middleware-hash
branch
from
086c2f4 to
24c56a4CompareMarch 15, 2024 11:05
@codecov
codecovBot
commented
Mar 15, 2024•

edited

Loading

Copy link


Copy Markdown

Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 84.32%. Comparing base (ee2cbd0) to head (3a736dc).

Report is 5 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@## master #65941 +/- ##
=======================================
Coverage 84.32% 84.32% =======================================
Files 5306 5306 Lines 237077 237093 +16 Branches 41000 41001 +1 =======================================
+ Hits 199904 199922 +18 + Misses 36955 36953 -2 
Partials 218 218 
FilesCoverage Δ
src/sentry/api/authentication.py90.45% <100.00%> (+0.49%)⬆️
src/sentry/options/defaults.py100.00% <100.00%> (ø)
src/sentry/services/hybrid_cloud/auth/model.py94.16% <100.00%> (+0.04%)⬆️
src/sentry/services/hybrid_cloud/auth/serial.py100.00% <ø> (ø)
src/sentry/services/hybrid_cloud/replica/impl.py93.61% <ø> (ø)
... and 7 files with indirect coverage changes
JonasBa pushed a commit
that referenced
this pull request
Mar 17, 2024
@mdtro@JonasBa
feat(hybridcloud): add index to apitokenreplica (#66947)
5ca4415
In support of: #65941
Adds an index for the `hashed_token` column on `ApiTokenReplica`.
@mdtro
mdtroforce-pushed
the
mdtro/apitoken-middleware-hash
branch
from
88a554f to
3a736dcCompareMarch 18, 2024 16:14
markstory
markstory
approved these changes
Mar 18, 2024
View reviewed changes
@markstorymarkstory
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
@mdtro
mdtro
merged commit 3ae4a10
into
masterMar 18, 2024
@mdtro
mdtro
deleted the

mdtro/apitoken-middleware-hash

branch
March 18, 2024 20:13
@mdtromdtro
added
the 
Trigger: Revert
Add to a merged PR to revert it (skips CI)
label
Mar 18, 2024
@getsentry-bot
getsentry-bot
commented
Mar 18, 2024

Copy link


Copy Markdown

Contributor
PR reverted: 92e8bd5
getsentry-bot added a commit
that referenced
this pull request
Mar 18, 2024
@getsentry-bot@mdtro
Revert "feat: hash support for user auth token middleware (#65941)"
92e8bd5
This reverts commit 3ae4a10.
Co-authored-by: mdtro <20070360+mdtro@users.noreply.github.com>
@mdtromdtro
mentioned this pull request
Mar 29, 2024
 Merged

mdtro added a commit
that referenced
this pull request
Apr 2, 2024
@mdtro
feat: hashed user auth tokens (#67969)
db950e3
- Update the `UserAuthTokenAuthentication` middleware to support hashed
token values. As tokens are used, it will store the appropriate hash
value.
- Use an option, `apitoken.use-and-update-hash-rate` that will apply the
code paths using the hashed values for lookups and updating the hashed
values on plaintext tokens randomly based on the configured rate.
- Introduce a temporary option, `apitoken.save-hash-on-create`. This
will be used in the model logic and in pre and post backfill migration
tests in the future.
This previously resulted in INC-684 via PR
#65941. The `hashed_token` and
`hashed_refresh_token` columns now have indexes.
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Apr 3, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@markstorymarkstorymarkstory approved these changes
@wedamijawedamijaAwaiting requested review from wedamija

Assignees


No one assigned


Labels

Scope: BackendAutomatically applied to PRs that change backend componentsTrigger: RevertAdd to a merged PR to revert it (skips CI)

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@mdtro@getsentry-bot@markstory

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: hash support for user auth token middleware - #65941
Merged
mdtro merged 11 commits into
masterfrom 
mdtro/apitoken-middleware-hash
Mar 18, 2024
Merged
feat: hash support for user auth token middleware#65941
mdtro merged 11 commits into
masterfrom 
mdtro/apitoken-middleware-hash
Conversation
@mdtro
@mdtromdtro
commented
Feb 27, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
  • Update the UserAuthTokenAuthentication middleware to support hashed token values. As tokens are used, it will store the appropriate hash value.
  • Introduce a temporary option, apitoken.save-hash-on-create. This will be used in the model logic and in pre and post backfill migration tests in the future.
@mdtro
mdtro
marked this pull request as ready for review
February 27, 2024 23:48
@mdtro
mdtro
requested a review
from a team
as a code ownerFebruary 27, 2024 23:48
@mdtro
mdtro
requested review from
a team and wedamijaFebruary 27, 2024 23:48
@github-actionsgithub-actionsBot
added
the 
Scope: Backend
Automatically applied to PRs that change backend components
label
Feb 27, 2024
@mdtro
mdtro
marked this pull request as draft
February 27, 2024 23:51
markstory
markstory
reviewed
Feb 28, 2024
View reviewed changes
Comment threadsrc/sentry/api/authentication.py
Outdated

Comment threadsrc/sentry/api/authentication.py
@mdtromdtro
mentioned this pull request
Mar 11, 2024
 Merged

mdtro added a commit
that referenced
this pull request
Mar 12, 2024
@mdtro
hybridcloud: add hashed_token to apitokenreplica (#66679)
744d9c7
Add `hashed_token` to `ApiTokenReplica`.
Prerequisite for #65941
@mdtro
mdtroforce-pushed
the
mdtro/apitoken-middleware-hash
branch
from
4b13f18 to
334283cCompareMarch 12, 2024 10:53
@mdtro
mdtro
marked this pull request as ready for review
March 12, 2024 11:46
@mdtro
mdtro
requested a review
from a team
as a code ownerMarch 12, 2024 11:46
mdtro
mdtro
commented
Mar 12, 2024
View reviewed changes
Comment threadsrc/sentry/api/authentication.py
Outdated

markstory
markstory
reviewed
Mar 13, 2024
View reviewed changes
Comment threadsrc/sentry/api/authentication.py
Comment threadsrc/sentry/services/hybrid_cloud/auth/serial.py
@mdtromdtro
mentioned this pull request
Mar 14, 2024
 Merged

mdtro added a commit
that referenced
this pull request
Mar 14, 2024
@mdtro
feat(hybridcloud): add index to apitokenreplica (#66947)
a806379
In support of: #65941
Adds an index for the `hashed_token` column on `ApiTokenReplica`.
@mdtro
mdtroforce-pushed
the
mdtro/apitoken-middleware-hash
branch
from
086c2f4 to
24c56a4CompareMarch 15, 2024 11:05
@codecov
codecovBot
commented
Mar 15, 2024•

edited

Loading

Copy link


Copy Markdown

Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 84.32%. Comparing base (ee2cbd0) to head (3a736dc).

Report is 5 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@## master #65941 +/- ##
=======================================
Coverage 84.32% 84.32% =======================================
Files 5306 5306 Lines 237077 237093 +16 Branches 41000 41001 +1 =======================================
+ Hits 199904 199922 +18 + Misses 36955 36953 -2 
Partials 218 218 
FilesCoverage Δ
src/sentry/api/authentication.py90.45% <100.00%> (+0.49%)⬆️
src/sentry/options/defaults.py100.00% <100.00%> (ø)
src/sentry/services/hybrid_cloud/auth/model.py94.16% <100.00%> (+0.04%)⬆️
src/sentry/services/hybrid_cloud/auth/serial.py100.00% <ø> (ø)
src/sentry/services/hybrid_cloud/replica/impl.py93.61% <ø> (ø)
... and 7 files with indirect coverage changes
JonasBa pushed a commit
that referenced
this pull request
Mar 17, 2024
@mdtro@JonasBa
feat(hybridcloud): add index to apitokenreplica (#66947)
5ca4415
In support of: #65941
Adds an index for the `hashed_token` column on `ApiTokenReplica`.
@mdtro
mdtroforce-pushed
the
mdtro/apitoken-middleware-hash
branch
from
88a554f to
3a736dcCompareMarch 18, 2024 16:14
markstory
markstory
approved these changes
Mar 18, 2024
View reviewed changes
@markstorymarkstory
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
@mdtro
mdtro
merged commit 3ae4a10
into
masterMar 18, 2024
@mdtro
mdtro
deleted the

mdtro/apitoken-middleware-hash

branch
March 18, 2024 20:13
@mdtromdtro
added
the 
Trigger: Revert
Add to a merged PR to revert it (skips CI)
label
Mar 18, 2024
@getsentry-bot
getsentry-bot
commented
Mar 18, 2024

Copy link


Copy Markdown

Contributor
PR reverted: 92e8bd5
getsentry-bot added a commit
that referenced
this pull request
Mar 18, 2024
@getsentry-bot@mdtro
Revert "feat: hash support for user auth token middleware (#65941)"
92e8bd5
This reverts commit 3ae4a10.
Co-authored-by: mdtro <20070360+mdtro@users.noreply.github.com>
@mdtromdtro
mentioned this pull request
Mar 29, 2024
 Merged

mdtro added a commit
that referenced
this pull request
Apr 2, 2024
@mdtro
feat: hashed user auth tokens (#67969)
db950e3
- Update the `UserAuthTokenAuthentication` middleware to support hashed
token values. As tokens are used, it will store the appropriate hash
value.
- Use an option, `apitoken.use-and-update-hash-rate` that will apply the
code paths using the hashed values for lookups and updating the hashed
values on plaintext tokens randomly based on the configured rate.
- Introduce a temporary option, `apitoken.save-hash-on-create`. This
will be used in the model logic and in pre and post backfill migration
tests in the future.
This previously resulted in INC-684 via PR
#65941. The `hashed_token` and
`hashed_refresh_token` columns now have indexes.
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Apr 3, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@markstorymarkstorymarkstory approved these changes
@wedamijawedamijaAwaiting requested review from wedamija

Assignees


No one assigned


Labels

Scope: BackendAutomatically applied to PRs that change backend componentsTrigger: RevertAdd to a merged PR to revert it (skips CI)

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@mdtro@getsentry-bot@markstory

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
feat: hash support for user auth token middleware - #65941
Merged
mdtro merged 11 commits into
masterfrom 
mdtro/apitoken-middleware-hash
Mar 18, 2024
Merged
feat: hash support for user auth token middleware#65941
mdtro merged 11 commits into
masterfrom 
mdtro/apitoken-middleware-hash
Conversation
@mdtro
@mdtromdtro
commented
Feb 27, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
  • Update the UserAuthTokenAuthentication middleware to support hashed token values. As tokens are used, it will store the appropriate hash value.
  • Introduce a temporary option, apitoken.save-hash-on-create. This will be used in the model logic and in pre and post backfill migration tests in the future.
@mdtro
mdtro
marked this pull request as ready for review
February 27, 2024 23:48
@mdtro
mdtro
requested a review
from a team
as a code ownerFebruary 27, 2024 23:48
@mdtro
mdtro
requested review from
a team and wedamijaFebruary 27, 2024 23:48
@github-actionsgithub-actionsBot
added
the 
Scope: Backend
Automatically applied to PRs that change backend components
label
Feb 27, 2024
@mdtro
mdtro
marked this pull request as draft
February 27, 2024 23:51
markstory
markstory
reviewed
Feb 28, 2024
View reviewed changes
Comment threadsrc/sentry/api/authentication.py
Outdated

Comment threadsrc/sentry/api/authentication.py
@mdtromdtro
mentioned this pull request
Mar 11, 2024
 Merged

mdtro added a commit
that referenced
this pull request
Mar 12, 2024
@mdtro
hybridcloud: add hashed_token to apitokenreplica (#66679)
744d9c7
Add `hashed_token` to `ApiTokenReplica`.
Prerequisite for #65941
@mdtro
mdtroforce-pushed
the
mdtro/apitoken-middleware-hash
branch
from
4b13f18 to
334283cCompareMarch 12, 2024 10:53
@mdtro
mdtro
marked this pull request as ready for review
March 12, 2024 11:46
@mdtro
mdtro
requested a review
from a team
as a code ownerMarch 12, 2024 11:46
mdtro
mdtro
commented
Mar 12, 2024
View reviewed changes
Comment threadsrc/sentry/api/authentication.py
Outdated

markstory
markstory
reviewed
Mar 13, 2024
View reviewed changes
Comment threadsrc/sentry/api/authentication.py
Comment threadsrc/sentry/services/hybrid_cloud/auth/serial.py
@mdtromdtro
mentioned this pull request
Mar 14, 2024
 Merged

mdtro added a commit
that referenced
this pull request
Mar 14, 2024
@mdtro
feat(hybridcloud): add index to apitokenreplica (#66947)
a806379
In support of: #65941
Adds an index for the `hashed_token` column on `ApiTokenReplica`.
@mdtro
mdtroforce-pushed
the
mdtro/apitoken-middleware-hash
branch
from
086c2f4 to
24c56a4CompareMarch 15, 2024 11:05
@codecov
codecovBot
commented
Mar 15, 2024•

edited

Loading

Copy link


Copy Markdown

Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 84.32%. Comparing base (ee2cbd0) to head (3a736dc).

Report is 5 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@## master #65941 +/- ##
=======================================
Coverage 84.32% 84.32% =======================================
Files 5306 5306 Lines 237077 237093 +16 Branches 41000 41001 +1 =======================================
+ Hits 199904 199922 +18 + Misses 36955 36953 -2 
Partials 218 218 
FilesCoverage Δ
src/sentry/api/authentication.py90.45% <100.00%> (+0.49%)⬆️
src/sentry/options/defaults.py100.00% <100.00%> (ø)
src/sentry/services/hybrid_cloud/auth/model.py94.16% <100.00%> (+0.04%)⬆️
src/sentry/services/hybrid_cloud/auth/serial.py100.00% <ø> (ø)
src/sentry/services/hybrid_cloud/replica/impl.py93.61% <ø> (ø)
... and 7 files with indirect coverage changes
JonasBa pushed a commit
that referenced
this pull request
Mar 17, 2024
@mdtro@JonasBa
feat(hybridcloud): add index to apitokenreplica (#66947)
5ca4415
In support of: #65941
Adds an index for the `hashed_token` column on `ApiTokenReplica`.
@mdtro
mdtroforce-pushed
the
mdtro/apitoken-middleware-hash
branch
from
88a554f to
3a736dcCompareMarch 18, 2024 16:14
markstory
markstory
approved these changes
Mar 18, 2024
View reviewed changes
@markstorymarkstory
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
@mdtro
mdtro
merged commit 3ae4a10
into
masterMar 18, 2024
@mdtro
mdtro
deleted the

mdtro/apitoken-middleware-hash

branch
March 18, 2024 20:13
@mdtromdtro
added
the 
Trigger: Revert
Add to a merged PR to revert it (skips CI)
label
Mar 18, 2024
@getsentry-bot
getsentry-bot
commented
Mar 18, 2024

Copy link


Copy Markdown

Contributor
PR reverted: 92e8bd5
getsentry-bot added a commit
that referenced
this pull request
Mar 18, 2024
@getsentry-bot@mdtro
Revert "feat: hash support for user auth token middleware (#65941)"
92e8bd5
This reverts commit 3ae4a10.
Co-authored-by: mdtro <20070360+mdtro@users.noreply.github.com>
@mdtromdtro
mentioned this pull request
Mar 29, 2024
 Merged

mdtro added a commit
that referenced
this pull request
Apr 2, 2024
@mdtro
feat: hashed user auth tokens (#67969)
db950e3
- Update the `UserAuthTokenAuthentication` middleware to support hashed
token values. As tokens are used, it will store the appropriate hash
value.
- Use an option, `apitoken.use-and-update-hash-rate` that will apply the
code paths using the hashed values for lookups and updating the hashed
values on plaintext tokens randomly based on the configured rate.
- Introduce a temporary option, `apitoken.save-hash-on-create`. This
will be used in the model logic and in pre and post backfill migration
tests in the future.
This previously resulted in INC-684 via PR
#65941. The `hashed_token` and
`hashed_refresh_token` columns now have indexes.
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Apr 3, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@markstorymarkstorymarkstory approved these changes
@wedamijawedamijaAwaiting requested review from wedamija

Assignees


No one assigned


Labels

Scope: BackendAutomatically applied to PRs that change backend componentsTrigger: RevertAdd to a merged PR to revert it (skips CI)

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@mdtro@getsentry-bot@markstory