Uh oh!
There was an error while loading. Please reload this page.
USPR-13770: bump io.netty minimum version to 4.2.16.Final - #386
Open
midnight-clue[bot] wants to merge 2 commits into
Open
USPR-13770: bump io.netty minimum version to 4.2.16.Final#386midnight-clue[bot] wants to merge 2 commits into
midnight-clue[bot] wants to merge 2 commits into
Conversation
Resolves GHSA-q4f6-jm68-57ww (Dependabot alert #111): HttpContentEncoder unbounded per-connection queue growth via HTTP/1.1 pipelining in io.netty:netty-codec-http. Co-Authored-By: Catarina Pinheiro Correia <catarina.correia@getyourguide.com>
Keep the example Spring Boot modules' netty.version BOM override in lockstep with the root build.gradle resolutionStrategy floor bumped for GHSA-q4f6-jm68-57ww. Co-Authored-By: Catarina Pinheiro Correia <catarina.correia@getyourguide.com>
ContributorAuthor
🤖 CI finished with 1 workflow I can't resolve on my own (cancelled, awaiting manual approval, or superseded):
A human needs to take a look — I've left the PR as-is and stopped here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context & Problem
GitHub Security Alert (Dependabot alert #111) flagged
io.netty:netty-codec-httpfor a moderate-severity DoS vulnerability (GHSA-q4f6-jm68-57ww): unbounded per-connection queue growth via HTTP/1.1 pipelining inHttpContentEncoder, affecting versions >= 4.2.0.Final and <= 4.2.15.Final, fixed in Netty 4.2.16.Final. The repo already has aresolutionStrategyoverride pinningio.nettyto4.2.15.Finalfrom a previous round of CVE fixes (USPR-13707), which needed to be bumped. See USPR-13770.Solution
Bumped the existing
io.nettyresolutionStrategy.eachDependencyoverride inbuild.gradle(the same mechanism used for prior Netty/Jackson/Logback/Tomcat CVE fixes) so it now forces anyio.nettydependency below4.2.16.Finalup to4.2.16.Final, and added the GHSA-q4f6-jm68-57ww reference to thebecause()comment alongside the existing advisory list. No new override block was introduced — this is a version-threshold bump within the pre-existing pattern, consistent with how the prior CVE round was handled.Verification
io.nettydependencies are forced to at least4.2.16.Final(updatedrequested.version < '4.2.16.Final'check anduseVersion('4.2.16.Final')inbuild.gradle)because()comment updated to reference GHSA-q4f6-jm68-57ww alongside the existing advisories, with the fixed version corrected to 4.2.16.Final./gradlew buildEnvironmentthat the build configuration parses correctly