Wire "Ask Murthy" to Android's on-device model/voice too - #2
Merged
Merged
Conversation
Picks AndroidLlamaAssistantService/FlutterTtsVoiceService on Android and the existing LinuxProcessAssistantService/LinuxProcessVoiceService on Linux desktop — Android needs no .env setup since it downloads its own model, so the section now shows unconditionally there. Adds the INTERNET permission explicitly for that download (Firebase already merges it in, but this is a big enough new use of it to declare on its own). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019E1aAx9dTscKLKfdrnc7cz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AndroidLlamaAssistantService/FlutterTtsVoiceServiceon Android and the existingLinuxProcessAssistantService/LinuxProcessVoiceServiceon Linux desktop for "Ask Murthy" (seedaily_routine_sdkPRs #2 and #3, both merged).envsetup since it downloads its own model, so the section now shows unconditionally there (Linux desktop still gated onMurthyAssistantConfigbeing configured)INTERNETpermission explicitly for that model download (Firebase already merges it in, but this is a big enough new use of it to declare on its own)Follow-up to #1 (merged)
This branch had an Android-wiring commit land just after #1 merged, so it needed a fresh PR rather than reopening #1.
Caveats
AndroidLlamaAssistantService, which is Dart-API-verified againstllama_cpp_dart0.2.2's real source but not yet built/run on an actual Android device — see that class's doc comment indaily_routine_sdkTest plan
flutter analyze/flutter testpass.env)🤖 Generated with Claude Code
https://claude.ai/code/session_019E1aAx9dTscKLKfdrnc7cz
Generated by Claude Code