Simplify logging by autayeu · Pull Request #233 · git-commit-id/git-commit-id-maven-plugin

autayeu · 2016-01-01T23:48:23Z

This pull contains the following changes (in addition to logging simplification itself)

logging is now standard Maven (no separation of logs to stderr, no shading)
docs (formatting mostly) improved
various typos fixed
updated dependencies (project and plugins, relevant for Update jgit version to v4.0.1.201506240215-r #216)
various clean-ups (diamonds, Java 7, try with resources, etc)
some clean-ups of testing rigs in production code
thread safety violation via static variable is fixed

… Maven logging. log message string construction to address.

…unique per test to avoid test lock-ups on Windows due to locked files (also enables parallel testing)

…ction code

…variable violates thread safety

ktoso · 2016-01-02T21:48:08Z

funny one, thanks (and for all the other typos too, thanks)

mvitz · 2016-01-03T12:44:34Z

Could be even shortened to <encoding>UTF-8</encoding> if I remember correctly.

mvitz · 2016-01-03T12:50:37Z

I like most of this PR but (maybe just as a note to myself) this makes the modularisation effort (see #92 for the discussion) even harder as now everything is dependent on maven.

…ularization (git-commit-id#92)

…a ones

…plugin-specific exception to address Michael comment about modularization (git-commit-id#92)

autayeu · 2016-01-03T16:58:24Z

Thank you for a thorough review!

I've addressed the comments above. Namely, logging bridges now are improved. In addition, I've refactored exception handling to favor modularization, removed few remaining static collection constructors, added project encoding handling to avoid hard-coded charsets.

It turns out property="session" removed earlier is needed. This case stresses the need for proper integration testing: I only got this one with manual testing. It should have been done by integration tests.

Please, review and merge. Thank you!

autayeu · 2016-01-07T19:09:53Z

Is there any other outstanding issues with this branch which we need to consider?

ktoso · 2016-01-07T19:13:35Z

I'll need to find time to review again – we don't want to make the modularisation effort harder, as mentioned by @mvitz. Please bear with me :)

autayeu · 2016-01-07T19:28:40Z

OK!

autayeu · 2016-01-13T19:33:34Z

Konrad, please, can you take a look at this pull request? Thank you!

autayeu · 2016-02-07T22:33:40Z

Konrad, what are the chances of seeing this merged?

ktoso · 2016-02-09T12:21:07Z

I'll review again today or tomorrow, was traveling and now sick. Thanks for your patience

autayeu · 2016-02-09T17:48:38Z

Thank you!

autayeu · 2016-03-12T11:11:37Z

Konrad, how do I interpret the situation with this pull? You're saying you'll merge it, but months later it is still not merged.

ktoso · 2016-03-12T16:13:41Z

Please don't assume malice where none is intended – i was very sick for a few weeks and then had work travel, was unable to catch up on all things. Thanks for the ping here (that was all that's needed) – will go over it now and merge if all good :)

ktoso · 2016-03-12T16:17:55Z

Minor nitpicks but no reason to delay merging, thanks again for your patience :)

Simplify logging

autayeu · 2016-03-12T16:31:03Z

Thank you for merging! And for useful review! Now the next step - release ;)

autayeu · 2016-03-12T17:37:29Z

By the way, your above comments are not nitpicking - there were few things in the pull which were touched by me "passing by", minor refactorings, which strictly speaking should have been separated from this pull.

ktoso · 2016-03-26T19:16:32Z

+ void setVerbose(boolean verbose);
+
+/*
+ The following borrowed from SLF4J Logger.java


I had to check license compatibility... seems we're good though - MIT

autayeu · 2016-01-01T23:48:23Z

This pull contains the following changes (in addition to logging simplification itself)

logging is now standard Maven (no separation of logs to stderr, no shading)
docs (formatting mostly) improved
various typos fixed
updated dependencies (project and plugins, relevant for Update jgit version to v4.0.1.201506240215-r #216)
various clean-ups (diamonds, Java 7, try with resources, etc)
some clean-ups of testing rigs in production code
thread safety violation via static variable is fixed

… Maven logging. log message string construction to address.

…unique per test to avoid test lock-ups on Windows due to locked files (also enables parallel testing)

…ction code

…variable violates thread safety

ktoso · 2016-01-02T21:48:08Z

funny one, thanks (and for all the other typos too, thanks)

mvitz · 2016-01-03T12:44:34Z

Could be even shortened to <encoding>UTF-8</encoding> if I remember correctly.

mvitz · 2016-01-03T12:50:37Z

I like most of this PR but (maybe just as a note to myself) this makes the modularisation effort (see #92 for the discussion) even harder as now everything is dependent on maven.

…ularization (git-commit-id#92)

…a ones

…plugin-specific exception to address Michael comment about modularization (git-commit-id#92)

autayeu · 2016-01-03T16:58:24Z

Thank you for a thorough review!

I've addressed the comments above. Namely, logging bridges now are improved. In addition, I've refactored exception handling to favor modularization, removed few remaining static collection constructors, added project encoding handling to avoid hard-coded charsets.

It turns out property="session" removed earlier is needed. This case stresses the need for proper integration testing: I only got this one with manual testing. It should have been done by integration tests.

Please, review and merge. Thank you!

autayeu · 2016-01-07T19:09:53Z

Is there any other outstanding issues with this branch which we need to consider?

ktoso · 2016-01-07T19:13:35Z

I'll need to find time to review again – we don't want to make the modularisation effort harder, as mentioned by @mvitz. Please bear with me :)

autayeu · 2016-01-07T19:28:40Z

OK!

autayeu · 2016-01-13T19:33:34Z

Konrad, please, can you take a look at this pull request? Thank you!

autayeu · 2016-02-07T22:33:40Z

Konrad, what are the chances of seeing this merged?

ktoso · 2016-02-09T12:21:07Z

I'll review again today or tomorrow, was traveling and now sick. Thanks for your patience

autayeu · 2016-02-09T17:48:38Z

Thank you!

autayeu · 2016-03-12T11:11:37Z

Konrad, how do I interpret the situation with this pull? You're saying you'll merge it, but months later it is still not merged.

ktoso · 2016-03-12T16:13:41Z

Please don't assume malice where none is intended – i was very sick for a few weeks and then had work travel, was unable to catch up on all things. Thanks for the ping here (that was all that's needed) – will go over it now and merge if all good :)

ktoso · 2016-03-12T16:17:55Z

Minor nitpicks but no reason to delay merging, thanks again for your patience :)

Simplify logging

autayeu · 2016-03-12T16:31:03Z

Thank you for merging! And for useful review! Now the next step - release ;)

autayeu · 2016-03-12T17:37:29Z

By the way, your above comments are not nitpicking - there were few things in the pull which were touched by me "passing by", minor refactorings, which strictly speaking should have been separated from this pull.

ktoso · 2016-03-26T19:16:32Z

+ void setVerbose(boolean verbose);
+
+/*
+ The following borrowed from SLF4J Logger.java


I had to check license compatibility... seems we're good though - MIT

autayeu · 2016-01-01T23:48:23Z

This pull contains the following changes (in addition to logging simplification itself)

logging is now standard Maven (no separation of logs to stderr, no shading)
docs (formatting mostly) improved
various typos fixed
updated dependencies (project and plugins, relevant for Update jgit version to v4.0.1.201506240215-r #216)
various clean-ups (diamonds, Java 7, try with resources, etc)
some clean-ups of testing rigs in production code
thread safety violation via static variable is fixed

… Maven logging. log message string construction to address.

…unique per test to avoid test lock-ups on Windows due to locked files (also enables parallel testing)

…ction code

…variable violates thread safety

ktoso · 2016-01-02T21:48:08Z

funny one, thanks (and for all the other typos too, thanks)

mvitz · 2016-01-03T12:44:34Z

Could be even shortened to <encoding>UTF-8</encoding> if I remember correctly.

mvitz · 2016-01-03T12:50:37Z

I like most of this PR but (maybe just as a note to myself) this makes the modularisation effort (see #92 for the discussion) even harder as now everything is dependent on maven.

…ularization (git-commit-id#92)

…a ones

…plugin-specific exception to address Michael comment about modularization (git-commit-id#92)

autayeu · 2016-01-03T16:58:24Z

Thank you for a thorough review!

I've addressed the comments above. Namely, logging bridges now are improved. In addition, I've refactored exception handling to favor modularization, removed few remaining static collection constructors, added project encoding handling to avoid hard-coded charsets.

It turns out property="session" removed earlier is needed. This case stresses the need for proper integration testing: I only got this one with manual testing. It should have been done by integration tests.

Please, review and merge. Thank you!

autayeu · 2016-01-07T19:09:53Z

Is there any other outstanding issues with this branch which we need to consider?

ktoso · 2016-01-07T19:13:35Z

I'll need to find time to review again – we don't want to make the modularisation effort harder, as mentioned by @mvitz. Please bear with me :)

autayeu · 2016-01-07T19:28:40Z

OK!

autayeu · 2016-01-13T19:33:34Z

Konrad, please, can you take a look at this pull request? Thank you!

autayeu · 2016-02-07T22:33:40Z

Konrad, what are the chances of seeing this merged?

ktoso · 2016-02-09T12:21:07Z

I'll review again today or tomorrow, was traveling and now sick. Thanks for your patience

autayeu · 2016-02-09T17:48:38Z

Thank you!

autayeu · 2016-03-12T11:11:37Z

Konrad, how do I interpret the situation with this pull? You're saying you'll merge it, but months later it is still not merged.

ktoso · 2016-03-12T16:13:41Z

Please don't assume malice where none is intended – i was very sick for a few weeks and then had work travel, was unable to catch up on all things. Thanks for the ping here (that was all that's needed) – will go over it now and merge if all good :)

ktoso · 2016-03-12T16:17:55Z

Minor nitpicks but no reason to delay merging, thanks again for your patience :)

Simplify logging

autayeu · 2016-03-12T16:31:03Z

Thank you for merging! And for useful review! Now the next step - release ;)

autayeu · 2016-03-12T17:37:29Z

By the way, your above comments are not nitpicking - there were few things in the pull which were touched by me "passing by", minor refactorings, which strictly speaking should have been separated from this pull.

ktoso · 2016-03-26T19:16:32Z

+ void setVerbose(boolean verbose);
+
+/*
+ The following borrowed from SLF4J Logger.java


I had to check license compatibility... seems we're good though - MIT

autayeu · 2016-01-01T23:48:23Z

This pull contains the following changes (in addition to logging simplification itself)

logging is now standard Maven (no separation of logs to stderr, no shading)
docs (formatting mostly) improved
various typos fixed
updated dependencies (project and plugins, relevant for Update jgit version to v4.0.1.201506240215-r #216)
various clean-ups (diamonds, Java 7, try with resources, etc)
some clean-ups of testing rigs in production code
thread safety violation via static variable is fixed

… Maven logging. log message string construction to address.

…unique per test to avoid test lock-ups on Windows due to locked files (also enables parallel testing)

…ction code

…variable violates thread safety

ktoso · 2016-01-02T21:48:08Z

funny one, thanks (and for all the other typos too, thanks)

mvitz · 2016-01-03T12:44:34Z

Could be even shortened to <encoding>UTF-8</encoding> if I remember correctly.

mvitz · 2016-01-03T12:50:37Z

I like most of this PR but (maybe just as a note to myself) this makes the modularisation effort (see #92 for the discussion) even harder as now everything is dependent on maven.

…ularization (git-commit-id#92)

…a ones

…plugin-specific exception to address Michael comment about modularization (git-commit-id#92)

autayeu · 2016-01-03T16:58:24Z

Thank you for a thorough review!

I've addressed the comments above. Namely, logging bridges now are improved. In addition, I've refactored exception handling to favor modularization, removed few remaining static collection constructors, added project encoding handling to avoid hard-coded charsets.

It turns out property="session" removed earlier is needed. This case stresses the need for proper integration testing: I only got this one with manual testing. It should have been done by integration tests.

Please, review and merge. Thank you!

autayeu · 2016-01-07T19:09:53Z

Is there any other outstanding issues with this branch which we need to consider?

ktoso · 2016-01-07T19:13:35Z

I'll need to find time to review again – we don't want to make the modularisation effort harder, as mentioned by @mvitz. Please bear with me :)

autayeu · 2016-01-07T19:28:40Z

OK!

autayeu · 2016-01-13T19:33:34Z

Konrad, please, can you take a look at this pull request? Thank you!

autayeu · 2016-02-07T22:33:40Z

Konrad, what are the chances of seeing this merged?

ktoso · 2016-02-09T12:21:07Z

I'll review again today or tomorrow, was traveling and now sick. Thanks for your patience

autayeu · 2016-02-09T17:48:38Z

Thank you!

autayeu · 2016-03-12T11:11:37Z

Konrad, how do I interpret the situation with this pull? You're saying you'll merge it, but months later it is still not merged.

ktoso · 2016-03-12T16:13:41Z

Please don't assume malice where none is intended – i was very sick for a few weeks and then had work travel, was unable to catch up on all things. Thanks for the ping here (that was all that's needed) – will go over it now and merge if all good :)

ktoso · 2016-03-12T16:17:55Z

Minor nitpicks but no reason to delay merging, thanks again for your patience :)

Simplify logging

autayeu · 2016-03-12T16:31:03Z

Thank you for merging! And for useful review! Now the next step - release ;)

autayeu · 2016-03-12T17:37:29Z

By the way, your above comments are not nitpicking - there were few things in the pull which were touched by me "passing by", minor refactorings, which strictly speaking should have been separated from this pull.

ktoso · 2016-03-26T19:16:32Z

+ void setVerbose(boolean verbose);
+
+/*
+ The following borrowed from SLF4J Logger.java


I had to check license compatibility... seems we're good though - MIT

autayeu · 2016-01-01T23:48:23Z

This pull contains the following changes (in addition to logging simplification itself)

logging is now standard Maven (no separation of logs to stderr, no shading)
docs (formatting mostly) improved
various typos fixed
updated dependencies (project and plugins, relevant for Update jgit version to v4.0.1.201506240215-r #216)
various clean-ups (diamonds, Java 7, try with resources, etc)
some clean-ups of testing rigs in production code
thread safety violation via static variable is fixed

… Maven logging. log message string construction to address.

…unique per test to avoid test lock-ups on Windows due to locked files (also enables parallel testing)

…ction code

…variable violates thread safety

ktoso · 2016-01-02T21:48:08Z

funny one, thanks (and for all the other typos too, thanks)

mvitz · 2016-01-03T12:44:34Z

Could be even shortened to <encoding>UTF-8</encoding> if I remember correctly.

mvitz · 2016-01-03T12:50:37Z

I like most of this PR but (maybe just as a note to myself) this makes the modularisation effort (see #92 for the discussion) even harder as now everything is dependent on maven.

…ularization (git-commit-id#92)

…a ones

…plugin-specific exception to address Michael comment about modularization (git-commit-id#92)

autayeu · 2016-01-03T16:58:24Z

Thank you for a thorough review!

I've addressed the comments above. Namely, logging bridges now are improved. In addition, I've refactored exception handling to favor modularization, removed few remaining static collection constructors, added project encoding handling to avoid hard-coded charsets.

It turns out property="session" removed earlier is needed. This case stresses the need for proper integration testing: I only got this one with manual testing. It should have been done by integration tests.

Please, review and merge. Thank you!

autayeu · 2016-01-07T19:09:53Z

Is there any other outstanding issues with this branch which we need to consider?

ktoso · 2016-01-07T19:13:35Z

I'll need to find time to review again – we don't want to make the modularisation effort harder, as mentioned by @mvitz. Please bear with me :)

autayeu · 2016-01-07T19:28:40Z

OK!

autayeu · 2016-01-13T19:33:34Z

Konrad, please, can you take a look at this pull request? Thank you!

autayeu · 2016-02-07T22:33:40Z

Konrad, what are the chances of seeing this merged?

ktoso · 2016-02-09T12:21:07Z

I'll review again today or tomorrow, was traveling and now sick. Thanks for your patience

autayeu · 2016-02-09T17:48:38Z

Thank you!

autayeu · 2016-03-12T11:11:37Z

Konrad, how do I interpret the situation with this pull? You're saying you'll merge it, but months later it is still not merged.

ktoso · 2016-03-12T16:13:41Z

Please don't assume malice where none is intended – i was very sick for a few weeks and then had work travel, was unable to catch up on all things. Thanks for the ping here (that was all that's needed) – will go over it now and merge if all good :)

ktoso · 2016-03-12T16:17:55Z

Minor nitpicks but no reason to delay merging, thanks again for your patience :)

Simplify logging

autayeu · 2016-03-12T16:31:03Z

Thank you for merging! And for useful review! Now the next step - release ;)

autayeu · 2016-03-12T17:37:29Z

By the way, your above comments are not nitpicking - there were few things in the pull which were touched by me "passing by", minor refactorings, which strictly speaking should have been separated from this pull.

ktoso · 2016-03-26T19:16:32Z

+ void setVerbose(boolean verbose);
+
+/*
+ The following borrowed from SLF4J Logger.java


I had to check license compatibility... seems we're good though - MIT

autayeu · 2016-01-01T23:48:23Z

This pull contains the following changes (in addition to logging simplification itself)

logging is now standard Maven (no separation of logs to stderr, no shading)
docs (formatting mostly) improved
various typos fixed
updated dependencies (project and plugins, relevant for Update jgit version to v4.0.1.201506240215-r #216)
various clean-ups (diamonds, Java 7, try with resources, etc)
some clean-ups of testing rigs in production code
thread safety violation via static variable is fixed

… Maven logging. log message string construction to address.

…unique per test to avoid test lock-ups on Windows due to locked files (also enables parallel testing)

…ction code

…variable violates thread safety

ktoso · 2016-01-02T21:48:08Z

funny one, thanks (and for all the other typos too, thanks)

mvitz · 2016-01-03T12:44:34Z

Could be even shortened to <encoding>UTF-8</encoding> if I remember correctly.

mvitz · 2016-01-03T12:50:37Z

I like most of this PR but (maybe just as a note to myself) this makes the modularisation effort (see #92 for the discussion) even harder as now everything is dependent on maven.

…ularization (git-commit-id#92)

…a ones

…plugin-specific exception to address Michael comment about modularization (git-commit-id#92)

autayeu · 2016-01-03T16:58:24Z

Thank you for a thorough review!

I've addressed the comments above. Namely, logging bridges now are improved. In addition, I've refactored exception handling to favor modularization, removed few remaining static collection constructors, added project encoding handling to avoid hard-coded charsets.

It turns out property="session" removed earlier is needed. This case stresses the need for proper integration testing: I only got this one with manual testing. It should have been done by integration tests.

Please, review and merge. Thank you!

autayeu · 2016-01-07T19:09:53Z

Is there any other outstanding issues with this branch which we need to consider?

ktoso · 2016-01-07T19:13:35Z

I'll need to find time to review again – we don't want to make the modularisation effort harder, as mentioned by @mvitz. Please bear with me :)

autayeu · 2016-01-07T19:28:40Z

OK!

autayeu · 2016-01-13T19:33:34Z

Konrad, please, can you take a look at this pull request? Thank you!

autayeu · 2016-02-07T22:33:40Z

Konrad, what are the chances of seeing this merged?

ktoso · 2016-02-09T12:21:07Z

I'll review again today or tomorrow, was traveling and now sick. Thanks for your patience

autayeu · 2016-02-09T17:48:38Z

Thank you!

autayeu · 2016-03-12T11:11:37Z

Konrad, how do I interpret the situation with this pull? You're saying you'll merge it, but months later it is still not merged.

ktoso · 2016-03-12T16:13:41Z

Please don't assume malice where none is intended – i was very sick for a few weeks and then had work travel, was unable to catch up on all things. Thanks for the ping here (that was all that's needed) – will go over it now and merge if all good :)

ktoso · 2016-03-12T16:17:55Z

Minor nitpicks but no reason to delay merging, thanks again for your patience :)

Simplify logging

autayeu · 2016-03-12T16:31:03Z

Thank you for merging! And for useful review! Now the next step - release ;)

autayeu · 2016-03-12T17:37:29Z

By the way, your above comments are not nitpicking - there were few things in the pull which were touched by me "passing by", minor refactorings, which strictly speaking should have been separated from this pull.

ktoso · 2016-03-26T19:16:32Z

+ void setVerbose(boolean verbose);
+
+/*
+ The following borrowed from SLF4J Logger.java


I had to check license compatibility... seems we're good though - MIT

autayeu · 2016-01-01T23:48:23Z

This pull contains the following changes (in addition to logging simplification itself)

logging is now standard Maven (no separation of logs to stderr, no shading)
docs (formatting mostly) improved
various typos fixed
updated dependencies (project and plugins, relevant for Update jgit version to v4.0.1.201506240215-r #216)
various clean-ups (diamonds, Java 7, try with resources, etc)
some clean-ups of testing rigs in production code
thread safety violation via static variable is fixed

… Maven logging. log message string construction to address.

…unique per test to avoid test lock-ups on Windows due to locked files (also enables parallel testing)

…ction code

…variable violates thread safety

ktoso · 2016-01-02T21:48:08Z

funny one, thanks (and for all the other typos too, thanks)

mvitz · 2016-01-03T12:44:34Z

Could be even shortened to <encoding>UTF-8</encoding> if I remember correctly.

mvitz · 2016-01-03T12:50:37Z

I like most of this PR but (maybe just as a note to myself) this makes the modularisation effort (see #92 for the discussion) even harder as now everything is dependent on maven.

…ularization (git-commit-id#92)

…a ones

…plugin-specific exception to address Michael comment about modularization (git-commit-id#92)

autayeu · 2016-01-03T16:58:24Z

Thank you for a thorough review!

I've addressed the comments above. Namely, logging bridges now are improved. In addition, I've refactored exception handling to favor modularization, removed few remaining static collection constructors, added project encoding handling to avoid hard-coded charsets.

It turns out property="session" removed earlier is needed. This case stresses the need for proper integration testing: I only got this one with manual testing. It should have been done by integration tests.

Please, review and merge. Thank you!

autayeu · 2016-01-07T19:09:53Z

Is there any other outstanding issues with this branch which we need to consider?

ktoso · 2016-01-07T19:13:35Z

I'll need to find time to review again – we don't want to make the modularisation effort harder, as mentioned by @mvitz. Please bear with me :)

autayeu · 2016-01-07T19:28:40Z

OK!

autayeu · 2016-01-13T19:33:34Z

Konrad, please, can you take a look at this pull request? Thank you!

autayeu · 2016-02-07T22:33:40Z

Konrad, what are the chances of seeing this merged?

ktoso · 2016-02-09T12:21:07Z

I'll review again today or tomorrow, was traveling and now sick. Thanks for your patience

autayeu · 2016-02-09T17:48:38Z

Thank you!

autayeu · 2016-03-12T11:11:37Z

Konrad, how do I interpret the situation with this pull? You're saying you'll merge it, but months later it is still not merged.

ktoso · 2016-03-12T16:13:41Z

Please don't assume malice where none is intended – i was very sick for a few weeks and then had work travel, was unable to catch up on all things. Thanks for the ping here (that was all that's needed) – will go over it now and merge if all good :)

ktoso · 2016-03-12T16:17:55Z

Minor nitpicks but no reason to delay merging, thanks again for your patience :)

Simplify logging

autayeu · 2016-03-12T16:31:03Z

Thank you for merging! And for useful review! Now the next step - release ;)

autayeu · 2016-03-12T17:37:29Z

By the way, your above comments are not nitpicking - there were few things in the pull which were touched by me "passing by", minor refactorings, which strictly speaking should have been separated from this pull.

ktoso · 2016-03-26T19:16:32Z

+ void setVerbose(boolean verbose);
+
+/*
+ The following borrowed from SLF4J Logger.java


I had to check license compatibility... seems we're good though - MIT

autayeu added 13 commits December 30, 2015 23:45

first bite of logging refactoring: now logs are in line with standard…
617e466
… Maven logging. log message string construction to address.

improved description logical order
c565788

dep updated, plugin management added
e4827eb

minor refactorings and typos
4274dfc

removed newCollection methods as irrelevant for Java 7
38a94f9

removed CLEANUP_FIRST - not needed anymore, sandbox repositories are …
ac6ced4
…unique per test to avoid test lock-ups on Windows due to locked files (also enables parallel testing)

try with resources
30bbc78

removed runningTests variable and special treatment of tests in produ…
83d36d8
…ction code

removed unused verbose variable
530497c

improved docs and annotations
4990e81

refactored commitIdGenerationMode processing because changing static …
7dd2e85
…variable violates thread safety

improved formatting for command line help display
f63c67f

avoid copying test repositories with other test resources
c6ba6ae

ktoso reviewed Jan 2, 2016
View reviewed changes

Comment threadREADME.md
ktosoJan 2, 2016
Copy link
Copy Markdown
Collaborator
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
funny one, thanks (and for all the other typos too, thanks)

mvitz reviewed Jan 3, 2016
View reviewed changes

Comment threadpom.xml
mvitzJan 3, 2016
Copy link
Copy Markdown
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be even shortened to <encoding>UTF-8</encoding> if I remember correctly.

autayeu added 4 commits January 3, 2016 16:44

bridging logging to address Konrad and Michael comments regarding mod…
5f76cde
…ularization (git-commit-id#92)

replaced static collection constructors from Google with standard Jav…
fed04ca
…a ones

replaced MojoExecutionException with GitCommitIdExecutionException - …
01ee123
…plugin-specific exception to address Michael comment about modularization (git-commit-id#92)

adhere to project encoding while reading-writing property files
2e9482b

autayeu mentioned this pull request Jan 13, 2016
Slf4j Misuse #230
Closed

ktoso added a commit that referenced this pull request Mar 12, 2016
Merge pull request#233from autayeu/simplify-logging
80abddb
Simplify logging

ktoso merged commit 80abddb into git-commit-id:masterMar 12, 2016

ktoso mentioned this pull request Mar 15, 2016
Fix for Slf4j misuse #231
Closed

ktoso mentioned this pull request Mar 26, 2016
Update jgit version to v4.0.1.201506240215-r #216
Closed

ktoso reviewed Mar 26, 2016
View reviewed changes

TheSnoozer mentioned this pull request Jun 8, 2016
Avoid the fat-slf4j-jar and solve the logging issue in a better way #202
Closed

TheSnoozer added this to the 2.2.1 milestone Jun 8, 2016

TheSnoozer mentioned this pull request Aug 28, 2016
Open Maven issue we should keep on the watch list #199
Closed
4 tasks