Skip to content

feature(repository): add listPullRequestReviews - #454

Open
SimonBarendse wants to merge 1 commit into
github-tools:masterfrom
SimonBarendse:453_list_pull_request_reviews
Open

feature(repository): add listPullRequestReviews#454
SimonBarendse wants to merge 1 commit into
github-tools:masterfrom
SimonBarendse:453_list_pull_request_reviews

Conversation

@SimonBarendse

Copy link
Copy Markdown

resolves#453

@mtscout6mtscout6 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for this

@SimonBarendse
SimonBarendseforce-pushed the 453_list_pull_request_reviews branch 3 times, most recently from 16724f5 to c73059aCompareSeptember 3, 2017 22:35
@SimonBarendse
SimonBarendseforce-pushed the 453_list_pull_request_reviews branch from c73059a to 3f9e5a2CompareSeptember 3, 2017 23:27
@SimonBarendseSimonBarendse changed the title Add listPullRequestReviews method to Repostitory classfeature(repository): add listPullRequestReviewsSep 3, 2017
@SimonBarendse

Copy link
Copy Markdown
Author

@mtscout6 I've added a test.

@esbanarango

Copy link
Copy Markdown

@mtscout6@SimonBarendse Anything in particular tat prevents this PR to be merged?

@j-rewerts

Copy link
Copy Markdown
Member

I think we've got to get this pointed to an actual test repository that has test reviews on it. @SimonBarendse Could you switch to using the test user for your test?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

List reviews on a Pull Request

4 participants

@SimonBarendse@esbanarango@j-rewerts@mtscout6