Uh oh!
There was an error while loading. Please reload this page.
Fix: Bump minimum macOS deployment target to 13.0 to match ComposableArchitecture requirement#809
Conversation
…wift files Agent-Logs-Url: https://github.com/github/CopilotForXcode/sessions/7096e011-d9d9-4710-b6aa-426ae95f1a7b Co-authored-by: CroffZ <18088142+CroffZ@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the Swift Package Manager manifests to require macOS 13.0, aligning the local packages’ declared minimum platform with the minimum required by swift-composable-architecture and unblocking the failing Swift CodeQL build.
Changes:
- Bump
Toolpackage minimum macOS platform from 12 → 13. - Bump
Corepackage minimum macOS platform from 12 → 13.
Show a summary per file
| File | Description |
|---|---|
| Tool/Package.swift | Raises Tool package minimum macOS version to 13.0. |
| Core/Package.swift | Raises Core package minimum macOS version to 13.0. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 2
| let package = Package( | ||
| name: "Tool", | ||
| platforms: [.macOS(.v12)], | ||
| platforms: [.macOS(.v13)], |
There was a problem hiding this comment.
Raising the SPM minimum platform to macOS 13.0 may require updating the Xcode targets’ deployment target as well. The Xcode project currently sets MACOSX_DEPLOYMENT_TARGET = 12.0 for several targets (e.g. Copilot for Xcode.xcodeproj/project.pbxproj:848), and those targets depend on products from Tool (e.g. XPCShared) / Core. If the app is intended to support macOS 13+ now, bump the Xcode deployment target (and any shared xcconfig) to 13.0; otherwise, consider pinning ComposableArchitecture to a version that still supports macOS 12.
There was a problem hiding this comment.
let package = Package(
name: "Tool",
platforms: [.macOS(.v13)],
| letpackage=Package( | ||
| name:"Core", | ||
| platforms:[.macOS(.v12)], | ||
| platforms:[.macOS(.v13)], |
There was a problem hiding this comment.
This change effectively drops macOS 12 support for the Core package. README.md currently documents “macOS 12+” as a requirement (README.md:29), and the Xcode project deployment targets are still set to 12.0 in multiple configurations. If macOS 13+ is now required due to ComposableArchitecture, please update the documented requirements and align Xcode build settings; otherwise, the project/package requirements will be inconsistent.
| platforms:[.macOS(.v13)], | |
| platforms:[.macOS(.v12)], |
There was a problem hiding this comment.
let package = Package(
name: "Core",
platforms: [.macOS(.v13)],
droomvriendje-stack
commented
Apr 8, 2026
ok |
| letpackage=Package( | ||
| name:"Core", | ||
| platforms:[.macOS(.v12)], | ||
| platforms:[.macOS(.v13)], |
There was a problem hiding this comment.
let package = Package(
name: "Core",
platforms: [.macOS(.v13)],
| letpackage=Package( | ||
| name:"Core", | ||
| platforms:[.macOS(.v12)], | ||
| platforms:[.macOS(.v13)], |
There was a problem hiding this comment.
let package = Package(
name: "Core",
platforms: [.macOS(.v13)],
| let package = Package( | ||
| name: "Tool", | ||
| platforms: [.macOS(.v12)], | ||
| platforms: [.macOS(.v13)], |
There was a problem hiding this comment.
let package = Package(
name: "Tool",
platforms: [.macOS(.v13)],
The
Analyze (swift)CodeQL workflow was failing at autobuild becauseComposableArchitecturenow requires macOS 13.0, whileTool/Package.swiftandCore/Package.swiftstill declared.macOS(.v12).Changes
Tool/Package.swift—.macOS(.v12)→.macOS(.v13)(affectsAppActivator,SharedUIComponents,Toast,ChatTab,ChatAPIService)Core/Package.swift—.macOS(.v12)→.macOS(.v13)(downstream consumer of the Tool package)Original prompt