Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Add metrics for inline comments - #1107
Merged
Merged
Conversation
Not yet used.
Previously `InlineCommentThreadViewModel` and `NewInlineCommentThreadViewModel` posted comments directly to `IApiClient` and then notified the `PullRequestSession` of the added comment. Simplified this by adding the functionality to post review comments to `PullRequestSession`.
jcansdaleforce-pushed
the
feature/inline-comments-metrics
branch
from
August 9, 2017 12:49
41b204a to
8927658Compare| return null; | ||
| } | ||
| /// <inheritdoc/> |
Collaborator
There was a problem hiding this comment.
Should these methods be added as part of this PR or have they snuck in from somewhere else?
ContributorAuthor
There was a problem hiding this comment.
They're part of the PR - I had to move things around a bit in order to be able to get hold of an IUsageTracker at the right place.
| } | ||
| /// <inheritdoc/> | ||
| public async Task<IPullRequestReviewCommentModel> PostReviewComment( |
Collaborator
There was a problem hiding this comment.
More new methods. This this PR depend on some other PR that hasn't been merged yet?
jcansdale
left a comment
Collaborator
There was a problem hiding this comment.
There seems to be some non-metrics related stuff in this PR. Has this snuck in from some other PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the following metrics:
NumberOfPRDetailsViewChangesNumberOfPRDetailsViewFileNumberOfPRDetailsCompareWithSolutionNumberOfPRDetailsOpenFileInSolutionNumberOfPRReviewDiffViewInlineCommentOpenNumberOfPRReviewDiffViewInlineCommentPostDepends on #1036