Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Update octokit to 0.29.0 - #1521

Merged
jcansdale merged 3 commits into
feature/pr-reviews-masterfrom
update/octokit-to-0.29.0
Mar 28, 2018
Merged

Update octokit to 0.29.0#1521
jcansdale merged 3 commits into
feature/pr-reviews-masterfrom
update/octokit-to-0.29.0

Conversation

@grokys

Copy link
Copy Markdown
Contributor

The PR reviews feature needs an updated octokit. This PR updates our octokit to the latest release 0.29.0.

Depends on #1501
Depends on editor-tools/octokit.net#4
Part of #1491

@shana
shana changed the base branch from feature/pr-reviews-master to feature/graphql-modelservice-pr-reviewsMarch 9, 2018 16:44
@shana
shana changed the base branch from feature/graphql-modelservice-pr-reviews to feature/pr-reviews-masterMarch 9, 2018 16:46
@shana
shana changed the base branch from feature/pr-reviews-master to feature/graphql-modelservice-pr-reviewsMarch 9, 2018 16:48
@grokys
grokysforce-pushed the feature/graphql-modelservice-pr-reviews branch from c649c25 to 0a20262CompareMarch 19, 2018 09:11
This is integrated a bit hackily into `ModelService`; `ModelService` doesn't really mesh well with GraphQL but without a lot of refactoring this was the best way to get things up and running.
@grokys
grokysforce-pushed the update/octokit-to-0.29.0 branch from 9349655 to 9353f41CompareMarch 19, 2018 09:26
@grokys
grokys changed the base branch from feature/graphql-modelservice-pr-reviews to feature/pr-reviews-masterMarch 19, 2018 09:27
@jcansdale
jcansdale changed the base branch from feature/pr-reviews-master to feature/pr-reviewsMarch 28, 2018 13:36
@jcansdale
jcansdale changed the base branch from feature/pr-reviews to feature/pr-reviews-masterMarch 28, 2018 13:36
@jcansdale
jcansdale merged commit f75bea3 into feature/pr-reviews-masterMar 28, 2018
@jcansdale
jcansdale deleted the update/octokit-to-0.29.0 branch March 28, 2018 13:42
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@grokys@shana@meaghanlewis@jcansdale