Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

[spike] Add View > Team Explorer button to GitHub pane command bar - #1561

Closed
jcansdale wants to merge 2 commits into
masterfrom
fixes/1558-toolbar-navigation-between-panes
Closed

[spike] Add View > Team Explorer button to GitHub pane command bar#1561
jcansdale wants to merge 2 commits into
masterfrom
fixes/1558-toolbar-navigation-between-panes

Conversation

@jcansdale

@jcansdalejcansdale commented Mar 23, 2018

Copy link
Copy Markdown
Collaborator

This PR

  • Add the View > Team Explorer button the the GitHub pane's command bar

image

image

Mentioned by @sguthals in #1558

I can go back to the list view of PRs or open a browser window into GitHub, but I can't get back to the Team Explorer home. To get there, I have to go down to the bottom and click on the Team Explorer tab.

Todo

  • An easy way to navigate back to the GitHub pane

When you try this functionality, the question quickly becomes; how do I get back to the GitHub pane.

I don't know if it's possible to add buttons to the Team Explorer command bar. If it was, the symmetry would make it feel pretty natural and discoverable. It would also let users easily return to GitHub from the Team Explorer - Changes view (which is a common workflow).

An alternative would be to allow users to click on the icon below GitHub to return to the GitHub pane. This wouldn't be available on the Team Explorer - Changes view, so users would need to navigate back via Home.

image

  • There are built in monikers for Forwards, Backwards and (maybe) Home that we could use.

This would make it consistent wit the Team Explorer and Solution Explorer tool bars:
image

Related

@jcansdalejcansdale changed the title Add view Team Explorer to GitHub pane command barAdd View > Team Explorer button to GitHub pane command barMar 23, 2018
@jcansdale

jcansdale commented Mar 23, 2018

Copy link
Copy Markdown
CollaboratorAuthor

There's an extension for viewing monikers here:
https://github.com/madskristensen/KnownMonikersExplorer

Here is the Backwards image moniker.

image

You can find the rest described here:

image

*Note, the name doesn't quite match in this case (Backwards vs Backward) 😕 *

@drguthals

Copy link
Copy Markdown

Thanks @jcansdale for this! I want to punt it to our first 3+1 week to get more feedback. I like this approach if it's the problem we want to solve. We may want to be solving a different problem though - making it less streamlined.

xmlns="http://schemas.microsoft.com/VisualStudio/2005-10-18/CommandTable"
xmlns:xs="http://www.w3.org/2001/XMLSchema">

<!-- Import the standard ImageCatalogGuid monikers -->

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sguthals Woot! 🎉 😜


<!-- Import the standard ImageCatalogGuid monikers -->
<Include href="KnownImageIds.vsct"/>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting review

@drguthalsdrguthals left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing

@drguthalsdrguthals left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing

@drguthalsdrguthals left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

@jcansdale
jcansdaleforce-pushed the fixes/1558-toolbar-navigation-between-panes branch from 7c43b4a to 7f0f3ddCompareAugust 23, 2018 16:04
@jcansdale

Copy link
Copy Markdown
CollaboratorAuthor

I've extracted the following commits to separate PRs (they shouldn't have been included in this PR):

@jcansdalejcansdale changed the title Add View > Team Explorer button to GitHub pane command bar[wip] Add View > Team Explorer button to GitHub pane command barAug 23, 2018
@jcansdalejcansdale changed the title [wip] Add View > Team Explorer button to GitHub pane command bar[spike] Add View > Team Explorer button to GitHub pane command barAug 23, 2018
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jcansdale@drguthals