Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Add PR reviews metrics. - #1567
Merged
Merged
Conversation
Adds two new metrics: - `NumberOfPRReviewDiffViewInlineCommentStartReview`: incremented when the "Start Review" button is clicked from an inline comment - `NumberOfPRReviewPosts`: incremented when a PR review is submitted
grokys
requested review from
StanleyGoldman, drguthals, jcansdale, meaghanlewis and shanaMarch 27, 2018 10:48
17 tasks
meaghanlewis
commented
Mar 27, 2018
Contributor
These metrics look good to me! Tested on VS2015 & VS2017 |
drguthals
commented
Mar 28, 2018
The first time I started a review from a diff and submitted that review it did not get recorded. I've tried twice since then and it worked. I'm going to try re-starting my experimental instance to see if the first one works when I re-start. |
drguthals
commented
Mar 29, 2018
Tests:
2015 Experimental:
2017 Experimental:
|
drguthals
approved these changes
Mar 29, 2018
drguthals
left a comment
There was a problem hiding this comment.
Looks good! Thanks for fixing that one bug. I have not been able to repro the first time that my metrics weren't updated, but I'm going to assume that was just funky with me for now.
jcansdale
changed the base branch from
feature/pr-review-authoring
to
feature/pr-reviews-masterApril 9, 2018 16:39
jcansdaleforce-pushed
the
feature/pr-review-metrics
branch
from
April 9, 2018 16:49
3ba7773 to
4e69c17Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two new metrics:
NumberOfPRReviewDiffViewInlineCommentStartReview: incremented when the "Start Review" button is clicked from an inline commentNumberOfPRReviewPosts: incremented when a PR review is submittedDepends on #1562
Part of #1491