Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Fix Octokit.GraphQL escaping issue. - #1581

Merged
jcansdale merged 2 commits into
feature/pr-reviews-masterfrom
fixes/graphql-escaping
Apr 10, 2018
Merged

Fix Octokit.GraphQL escaping issue.#1581
jcansdale merged 2 commits into
feature/pr-reviews-masterfrom
fixes/graphql-escaping

Conversation

@grokys

@grokysgrokys commented Apr 4, 2018

Copy link
Copy Markdown
Contributor

Updates the Octokit.GraphQL package to 0.0.2-alpha.

This fixes the escaping issue at octokit/octokit.graphql.net#72.

Now PR review comments that are submitted with a " character should work!

Depends on #1580
Part of #1491

@meaghanlewis

Copy link
Copy Markdown
Contributor

LGTM!

@jcansdale
jcansdale changed the base branch from feature/pr-reviews-master to feature/pr-reviewsApril 10, 2018 10:47
@jcansdale
jcansdale changed the base branch from feature/pr-reviews to feature/pr-reviews-masterApril 10, 2018 10:47

@jcansdalejcansdale left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jcansdale
jcansdale merged commit 8cfef76 into feature/pr-reviews-masterApr 10, 2018
@jcansdale
jcansdale deleted the fixes/graphql-escaping branch April 10, 2018 10:48
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@grokys@meaghanlewis@jcansdale