Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Make avatar in PR review summary clickable. - #1586

Merged
jcansdale merged 1 commit into
feature/pr-reviews-masterfrom
fixes/make-review-avatar-clickable
Apr 10, 2018
Merged

Make avatar in PR review summary clickable.#1586
jcansdale merged 1 commit into
feature/pr-reviews-masterfrom
fixes/make-review-avatar-clickable

Conversation

@grokys

@grokysgrokys commented Apr 5, 2018

Copy link
Copy Markdown
Contributor

Addresses this request in #1570:

Could we make it so you can click on either the avatar or the ✔️ / 💬? #1523 (comment)

This makes the avatar in the "Reviewers" section clickable; when clicked it navigates to the user's reviews:

image

Depends on #1585
Part of #1491

@donokudadonokuda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the changes in 02427b6 and it looks good to me.

Also pulled it down and tested the branch locally 👍

@meaghanlewis

Copy link
Copy Markdown
Contributor

LGTM 👍

@jcansdale
jcansdale changed the base branch from feature/pr-reviews-master to feature/pr-reviewsApril 10, 2018 11:05
@jcansdale
jcansdale changed the base branch from feature/pr-reviews to feature/pr-reviews-masterApril 10, 2018 11:06
@jcansdale
jcansdale merged commit cef9124 into feature/pr-reviews-masterApr 10, 2018
@jcansdale
jcansdale deleted the fixes/make-review-avatar-clickable branch April 10, 2018 11:10
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@grokys@meaghanlewis@donokuda@jcansdale