Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Update to Octokit.GraphQL to 0.1.0 - #1767

Merged
StanleyGoldman merged 11 commits into
masterfrom
refactor/pr-list-0.6-update
Jul 12, 2018
Merged

Update to Octokit.GraphQL to 0.1.0#1767
StanleyGoldman merged 11 commits into
masterfrom
refactor/pr-list-0.6-update

Conversation

@StanleyGoldman

@StanleyGoldmanStanleyGoldman commented Jun 28, 2018•
edited by grokys
Loading

Copy link
Copy Markdown
Contributor

Update Octokit.GraphQL to 0.1.0-beta version from nuget.org

Fixes#1774.

@StanleyGoldman
StanleyGoldmanforce-pushed the refactor/pr-list-0.6-update branch from 20a4923 to 82f0d6aCompareJuly 11, 2018 14:29
@grokys

grokys commented Jul 11, 2018

Copy link
Copy Markdown
Contributor

I think lib/Octokit.GraphQL.0.0.6-alpha.nupkg can be removed, right?

@grokys

grokys commented Jul 11, 2018

Copy link
Copy Markdown
Contributor

Regarding the CI failures,I'm not sure why they're failing now when they weren't failing before, but at one point I had to add a binding redirect to the unit tests project, before it was split apart:

https://github.com/github/VisualStudio/pull/1501/files#diff-1567700eee9e01c12d5752e9988072a1R7

You might have to add a similar config to all the unit test projects.

It seems strange that it worked without this on 10.0 but not on 9.0 though!

@StanleyGoldman
StanleyGoldmanforce-pushed the refactor/pr-list-0.6-update branch from dc39fa1 to b13fd61CompareJuly 11, 2018 22:28
@grokysgrokys changed the title Update to Octokit.GraphQL to 0.6-alphaUpdate to Octokit.GraphQL to 0.1.0Jul 12, 2018
@grokys
grokys changed the base branch from refactor/pr-list to masterJuly 12, 2018 08:14
grokys
grokys suggested changes Jul 12, 2018
View reviewed changes

@grokysgrokys left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, but the version is marked as 0.1.0-alpha. Shouldn't 0.1.0 be beta? Also we should probably upload it to nuget.org and use the package from there?

grokys
grokys approved these changes Jul 12, 2018
View reviewed changes

@grokysgrokys left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now using 0.1.0-beta from nuget.org.

@StanleyGoldman

StanleyGoldman commented Jul 12, 2018

Copy link
Copy Markdown
ContributorAuthor

Nice..

@StanleyGoldman
StanleyGoldman merged commit d2379e3 into masterJul 12, 2018
@grokysgrokys mentioned this pull request Oct 5, 2018
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@grokysgrokysgrokys approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@StanleyGoldman@grokys