Uh oh!
There was an error while loading. Please reload this page.
Fix extension on versions of Visual Studio 2017 earlier than 15.4.4 - #1839
Conversation
Fall back to referencing Microsoft.VisualStudio.Threading.15.0. This should maintain compatibility with versions of Visual Studio 2017 prior to 15.3. Microsoft.VisualStudio.Shell.15 has a package dependency constraint and has been changed from 15.4.27004 to 15.0.26228.
jcansdale
commented
Aug 8, 2018
@sharwell I can't for the life of me work out why changing from: <packageid="Microsoft.VisualStudio.Shell.15.0"version="15.4.27004"targetFramework="net461" />
<packageid="Microsoft.VisualStudio.Threading"version="15.4.4"targetFramework="net461" />to <packageid="Microsoft.VisualStudio.Shell.15.0"version="15.0.26228"targetFramework="net461" />
<packageid="Microsoft.VisualStudio.Threading"version="15.0.240"targetFramework="net461" />Would be necessary for an extension to install correctly on Visual Studo
This fix makes sense for the person running Have you come across anything else like this before? |
grokys
commented
Aug 10, 2018
So does it look like this doesn't actually fix the problem and it's actually the uninstall/reinstall/update process that fixes the problem? |
jcansdale
commented
Aug 10, 2018
meaghanlewis
commented
Aug 10, 2018
This LGTM! Tested on VS2017 Version 15.0.26228.48. I installed the latest release version of GHfVS ( 2.5.4.3349) which was very broken and then installed the build from this PR and all our major functionality is working again. Thanks @jcansdale 🎉 |
jcansdale
commented
Aug 10, 2018
Excellent! This sounds like a good - worst case - VM to have in reserve. 😄 |
What this PR does
15.4.4Microsoft.VisualStudio.Shell.15.0version15.0.26228Microsoft.VisualStudio.Threadingversion15.0.240This allows the extension to continue working on versions of Visual Studio 2017 earlier than
15.4.4(#1812 was a report from someone using Visual Studio15.2.6).Note, this doesn't fix either of the following (they appear to have been caused by random extension cache corruption):
How to test
Ideally we would be checking that the extension works with the first RTM version of Visual Studio 2017. I don't know if this is still available for download?
Fixes#1812 Error On Project Load (VS 15.2.6)