Uh oh!
There was an error while loading. Please reload this page.
Remove repository responsibilities from TeamExplorerServiceHolder (repository refactor part 2) - #2025
Conversation
Make ITeamExplorerServiceHolder responsible for holding references to services, but not watching for and marshaling repository change events. Delegate to ITeamExplorerContext for this.
This is no longer called by TeamExplorerServiceHolder.
Contains a call chain that results in a call to a virtual method defined by the class.
grokys
commented
Nov 7, 2018
One thing I noticed: when I change the name of the We should check to see if |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
jcansdale
commented
Nov 7, 2018
I'd be inclined to look at that in a separate PR. We need to handle the situation when there is no |
jcansdale
commented
Nov 8, 2018
Merged as part of #2028. |
What this PR does
TeamExplorerServiceHolderhas picked up responsibilities beyond holding services for the Team Explorer views. This PR removes its repository watching and event marshaling responsibilities and delegates them toITeamExplorerContext. It also removes the need for refreshing a liveLocalRepositoryModel, meaning the model can now be immutable after creation.ActiveRepo,SubscribeandUnsubscribefromITeamExplorerServiceHolderRefreshCloneUrlfromIGitServiceTeamExplorerContextandJoinableTaskFactoryfromITeamExplorerServiceHolder(for repo change events and marshaling)How to test
I've changed code that listens for repository change and refreshes the Team Explorer UI. We need to test moving between repositories and changing the clone URL.
Team Explorer - Homeviewgit remote rename _origin origingit remote rename origin _origin