Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Adding indications for protected branches - #2029

Merged
StanleyGoldman merged 12 commits into
check-second-linefrom
protected-branches
Dec 13, 2018
Merged

Adding indications for protected branches#2029
StanleyGoldman merged 12 commits into
check-second-linefrom
protected-branches

Conversation

@StanleyGoldman

@StanleyGoldmanStanleyGoldman commented Nov 2, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request depends on:

This pull request adds "required" labels in the Pull Request Checks list.
image

Needs some 💓 from @donokuda

@StanleyGoldmanStanleyGoldman changed the title Adding indications for protected branches[WIP] Adding indications for protected branchesNov 2, 2018
@StanleyGoldman

StanleyGoldman commented Dec 12, 2018

Copy link
Copy Markdown
ContributorAuthor

Hint: https://stackoverflow.com/questions/35828637/c-sharp-wpf-insert-an-elliptical-fill-inside-a-polygon

@StanleyGoldman
Merge remote-tracking branch 'origin/master' into protected-branches
8f91ca3
# Conflicts:
#	src/GitHub.App/Services/PullRequestService.cs
#	src/GitHub.App/ViewModels/GitHubPane/PullRequestCheckViewModel.cs
#	src/GitHub.Exports.Reactive/Collections/TrackingCollection.cs
#	src/GitHub.Exports.Reactive/ViewModels/GitHubPane/IPullRequestDetailViewModel.cs
#	src/GitHub.Exports/Models/CheckRunModel.cs
#	src/GitHub.VisualStudio.UI/Views/GitHubPane/PullRequestCheckView.xaml
#	test/GitHub.App.UnitTests/ViewModels/GitHubPane/PullRequestCreationViewModelTests.cs
@StanleyGoldman
Merge branch 'check-second-line' into protected-branches
3f0ac46
# Conflicts:
#	src/GitHub.VisualStudio.UI/Views/GitHubPane/PullRequestCheckView.xaml
@codecov

codecovBot commented Dec 13, 2018•
edited
Loading

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (check-second-line@a489cbe). Click here to learn what that means.
The diff coverage is 3.12%.

@@ Coverage Diff @@## check-second-line #2029 +/- ##
====================================================
Coverage ? 38.89% ====================================================
Files ? 411 Lines ? 17679 Branches ? 2447 ====================================================
Hits ? 6876 Misses ? 10256 Partials ? 547
Impacted FilesCoverage Δ
...rc/GitHub.Exports/Models/PullRequestDetailModel.cs100% <ø> (ø)
...Exports.Reactive/Collections/TrackingCollection.cs57.82% <ø> (ø)
src/GitHub.App/Services/RepositoryService.cs0% <0%> (ø)
...ViewModels/GitHubPane/PullRequestCheckViewModel.cs1.06% <0%> (ø)
src/GitHub.Exports/Models/ProtectedBranch.cs0% <0%> (ø)
...wModels/GitHubPane/PullRequestListItemViewModel.cs61.11% <0%> (ø)
src/GitHub.Exports/Models/StatusModel.cs0% <0%> (ø)
src/GitHub.App/Services/RepositoryCloneService.cs49.48% <0%> (ø)
src/GitHub.Exports/Models/CheckRunModel.cs0% <0%> (ø)
src/GitHub.App/Services/PullRequestService.cs32.29% <1.96%> (ø)
... and 2 more

@StanleyGoldman
StanleyGoldman changed the base branch from master to check-second-lineDecember 13, 2018 15:30
@StanleyGoldmanStanleyGoldman changed the title [WIP] Adding indications for protected branchesAdding indications for protected branchesDec 13, 2018
@StanleyGoldman
StanleyGoldman merged commit bda657a into check-second-lineDec 13, 2018
@StanleyGoldman
StanleyGoldman deleted the protected-branches branch December 13, 2018 16:02
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@donokudadonokuda

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@StanleyGoldman@donokuda