Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Implementing Autocompletebox - #2159

Merged
StanleyGoldman merged 32 commits into
autocompletebox-fixfrom
autocompletebox-implementation
Apr 8, 2019
Merged

Implementing Autocompletebox#2159
StanleyGoldman merged 32 commits into
autocompletebox-fixfrom
autocompletebox-implementation

Conversation

@StanleyGoldman

@StanleyGoldmanStanleyGoldman commented Jan 4, 2019

Copy link
Copy Markdown
Contributor

This pull request is the set of changes made to implement AutoCompleteBox

# Conflicts:
#	src/GitHub.VisualStudio.UI/Styles/ThemeBlue.xaml
#	src/GitHub.VisualStudio.UI/Styles/ThemeDark.xaml
#	src/GitHub.VisualStudio.UI/Styles/ThemeLight.xaml
@StanleyGoldman
StanleyGoldmanforce-pushed the autocompletebox-implementation branch from b311389 to 0dbabcdCompareFebruary 26, 2019 17:37
@meaghanlewismeaghanlewis added this to the 2.9.0 milestone Feb 26, 2019
@StanleyGoldman
StanleyGoldmanforce-pushed the autocompletebox-implementation branch from c6ddb31 to 4a2657eCompareMarch 11, 2019 16:13
@jcansdale

jcansdale commented Mar 25, 2019

Copy link
Copy Markdown
Collaborator

I just got the following exception/crash after @-ing myself and clicking on the avatar.

Application: devenv.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.InvalidOperationException
at GitHub.UI.Controls.AutoCompleteBox.AutoCompleteTextInputExtensions.GetExpandedText(GitHub.UI.IAutoCompleteTextInput, System.String, Int32)
at GitHub.UI.AutoCompleteBox.ExpandSuggestion(System.String)
at GitHub.UI.AutoCompleteBox.OnAdapterSelectionComplete(System.Object, System.Windows.RoutedEventArgs)
at GitHub.UI.SelectorSelectionAdapter.OnCommit(System.Object, System.Windows.RoutedEventArgs)
at GitHub.UI.SelectorSelectionAdapter.OnCommit()
at GitHub.UI.SelectorSelectionAdapter.OnSelectorMouseLeftButtonUp(System.Object, System.Windows.Input.MouseButtonEventArgs)
at System.Windows.Input.MouseButtonEventArgs.InvokeEventHandler(System.Delegate, System.Object)
at System.Windows.RoutedEventArgs.InvokeHandler(System.Delegate, System.Object)
at System.Windows.RoutedEventHandlerInfo.InvokeHandler(System.Object, System.Windows.RoutedEventArgs)
at System.Windows.EventRoute.InvokeHandlersImpl(System.Object, System.Windows.RoutedEventArgs, Boolean)
at System.Windows.UIElement.ReRaiseEventAs(System.Windows.DependencyObject, System.Windows.RoutedEventArgs, System.Windows.RoutedEvent)
at System.Windows.UIElement.OnMouseUpThunk(System.Object, System.Windows.Input.MouseButtonEventArgs)
at System.Windows.Input.MouseButtonEventArgs.InvokeEventHandler(System.Delegate, System.Object)
at System.Windows.RoutedEventArgs.InvokeHandler(System.Delegate, System.Object)
at System.Windows.RoutedEventHandlerInfo.InvokeHandler(System.Object, System.Windows.RoutedEventArgs)
at System.Windows.EventRoute.InvokeHandlersImpl(System.Object, System.Windows.RoutedEventArgs, Boolean)
at System.Windows.UIElement.RaiseEventImpl(System.Windows.DependencyObject, System.Windows.RoutedEventArgs)
at System.Windows.ContentElement.RaiseTrustedEvent(System.Windows.RoutedEventArgs)
at System.Windows.Input.InputManager.ProcessStagingArea()
at System.Windows.Input.InputManager.ProcessInput(System.Windows.Input.InputEventArgs)
at System.Windows.Input.InputProviderSite.ReportInput(System.Windows.Input.InputReport)
at System.Windows.Interop.HwndMouseInputProvider.ReportInput(IntPtr, System.Windows.Input.InputMode, Int32, System.Windows.Input.RawMouseActions, Int32, Int32, Int32)
at System.Windows.Interop.HwndMouseInputProvider.FilterMessage(IntPtr, MS.Internal.Interop.WindowMessage, IntPtr, IntPtr, Boolean ByRef)
at System.Windows.Interop.HwndSource.InputFilterMessage(IntPtr, Int32, IntPtr, IntPtr, Boolean ByRef)
at MS.Win32.HwndWrapper.WndProc(IntPtr, Int32, IntPtr, IntPtr, Boolean ByRef)
at MS.Win32.HwndSubclass.DispatcherCallbackOperation(System.Object)
at System.Windows.Threading.ExceptionWrapper.InternalRealCall(System.Delegate, System.Object, Int32)
at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(System.Object, System.Delegate, System.Object, Int32, System.Delegate)
at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(System.Windows.Threading.DispatcherPriority, System.TimeSpan, System.Delegate, System.Object, Int32)
at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr, Int32, IntPtr, IntPtr)

image

image

@StanleyGoldman
StanleyGoldmanforce-pushed the autocompletebox-implementation branch from dcddf52 to c40b757CompareMarch 28, 2019 15:11
@StanleyGoldmanStanleyGoldman changed the title [WIP] Implementing AutocompleteboxImplementing AutocompleteboxApr 8, 2019
@StanleyGoldman
StanleyGoldman merged commit be1ab80 into autocompletebox-fixApr 8, 2019
@StanleyGoldman
StanleyGoldman deleted the autocompletebox-implementation branch April 8, 2019 14:18
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@StanleyGoldman@jcansdale@meaghanlewis