Caching GraphQL queries by grokys · Pull Request #2181 · github/VisualStudio

grokys · 2019-01-16T13:27:47Z

This PR adds caching to GraphQL queries. It introduces a new IGraphQLClient which is used instead of (and wraps) Octokit.GraphQL's IConnection.

When a query is submitted, this class hashes the query and uses this as a cache key. Queries are cached in the filesystem using a slightly modified version of https://github.com/acarteas/FileCache.

The main complication here is that if you have say 3 pages worth of the PR list cached then pressing "Refresh" needs to clear all pages of the PR list. We use the region name to identify such queries and when refresh is pressed, call FileCache.ClearRegion. This method isn't present in the mainline FileCache which is why we ship a slightly modified version of it.

Depends on octokit/octokit.graphql.net#186

Also brought `FileCache` into our source instead of importing its package because needed to add the `ClearRegion` method.

StanleyGoldman

I don't mean to do this. This is a test.

Sorry

# Conflicts: # submodules/octokit.graphql.net

StanleyGoldman · 2019-02-28T15:50:37Z

As per conversations had on slack graphql caching will be a double edged sword. We will need to review all of our usages of the graphql library to make sure caching will not result in any user experience bugs.

StanleyGoldman · 2019-02-28T15:56:11Z

Functionality to get a page of a list of pull requests

Handled by: Caching for default 8 hours and clear on refresh

VisualStudio/src/GitHub.App/Services/PullRequestService.cs

Lines 95 to 222 in c3b597f

ICompiledQuery<Page<PullRequestListItemModel>>query;
if(address.IsGitHubDotCom())
{
if(readPullRequests==null)
{
readPullRequests=newQuery()
.Repository(owner:Var(nameof(owner)),name:Var(nameof(name)))
.PullRequests(
first:100,
after:Var(nameof(after)),
orderBy:newIssueOrder{Direction=OrderDirection.Desc,Field=IssueOrderField.CreatedAt},
states:Var(nameof(states)))
.Select(page =>newPage<PullRequestListItemModel>
{
EndCursor=page.PageInfo.EndCursor,
HasNextPage=page.PageInfo.HasNextPage,
TotalCount=page.TotalCount,
Items=page.Nodes.Select(pr =>newListItemAdapter
{
Id=pr.Id.Value,
LastCommit=pr.Commits(null,null,1,null).Nodes.Select(commit =>
newLastCommitSummaryAdapter
{
CheckSuites=commit.Commit.CheckSuites(null,null,null,null,null).AllPages(10)
.Select(suite =>newCheckSuiteSummaryModel
{
CheckRuns=suite.CheckRuns(null,null,null,null,null).AllPages(10)
.Select(run =>newCheckRunSummaryModel
{
Conclusion=run.Conclusion.FromGraphQl(),
Status=run.Status.FromGraphQl()
}).ToList(),
}).ToList(),
Statuses=commit.Commit.Status
.Select(context =>
context.Contexts.Select(statusContext =>newStatusSummaryModel
{
State=statusContext.State.FromGraphQl(),
}).ToList()
).SingleOrDefault()
}).ToList().FirstOrDefault(),
Author=newActorModel
{
Login=pr.Author.Login,
AvatarUrl=pr.Author.AvatarUrl(null),
},
CommentCount=pr.Comments(0,null,null,null).TotalCount,
Number=pr.Number,
Reviews=pr.Reviews(null,null,null,null,null,null).AllPages().Select(review =>newReviewAdapter
{
Body=review.Body,
CommentCount=review.Comments(null,null,null,null).TotalCount,
}).ToList(),
State=pr.State.FromGraphQl(),
Title=pr.Title,
UpdatedAt=pr.UpdatedAt,
}).ToList(),
}).Compile();
}
query=readPullRequests;
}
else
{
if(readPullRequestsEnterprise==null)
{
readPullRequestsEnterprise=newQuery()
.Repository(owner:Var(nameof(owner)),name:Var(nameof(name)))
.PullRequests(
first:100,
after:Var(nameof(after)),
orderBy:newIssueOrder{Direction=OrderDirection.Desc,Field=IssueOrderField.CreatedAt},
states:Var(nameof(states)))
.Select(page =>newPage<PullRequestListItemModel>
{
EndCursor=page.PageInfo.EndCursor,
HasNextPage=page.PageInfo.HasNextPage,
TotalCount=page.TotalCount,
Items=page.Nodes.Select(pr =>newListItemAdapter
{
Id=pr.Id.Value,
LastCommit=pr.Commits(null,null,1,null).Nodes.Select(commit =>
newLastCommitSummaryAdapter
{
Statuses=commit.Commit.Status.Select(context =>
context==null
?null
:context.Contexts
.Select(statusContext =>newStatusSummaryModel
{
State=statusContext.State.FromGraphQl()
}).ToList()
).SingleOrDefault()
}).ToList().FirstOrDefault(),
Author=newActorModel
{
Login=pr.Author.Login,
AvatarUrl=pr.Author.AvatarUrl(null),
},
CommentCount=pr.Comments(0,null,null,null).TotalCount,
Number=pr.Number,
Reviews=pr.Reviews(null,null,null,null,null,null).AllPages().Select(review =>newReviewAdapter
{
Body=review.Body,
CommentCount=review.Comments(null,null,null,null).TotalCount,
}).ToList(),
State=pr.State.FromGraphQl(),
Title=pr.Title,
UpdatedAt=pr.UpdatedAt,
}).ToList(),
}).Compile();
}
query=readPullRequestsEnterprise;
}
vargraphql=awaitgraphqlFactory.CreateConnection(address);
varvars=newDictionary<string,object>
{
{nameof(owner),owner},
{nameof(name),name},
{nameof(after),after},
{nameof(states),states.Select(x =>(Octokit.GraphQL.Model.PullRequestState)x).ToList()},
};
varregion=owner+'/'+name+"/pr-list";
varresult=awaitgraphql.Run(query,vars,regionName:region);

Functionality to get the pull request detail

Handled by: Caching for default 8 hours and clear on item refresh

VisualStudio/src/GitHub.InlineReviews/Services/PullRequestSessionService.cs

Lines 297 to 405 in c3b597f

if(readPullRequest==null)
{
readPullRequest=newQuery()
.Repository(owner:Var(nameof(owner)),name:Var(nameof(name)))
.PullRequest(number:Var(nameof(number)))
.Select(pr =>newPullRequestDetailModel
{
Id=pr.Id.Value,
Number=pr.Number,
Author=newActorModel
{
Login=pr.Author.Login,
AvatarUrl=pr.Author.AvatarUrl(null),
},
Title=pr.Title,
Body=pr.Body,
BaseRefSha=pr.BaseRefOid,
BaseRefName=pr.BaseRefName,
BaseRepositoryOwner=pr.Repository.Owner.Login,
HeadRefName=pr.HeadRefName,
HeadRefSha=pr.HeadRefOid,
HeadRepositoryOwner=pr.HeadRepositoryOwner!=null?pr.HeadRepositoryOwner.Login:null,
State=pr.State.FromGraphQl(),
UpdatedAt=pr.UpdatedAt,
CommentCount=pr.Comments(0,null,null,null).TotalCount,
Comments=pr.Comments(null,null,null,null).AllPages().Select(comment =>newCommentModel
{
Id=comment.Id.Value,
Author=newActorModel
{
Login=comment.Author.Login,
AvatarUrl=comment.Author.AvatarUrl(null),
},
Body=comment.Body,
CreatedAt=comment.CreatedAt,
DatabaseId=comment.DatabaseId.Value,
Url=comment.Url,
}).ToList(),
Reviews=pr.Reviews(null,null,null,null,null,null).AllPages().Select(review =>newPullRequestReviewModel
{
Id=review.Id.Value,
Body=review.Body,
CommitId=review.Commit.Oid,
State=review.State.FromGraphQl(),
SubmittedAt=review.SubmittedAt,
Author=newActorModel
{
Login=review.Author.Login,
AvatarUrl=review.Author.AvatarUrl(null),
},
Comments=review.Comments(null,null,null,null).AllPages().Select(comment =>newCommentAdapter
{
Id=comment.Id.Value,
PullRequestId=comment.PullRequest.Number,
DatabaseId=comment.DatabaseId.Value,
Author=newActorModel
{
Login=comment.Author.Login,
AvatarUrl=comment.Author.AvatarUrl(null),
},
Body=comment.Body,
Path=comment.Path,
CommitSha=comment.Commit.Oid,
DiffHunk=comment.DiffHunk,
Position=comment.Position,
OriginalPosition=comment.OriginalPosition,
OriginalCommitId=comment.OriginalCommit.Oid,
ReplyTo=comment.ReplyTo!=null?comment.ReplyTo.Id.Value:null,
CreatedAt=comment.CreatedAt,
Url=comment.Url,
}).ToList(),
}).ToList(),
Timeline=pr.Timeline(null,null,null,null,null).AllPages().Select(item =>item.Switch<object>(when=>
when.Commit(commit =>newCommitModel
{
AbbreviatedOid=commit.AbbreviatedOid,
// TODO: commit.Author.User can be null
Author=newActorModel
{
Login=commit.Author.User.Login,
AvatarUrl=commit.Author.User.AvatarUrl(null),
},
MessageHeadline=commit.MessageHeadline,
Oid=commit.Oid,
}).IssueComment(comment =>newCommentModel
{
Author=newActorModel
{
Login=comment.Author.Login,
AvatarUrl=comment.Author.AvatarUrl(null),
},
Body=comment.Body,
CreatedAt=comment.CreatedAt,
DatabaseId=comment.DatabaseId.Value,
Id=comment.Id.Value,
Url=comment.Url,
}))).ToList()
}).Compile();
}
varvars=newDictionary<string,object>
{
{nameof(owner),owner},
{nameof(name),name},
{nameof(number),number},
};
varconnection=awaitgraphqlFactory.CreateConnection(address);
varresult=awaitconnection.Run(readPullRequest,vars,refresh:refresh);

Functionality to get the last commit of a pull request for statuses

Handled by: Caching for default 8 hours and clear on item refresh

VisualStudio/src/GitHub.InlineReviews/Services/PullRequestSessionService.cs

Lines 823 to 916 in c3b597f

asyncTask<LastCommitAdapter>GetPullRequestLastCommitAdapter(HostAddressaddress,stringowner,stringname,intnumber,boolrefresh)
{
ICompiledQuery<IEnumerable<LastCommitAdapter>>query;
if(address.IsGitHubDotCom())
{
if(readCommitStatuses==null)
{
readCommitStatuses=newQuery()
.Repository(owner:Var(nameof(owner)),name:Var(nameof(name)))
.PullRequest(number:Var(nameof(number))).Commits(last:1).Nodes.Select(
 commit =>newLastCommitAdapter
{
HeadSha=commit.Commit.Oid,
CheckSuites=commit.Commit.CheckSuites(null,null,null,null,null).AllPages(10)
.Select(suite =>newCheckSuiteModel
{
CheckRuns=suite.CheckRuns(null,null,null,null,null).AllPages(10)
.Select(run =>newCheckRunModel
{
Id=run.Id.Value,
Conclusion=run.Conclusion.FromGraphQl(),
Status=run.Status.FromGraphQl(),
Name=run.Name,
DetailsUrl=run.Permalink,
Summary=run.Summary,
Text=run.Text,
Annotations=run.Annotations(null,null,null,null).AllPages()
.Select(annotation =>newCheckRunAnnotationModel
{
Title=annotation.Title,
Message=annotation.Message,
Path=annotation.Path,
AnnotationLevel=annotation.AnnotationLevel.Value.FromGraphQl(),
StartLine=annotation.Location.Start.Line,
EndLine=annotation.Location.End.Line,
}).ToList()
}).ToList(),
ApplicationName=suite.App!=null?suite.App.Name:"Private App"
}).ToList(),
Statuses=commit.Commit.Status
.Select(context =>
context.Contexts.Select(statusContext =>newStatusModel
{
State=statusContext.State.FromGraphQl(),
Context=statusContext.Context,
TargetUrl=statusContext.TargetUrl,
Description=statusContext.Description
}).ToList()
).SingleOrDefault()
}
).Compile();
}
query=readCommitStatuses;
}
else
{
if(readCommitStatusesEnterprise==null)
{
readCommitStatusesEnterprise=newQuery()
.Repository(owner:Var(nameof(owner)),name:Var(nameof(name)))
.PullRequest(number:Var(nameof(number))).Commits(last:1).Nodes.Select(
 commit =>newLastCommitAdapter
{
Statuses=commit.Commit.Status==null?null:commit.Commit.Status
.Select(context =>context==null
?null
:context.Contexts
.Select(statusContext =>newStatusModel
{
State=statusContext.State.FromGraphQl(),
Context=statusContext.Context,
TargetUrl=statusContext.TargetUrl,
Description=statusContext.Description,
}).ToList()
).SingleOrDefault()
}
).Compile();
}
query=readCommitStatusesEnterprise;
}
varvars=newDictionary<string,object>
{
{nameof(owner),owner},
{nameof(name),name},
{nameof(number),number},
};
varconnection=awaitgraphqlFactory.CreateConnection(address);
varresult=awaitconnection.Run(query,vars,refresh);
returnresult.First();
}

Functionality to get a list of viewer repositories for cloning

Handled by: Caching for default 8 hours and clear on refresh

VisualStudio/src/GitHub.App/Services/RepositoryCloneService.cs

Lines 67 to 112 in c3b597f

publicasyncTask<ViewerRepositoriesModel>ReadViewerRepositories(HostAddressaddress)
{
if(readViewerRepositories==null)
{
varorder=newRepositoryOrder
{
Field=RepositoryOrderField.PushedAt,
Direction=OrderDirection.Desc
};
varrepositorySelection=newFragment<Repository,RepositoryListItemModel>(
"repository",
 repo =>newRepositoryListItemModel
{
IsFork=repo.IsFork,
IsPrivate=repo.IsPrivate,
Name=repo.Name,
Owner=repo.Owner.Login,
Url=newUri(repo.Url),
});
readViewerRepositories=newQuery()
.Viewer
.Select(viewer =>newViewerRepositoriesModel
{
Owner=viewer.Login,
Repositories=viewer.Repositories(null,null,null,null,null,null,null,order,null,null)
.AllPages()
.Select(repositorySelection).ToList(),
ContributedToRepositories=viewer.RepositoriesContributedTo(100,null,null,null,null,null,null,order,null)
.Nodes
.Select(repositorySelection).ToList(),
Organizations=viewer.Organizations(null,null,null,null).AllPages().Select(org =>new
{
org.Login,
Repositories=org.Repositories(100,null,null,null,null,null,null,order,null,null)
.Nodes
.Select(repositorySelection).ToList()
}).ToDictionary(x =>x.Login, x =>(IReadOnlyList<RepositoryListItemModel>)x.Repositories),
}).Compile();
}
vargraphql=awaitgraphqlFactory.CreateConnection(address).ConfigureAwait(false);
varresult=awaitgraphql.Run(readViewerRepositories).ConfigureAwait(false);
returnresult;
}

Functionality to get a pull request node id

Handled by: Caching for default 8 hours

VisualStudio/src/GitHub.InlineReviews/Services/PullRequestSessionService.cs

Lines 458 to 472 in 14eadbe

publicasyncTask<string>GetGraphQLPullRequestId(
LocalRepositoryModellocalRepository,
stringrepositoryOwner,
intnumber)
{
varaddress=HostAddress.Create(localRepository.CloneUrl.Host);
vargraphql=awaitgraphqlFactory.CreateConnection(address);
varquery=newQuery()
.Repository(owner:repositoryOwner,name:localRepository.Name)
.PullRequest(number)
.Select(x =>x.Id);
return(awaitgraphql.Run(query)).Value;
}

Functionality to get assignable users

Handled by: Caching for 1 hour

VisualStudio/src/GitHub.App/Services/PullRequestService.cs

Lines 305 to 338 in c3b597f

publicasyncTask<Page<ActorModel>>ReadAssignableUsers(
HostAddressaddress,
stringowner,
stringname,
stringafter)
{
if(readAssignableUsers==null)
{
readAssignableUsers=newQuery()
.Repository(owner:Var(nameof(owner)),name:Var(nameof(name)))
.AssignableUsers(first:100,after:Var(nameof(after)))
.Select(connection =>newPage<ActorModel>
{
EndCursor=connection.PageInfo.EndCursor,
HasNextPage=connection.PageInfo.HasNextPage,
TotalCount=connection.TotalCount,
Items=connection.Nodes.Select(user =>newActorModel
{
AvatarUrl=user.AvatarUrl(30),
Login=user.Login,
}).ToList(),
}).Compile();
}
vargraphql=awaitgraphqlFactory.CreateConnection(address);
varvars=newDictionary<string,object>
{
{nameof(owner),owner},
{nameof(name),name},
{nameof(after),after},
};
returnawaitgraphql.Run(readAssignableUsers,vars);
}

Functionality to get the viewer details

Handled by: Caching for 10 minutes

VisualStudio/src/GitHub.InlineReviews/Services/PullRequestSessionService.cs

Lines 441 to 456 in c3b597f

publicvirtualasyncTask<ActorModel>ReadViewer(HostAddressaddress)
{
if(readViewer==null)
{
readViewer=newQuery()
.Viewer
.Select(x =>newActorModel
{
Login=x.Login,
AvatarUrl=x.AvatarUrl(null),
}).Compile();
}
varconnection=awaitgraphqlFactory.CreateConnection(address);
returnawaitconnection.Run(readViewer);
}

Functionality to get a parent repo if one exists

Handled by: Caching for default 8 hours

VisualStudio/src/GitHub.App/Services/RepositoryService.cs

Lines 28 to 51 in c3b597f

publicasyncTask<(stringowner,stringname)?>FindParent(HostAddressaddress,stringowner,stringname)
{
Guard.ArgumentNotNull(address,nameof(address));
Guard.ArgumentNotEmptyString(owner,nameof(owner));
Guard.ArgumentNotEmptyString(name,nameof(name));
if(readParentOwnerLogin==null)
{
readParentOwnerLogin=newQuery()
.Repository(owner:Var(nameof(owner)),name:Var(nameof(name)))
.Select(r =>r.Parent!=null?Tuple.Create(r.Parent.Owner.Login,r.Parent.Name):null)
.Compile();
}
varvars=newDictionary<string,object>
{
{nameof(owner),owner},
{nameof(name),name},
};
vargraphql=awaitgraphqlFactory.CreateConnection(address);
varresult=awaitgraphql.Run(readParentOwnerLogin,vars);
returnresult!=null?(result.Item1,result.Item2):((string,string)?)null;
}

StanleyGoldman

The refresh flag should be chained down to this call

VisualStudio/src/GitHub.InlineReviews/Services/PullRequestSessionService.cs

Lines 412 to 413 in 14eadbe

varlastCommitModel=awaitlog.TimeAsync(nameof(GetPullRequestLastCommitAdapter),
()=>GetPullRequestLastCommitAdapter(address,owner,name,number));

Fixed

StanleyGoldman

Minor nitpick

StanleyGoldman · 2019-03-01T13:38:28Z


+ public async Task ClearPullRequestsCache(HostAddress address, string owner, string name)
+ {
+ var region = owner + '/' + name + "/pr-list";


…phql-caching

…hing # Conflicts: # src/GitHub.InlineReviews/Services/PullRequestSessionService.cs

I think it's good, but i'm probably too close now to evaluate

jcansdale

Looks good to me. Just a question about removing a Visual Studio threading dependency.

StanleyGoldman · 2019-04-04T13:12:36Z

While I was prepping to present at the Visual Studio 2019 launch, my head had a thought about how the caching would affect the fork function and what routine is that using...

…hing

StanleyGoldman · 2019-04-04T19:05:48Z

GraphQL is not used to fork repos

jcansdale

Let's do this!

grokys added 2 commits January 7, 2019 16:54

Added caching to GraphQL connections.
3d1ea19

Implement refreshing PR list and details.
b046d6d
Also brought `FileCache` into our source instead of importing its package because needed to add the `ClearRegion` method.

grokys requested review from StanleyGoldman and jcansdale January 16, 2019 13:27

grokys mentioned this pull request Jan 16, 2019
Added IsMutation to ICompiledQuery. octokit/octokit.graphql.net#186
Merged

StanleyGoldman previously requested changes Feb 20, 2019
View reviewed changes

StanleyGoldman added 2 commits February 27, 2019 10:39

Merge branch 'master' into feature/graphql-caching
bbdcf99
# Conflicts: # submodules/octokit.graphql.net

Update submodule
14eadbe

Fixing compilation errors
ff484ab

StanleyGoldman previously requested changes Feb 28, 2019
View reviewed changes

Passing through the call to refresh
c3b597f

StanleyGoldman previously requested changes Mar 1, 2019
View reviewed changes

StanleyGoldman added 7 commits March 8, 2019 07:41

Merge remote-tracking branch 'remotes/origin/master' into feature/gra…
4d140c6
…phql-caching

Cache assignable users for an hour
81ed3b4

Merge branch 'master' into feature/graphql-caching
63c829c

Caching ReadViewer for 10 minutes
00da02c

Adding functionality to refresh user repository list
e9395e8

Ensuring the first load is never cached
ade3b5f

Disabling caching for the repository clone view
f7e42eb

StanleyGoldman mentioned this pull request Mar 26, 2019
[wip] Adding Caching to the clone repo dialog #2301
Closed
1 task

StanleyGoldman changed the title ~~WIP: GraphQL caching.~~GraphQL caching.Mar 27, 2019

StanleyGoldman added 2 commits March 27, 2019 06:59

Merge remote-tracking branch 'origin/master' into feature/graphql-cac…
e6290ba
…hing # Conflicts: # src/GitHub.InlineReviews/Services/PullRequestSessionService.cs

Fixes needed after merge
6c9874b

StanleyGoldman added 2 commits March 27, 2019 16:41

Fixing some tests
895bbb2

Fixing tests
098cd3f

Fixing tests
0f46686

jcansdale reviewed Mar 29, 2019
View reviewed changes

Comment threadsrc/GitHub.Api/GraphQLClient.cs Outdated

StanleyGoldman added 2 commits April 4, 2019 13:58

Changing code to use Task.Run over TaskScheduler.Default
415e7dd

Merge remote-tracking branch 'origin/master' into feature/graphql-cac…
c8ace03
…hing

jcansdale approved these changes Apr 4, 2019
View reviewed changes

jcansdale merged commit 794ae47 into masterApr 4, 2019

jcansdale deleted the feature/graphql-caching branch April 4, 2019 19:09

StanleyGoldman added the enhancement label Apr 11, 2019

StanleyGoldman changed the title ~~GraphQL caching.~~Caching GraphQL queriesApr 11, 2019

Navigation Menu

Uh oh!

Caching GraphQL queries - #2181

Caching GraphQL queries#2181
jcansdale merged 20 commits into
masterfrom
feature/graphql-caching

grokys commented Jan 16, 2019•
edited
Loading

Uh oh!

StanleyGoldman left a comment

Uh oh!

StanleyGoldman commented Feb 28, 2019

Uh oh!

StanleyGoldman commented Feb 28, 2019•
edited
Loading

Uh oh!

StanleyGoldman left a comment

Uh oh!

StanleyGoldman left a comment

Uh oh!

Uh oh!

StanleyGoldmanMar 1, 2019

Uh oh!

jcansdale left a comment

Uh oh!

Uh oh!

StanleyGoldman commented Apr 4, 2019

Uh oh!

StanleyGoldman commented Apr 4, 2019

Uh oh!

jcansdale left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	varlastCommitModel=awaitlog.TimeAsync(nameof(GetPullRequestLastCommitAdapter),
	()=>GetPullRequestLastCommitAdapter(address,owner,name,number));

Uh oh!

Conversation

grokys commented Jan 16, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

StanleyGoldman left a comment

Choose a reason for hiding this comment

Uh oh!

StanleyGoldman commented Feb 28, 2019

Uh oh!

StanleyGoldman commented Feb 28, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Functionality to get a page of a list of pull requests

Functionality to get the pull request detail

Functionality to get the last commit of a pull request for statuses

Functionality to get a list of viewer repositories for cloning

Functionality to get a pull request node id

Functionality to get assignable users

Functionality to get the viewer details

Functionality to get a parent repo if one exists

Uh oh!

StanleyGoldman left a comment

Choose a reason for hiding this comment

Uh oh!

StanleyGoldman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

StanleyGoldmanMar 1, 2019

Choose a reason for hiding this comment

Uh oh!

jcansdale left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

StanleyGoldman commented Apr 4, 2019

Uh oh!

StanleyGoldman commented Apr 4, 2019

Uh oh!

jcansdale left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

grokys commented Jan 16, 2019•
edited
Loading

StanleyGoldman commented Feb 28, 2019•
edited
Loading