Use PullRequest.timelineItems instead of PullRequest.timeline

[jcansdale]

The the deprecated PullRequest.timeline field is going away soon. When it does, this will happen. Convert to using the modern PullRequest.timelineItems field.

Todo

• Only fetch pull request comments and commits.

How to test

• Open pull request details view
• Open pull request timeline page
• Check that pull request comments and commits appear as expected

Seems to be working...

Notes

Thanks @parto, @xuorig, @rmosolgo and @nplasterer for the heads up about this!

Fixes#2481

[rmosolgo]

Glad it turned out to be a pretty clear substitution 🎉

What's the release turn-around after this PR is merged?

[jcansdale]

@rmosolgo,

What's the release turn-around after this PR is merged?

I'm hoping to get a new version out this week! Hopefully auto-update will work for most users. I know some can get stuck on old versions.

[rmosolgo]

@jcansdale, have you cut a new release? Ok to go ahead with the deprecations? (Well, yknow, as ok as ever ?)

[jcansdale]

@rmosolgo sorry about the delay. it has been another crazy week! 😉

I'll try to get a release out today. I'll keep you posted!

[rmosolgo]

Just checking in about that release -- soon, I need to remove these deprecated schema bits, I'd love for folks to have an upgrade path when that happens!

[jcansdale]

@rmosolgo the updated version is out, but I'm having one hell of a time with Visual Studio's auto-update mechanism. First our certificate expired and now the updated cert doesn't appear to be taking. 😭

[rmosolgo]

Can you tell if the update has been rolling itself out? Still hoping to move forward with https://github.com/github/ecosystem-api/issues/1876 soon, but if you want to try again, I'll wait!

[jcansdale]

Hi @rmosolgo,

Here's how the rollout is looking.

Users updated to the latest version is still depressingly low. I've written to the VS installer folks, but haven't heard back yet. I'll ping them again via Teams. 🤞