Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Add support for Visual Studio Team Explorer 2017 - #961

Merged
jcansdale merged 5 commits into
masterfrom
jcansdale/TeamExplorer2017
Dec 13, 2017
Merged

Add support for Visual Studio Team Explorer 2017#961
jcansdale merged 5 commits into
masterfrom
jcansdale/TeamExplorer2017

Conversation

@jcansdale

@jcansdalejcansdale commented Apr 27, 2017

Copy link
Copy Markdown
Collaborator

From the Visual Studio website:

"Visual Studio Team Explorer 2017 is a rich, standalone client for accessing Team Foundation Server and Visual Studio Team Services and is free for any user. This install only includes Team Explorer so you can access version control and work item tracking without other IDE components."
https://www.visualstudio.com/en-us/news/releasenotes/vs2017-relnotes#te

At the very least, adding support for this could be useful for testing (a minimal install of VS with just the packages we need). It's also an obvious target for our extension!

image

At the moment all this PR does is allows the extension to load when the InstallationTarget is "Microsoft.VisualStudio.IntegratedShell".

We will likely want to check what components are available when loading the extension so we don't fail in any IntegratedShells that don't have Team Explorer available.

Fixes#938

@jcansdale
jcansdale requested a review from shanaApril 27, 2017 11:13
@jcansdale

Copy link
Copy Markdown
CollaboratorAuthor

I've added a dependency on the TeamExplorer extension (versions 14.0-15.*). This stops the VSIX Installer for showing it as an option for any instance of VS/VS Shell that doesn't have TeamExplorer installed.

This is probably a good independently of Visual Studio Team Explorer, in case someone doesn't have TeamExplorer installed in Visual Studio.

@jcansdale
jcansdaleforce-pushed the jcansdale/TeamExplorer2017 branch from e8d27da to e42a75eCompareApril 27, 2017 11:55
@jcansdale

Copy link
Copy Markdown
CollaboratorAuthor

Not sure what else there is to do here. It's a simple change and seems to work as hoped. 😄

I wasn't completely sure which version range to use. I've plumped for [14.0,16.0) in case a new 15.x point release came out.

I notice we've used [14.0,15.0] in other places. Is this by design? Are we deliberately being pessimistic about compatibility with new point releases? Microsoft do have a "15.1" update out, but they seem to have kept the VS version at 15.0. 😕

@jcansdalejcansdale changed the title WIP: Add support for Visual Studio Team Explorer 2017Add support for Visual Studio Team Explorer 2017Apr 27, 2017
@jcansdale
jcansdale requested a review from grokysApril 27, 2017 12:02

@grokysgrokys left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks to be pretty low-impact.

The only thing I'd like to know is what version the usage tracker picks up here as it'd be good to have metrics on how many people use this.

@jcansdale

Copy link
Copy Markdown
CollaboratorAuthor

I can't open PRs in some repos. There were some null ref exceptions, e.g:

image

Not sure if it's related to this PR. Need to investigate further.

@meaghanlewis

Copy link
Copy Markdown
Contributor

@jcansdale earlier today I got the same errors with PRs in certain repos while using the latest master build so I don't think what you're seeing is related to this PR.

I was going to open up an issue about it, but then I logged out and back in again and haven't reproduced this problem since.

@jcansdale

Copy link
Copy Markdown
CollaboratorAuthor

@meaghanlewis.

I got the same errors with PRs in certain repos while using the latest master build so I don't think what you're seeing is related to this PR.

Ah, thanks for letting me know! Will you open an issue about it? You can use the screenshot above.

@jcansdale
jcansdale merged commit bef85ec into masterDec 13, 2017
@jcansdale
jcansdale deleted the jcansdale/TeamExplorer2017 branch December 13, 2017 09:46
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jcansdale@meaghanlewis@grokys@shana