Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Nov 14, 2019. It is now read-only.
Implements Carbon namespacing - #31
Open
alindeman wants to merge 1 commit into
Open
Conversation
alindemanforce-pushed
the
namespacing
branch
2 times, most recently
from
March 18, 2016 15:14
1f55e9c to
922b484Comparealindemanforce-pushed
the
namespacing
branch
2 times, most recently
from
June 16, 2016 18:06
1bb8460 to
8812227Compareblak3r2
commented
Oct 29, 2016
For what it's worth, I have tested this pull request and it worked for me. If you want to use carbon-namespacing then add the following options to your backend type carbon: |
eugenepaniot
commented
Nov 15, 2016
+1 |
StevenACoffman
commented
Mar 29, 2017
ghost
commented
Aug 30, 2017
Is this dead? :) |
vmg
commented
Aug 30, 2017
Contributor
Generally speaking, we don't merge any features which we don't actively use in GitHub because we're afraid of unexpected side effects. This PR looks correct, however. If you really need this feature I'd advise you to carry this patch on a fork of brubeck. |
haggy
commented
Aug 26, 2019
@vmg Why even bother open sourcing this then? |
everpcpc added a commit
to douban/brubeck
that referenced
this pull request
Nov 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
statsd supports namespacing. For instance with a global namespace of
statsand a counter namespace ofcounters, all counters would be namespaced asstats.counters.foo.This PR implements statsd's namespacing logic (except for legacy namespacing, which I don't think we should be encouraging) in brubeck. Namespacing is not enabled by default, but can be configured in
config.json.Feedback welcomed 💚