Skip to content

Note in readme about go analysis in macos-latest - #17

Merged
anaarmas merged 3 commits into
masterfrom
go-macos-readme
May 8, 2020
Merged

Note in readme about go analysis in macos-latest#17
anaarmas merged 3 commits into
masterfrom
go-macos-readme

Conversation

@anaarmas

@anaarmasanaarmas commented May 4, 2020

Copy link
Copy Markdown
Contributor

Merge / deployment checklist

  • Run test builds as necessary. Can be on this repository or elsewhere as needed in order to test the change - please include links to tests in other repos!
    • CodeQL using init/analyze actions
    • 3rd party tool using upload action
  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

@anaarmas

Copy link
Copy Markdown
ContributorAuthor

(I also fixed a bit of formatting)

@robertbrignullrobertbrignull left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be a little clearer, but it's still ok as it is.

Comment threadREADME.md Outdated

### Analysing Go together with other languages on `macos-latest`

This is currently not possible for Java, C/C++, or C#.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would clarify this slightly as I don't think it's very understandable right now if this is the first you're reading of this limitation.
Perhaps "When running on macos it is currently not possible to analyze Go in conjunction with any of Java, C/C++, or C#. Each language can still be analyzed separately."

@anaarmas
anaarmas merged commit 5a800cc into masterMay 8, 2020
@chrisgavin
chrisgavin deleted the go-macos-readme branch September 2, 2020 13:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@anaarmas@robertbrignull