Skip to content

Use smaller Plarform-Language packages when analyzing only one language#172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marcogario wants to merge 19 commits into from
Closed

Use smaller Plarform-Language packages when analyzing only one language #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
e4c39c9
Add CI for testing small bundles
marcogario Sep 4, 2020
408e376
Add test for bundle with platform and language
marcogario Sep 4, 2020
7951f91
Add logic to download codeql platform-language pkg
marcogario Sep 9, 2020
3f5bb98
# This is a combination of 4 commits.
marcogario Sep 9, 2020
d3d7dd4
# This is a combination of 4 commits.
marcogario Sep 9, 2020
57b0b7f
Add logic to download codeql platform-language pkg
marcogario Sep 9, 2020
588a28d
Merge remote-tracking branch 'origin/main' into platform_lang_pkg
marcogario Sep 11, 2020
7b29d2e
Move language functions in dedicated package
marcogario Sep 11, 2020
d093fc0
Remove old workflow
marcogario Sep 11, 2020
0ca7a34
CI: Add test for small-bundles
marcogario Sep 11, 2020
b9e8fa6
Merge remote-tracking branch 'origin/main' into platform_lang_pkg
marcogario Sep 15, 2020
4d836f4
fix linter
marcogario Sep 15, 2020
b9f08d9
Fix early termination
marcogario Sep 15, 2020
7f2fa9c
Merge branch 'main' into platform_lang_pkg
marcogario Sep 17, 2020
c25320c
Improve integration test
marcogario Sep 17, 2020
1157017
Assume small bundles are available in the official repo
marcogario Sep 17, 2020
f8e9262
Merge remote-tracking branch 'origin/main' into platform_lang_pkg
marcogario Sep 21, 2020
8547a75
Disable dependency in CI
marcogario Sep 21, 2020
11e79a3
Fix test for toolcache
marcogario Sep 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions .github/workflows/integration-testing.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -127,6 +127,48 @@ jobs:
env:
TEST_MODE: true

single-language-bundles:

@robertbrignullrobertbrignullSep 16, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need some check after running the actions to make sure it actually downloaded the right bundles. Currently it could download the full thing each time and still pass.
You should be able to look inside the toolcache directory and see what it has downloaded. You'll find it under /opt/hostedtoolcache (at least on linux) or you can use $AGENT_TOOLSDIRECTORY (which might work on all operating systems).

@marcogariomarcogarioSep 17, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea was not to require this, although I can see how it would be good to test this in a non-failing way.
I did not want to make the bundle-release process more complex, so these tests should pass with only the main bundle (fallback behavior). I see how outputting a message that we used the smaller bundler would be useful for validation.

# These are 21 jobs, run them only if the earlier multi-language job suceeded
# needs: multi-language-repo_test-autodetect-languages
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
language: ["none", "cpp", "csharp", "go", "java", "javascript", "python"]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v2
- name: Move codeql-action
shell: bash
run: |
mkdir ../action
mv * .github ../action/
mv ../action/tests/multi-language-repo/{*,.github} .

# The next 2 steps are mutually exclusive.
# In one case, we setup codeql for a single language.
# In the other, we setup codeql for a platform
- name: Test language-specific bundle
uses: ./../action/init
if: matrix.language != 'none'
with:
languages: ${{ matrix.language }}
- name: Test platform-secific bundle
uses: ./../action/init
if: matrix.language == 'none'

- name: Build code
shell: bash
run: ./build.sh
- uses: ./../action/analyze
env:
TEST_MODE: true

- name: Check ToolCache (language-specific bundle)
if: matrix.language != 'none'
shell: bash
run: test -n "$(find -maxdepth 1 -name "codeql-bundle-0.0.0-*.${OS}-${{matrix.language}}" -print -quit)"

test-proxy:
runs-on: ubuntu-latest
container:
Expand Down
83 changes: 71 additions & 12 deletions lib/codeql.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading