Skip to content

Platform specific bundle - #240

Merged
marcogario merged 1 commit into
mainfrom
marcogario/platform-bundle
Oct 1, 2020
Merged

Platform specific bundle#240
marcogario merged 1 commit into
mainfrom
marcogario/platform-bundle

Conversation

@marcogario

@marcogariomarcogario commented Sep 30, 2020

Copy link
Copy Markdown
Contributor

Download the platform specific bundle. These bundles are generated via the split workflow https://github.com/github/codeql-action/blob/main/.github/workflows/split.yml

If the tool url is provided, we will still respect that. However, in other cases we download codeql-bundle-${platform}.tar.gz

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

@marcogario
marcogarioforce-pushed the marcogario/platform-bundle branch from b10805b to 4792b31CompareOctober 1, 2020 07:59
@marcogario
marcogarioforce-pushed the marcogario/platform-bundle branch from 4792b31 to d5029a8CompareOctober 1, 2020 08:04
@marcogario
marcogario marked this pull request as ready for review October 1, 2020 08:27

@robertbrignullrobertbrignull left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is all good. I've checked that it still uses a pinned version from the environment in preference to downloading the platform specific pack. And it still uses a user-supplied download URL if given.

As noted in person earlier, this now relies on all the platform specific versions being present. But this will be true for dotcom, and I believe you checked that the sync tool copies all artefacts. So this requirement should be fine.

@marcogario

Copy link
Copy Markdown
ContributorAuthor

As noted in person earlier, this now relies on all the platform specific versions being present. But this will be true for dotcom, and I believe you checked that the sync tool copies all artefacts. So this requirement should be fine.

Yes, this is worth underlying one more time: the platform bundles are now a requirement.

Indeed, I did verify that the sync tool supports this, and did also update the bundle release process accordingly.

@marcogario
marcogario merged commit b9e9339 into mainOct 1, 2020
@marcogario
marcogario deleted the marcogario/platform-bundle branch October 1, 2020 09:29
@github-actionsgithub-actionsBot mentioned this pull request Oct 5, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@marcogario@robertbrignull