Skip to content

Add the --threads config option to finalize db - #281

Merged
aeisenberg merged 1 commit into
github:mainfrom
aeisenberg:aeisenberg/threads-finalize
Nov 3, 2020
Merged

Add the --threads config option to finalize db#281
aeisenberg merged 1 commit into
github:mainfrom
aeisenberg:aeisenberg/threads-finalize

Conversation

@aeisenberg

@aeisenbergaeisenberg commented Oct 29, 2020

Copy link
Copy Markdown
Contributor

This flag is already being used for runQueries, so let's use it for
finalize as well.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

@aeisenberg

aeisenberg commented Oct 29, 2020

Copy link
Copy Markdown
ContributorAuthor

I have not updated the README yet. I'll handle that soon. Also, any sort of unit tests or integration tests I should be adding or updating?

@aeisenberg
aeisenbergforce-pushed the aeisenberg/threads-finalize branch from b62a720 to e5961adCompareOctober 29, 2020 15:28
@aeisenberg

aeisenberg commented Oct 29, 2020

Copy link
Copy Markdown
ContributorAuthor

Also, there's a failing Integration Testing / runner-upload-sarif. I don't understand why.

@robertbrignull

robertbrignull commented Oct 29, 2020

Copy link
Copy Markdown
Contributor

Also, there's a failing Integration Testing / runner-upload-sarif. I don't understand why.

That's because you opened your PR from a fork and so the actions token doesn't have write scopes. You can just ignore the failure for this PR.

robertbrignull
robertbrignull approved these changes Nov 3, 2020
View reviewed changes

@robertbrignullrobertbrignull left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no problem with this. I trust you that passing this flag to this command makes sense.

No need to update the readme or tests for this change. If the existing integration tests pass then that should be enough.

@aeisenberg

aeisenberg commented Nov 3, 2020

Copy link
Copy Markdown
ContributorAuthor

Thanks! Will resolve conflicts and rebase.

@aeisenberg
Add the --threads config option to finalize db
dd96eda
This flag is already being used for `runQueries`, so let's use it for
finalize as well.
@aeisenberg
aeisenbergforce-pushed the aeisenberg/threads-finalize branch from e5961ad to dd96edaCompareNovember 3, 2020 16:15
@aeisenberg
aeisenberg merged commit bc1ee16 into github:mainNov 3, 2020
@github-actionsgithub-actionsBot mentioned this pull request Nov 9, 2020
Merged
aofaof0907 pushed a commit to aofaof0907/codeql-action that referenced this pull request Jul 29, 2021
@aeisenberg@aofaof0907
Add the --threads config option to finalize db (github#281)
ab22703
This flag is already being used for `runQueries`, so let's use it for
finalize as well.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robertbrignullrobertbrignullrobertbrignull approved these changes
@sampartsampartAwaiting requested review from sampart
@cbraynorcbraynorAwaiting requested review from cbraynor

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aeisenberg@robertbrignull