Uh oh!
There was an error while loading. Please reload this page.
Send action ref and tool version in status reports - #301
Conversation
65df982 to
80b43caComparerobertbrignull
commented
Nov 12, 2020
The failed checkrun is just some alert churn because I changed I checked the data that's coming through and the |
robertbrignull
commented
Nov 12, 2020
Can confirm the |
chrisgavin
left a comment
There was a problem hiding this comment.
LGTM. I was a bit worried it might not be compatible with 2.22, but we don't send status reports on Enterprise so it seems like it should be fine. 👍
| path.isAbsolute(relativeScriptPath) | ||
| ) { | ||
| if (isRunningLocalAction()) { |
There was a problem hiding this comment.
Thanks for factoring this out. 👍
Requires some changes on the server side before this will work / can be merged.
This sends the action ref, and the tools input and resolved version as part of the status reports. Getting the resolved tools version in a nice format proved slightly awkward, but hopefully the result in this PR isn't too bad.
Merge / deployment checklist