Uh oh!
There was an error while loading. Please reload this page.
Test Go autobuild - #324
Merged
Merged
Conversation
robertbrignullforce-pushed
the
robertbrignull/go_autobuild
branch
from
November 27, 2020 11:34
268c328 to
7174a81Comparerobertbrignull
commented
Nov 27, 2020
ContributorAuthor
I wanted to make sure the Go tracing was working if you used the autobuild action and thought we may as well add an integration test for it. Turns out it does work. |
chrisgavin
approved these changes
Nov 30, 2020
chrisgavin
left a comment
Contributor
There was a problem hiding this comment.
Looks good with the exception of one question.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Chris Gavin <chris@chrisgavin.me>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should be testing using autobuild with Go as well as a manual build command, just in case.
Merge / deployment checklist