Uh oh!
There was an error while loading. Please reload this page.
Remove date specific pull request warnings - #367
Conversation
| [key: string]: string; | ||
| }): { [key: string]: CodedError } { | ||
| function toCodedErrors<T>(errors: T): Record<keyof T, CodedError> { |
There was a problem hiding this comment.
I updated this so that the keys are typechecked and you get an error if you try and use one that is not defined.
chrisgavin
left a comment
There was a problem hiding this comment.
LGTM.
Do we want to have a period where we continue to post a re-worded version of the warning even after making the change in case people go looking for reasons why their Actions are no longer working as expected? I guess it should be very rare people are depending on the old behavior now, so I think just removing the warning is also fine. 👍
fa26c9a to
44ed1c6Comparesimon-engledew
commented
Jan 29, 2021
👍 Cool. We can always put it back in if people run into it a lot. |
After January 2021 CodeQL will no longer display pull request results if
on.pull_requestis not set.Now we only need to warn if on.pull_request is configured without a corresponding
on.push.