Uh oh!
There was an error while loading. Please reload this page.
Convert update-release-branch.py to TypeScript - #4010
Conversation
There was a problem hiding this comment.
Pull request overview
Ports release-branch preparation and backport automation from Python to TypeScript.
Changes:
- Adds TypeScript release, changelog, API, and dry-run logic.
- Updates release workflows and dependency installation.
- Adds shared paths and editor skill settings.
Show a summary per file
| File | Description |
|---|---|
pr-checks/update-release-branch.ts | Implements release branch preparation and PR creation. |
pr-checks/changelog.ts | Implements changelog transformations. |
pr-checks/config.ts | Adds shared paths and dry-run options. |
.github/workflows/update-release-branch.yml | Invokes the TypeScript script. |
.github/actions/release-initialise/action.yml | Installs JavaScript dependencies. |
.github/actions/release-branches/action.yml | Removes redundant dependency installation. |
.vscode/settings.json | Adds agent skill locations. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 9
- Review effort level: Medium
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Remove now unneeded `npm ci` from `release-branches` action
29bc2b4 to
ae48798CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
henrymercer
left a comment
There was a problem hiding this comment.
This has now been tested on a test repo, so let's try it out.
Converts the
update-release-branch.pyscript to TypeScript following the same approach we have used to convert other legacy, Python scripts to TypeScript. The existingupdate-release-branch.pyscript had no tests. I have added some here, but adding full test coverage for this part of the automation requires a lot more work and refactoring of the new script. To keep it somewhat reviewable, the TypeScript version is kept similar to the Python one.Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Environments:
How did/will you validate this change?
.test.tsfiles).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist