Skip to content

Promote AllowToolcacheInput feature - #4044

Merged
mbg merged 1 commit into
mainfrom
mbg/ff/promote-toolcache
Jul 24, 2026
Merged

Promote AllowToolcacheInput feature#4044
mbg merged 1 commit into
mainfrom
mbg/ff/promote-toolcache

Conversation

@mbg

@mbgmbg commented Jul 24, 2026

Copy link
Copy Markdown
Member

This feature has been rolled out for some time now. This PR removes the FF and makes the behaviour that was guarded by it the default.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Workflow types:

  • Managed - Impacts users with dynamic workflows (Default Setup, Code Quality, ...).

Products:

  • Code Scanning - The changes impact analyses when analysis-kinds: code-scanning.
  • Code Quality - The changes impact analyses when analysis-kinds: code-quality.
  • Other first-party - The changes impact other first-party analyses.

Environments:

  • Dotcom - Impacts CodeQL workflows on github.com and/or GitHub Enterprise Cloud with Data Residency.
  • GHES - Impacts CodeQL workflows on GitHub Enterprise Server.

How did/will you validate this change?

  • Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).
  • End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

  • Telemetry - I rely on existing telemetry or have made changes to the telemetry.
    • Dashboards - I will watch relevant dashboards for issues after the release. Consider whether this requires this change to be released at a particular time rather than as part of a regular release.
    • Alerts - New or existing monitors will trip if something goes wrong with this change.

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@mbgmbg self-assigned this Jul 24, 2026
@mbg
mbg requested a review from a team as a code ownerJuly 24, 2026 15:30
CopilotAI review requested due to automatic review settings July 24, 2026 15:30
@github-actionsgithub-actionsBot added the size/S Should be easy to review label Jul 24, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

  • Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.

Pull request overview

Promotes tools: toolcache to default behavior for dynamic workflows and test mode by removing its feature flag.

Changes:

  • Removes AllowToolcacheInput configuration.
  • Simplifies toolcache eligibility and warning logic.
  • Updates unit tests for unconditional availability.
Show a summary per file
FileDescription
src/setup-codeql.tsRemoves feature-flag gating.
src/setup-codeql.test.tsUpdates toolcache tests.
src/feature-flags.tsRemoves the promoted flag.
lib/entry-points.jsGenerated artifact; excluded from review.

Review details

Files excluded by content exclusion policy (1)
  • lib/entry-points.js
  • Files reviewed: 3/4 changed files
  • Comments generated: 0
  • Review effort level: Medium

@mbg
mbg added this pull request to the merge queueJul 24, 2026
Merged via the queue into main with commit 3434fbbJul 24, 2026
223 checks passed
@mbg
mbg deleted the mbg/ff/promote-toolcache branch July 24, 2026 16:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/SShould be easy to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mbg@oscarsj