Skip to content

Avoid fingerprinting directories - #479

Merged
aeisenberg merged 1 commit into
mainfrom
aeisenberg/directory-fingerprint
May 5, 2021
Merged

Avoid fingerprinting directories#479
aeisenberg merged 1 commit into
mainfrom
aeisenberg/directory-fingerprint

Conversation

@aeisenberg

Copy link
Copy Markdown
Contributor

Fixes#478

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

@aeisenberg
aeisenbergforce-pushed the aeisenberg/directory-fingerprint branch from 1405700 to f584f94CompareMay 5, 2021 20:39

@chrisgavinchrisgavin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It makes sense to treat directories the same as non-existent files; we can't really compute a fingerprint for them.

@aeisenberg
aeisenberg merged commit a7d3945 into mainMay 5, 2021
@aeisenberg
aeisenberg deleted the aeisenberg/directory-fingerprint branch May 5, 2021 20:54
@github-actionsgithub-actionsBot mentioned this pull request May 10, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fingerprinting in the upload-sarif action fails with directories

2 participants

@aeisenberg@chrisgavin