Skip to content

Use bundle URL version as the cache version - #69

Merged
alexkappa merged 12 commits into
masterfrom
fix-self-hosted-stale-bundle-download
Jun 19, 2020
Merged

Use bundle URL version as the cache version#69
alexkappa merged 12 commits into
masterfrom
fix-self-hosted-stale-bundle-download

Conversation

@alexkappa

@alexkappaalexkappa commented Jun 17, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Merge / deployment checklist

  • Run test builds as necessary. Can be on this repository or elsewhere as needed in order to test the change - please include links to tests in other repos!
    • CodeQL using init/analyze actions
    • 3rd party tool using upload action
  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

robertbrignull
robertbrignull approved these changes Jun 17, 2020
View reviewed changes

@robertbrignullrobertbrignull left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation LGTM

@alexkappa
alexkappa marked this pull request as ready for review June 19, 2020 09:14
tibbes
tibbes reviewed Jun 19, 2020
View reviewed changes
Comment threadlib/setup-tools.js Outdated
@alexkappaalexkappa changed the title wip: hash bundle url and use it as the cache versionUse bundle URL version as the cache versionJun 19, 2020
chrisgavin
chrisgavin reviewed Jun 19, 2020
View reviewed changes
Comment threadsrc/setup-tools.ts Outdated
Comment threadsrc/setup-tools.test.ts Outdated
robertbrignull
robertbrignull reviewed Jun 19, 2020
View reviewed changes
Comment threadsrc/setup-tools.test.ts Outdated
@robertbrignull

robertbrignull commented Jun 19, 2020

Copy link
Copy Markdown
Contributor

The unit tests look really good to me and look like they validate the behaviour pretty well. I'm running a quick test locally too just to make sure, but I don't expect it to fail.

robertbrignull
robertbrignull approved these changes Jun 19, 2020
View reviewed changes

@robertbrignullrobertbrignull left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this and confirmed it's downloading and using the correct versions now

root@02c171a6cfa5:/actions-runner# ls _work/_tool/CodeQL/
0.0.0-20200427 0.0.0-20200601 1.0.0

Unless anyone else has comments I think this is ready to merge whenever you want.

Alex Kalyvitisand others added 2 commits June 19, 2020 13:27
Alex Kalyvitis@robertbrignull
Use Object.entries() instead of checking hasOwnProperty
34c941d
Co-authored-by: Robert <robertbrignull@github.com>
Alex Kalyvitis
build ts
38c2311
@alexkappa
alexkappa merged commit 74f864b into masterJun 19, 2020
@github-actionsgithub-actionsBot mentioned this pull request Jun 22, 2020
Merged
@snyk-botsnyk-bot mentioned this pull request Apr 24, 2023
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robertbrignullrobertbrignullrobertbrignull approved these changes
+2 more reviewers
@chrisgavinchrisgavinchrisgavin left review comments
@tibbestibbestibbes left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexkappa@robertbrignull@chrisgavin@tibbes